René's URL Explorer Experiment


Title: feat(reporting-storage): let the Postgres service factory build a subclass by bokelley · Pull Request #1589 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: feat(reporting-storage): let the Postgres service factory build a subclass by bokelley · Pull Request #1589 · adcontextprotocol/adcp-client-python

X Title: feat(reporting-storage): let the Postgres service factory build a subclass by bokelley · Pull Request #1589 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Fixes #1588. postgres_reliable_reporting_service(...), which replaced ReliableReportingService.postgres(...) in 9.0.0 (#1557), always constructed the base ReliableReportingService, while SubClass.m...

X Description: Fixes #1588. postgres_reliable_reporting_service(...), which replaced ReliableReportingService.postgres(...) in 9.0.0 (#1557), always constructed the base ReliableReportingService, while SubClass.m...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/1589

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4c593fe2-61d6-02db-096d-05b56faa7837
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD574:19114D:BB3DE9:F1F7FA:6B00E93A
html-safe-noncea5db96c18866732c013fbfa94404737870135c1aee6425614743a172433ecffb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTc0OjE5MTE0RDpCQjNERTk6RjFGN0ZBOjZCMDBFOTNBIiwidmlzaXRvcl9pZCI6IjU1ODQ3MDQ2NzYzNzg1MDM0ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacce0d963469ec527042646754e4a86fc945cfff7570f0b237ca6f67c5811eb4df
hovercard-subject-tagpull_request:4999400266
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1589/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9983bbcfd000677f061d7f5209b4c156dd08b72e8ab1b011009a4cbf9a3ab4ec/adcontextprotocol/adcp-client-python/pull/1589
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9983bbcfd000677f061d7f5209b4c156dd08b72e8ab1b011009a4cbf9a3ab4ec/adcontextprotocol/adcp-client-python/pull/1589
og:image:altFixes #1588. postgres_reliable_reporting_service(...), which replaced ReliableReportingService.postgres(...) in 9.0.0 (#1557), always constructed the base ReliableReportingService, while SubClass.m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/1589#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1589
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1589
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1589
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1589
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1589
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests12 (12)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
bokelley/storage-service-classhttps://github.com/adcontextprotocol/adcp-client-python/tree/bokelley/storage-service-class
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/1589
Commits2 (2)https://github.com/adcontextprotocol/adcp-client-python/pull/1589/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/1589/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/1589/files
feat(reporting-storage): let the Postgres service factory build a subclasshttps://github.com/adcontextprotocol/adcp-client-python/pull/1589#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
bokelley/storage-service-classhttps://github.com/adcontextprotocol/adcp-client-python/tree/bokelley/storage-service-class
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 24, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1589#issue-6017910463
#1588https://github.com/adcontextprotocol/adcp-client-python/issues/1588
#1557https://github.com/adcontextprotocol/adcp-client-python/pull/1557
Claude Codehttps://claude.com/claude-code
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1589
bokelleyhttps://github.com/bokelley
October 24, 2026 21:40https://github.com/adcontextprotocol/adcp-client-python/pull/1589#commits-pushed-927d5c2
https://github.com/bokelley
https://github.com/claude
feat(reporting-storage): let the Postgres service factory build a sub…https://github.com/adcontextprotocol/adcp-client-python/pull/1589/commits/927d5c20c39a26d0b69b24312c249cab5e9d6564
927d5c2https://github.com/adcontextprotocol/adcp-client-python/pull/1589/commits/927d5c20c39a26d0b69b24312c249cab5e9d6564
#1588https://github.com/adcontextprotocol/adcp-client-python/issues/1588
https://github.com/bokelley
https://github.com/claude
test(reporting-storage): cover the Postgres factory's service_classhttps://github.com/adcontextprotocol/adcp-client-python/pull/1589/commits/dd57324b0dbe93e24abd7b3c63410e56bb22d0f6
dd57324https://github.com/adcontextprotocol/adcp-client-python/pull/1589/commits/dd57324b0dbe93e24abd7b3c63410e56bb22d0f6
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
KonstantinMirinhttps://github.com/KonstantinMirin
rachitm022https://github.com/rachitm022
code ownershttps://github.com/adcontextprotocol/adcp-client-python/blob/6f13ce07e69bc24de23ce63b97958875f6866cc7/.github/CODEOWNERS#L3
October 24, 2026 21:41https://github.com/adcontextprotocol/adcp-client-python/pull/1589#event-34151011386
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 24, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1589#pullrequestreview-5640142658
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1589/files/dd57324b0dbe93e24abd7b3c63410e56bb22d0f6
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1589#pullrequestreview-5640142658
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1589
https://github.com/apps/github-code-quality
github-code-qualityhttps://github.com/apps/github-code-quality
Oct 24, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1589#pullrequestreview-5640166739
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1589/files/dd57324b0dbe93e24abd7b3c63410e56bb22d0f6
packages/adcp-reporting-storage/src/adcp_reporting_storage/service.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1589/files/dd57324b0dbe93e24abd7b3c63410e56bb22d0f6#diff-6dc2e4d809c70b954a87b3430589d16b43ed5397949d7e7210c6384bfd8530e8
packages/adcp-reporting-storage/src/adcp_reporting_storage/service.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1589/files/dd57324b0dbe93e24abd7b3c63410e56bb22d0f6#diff-6dc2e4d809c70b954a87b3430589d16b43ed5397949d7e7210c6384bfd8530e8
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
a9cfd0chttps://github.com/adcontextprotocol/adcp-client-python/commit/a9cfd0cb90b354179c598b23b76cda8601f90274
Oct 24, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1589#event-34152691283
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1589
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
October 24, 2026 22:24https://github.com/adcontextprotocol/adcp-client-python/pull/1589#event-34152692508
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 25, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1589#ref-pullrequest-6024043059
ci: map the two rebase-merged commits to their PRs and fix a stale test #1601 https://github.com/adcontextprotocol/adcp-client-python/pull/1601
bokelleyhttps://github.com/bokelley
Oct 25, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1589#ref-commit-d15de53
https://github.com/bokelley
https://github.com/claude
ci: map the two rebase-merged commits to their PRs and fix a stale te…https://github.com/adcontextprotocol/adcp-client-python/commit/d15de535a4c588d15ed6eb9f8798ca0083a6b456
d15de53https://github.com/adcontextprotocol/adcp-client-python/commit/d15de535a4c588d15ed6eb9f8798ca0083a6b456
#1601https://github.com/adcontextprotocol/adcp-client-python/pull/1601
#1589https://github.com/adcontextprotocol/adcp-client-python/pull/1589
#1595https://github.com/adcontextprotocol/adcp-client-python/pull/1595
#1591https://github.com/adcontextprotocol/adcp-client-python/pull/1591
#1600https://github.com/adcontextprotocol/adcp-client-python/pull/1600
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 25, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1589#ref-pullrequest-6024468050
docs(reporting-storage): note that 0.1.0b2 and 0.1.0b3 were not published #1602 https://github.com/adcontextprotocol/adcp-client-python/pull/1602
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1589
https://github.com/apps/aao-secretariat
aao-secretariat[bot] https://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1589/files/dd57324b0dbe93e24abd7b3c63410e56bb22d0f6
https://github.com/KonstantinMirin
KonstantinMirin https://github.com/KonstantinMirin
https://github.com/rachitm022
rachitm022 https://github.com/rachitm022
https://github.com/apps/github-code-quality
github-code-quality[bot] https://github.com/apps/github-code-quality
https://github.com/adcontextprotocol/adcp-client-python/pull/1589/files/dd57324b0dbe93e24abd7b3c63410e56bb22d0f6
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1589
postgres_reliable_reporting_service always builds the base ReliableReportingService, so adopters can't use a subclass https://github.com/adcontextprotocol/adcp-client-python/issues/1588
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1589
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.