René's URL Explorer Experiment


Title: fix(types): inherit the generated constraints on the canonical creatives field by KonstantinMirin · Pull Request #1548 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(types): inherit the generated constraints on the canonical creatives field by KonstantinMirin · Pull Request #1548 · adcontextprotocol/adcp-client-python

X Title: fix(types): inherit the generated constraints on the canonical creatives field by KonstantinMirin · Pull Request #1548 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: What this changes The canonical SyncCreativesRequest redeclares creatives for one reason — to narrow the element type from the generated Creative to the canonical CreativeAsset — and it did that by...

X Description: What this changes The canonical SyncCreativesRequest redeclares creatives for one reason — to narrow the element type from the generated Creative to the canonical CreativeAsset — and it did that by...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/1548

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:88183d8d-6fa3-2781-413b-6e028711f6dd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8062:95C88:A642F8:DDF8A9:6B00E98B
html-safe-nonce1a58f380c9495bdd32830f5a8eb3616fdce033eab47999abc3352f8c379ded1b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDYyOjk1Qzg4OkE2NDJGODpEREY4QTk6NkIwMEU5OEIiLCJ2aXNpdG9yX2lkIjoiNzI0NzkzNDA2Nzg1NjQ0OTM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac266b28677bd1efd4fe63979e8a2d7d536a9dee15adf7023fcb28c124a485280f
hovercard-subject-tagpull_request:4941420766
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1548/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/af6395267869a4e7e397c43e3d8e0ee53dcb20ee3c0efce8d0723c1e09c1113a/adcontextprotocol/adcp-client-python/pull/1548
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/af6395267869a4e7e397c43e3d8e0ee53dcb20ee3c0efce8d0723c1e09c1113a/adcontextprotocol/adcp-client-python/pull/1548
og:image:altWhat this changes The canonical SyncCreativesRequest redeclares creatives for one reason — to narrow the element type from the generated Creative to the canonical CreativeAsset — and it did that by...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKonstantinMirin
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/1548#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1548
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1548
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests12 (12)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
adcontextprotocol:mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
KonstantinMirin:fix/canonical-sync-creatives-inherit-constraintshttps://github.com/KonstantinMirin/adcp-client-python/tree/fix/canonical-sync-creatives-inherit-constraints
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
Commits2 (2)https://github.com/adcontextprotocol/adcp-client-python/pull/1548/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/1548/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/1548/files
fix(types): inherit the generated constraints on the canonical creatives fieldhttps://github.com/adcontextprotocol/adcp-client-python/pull/1548#top
bokelleyhttps://github.com/bokelley
adcontextprotocol:mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
KonstantinMirin:fix/canonical-sync-creatives-inherit-constraintshttps://github.com/KonstantinMirin/adcp-client-python/tree/fix/canonical-sync-creatives-inherit-constraints
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 20, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1548#issue-5948388449
#1546https://github.com/adcontextprotocol/adcp-client-python/pull/1546
#1547https://github.com/adcontextprotocol/adcp-client-python/issues/1547
#1545https://github.com/adcontextprotocol/adcp-client-python/issues/1545
#1546https://github.com/adcontextprotocol/adcp-client-python/pull/1546
#1546https://github.com/adcontextprotocol/adcp-client-python/pull/1546
#1547https://github.com/adcontextprotocol/adcp-client-python/issues/1547
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
https://github.com/KonstantinMirin
fix(types): inherit the generated constraints on the canonical creati…https://github.com/adcontextprotocol/adcp-client-python/pull/1548/commits/0ef2044f8ed634d3053ba117b96dc6131f12f350
0ef2044https://github.com/adcontextprotocol/adcp-client-python/pull/1548/commits/0ef2044f8ed634d3053ba117b96dc6131f12f350
adcontextprotocol#1546https://github.com/adcontextprotocol/adcp-client-python/pull/1546
adcontextprotocol#1547https://github.com/adcontextprotocol/adcp-client-python/issues/1547
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
bokelleyhttps://github.com/bokelley
rachitm022https://github.com/rachitm022
code ownershttps://github.com/adcontextprotocol/adcp-client-python/blob/5ce9ee4dc9daef34af143b84ff7d660489fef1be/.github/CODEOWNERS#L3
October 20, 2026 19:40https://github.com/adcontextprotocol/adcp-client-python/pull/1548#event-33778524923
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 20, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1548#pullrequestreview-5590727027
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1548/files/0ef2044f8ed634d3053ba117b96dc6131f12f350
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1548#pullrequestreview-5590727027
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1546https://github.com/adcontextprotocol/adcp-client-python/pull/1546
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
October 21, 2026 09:40https://github.com/adcontextprotocol/adcp-client-python/pull/1548#event-33831421172
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 21, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1548#ref-pullrequest-5960285014
fix(codegen)!: refuse a JSON null on optional properties whose schema forbids one #1555 https://github.com/adcontextprotocol/adcp-client-python/pull/1555
https://github.com/bokelley
https://github.com/claude
fix(types): inherit the generated creatives constraints on PackageUpd…https://github.com/adcontextprotocol/adcp-client-python/pull/1548/commits/0afbe280c1153523746e3a679ecf0d3ed539bfb9
0afbe28https://github.com/adcontextprotocol/adcp-client-python/pull/1548/commits/0afbe280c1153523746e3a679ecf0d3ed539bfb9
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1548#pullrequestreview-5590727027
0afbe28https://github.com/adcontextprotocol/adcp-client-python/commit/0afbe280c1153523746e3a679ecf0d3ed539bfb9
October 22, 2026 10:02https://github.com/adcontextprotocol/adcp-client-python/pull/1548#event-33937174342
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 22, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1548#pullrequestreview-5612513214
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1548/files/0afbe280c1153523746e3a679ecf0d3ed539bfb9
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1548#pullrequestreview-5612513214
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 22, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1548#pullrequestreview-5612627987
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1548/files/0afbe280c1153523746e3a679ecf0d3ed539bfb9
bokelleyhttps://github.com/bokelley
https://github.com/adcontextprotocol/adcp-client-python/pull/1548#pullrequestreview-5612627987
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1546https://github.com/adcontextprotocol/adcp-client-python/pull/1546
0afbe28https://github.com/adcontextprotocol/adcp-client-python/commit/0afbe280c1153523746e3a679ecf0d3ed539bfb9
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
69a0f6bhttps://github.com/adcontextprotocol/adcp-client-python/commit/69a0f6b9525b400b17b25c1b18294a4650c56afb
Oct 22, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1548#event-33948104739
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Oct 22, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1548#ref-pullrequest-5931228976
chore(main): release 9.0.0 #1540 https://github.com/adcontextprotocol/adcp-client-python/pull/1540
chore: merge main into next through 9.2.0 #1578 https://github.com/adcontextprotocol/adcp-client-python/pull/1578
fix(types): inherit the generated creatives ceiling on PackageRequest #1579 https://github.com/adcontextprotocol/adcp-client-python/pull/1579
fix(types): backport generated creatives constraints on canonical packages and sync to 8.x #1584 https://github.com/adcontextprotocol/adcp-client-python/pull/1584
bokelleyhttps://github.com/bokelley
Oct 24, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1548#ref-commit-6f13ce0
https://github.com/bokelley
https://github.com/claude
fix(types): inherit the generated creatives ceiling on PackageRequest (https://github.com/adcontextprotocol/adcp-client-python/commit/6f13ce07e69bc24de23ce63b97958875f6866cc7
…https://github.com/adcontextprotocol/adcp-client-python/pull/1579
6f13ce0https://github.com/adcontextprotocol/adcp-client-python/commit/6f13ce07e69bc24de23ce63b97958875f6866cc7
…#1579https://github.com/adcontextprotocol/adcp-client-python/pull/1579
#1548https://github.com/adcontextprotocol/adcp-client-python/pull/1548
bokelleyhttps://github.com/bokelley
Oct 24, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1548#ref-commit-39829da
https://github.com/bokelley
https://github.com/claude
fix(types): backport generated creatives constraints on canonical pac…https://github.com/adcontextprotocol/adcp-client-python/commit/39829dad3ccdc0d47a2f6e03b22b584542aa99dd
39829dahttps://github.com/adcontextprotocol/adcp-client-python/commit/39829dad3ccdc0d47a2f6e03b22b584542aa99dd
#1546https://github.com/adcontextprotocol/adcp-client-python/pull/1546
#1548https://github.com/adcontextprotocol/adcp-client-python/pull/1548
bokelleyhttps://github.com/bokelley
Oct 24, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1548#ref-commit-9b3d11e
https://github.com/bokelley
fix(types): backport generated creatives constraints on canonical pac…https://github.com/adcontextprotocol/adcp-client-python/commit/9b3d11e59d9671949692f8401ae5b26c1dcdcb60
9b3d11ehttps://github.com/adcontextprotocol/adcp-client-python/commit/9b3d11e59d9671949692f8401ae5b26c1dcdcb60
#1584https://github.com/adcontextprotocol/adcp-client-python/pull/1584
#1548https://github.com/adcontextprotocol/adcp-client-python/pull/1548
#1546https://github.com/adcontextprotocol/adcp-client-python/pull/1546
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 25, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1548#ref-pullrequest-6030828462
fix(types): inherit the generated field on every hand-written redeclaration #1625 https://github.com/adcontextprotocol/adcp-client-python/pull/1625
bokelleyhttps://github.com/bokelley
Oct 26, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1548#ref-commit-6e0ed68
https://github.com/bokelley
fix(types): inherit the generated field on every hand-written redecla…https://github.com/adcontextprotocol/adcp-client-python/commit/6e0ed688e16c3be94fb117fef5157b4cda08a136
6e0ed68https://github.com/adcontextprotocol/adcp-client-python/commit/6e0ed688e16c3be94fb117fef5157b4cda08a136
#1625https://github.com/adcontextprotocol/adcp-client-python/pull/1625
#1620https://github.com/adcontextprotocol/adcp-client-python/issues/1620
#1587https://github.com/adcontextprotocol/adcp-client-python/issues/1587
#1610https://github.com/adcontextprotocol/adcp-client-python/issues/1610
#1548https://github.com/adcontextprotocol/adcp-client-python/pull/1548
#1579https://github.com/adcontextprotocol/adcp-client-python/pull/1579
#1591https://github.com/adcontextprotocol/adcp-client-python/pull/1591
#1548https://github.com/adcontextprotocol/adcp-client-python/pull/1548
https://claude.com/claude-codehttps://claude.com/claude-code
https://app.conductor.build/pro-user-232ad008-36c5-45c0-b430-d68f028abd4b/w/851https://app.conductor.build/pro-user-232ad008-36c5-45c0-b430-d68f028abd4b/w/851
chore(next): release 9.0.0 #1533 https://github.com/adcontextprotocol/adcp-client-python/pull/1533
chore(next): release 10.0.0-beta.0 #1673 https://github.com/adcontextprotocol/adcp-client-python/pull/1673
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1548
https://github.com/bokelley
bokelley https://github.com/bokelley
https://github.com/adcontextprotocol/adcp-client-python/pull/1548/files/0afbe280c1153523746e3a679ecf0d3ed539bfb9
https://github.com/apps/aao-secretariat
aao-secretariat[bot] https://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1548/files/0afbe280c1153523746e3a679ecf0d3ed539bfb9
https://github.com/rachitm022
rachitm022 https://github.com/rachitm022
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1548
https://github.com/KonstantinMirin
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.