René's URL Explorer Experiment


Title: fix: use default JSON separators for webhook HMAC signing by EmmaLouise2018 · Pull Request #152 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix: use default JSON separators for webhook HMAC signing by EmmaLouise2018 · Pull Request #152 · adcontextprotocol/adcp-client-python

X Title: fix: use default JSON separators for webhook HMAC signing by EmmaLouise2018 · Pull Request #152 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Summary Signing fix: get_adcp_signed_headers_for_webhook() was computing HMAC over compact JSON (separators=(",", ":")) but callers send the body via json= kwarg which uses def...

X Description: Summary Signing fix: get_adcp_signed_headers_for_webhook() was computing HMAC over compact JSON (separators=(",", ":")) but callers send the body via json= kwar...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/152

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:109dac82-22a9-e95a-7284-47ec42d020d2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB776:28815B:10051C4:155ECB8:6B011123
html-safe-nonce88bef9a2f024197d2759f06d0d5dbee9a245d6e3f304e0deb795ea87bd64744e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzc2OjI4ODE1QjoxMDA1MUM0OjE1NUVDQjg6NkIwMTExMjMiLCJ2aXNpdG9yX2lkIjoiMTQ4NTkxMDQ0MDA5NzI2MjQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac66b78a1422571f12d8e3d943fb393d2956e7411653b492e73b741b082ebd206c
hovercard-subject-tagpull_request:3381445180
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/152/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7b38f42d4dc881477757688fb8305e2caf5c21f57adcb95f57ee35d7a7fa8b5a/adcontextprotocol/adcp-client-python/pull/152
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7b38f42d4dc881477757688fb8305e2caf5c21f57adcb95f57ee35d7a7fa8b5a/adcontextprotocol/adcp-client-python/pull/152
og:image:altSummary Signing fix: get_adcp_signed_headers_for_webhook() was computing HMAC over compact JSON (separators=(",", ":")) but callers send the body via json= kwarg which uses def...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEmmaLouise2018
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/152#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F152
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F152
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/152
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/152
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/152
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
EmmaLouise2018https://github.com/EmmaLouise2018
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
EmmaLouise2018/fix-issue-151https://github.com/adcontextprotocol/adcp-client-python/tree/EmmaLouise2018/fix-issue-151
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/152
Commits3 (3)https://github.com/adcontextprotocol/adcp-client-python/pull/152/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/152/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/152/files
fix: use default JSON separators for webhook HMAC signinghttps://github.com/adcontextprotocol/adcp-client-python/pull/152#top
EmmaLouise2018https://github.com/EmmaLouise2018
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
EmmaLouise2018/fix-issue-151https://github.com/adcontextprotocol/adcp-client-python/tree/EmmaLouise2018/fix-issue-151
https://github.com/EmmaLouise2018
EmmaLouise2018https://github.com/EmmaLouise2018
Mar 11, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/152#issue-4055067279
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/152
adcontextprotocol/adcp PR #1383https://github.com/adcontextprotocol/adcp/pull/1383
#151https://github.com/adcontextprotocol/adcp-client-python/issues/151
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/152
https://github.com/EmmaLouise2018
fix: use default JSON separators for webhook HMAC signinghttps://github.com/adcontextprotocol/adcp-client-python/pull/152/commits/0dd495fd83c0c0d4df99fe794d878d0f98735cc8
0dd495fhttps://github.com/adcontextprotocol/adcp-client-python/pull/152/commits/0dd495fd83c0c0d4df99fe794d878d0f98735cc8
#151https://github.com/adcontextprotocol/adcp-client-python/issues/151
https://github.com/EmmaLouise2018
EmmaLouise2018https://github.com/EmmaLouise2018
bokelleyhttps://github.com/bokelley
March 11, 2026 01:34https://github.com/adcontextprotocol/adcp-client-python/pull/152#event-23452611772
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Mar 11, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/152#pullrequestreview-3927054906
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/152/files/0dd495fd83c0c0d4df99fe794d878d0f98735cc8
bokelleyhttps://github.com/bokelley
https://github.com/adcontextprotocol/adcp-client-python/pull/152#pullrequestreview-3927054906
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#314https://github.com/adcontextprotocol/adcp-client-python/issues/314
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/152
https://github.com/EmmaLouise2018
fix: add raw_body support for verification and use Unix timestampshttps://github.com/adcontextprotocol/adcp-client-python/pull/152/commits/4a663e5406bbf2ce533842fdd74c749a79f802d1
4a663e5https://github.com/adcontextprotocol/adcp-client-python/pull/152/commits/4a663e5406bbf2ce533842fdd74c749a79f802d1
#151https://github.com/adcontextprotocol/adcp-client-python/issues/151
https://github.com/EmmaLouise2018
EmmaLouise2018https://github.com/EmmaLouise2018
Mar 11, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/152#issuecomment-4036658592
4a663e5https://github.com/adcontextprotocol/adcp-client-python/commit/4a663e5406bbf2ce533842fdd74c749a79f802d1
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/152
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Mar 11, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/152#ref-pullrequest-4056030209
Add HMAC-SHA256 test vectors for cross-language interop adcontextprotocol/adcp#1383 https://github.com/adcontextprotocol/adcp/pull/1383
https://github.com/EmmaLouise2018
EmmaLouise2018https://github.com/EmmaLouise2018
bokelleyhttps://github.com/bokelley
March 11, 2026 05:50https://github.com/adcontextprotocol/adcp-client-python/pull/152#event-23457360808
https://github.com/EmmaLouise2018
test: validate webhook HMAC against official AdCP test vectorshttps://github.com/adcontextprotocol/adcp-client-python/pull/152/commits/72f8f4b240a5a63da56f3de0ba5eccfe13c55bea
72f8f4bhttps://github.com/adcontextprotocol/adcp-client-python/pull/152/commits/72f8f4b240a5a63da56f3de0ba5eccfe13c55bea
#1383https://github.com/adcontextprotocol/adcp-client-python/issues/1383
https://github.com/EmmaLouise2018
EmmaLouise2018https://github.com/EmmaLouise2018
2223f6ehttps://github.com/adcontextprotocol/adcp-client-python/commit/2223f6ed5a2d32cdc000a273f591d30e3cfe2e65
Mar 11, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/152#event-23478430042
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/152
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F152
https://github.com/bokelley
bokelley https://github.com/bokelley
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/152
Bug: get_adcp_signed_headers_for_webhook signs compact JSON but wire body uses default JSON https://github.com/adcontextprotocol/adcp-client-python/issues/151
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/152
https://github.com/EmmaLouise2018
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.