René's URL Explorer Experiment


Title: fix(signing)!: apply canonicalization step 5 whatever the query does by KonstantinMirin · Pull Request #1456 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(signing)!: apply canonicalization step 5 whatever the query does by KonstantinMirin · Pull Request #1456 · adcontextprotocol/adcp-client-python

X Title: fix(signing)!: apply canonicalization step 5 whatever the query does by KonstantinMirin · Pull Request #1456 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: The divergence canonicalize_target_uri applies step 5 of the AdCP URL-canonicalization algorithm only when a query string is present (src/adcp/signing/canonical.py:125): path = _normalize_path(part...

X Description: The divergence canonicalize_target_uri applies step 5 of the AdCP URL-canonicalization algorithm only when a query string is present (src/adcp/signing/canonical.py:125): path = _normalize_path(part...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/1456

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bce6725d-db4a-6bd0-029a-f4ada43739f2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id87B2:A20F9:D1C992:1181934:6B00F958
html-safe-noncecbd0a35f5447117aee33e868143b01d1d3e75d92d0f4979d49d16001a4606874
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0IyOkEyMEY5OkQxQzk5MjoxMTgxOTM0OjZCMDBGOTU4IiwidmlzaXRvcl9pZCI6IjMzNDE3MDU5NTUwNTc0MDAxNTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf6e83821dc914d6e5b1c295a4c0a33bb61748493d550779ff9734998a15cb7ff
hovercard-subject-tagpull_request:4794844724
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1456/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c0b4b865a9752ebf5fca3f9e89c932fe0630012937242cd5ed8992141fb920fa/adcontextprotocol/adcp-client-python/pull/1456
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c0b4b865a9752ebf5fca3f9e89c932fe0630012937242cd5ed8992141fb920fa/adcontextprotocol/adcp-client-python/pull/1456
og:image:altThe divergence canonicalize_target_uri applies step 5 of the AdCP URL-canonicalization algorithm only when a query string is present (src/adcp/signing/canonical.py:125): path = _normalize_path(part...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKonstantinMirin
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/1456#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1456
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1456
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
adcontextprotocol:mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
KonstantinMirin:fix/canonical-step5-empty-pathhttps://github.com/KonstantinMirin/adcp-client-python/tree/fix/canonical-step5-empty-path
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
Commits1 (1)https://github.com/adcontextprotocol/adcp-client-python/pull/1456/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/1456/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/1456/files
fix(signing)!: apply canonicalization step 5 whatever the query doeshttps://github.com/adcontextprotocol/adcp-client-python/pull/1456#top
bokelleyhttps://github.com/bokelley
adcontextprotocol:mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
KonstantinMirin:fix/canonical-step5-empty-pathhttps://github.com/KonstantinMirin/adcp-client-python/tree/fix/canonical-step5-empty-path
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 9, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1456#issue-5771389176
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
docs/reference/url-canonicalization.mdxhttps://github.com/adcontextprotocol/adcp/blob/main/docs/reference/url-canonicalization.mdx
#1https://github.com/adcontextprotocol/adcp-client-python/pull/1
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
bokelleyhttps://github.com/bokelley
code ownerhttps://github.com/adcontextprotocol/adcp-client-python/blob/7d610e1ae1f6aedd5b9290857052e86c209b634c/.github/CODEOWNERS#L3
October 9, 2026 01:35https://github.com/adcontextprotocol/adcp-client-python/pull/1456#event-32838708170
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 9, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1456#pullrequestreview-5465218464
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1456/files
src/adcp/signing/canonical.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1456/files#diff-0d2897b75d8d6cd3bfdde59331d2d352848181fda0c024ece51ff479759840dc
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 9, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1456#discussion_r4226203489
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 9, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1456#discussion_r4231453319
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
dcf4165https://github.com/adcontextprotocol/adcp-client-python/commit/dcf4165de04831141aad6d484ec69bd701ce7ecb
dcf4165https://github.com/adcontextprotocol/adcp-client-python/commit/dcf4165de04831141aad6d484ec69bd701ce7ecb
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 9, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1456#pullrequestreview-5465221937
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1456/files
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1456#pullrequestreview-5465221937
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
force-pushedhttps://github.com/adcontextprotocol/adcp-client-python/compare/cf54500af668454ae5767e967a612d9adf7af9c7..6de6e7131adf351f92a23e8b238e88bb9cfe2d4f
cf54500https://github.com/adcontextprotocol/adcp-client-python/commit/cf54500af668454ae5767e967a612d9adf7af9c7
6de6e71https://github.com/adcontextprotocol/adcp-client-python/commit/6de6e7131adf351f92a23e8b238e88bb9cfe2d4f
Compare https://github.com/adcontextprotocol/adcp-client-python/compare/cf54500af668454ae5767e967a612d9adf7af9c7..6de6e7131adf351f92a23e8b238e88bb9cfe2d4f
October 9, 2026 14:54https://github.com/adcontextprotocol/adcp-client-python/pull/1456#event-32885320193
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 9, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1456#event-32885325656
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 9, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1456#issuecomment-6083397011
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
dcf4165https://github.com/adcontextprotocol/adcp-client-python/commit/dcf4165de04831141aad6d484ec69bd701ce7ecb
cf54500https://github.com/adcontextprotocol/adcp-client-python/commit/cf54500af668454ae5767e967a612d9adf7af9c7
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
https://github.com/KonstantinMirin
fix(signing)!: apply canonicalization step 5 whatever the query doeshttps://github.com/adcontextprotocol/adcp-client-python/pull/1456/commits/dcf4165de04831141aad6d484ec69bd701ce7ecb
dcf4165https://github.com/adcontextprotocol/adcp-client-python/pull/1456/commits/dcf4165de04831141aad6d484ec69bd701ce7ecb
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
force-pushedhttps://github.com/adcontextprotocol/adcp-client-python/compare/6de6e7131adf351f92a23e8b238e88bb9cfe2d4f..dcf4165de04831141aad6d484ec69bd701ce7ecb
6de6e71https://github.com/adcontextprotocol/adcp-client-python/commit/6de6e7131adf351f92a23e8b238e88bb9cfe2d4f
dcf4165https://github.com/adcontextprotocol/adcp-client-python/commit/dcf4165de04831141aad6d484ec69bd701ce7ecb
Compare https://github.com/adcontextprotocol/adcp-client-python/compare/6de6e7131adf351f92a23e8b238e88bb9cfe2d4f..dcf4165de04831141aad6d484ec69bd701ce7ecb
October 9, 2026 14:56https://github.com/adcontextprotocol/adcp-client-python/pull/1456#event-32885459447
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1456#pullrequestreview-5465221937
October 9, 2026 15:16https://github.com/adcontextprotocol/adcp-client-python/pull/1456#event-32886995693
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 9, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1456#pullrequestreview-5471964824
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1456/files/dcf4165de04831141aad6d484ec69bd701ce7ecb
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1456#pullrequestreview-5471964824
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 9, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1456#issuecomment-6088489717
@bokelleyhttps://github.com/bokelley
@rachitm022https://github.com/rachitm022
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 10, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1456#pullrequestreview-5479647649
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1456/files/dcf4165de04831141aad6d484ec69bd701ce7ecb
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
0830b4ehttps://github.com/adcontextprotocol/adcp-client-python/commit/0830b4e2262435ca7b66c256288a1657f3f51dfd
Oct 10, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1456#event-32947245655
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Oct 10, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1456#ref-pullrequest-5766765442
chore(main): release 9.0.0-beta.3 #1455 https://github.com/adcontextprotocol/adcp-client-python/pull/1455
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1456
https://github.com/bokelley
bokelley https://github.com/bokelley
https://github.com/adcontextprotocol/adcp-client-python/pull/1456/files/dcf4165de04831141aad6d484ec69bd701ce7ecb
https://github.com/apps/aao-secretariat
aao-secretariat[bot] https://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1456/files/dcf4165de04831141aad6d484ec69bd701ce7ecb
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1456
https://github.com/KonstantinMirin
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.