| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:732b8a07-1195-aa81-3168-cfee6d5602d9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E60E:1D8AA1:D47518:1191AB6:6B00F4F6 |
| html-safe-nonce | 4d2e7d58938a74358c061a56550172c487a4e28fac7d517692a3e89ee1365a80 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjBFOjFEOEFBMTpENDc1MTg6MTE5MUFCNjo2QjAwRjRGNiIsInZpc2l0b3JfaWQiOiI4NjYxNDUzMTA1MDEyOTk1MzE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | bb4dd6f0027c0989fbb58edade04c4e7e33e551bcfd753ece9f0243deeb628a5 |
| hovercard-subject-tag | pull_request:4759304729 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1419/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ce38402c3f40296a61caea0d820f8f87783779b27efa2ae002911bd786ffeb8b/adcontextprotocol/adcp-client-python/pull/1419 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ce38402c3f40296a61caea0d820f8f87783779b27efa2ae002911bd786ffeb8b/adcontextprotocol/adcp-client-python/pull/1419 |
| og:image:alt | Closes #1416. Found in the post-merge audit of #1392.
Problem
Ten overriding list fields in src/adcp/types/canonical_creative.py were annotated SchemaVariant[...]. That marker is for adopter overri... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1419 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1419 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
| adcontextprotocol | https://github.com/adcontextprotocol |
| adcp-client-python | https://github.com/adcontextprotocol/adcp-client-python |
| Code | https://github.com/adcontextprotocol/adcp-client-python |
| Issues44 (44) | https://github.com/adcontextprotocol/adcp-client-python/issues |
| Pull requests13 (13) | https://github.com/adcontextprotocol/adcp-client-python/pulls |
| Actions | https://github.com/adcontextprotocol/adcp-client-python/actions |
| Projects | https://github.com/adcontextprotocol/adcp-client-python/projects |
| Security and quality | https://github.com/adcontextprotocol/adcp-client-python/security |
| Insights | https://github.com/adcontextprotocol/adcp-client-python/insights |
| https://github.com/adcontextprotocol/adcp-client-python |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| claude/issue-1416-canonical-field-types | https://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-1416-canonical-field-types |
| Conversation | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
| Commits4 (4) | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits |
| Checks | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/checks |
| Files changed | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files |
| fix(types): declare the canonical list overrides precisely for every checker | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#top |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| claude/issue-1416-canonical-field-types | https://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-1416-canonical-field-types |
|
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| Oct 6, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#issue-5729092564 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
| #1416 | https://github.com/adcontextprotocol/adcp-client-python/issues/1416 |
| #1392 | https://github.com/adcontextprotocol/adcp-client-python/pull/1392 |
| Claude Code | https://claude.com/claude-code |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| fix(types): declare the canonical list overrides precisely for every … | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/cb0ba0daef631975f3b80d4d86863743fe5486ba |
| cb0ba0d | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/cb0ba0daef631975f3b80d4d86863743fe5486ba |
| #1392 | https://github.com/adcontextprotocol/adcp-client-python/pull/1392 |
| #1416 | https://github.com/adcontextprotocol/adcp-client-python/issues/1416 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| KonstantinMirin | https://github.com/KonstantinMirin |
| code owner | https://github.com/adcontextprotocol/adcp-client-python/blob/0d2e61d4e8fe6db2c81e34127403715f3219dd1c/.github/CODEOWNERS#L3 |
| October 6, 2026 13:19 | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32601605254 |
| https://github.com/apps/aao-secretariat |
| aao-secretariat | https://github.com/apps/aao-secretariat |
|
Oct 6, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5429684480 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/cb0ba0daef631975f3b80d4d86863743fe5486ba |
| aao-secretariat | https://github.com/apps/aao-secretariat |
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5429684480 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
| https://github.com/apps/github-code-quality |
| github-code-quality | https://github.com/apps/github-code-quality |
|
Oct 6, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5429782857 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/cb0ba0daef631975f3b80d4d86863743fe5486ba |
| tests/test_canonical_override_field_types.py | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/cb0ba0daef631975f3b80d4d86863743fe5486ba#diff-2c2c6701a500e317958b7ac554dffdccf96967aa563824aed4cb2bbc2152e6ca |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| test(types): pass str as the parametrize id function directly | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/924aa902b43536fed43bfdbfa1b2a655a2517ba0 |
| 924aa90 | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/924aa902b43536fed43bfdbfa1b2a655a2517ba0 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| aao-secretariat[bot] | https://github.com/apps/aao-secretariat |
| stale review | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5429684480 |
| 924aa90 | https://github.com/adcontextprotocol/adcp-client-python/commit/924aa902b43536fed43bfdbfa1b2a655a2517ba0 |
| October 6, 2026 14:34 | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32608133966 |
| https://github.com/apps/aao-secretariat |
| aao-secretariat | https://github.com/apps/aao-secretariat |
|
Oct 6, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5430273080 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/924aa902b43536fed43bfdbfa1b2a655a2517ba0 |
| aao-secretariat | https://github.com/apps/aao-secretariat |
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5430273080 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| cb0ba0d | https://github.com/adcontextprotocol/adcp-client-python/commit/cb0ba0daef631975f3b80d4d86863743fe5486ba |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| fix(ci): skip pyright fixtures whose optional dependency is not insta… | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/63142fa87010e9caa8cc23d520229f8af62797b7 |
| 63142fa | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/63142fa87010e9caa8cc23d520229f8af62797b7 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| aao-secretariat[bot] | https://github.com/apps/aao-secretariat |
| stale review | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5430273080 |
| 63142fa | https://github.com/adcontextprotocol/adcp-client-python/commit/63142fa87010e9caa8cc23d520229f8af62797b7 |
| October 6, 2026 16:15 | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32617232075 |
| https://github.com/apps/aao-secretariat |
| aao-secretariat | https://github.com/apps/aao-secretariat |
|
Oct 6, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5431497369 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/63142fa87010e9caa8cc23d520229f8af62797b7 |
| scripts/run_pyright_type_checks.py | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/63142fa87010e9caa8cc23d520229f8af62797b7#diff-7d374517bffab54aa11bb39f014dd102fb920ff166a374fed75f995e0b789773 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
| https://github.com/apps/aao-secretariat |
| aao-secretariat | https://github.com/apps/aao-secretariat |
|
Oct 6, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5431502499 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/63142fa87010e9caa8cc23d520229f8af62797b7 |
| aao-secretariat | https://github.com/apps/aao-secretariat |
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5431502499 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| fix(ci): install the pg extra for the pyright gate instead of skippin… | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/a838d05eb34ec87c20f51315207ea79b3ef7fa3a |
| a838d05 | https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/a838d05eb34ec87c20f51315207ea79b3ef7fa3a |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| aao-secretariat[bot] | https://github.com/apps/aao-secretariat |
| stale review | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5431502499 |
| a838d05 | https://github.com/adcontextprotocol/adcp-client-python/commit/a838d05eb34ec87c20f51315207ea79b3ef7fa3a |
| October 6, 2026 17:20 | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32621926003 |
| https://github.com/apps/aao-secretariat |
| aao-secretariat | https://github.com/apps/aao-secretariat |
|
Oct 6, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5432172050 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/a838d05eb34ec87c20f51315207ea79b3ef7fa3a |
| aao-secretariat | https://github.com/apps/aao-secretariat |
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5432172050 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| 43910ce | https://github.com/adcontextprotocol/adcp-client-python/commit/43910ce9fe22ca87e6b2e79dc549f4bf31198a19 |
| Oct 6, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32625867429 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| October 6, 2026 18:15 | https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32625870214 |
| https://github.com/apps/aao-ipr-bot |
| aao-ipr-bot | https://github.com/apps/aao-ipr-bot |
|
Oct 6, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#ref-pullrequest-5732138513 |
|
chore(main): release 9.0.0-beta.2
#1421
| https://github.com/adcontextprotocol/adcp-client-python/pull/1421 |
| https://github.com/KonstantinMirin |
| KonstantinMirin | https://github.com/KonstantinMirin |
|
Oct 20, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419#ref-issue-5948369195 |
|
Generated optional properties render as T | None, accepting an explicit JSON null the schema forbids
#1547
| https://github.com/adcontextprotocol/adcp-client-python/issues/1547 |
| https://github.co/hiddenchars |
| https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1419 |
|
| https://github.com/apps/aao-secretariat |
|
aao-secretariat[bot]
| https://github.com/apps/aao-secretariat |
|
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/a838d05eb34ec87c20f51315207ea79b3ef7fa3a |
|
| https://github.com/KonstantinMirin |
|
KonstantinMirin
| https://github.com/KonstantinMirin |
|
| https://github.com/apps/github-code-quality |
|
github-code-quality[bot]
| https://github.com/apps/github-code-quality |
|
| https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/cb0ba0daef631975f3b80d4d86863743fe5486ba |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
|
Canonical response fields typed SchemaVariant lose element types (pyright errors, Any under the mypy plugin)
| https://github.com/adcontextprotocol/adcp-client-python/issues/1416 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1419 |
|
| https://github.com/bokelley |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |