René's URL Explorer Experiment


Title: fix(types): declare the canonical list overrides precisely for every checker by bokelley · Pull Request #1419 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(types): declare the canonical list overrides precisely for every checker by bokelley · Pull Request #1419 · adcontextprotocol/adcp-client-python

X Title: fix(types): declare the canonical list overrides precisely for every checker by bokelley · Pull Request #1419 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Closes #1416. Found in the post-merge audit of #1392. Problem Ten overriding list fields in src/adcp/types/canonical_creative.py were annotated SchemaVariant[...]. That marker is for adopter overri...

X Description: Closes #1416. Found in the post-merge audit of #1392. Problem Ten overriding list fields in src/adcp/types/canonical_creative.py were annotated SchemaVariant[...]. That marker is for adopter overri...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/1419

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:732b8a07-1195-aa81-3168-cfee6d5602d9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE60E:1D8AA1:D47518:1191AB6:6B00F4F6
html-safe-nonce4d2e7d58938a74358c061a56550172c487a4e28fac7d517692a3e89ee1365a80
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjBFOjFEOEFBMTpENDc1MTg6MTE5MUFCNjo2QjAwRjRGNiIsInZpc2l0b3JfaWQiOiI4NjYxNDUzMTA1MDEyOTk1MzE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbb4dd6f0027c0989fbb58edade04c4e7e33e551bcfd753ece9f0243deeb628a5
hovercard-subject-tagpull_request:4759304729
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1419/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ce38402c3f40296a61caea0d820f8f87783779b27efa2ae002911bd786ffeb8b/adcontextprotocol/adcp-client-python/pull/1419
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ce38402c3f40296a61caea0d820f8f87783779b27efa2ae002911bd786ffeb8b/adcontextprotocol/adcp-client-python/pull/1419
og:image:altCloses #1416. Found in the post-merge audit of #1392. Problem Ten overriding list fields in src/adcp/types/canonical_creative.py were annotated SchemaVariant[...]. That marker is for adopter overri...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/1419#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1419
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1419
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-1416-canonical-field-typeshttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-1416-canonical-field-types
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
Commits4 (4)https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/1419/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419/files
fix(types): declare the canonical list overrides precisely for every checkerhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-1416-canonical-field-typeshttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-1416-canonical-field-types
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 6, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1419#issue-5729092564
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
#1416https://github.com/adcontextprotocol/adcp-client-python/issues/1416
#1392https://github.com/adcontextprotocol/adcp-client-python/pull/1392
Claude Codehttps://claude.com/claude-code
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
https://github.com/bokelley
https://github.com/claude
fix(types): declare the canonical list overrides precisely for every …https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/cb0ba0daef631975f3b80d4d86863743fe5486ba
cb0ba0dhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/cb0ba0daef631975f3b80d4d86863743fe5486ba
#1392https://github.com/adcontextprotocol/adcp-client-python/pull/1392
#1416https://github.com/adcontextprotocol/adcp-client-python/issues/1416
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
KonstantinMirinhttps://github.com/KonstantinMirin
code ownerhttps://github.com/adcontextprotocol/adcp-client-python/blob/0d2e61d4e8fe6db2c81e34127403715f3219dd1c/.github/CODEOWNERS#L3
October 6, 2026 13:19https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32601605254
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5429684480
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/cb0ba0daef631975f3b80d4d86863743fe5486ba
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5429684480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
https://github.com/apps/github-code-quality
github-code-qualityhttps://github.com/apps/github-code-quality
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5429782857
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/cb0ba0daef631975f3b80d4d86863743fe5486ba
tests/test_canonical_override_field_types.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/cb0ba0daef631975f3b80d4d86863743fe5486ba#diff-2c2c6701a500e317958b7ac554dffdccf96967aa563824aed4cb2bbc2152e6ca
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
https://github.com/bokelley
https://github.com/claude
test(types): pass str as the parametrize id function directlyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/924aa902b43536fed43bfdbfa1b2a655a2517ba0
924aa90https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/924aa902b43536fed43bfdbfa1b2a655a2517ba0
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5429684480
924aa90https://github.com/adcontextprotocol/adcp-client-python/commit/924aa902b43536fed43bfdbfa1b2a655a2517ba0
October 6, 2026 14:34https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32608133966
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5430273080
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/924aa902b43536fed43bfdbfa1b2a655a2517ba0
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5430273080
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cb0ba0dhttps://github.com/adcontextprotocol/adcp-client-python/commit/cb0ba0daef631975f3b80d4d86863743fe5486ba
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
https://github.com/bokelley
https://github.com/claude
fix(ci): skip pyright fixtures whose optional dependency is not insta…https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/63142fa87010e9caa8cc23d520229f8af62797b7
63142fahttps://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/63142fa87010e9caa8cc23d520229f8af62797b7
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5430273080
63142fahttps://github.com/adcontextprotocol/adcp-client-python/commit/63142fa87010e9caa8cc23d520229f8af62797b7
October 6, 2026 16:15https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32617232075
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5431497369
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/63142fa87010e9caa8cc23d520229f8af62797b7
scripts/run_pyright_type_checks.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/63142fa87010e9caa8cc23d520229f8af62797b7#diff-7d374517bffab54aa11bb39f014dd102fb920ff166a374fed75f995e0b789773
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5431502499
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/63142fa87010e9caa8cc23d520229f8af62797b7
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5431502499
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
https://github.com/bokelley
https://github.com/claude
fix(ci): install the pg extra for the pyright gate instead of skippin…https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/a838d05eb34ec87c20f51315207ea79b3ef7fa3a
a838d05https://github.com/adcontextprotocol/adcp-client-python/pull/1419/commits/a838d05eb34ec87c20f51315207ea79b3ef7fa3a
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5431502499
a838d05https://github.com/adcontextprotocol/adcp-client-python/commit/a838d05eb34ec87c20f51315207ea79b3ef7fa3a
October 6, 2026 17:20https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32621926003
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5432172050
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/a838d05eb34ec87c20f51315207ea79b3ef7fa3a
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1419#pullrequestreview-5432172050
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
43910cehttps://github.com/adcontextprotocol/adcp-client-python/commit/43910ce9fe22ca87e6b2e79dc549f4bf31198a19
Oct 6, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32625867429
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
October 6, 2026 18:15https://github.com/adcontextprotocol/adcp-client-python/pull/1419#event-32625870214
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1419#ref-pullrequest-5732138513
chore(main): release 9.0.0-beta.2 #1421 https://github.com/adcontextprotocol/adcp-client-python/pull/1421
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 20, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1419#ref-issue-5948369195
Generated optional properties render as T | None, accepting an explicit JSON null the schema forbids #1547 https://github.com/adcontextprotocol/adcp-client-python/issues/1547
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1419
https://github.com/apps/aao-secretariat
aao-secretariat[bot] https://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/a838d05eb34ec87c20f51315207ea79b3ef7fa3a
https://github.com/KonstantinMirin
KonstantinMirin https://github.com/KonstantinMirin
https://github.com/apps/github-code-quality
github-code-quality[bot] https://github.com/apps/github-code-quality
https://github.com/adcontextprotocol/adcp-client-python/pull/1419/files/cb0ba0daef631975f3b80d4d86863743fe5486ba
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
Canonical response fields typed SchemaVariant lose element types (pyright errors, Any under the mypy plugin) https://github.com/adcontextprotocol/adcp-client-python/issues/1416
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1419
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.