René's URL Explorer Experiment


Title: refactor(codegen)!: make the generated domain tree the one public type surface by KonstantinMirin · Pull Request #1392 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: refactor(codegen)!: make the generated domain tree the one public type surface by KonstantinMirin · Pull Request #1392 · adcontextprotocol/adcp-client-python

X Title: refactor(codegen)!: make the generated domain tree the one public type surface by KonstantinMirin · Pull Request #1392 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: datamodel-code-generator wrote its models to adcp.types.generated_poc, and consolidate_exports.py then emitted 1,059 one-line re-export modules under adcp.types.domains pointing at them. Two trees ...

X Description: datamodel-code-generator wrote its models to adcp.types.generated_poc, and consolidate_exports.py then emitted 1,059 one-line re-export modules under adcp.types.domains pointing at them. Two trees ...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/1392

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0651b41a-d62f-66d2-d9f5-f4c9a79bb206
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB34E:364B55:B5FAB7:EC9EDE:6B00E934
html-safe-nonce6164c20349193c058a9f4573d44481d76bfa9047c6c19443cd7a835280953c69
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzRFOjM2NEI1NTpCNUZBQjc6RUM5RURFOjZCMDBFOTM0IiwidmlzaXRvcl9pZCI6IjIwNjk3NzI3NTM1MTQzMjYzMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf8ce0ae09652de792f4b574053d44689b581d3e49a5d62c4ad94eef6518c1be8
hovercard-subject-tagpull_request:4736112501
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1392/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9a48e69a30cc2834315d79190a8f1f9f43a96caa475adb744eb00efb49f2a541/adcontextprotocol/adcp-client-python/pull/1392
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9a48e69a30cc2834315d79190a8f1f9f43a96caa475adb744eb00efb49f2a541/adcontextprotocol/adcp-client-python/pull/1392
og:image:altdatamodel-code-generator wrote its models to adcp.types.generated_poc, and consolidate_exports.py then emitted 1,059 one-line re-export modules under adcp.types.domains pointing at them. Two trees ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKonstantinMirin
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/1392#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1392
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1392
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests12 (12)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
adcontextprotocol:mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
KonstantinMirin:feat/type-lattice-and-subclasseshttps://github.com/KonstantinMirin/adcp-client-python/tree/feat/type-lattice-and-subclasses
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
Commits24 (24)https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/files
refactor(codegen)!: make the generated domain tree the one public type surfacehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392#top
bokelleyhttps://github.com/bokelley
adcontextprotocol:mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
KonstantinMirin:feat/type-lattice-and-subclasseshttps://github.com/KonstantinMirin/adcp-client-python/tree/feat/type-lattice-and-subclasses
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 4, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#issue-5701444131
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
#1396https://github.com/adcontextprotocol/adcp-client-python/pull/1396
#1374https://github.com/adcontextprotocol/adcp-client-python/pull/1374
fix(codegen): make a dead post-generation fix and a stale generated tree fail the build #1374https://github.com/adcontextprotocol/adcp-client-python/pull/1374
fix(codegen): make a dead post-generation fix and a stale generated tree fail the build #1374https://github.com/adcontextprotocol/adcp-client-python/pull/1374
fix(types): name each export once in __all__ #1393https://github.com/adcontextprotocol/adcp-client-python/pull/1393
fix(codegen): keep the format-reference agent_url as the wire string #1396https://github.com/adcontextprotocol/adcp-client-python/pull/1396
fix(codegen): keep the format-reference agent_url as the wire string #1396https://github.com/adcontextprotocol/adcp-client-python/pull/1396
fix(codegen): make a dead post-generation fix and a stale generated tree fail the build #1374https://github.com/adcontextprotocol/adcp-client-python/pull/1374
#1360https://github.com/adcontextprotocol/adcp-client-python/issues/1360
#1368https://github.com/adcontextprotocol/adcp-client-python/pull/1368
#1368https://github.com/adcontextprotocol/adcp-client-python/pull/1368
#1409https://github.com/adcontextprotocol/adcp-client-python/issues/1409
adcontextprotocol/adcp#7913https://github.com/adcontextprotocol/adcp/issues/7913
#1367https://github.com/adcontextprotocol/adcp-client-python/pull/1367
#1409https://github.com/adcontextprotocol/adcp-client-python/issues/1409
#1360https://github.com/adcontextprotocol/adcp-client-python/issues/1360
#1241https://github.com/adcontextprotocol/adcp-client-python/issues/1241
#1374https://github.com/adcontextprotocol/adcp-client-python/pull/1374
#1396https://github.com/adcontextprotocol/adcp-client-python/pull/1396
adcontextprotocol/adcp#7929https://github.com/adcontextprotocol/adcp/issues/7929
#1402https://github.com/adcontextprotocol/adcp-client-python/issues/1402
#1398https://github.com/adcontextprotocol/adcp-client-python/issues/1398
#1384https://github.com/adcontextprotocol/adcp-client-python/issues/1384
#1399https://github.com/adcontextprotocol/adcp-client-python/issues/1399
#1398https://github.com/adcontextprotocol/adcp-client-python/issues/1398
#1401https://github.com/adcontextprotocol/adcp-client-python/issues/1401
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 4, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-pullrequest-5693642076
fix(codegen)!: enforce root-level anyOf/oneOf required groups #1368 https://github.com/adcontextprotocol/adcp-client-python/pull/1368
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 4, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5407291151
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1392/files
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5407291151
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
KonstantinMirinhttps://github.com/KonstantinMirin
October 4, 2026 23:55https://github.com/adcontextprotocol/adcp-client-python/pull/1392#commits-pushed-a942fd2
https://github.com/KonstantinMirin
feat(types): add the AdcpRequest/AdcpResponse lattice and normalize t…https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/a942fd24c2272dc554170e8f002790f8845fc1d9
a942fd2https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/a942fd24c2272dc554170e8f002790f8845fc1d9
https://github.com/KonstantinMirin
test(types): record the forged-model refusal and the two predicates' …https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/4a5f77222525b0e5f5bfcd22b596f22c6a15ed0e
4a5f772https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/4a5f77222525b0e5f5bfcd22b596f22c6a15ed0e
https://github.com/KonstantinMirin
refactor(types): give the task-message resolution one home, runnable …https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/82bfda665481decdaeceb422ec46a02541f829ba
82bfda6https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/82bfda665481decdaeceb422ec46a02541f829ba
https://github.com/KonstantinMirin
fix(types): refuse to normalize a schema whose union arm is a bare $refhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/2183e588b8dfa015b61fc86c71d871e350ddb476
2183e58https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/2183e588b8dfa015b61fc86c71d871e350ddb476
https://github.com/KonstantinMirin
refactor(types)!: make every canonical model a subclass, not a runtim…https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/5db51c4a74f8b44a4e293cdc19e86518b8521f1f
5db51c4https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/5db51c4a74f8b44a4e293cdc19e86518b8521f1f
adcontextprotocol#1368https://github.com/adcontextprotocol/adcp-client-python/pull/1368
https://github.com/KonstantinMirin
feat(types): add AdcpVersionEnvelope to the curated protocol surfacehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/e77e348b99abbe10857fb96bfac2830405f15097
e77e348https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/e77e348b99abbe10857fb96bfac2830405f15097
https://github.com/KonstantinMirin
feat(codegen): derive a union arm's name from its schema nodehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/fcbf4229fc4b8323bde3b5e44b8684a578beb6dc
fcbf422https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/fcbf4229fc4b8323bde3b5e44b8684a578beb6dc
https://github.com/KonstantinMirin
test(codegen): pin the two response arms the naming rule cannot name …https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/5d705ca8d62e92ccca0ca2ff6e1f90e512a932f8
5d705cahttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/5d705ca8d62e92ccca0ca2ff6e1f90e512a932f8
https://github.com/KonstantinMirin
fix(types): an inherited validator that reads a removed field reads Nonehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/e3b07c886dcb81595ee6ccdcc74a693a08a3c3a0
e3b07c8https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/e3b07c886dcb81595ee6ccdcc74a693a08a3c3a0
https://github.com/KonstantinMirin
fix(codegen): read a composing root's alias the way Annotated is definedhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/f8706bc35363af0c093135d276b8a2575ba11e3b
f8706bchttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/f8706bc35363af0c093135d276b8a2575ba11e3b
https://github.com/KonstantinMirin
fix(types): stop a tolerant delivery model passing as its strict wire…https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/37367fd2545f57a546800abb166a58be57238553
37367fdhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/37367fd2545f57a546800abb166a58be57238553
adcontextprotocol#1241https://github.com/adcontextprotocol/adcp-client-python/issues/1241
adcontextprotocol#1368https://github.com/adcontextprotocol/adcp-client-python/pull/1368
adcontextprotocol#1353https://github.com/adcontextprotocol/adcp-client-python/pull/1353
adcontextprotocol#1375https://github.com/adcontextprotocol/adcp-client-python/pull/1375
adcontextprotocol#1367https://github.com/adcontextprotocol/adcp-client-python/pull/1367
adcontextprotocol#1371https://github.com/adcontextprotocol/adcp-client-python/pull/1371
https://github.com/KonstantinMirin
test(types): grade validator inheritance instead of clone carryinghttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/24c4559bcaeff8f9d433469f4dd1476ac8b3c85a
24c4559https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/24c4559bcaeff8f9d433469f4dd1476ac8b3c85a
https://github.com/KonstantinMirin
fix(types): take the domain mirror in the SDK's own decisioning helperhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/254929100de13e5714ff4c65eda8fcc58d3d92e6
2549291https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/254929100de13e5714ff4c65eda8fcc58d3d92e6
https://github.com/KonstantinMirin
docs: document the type surface and the generation pipelinehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/731ffa744d38e9ce2ddd99437d46ff11f811b5a1
731ffa7https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/731ffa744d38e9ce2ddd99437d46ff11f811b5a1
https://github.com/KonstantinMirin
refactor(codegen)!: generate the domain tree as the public treehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/83d4c238043c5336c7cee673bea333f7137d3074
83d4c23https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/83d4c238043c5336c7cee673bea333f7137d3074
adcontextprotocol#1360https://github.com/adcontextprotocol/adcp-client-python/issues/1360
adcontextprotocol#1374https://github.com/adcontextprotocol/adcp-client-python/pull/1374
adcontextprotocol#1374https://github.com/adcontextprotocol/adcp-client-python/pull/1374
https://github.com/KonstantinMirin
docs: the generated tree is the public tree, not an internal layerhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/724751c5b8d9ba4e551e51d7686e31d0ce9424a4
724751chttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/724751c5b8d9ba4e551e51d7686e31d0ce9424a4
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 5, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#event-32477658076
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5407291151
724751chttps://github.com/adcontextprotocol/adcp-client-python/commit/724751c5b8d9ba4e551e51d7686e31d0ce9424a4
October 5, 2026 04:45https://github.com/adcontextprotocol/adcp-client-python/pull/1392#event-32477671110
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
force-pushedhttps://github.com/adcontextprotocol/adcp-client-python/compare/19809d2a1257744ac62c1bd25ca092901f488890..724751c5b8d9ba4e551e51d7686e31d0ce9424a4
19809d2https://github.com/adcontextprotocol/adcp-client-python/commit/19809d2a1257744ac62c1bd25ca092901f488890
724751chttps://github.com/adcontextprotocol/adcp-client-python/commit/724751c5b8d9ba4e551e51d7686e31d0ce9424a4
Compare https://github.com/adcontextprotocol/adcp-client-python/compare/19809d2a1257744ac62c1bd25ca092901f488890..724751c5b8d9ba4e551e51d7686e31d0ce9424a4
October 5, 2026 04:45https://github.com/adcontextprotocol/adcp-client-python/pull/1392#event-32477671327
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
bokelleyhttps://github.com/bokelley
code ownerhttps://github.com/adcontextprotocol/adcp-client-python/blob/197bcde31f3d3a2ddb454f8be77dd35ebda3f6ed/.github/CODEOWNERS#L3
October 5, 2026 04:45https://github.com/adcontextprotocol/adcp-client-python/pull/1392#event-32477671402
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 5, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5410099586
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1392/files/724751c5b8d9ba4e551e51d7686e31d0ce9424a4
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5410099586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 5, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5410099924
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1392/files/724751c5b8d9ba4e551e51d7686e31d0ce9424a4
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5410099924
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 5, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#issuecomment-5988320896
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/bokelley
https://github.com/apps/conductor-build-app
bokelleyhttps://github.com/bokelley
Oct 5, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#issuecomment-5992372822
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
#1366https://github.com/adcontextprotocol/adcp-client-python/issues/1366
#1313https://github.com/adcontextprotocol/adcp-client-python/issues/1313
types: the export surface of adcp.types is enumerated by hand, so 773 generated classes are reachable under no public name #1360https://github.com/adcontextprotocol/adcp-client-python/issues/1360
types: canonical_creative.pyi hides four required fields of CreateMediaBuyRequest and invents one, so mypy accepts a construction pydantic rejects #1366https://github.com/adcontextprotocol/adcp-client-python/issues/1366
@bokelleyhttps://github.com/bokelley
@KonstantinMirinhttps://github.com/KonstantinMirin
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 5, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-issue-5711179049
A tolerant canonical model subtypes a strict wire model while lacking one of its fields #1397 https://github.com/adcontextprotocol/adcp-client-python/issues/1397
https://github.com/KonstantinMirin
test(types): grade the canonical field removal, and hide it from the …https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/866d59cab531ad0d8eb14e0b85a0c4965ec58859
866d59chttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/866d59cab531ad0d8eb14e0b85a0c4965ec58859
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 5, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#issuecomment-5994764227
#1397https://github.com/adcontextprotocol/adcp-client-python/issues/1397
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/KonstantinMirin
feat(types)!: serve the pre-9.0 generated_poc path from the module it…https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/48c2368b293ac9bb8d059436a96e3fee4b2ea76b
48c2368https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/48c2368b293ac9bb8d059436a96e3fee4b2ea76b
adcontextprotocol#1360https://github.com/adcontextprotocol/adcp-client-python/issues/1360
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 6, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#issuecomment-6008680372
@bokelleyhttps://github.com/bokelley
Claude Codehttps://claude.ai/code
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 6, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#issuecomment-6008832841
#1402https://github.com/adcontextprotocol/adcp-client-python/issues/1402
#1402https://github.com/adcontextprotocol/adcp-client-python/issues/1402
Claude Codehttps://claude.ai/code
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-pullrequest-5722934193
feat(signing): publish the recovery classification the signing schema mandates #1403 https://github.com/adcontextprotocol/adcp-client-python/pull/1403
KonstantinMirinhttps://github.com/KonstantinMirin
October 6, 2026 00:57https://github.com/adcontextprotocol/adcp-client-python/pull/1392#commits-pushed-607adf4
https://github.com/KonstantinMirin
fix(types): serve a split generated_poc module from both of its halveshttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/607adf44176beaee02e4df3084976c31ddd7f097
607adf4https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/607adf44176beaee02e4df3084976c31ddd7f097
adcontextprotocol#1402https://github.com/adcontextprotocol/adcp-client-python/issues/1402
https://github.com/KonstantinMirin
fix(types): make every Legacy name the generated class, one per respo…https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/633559b0242ec3645c8d91a4e836759a69b75dec
633559bhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/633559b0242ec3645c8d91a4e836759a69b75dec
adcontextprotocol#1384https://github.com/adcontextprotocol/adcp-client-python/issues/1384
adcontextprotocol#1398https://github.com/adcontextprotocol/adcp-client-python/issues/1398
adcontextprotocol#1399https://github.com/adcontextprotocol/adcp-client-python/issues/1399
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5423969258
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1392/files/633559b0242ec3645c8d91a4e836759a69b75dec
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5423969258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/KonstantinMirin
docs: name the one generated_poc stem that split, where an adopter re…https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/152f15baf86f9a778630b2e0471336a35ac0a7d5
152f15bhttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/152f15baf86f9a778630b2e0471336a35ac0a7d5
adcontextprotocol#1402https://github.com/adcontextprotocol/adcp-client-python/issues/1402
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5423979710
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1392/files/152f15baf86f9a778630b2e0471336a35ac0a7d5
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5423979710
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/KonstantinMirin
fix(types): tell a split deprecated name's reader where its classes wenthttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/0107506eeb05752a1630421764ea7d01dff0da8f
0107506https://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/0107506eeb05752a1630421764ea7d01dff0da8f
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5424014353
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1392/files/0107506eeb05752a1630421764ea7d01dff0da8f
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5424014353
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-issue-5724823642
Name union arms from their schema node instead of their position #1409 https://github.com/adcontextprotocol/adcp-client-python/issues/1409
https://github.com/bokelley
https://github.com/claude
chore(codegen): move the unwired union-arm naming rule tohttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/2687a8ee07175125f60963d88e1ad581615706dc
adcontextpr…https://github.com/adcontextprotocol/adcp-client-python/issues/1409
2687a8ehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392/commits/2687a8ee07175125f60963d88e1ad581615706dc
…otocol#1409https://github.com/adcontextprotocol/adcp-client-python/issues/1409
adcontextprotocol#1409https://github.com/adcontextprotocol/adcp-client-python/issues/1409
adcontextprotocol#1409https://github.com/adcontextprotocol/adcp-client-python/issues/1409
https://github.com/bokelley
https://github.com/apps/conductor-build-app
bokelleyhttps://github.com/bokelley
Oct 6, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#issuecomment-6012377400
@KonstantinMirinhttps://github.com/KonstantinMirin
claude/issue-1409-union-arm-naminghttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-1409-union-arm-naming
Name union arms from their schema node instead of their position #1409https://github.com/adcontextprotocol/adcp-client-python/issues/1409
#1398https://github.com/adcontextprotocol/adcp-client-python/issues/1398
#1399https://github.com/adcontextprotocol/adcp-client-python/issues/1399
#1402https://github.com/adcontextprotocol/adcp-client-python/issues/1402
#1401https://github.com/adcontextprotocol/adcp-client-python/issues/1401
Claude Codehttps://claude.ai/code
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5425717323
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1392/files/2687a8ee07175125f60963d88e1ad581615706dc
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5425717323
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#pullrequestreview-5426393511
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1392/files/2687a8ee07175125f60963d88e1ad581615706dc
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
3092340https://github.com/adcontextprotocol/adcp-client-python/commit/3092340c1a99a40c0b65029d97c155bb553a2836
Oct 6, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#event-32585071312
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-pullrequest-5726145668
chore(main): release 9.0.0-beta.1 #1411 https://github.com/adcontextprotocol/adcp-client-python/pull/1411
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-pullrequest-5727050917
chore(release): start SDK 9 beta series #1412 https://github.com/adcontextprotocol/adcp-client-python/pull/1412
https://github.com/bokelley
https://github.com/apps/conductor-build-app
bokelleyhttps://github.com/bokelley
Oct 6, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#issuecomment-6015828306
#1398https://github.com/adcontextprotocol/adcp-client-python/issues/1398
#1399https://github.com/adcontextprotocol/adcp-client-python/issues/1399
#1402https://github.com/adcontextprotocol/adcp-client-python/issues/1402
ProductFormatDeclaration and Format are the same class, while the schema's 16-arm union is exported as LegacyProductFormatDeclaration #1401https://github.com/adcontextprotocol/adcp-client-python/issues/1401
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/bokelley
https://github.com/apps/conductor-build-app
bokelleyhttps://github.com/bokelley
Oct 6, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1392#issuecomment-6015837726
2687a8ehttps://github.com/adcontextprotocol/adcp-client-python/commit/2687a8ee07175125f60963d88e1ad581615706dc
#1409https://github.com/adcontextprotocol/adcp-client-python/issues/1409
2687a8ehttps://github.com/adcontextprotocol/adcp-client-python/commit/2687a8ee07175125f60963d88e1ad581615706dc
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-pullrequest-5728339121
docs: say who owns the format_kind check now that the SDK does not #1415 https://github.com/adcontextprotocol/adcp-client-python/pull/1415
Canonical response fields typed SchemaVariant lose element types (pyright errors, Any under the mypy plugin) #1416 https://github.com/adcontextprotocol/adcp-client-python/issues/1416
generated_poc deprecation points at a codemod that doesn't rewrite; types docstring still forbids adcp.types.domains #1417 https://github.com/adcontextprotocol/adcp-client-python/issues/1417
types: canonical_creative.pyi hides four required fields of CreateMediaBuyRequest and invents one, so mypy accepts a construction pydantic rejects #1366 https://github.com/adcontextprotocol/adcp-client-python/issues/1366
fix(types): declare the canonical list overrides precisely for every checker #1419 https://github.com/adcontextprotocol/adcp-client-python/pull/1419
fix(migrate): rewrite generated_poc imports to adcp.types.domains, split-aware #1420 https://github.com/adcontextprotocol/adcp-client-python/pull/1420
bokelleyhttps://github.com/bokelley
Oct 6, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-commit-43910ce
https://github.com/bokelley
https://github.com/claude
fix(types): declare the canonical list overrides precisely for every …https://github.com/adcontextprotocol/adcp-client-python/commit/43910ce9fe22ca87e6b2e79dc549f4bf31198a19
43910cehttps://github.com/adcontextprotocol/adcp-client-python/commit/43910ce9fe22ca87e6b2e79dc549f4bf31198a19
#1419https://github.com/adcontextprotocol/adcp-client-python/pull/1419
#1392https://github.com/adcontextprotocol/adcp-client-python/pull/1392
#1416https://github.com/adcontextprotocol/adcp-client-python/issues/1416
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 9, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-commit-30bd542
https://github.com/KonstantinMirin
docs: say who owns the format_kind check now that the SDK does nothttps://github.com/KonstantinMirin/adcp-client-python/commit/30bd54266d3968057da08d3bf61600035f9d7fd5
30bd542https://github.com/KonstantinMirin/adcp-client-python/commit/30bd54266d3968057da08d3bf61600035f9d7fd5
adcontextprotocol#1392https://github.com/adcontextprotocol/adcp-client-python/pull/1392
bokelleyhttps://github.com/bokelley
Oct 10, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-commit-e565601
https://github.com/KonstantinMirin
docs: say who owns the format_kind check now that the SDK does not (https://github.com/adcontextprotocol/adcp-client-python/commit/e565601297890ecebf601d2a38117ddd6ef8c9ba
#…https://github.com/adcontextprotocol/adcp-client-python/pull/1415
e565601https://github.com/adcontextprotocol/adcp-client-python/commit/e565601297890ecebf601d2a38117ddd6ef8c9ba
…1415https://github.com/adcontextprotocol/adcp-client-python/pull/1415
#1392https://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
Oct 20, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1392#ref-issue-5948369195
Generated optional properties render as T | None, accepting an explicit JSON null the schema forbids #1547 https://github.com/adcontextprotocol/adcp-client-python/issues/1547
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1392
https://github.com/apps/aao-secretariat
aao-secretariat[bot] https://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1392/files/2687a8ee07175125f60963d88e1ad581615706dc
https://github.com/bokelley
bokelley https://github.com/bokelley
https://github.com/adcontextprotocol/adcp-client-python/pull/1392/files/2687a8ee07175125f60963d88e1ad581615706dc
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1392
https://github.com/KonstantinMirin
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.