René's URL Explorer Experiment


Title: feat(signing): verify request signatures in the framework before dispatch by bokelley · Pull Request #1266 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: feat(signing): verify request signatures in the framework before dispatch by bokelley · Pull Request #1266 · adcontextprotocol/adcp-client-python

X Title: feat(signing): verify request signatures in the framework before dispatch by bokelley · Pull Request #1266 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Summary Closes #1260. A seller that declares request_signing can now have the framework verify signatures before dispatch, instead of hand-wiring verification, the keyid → agent mapping, and identi...

X Description: Summary Closes #1260. A seller that declares request_signing can now have the framework verify signatures before dispatch, instead of hand-wiring verification, the keyid → agent mapping, and identi...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/1266

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c9f0e59f-a3ae-c99f-a581-d9e9bbe4f543
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA46A:1D86C4:1003F32:1463AE7:6B0111C4
html-safe-nonced9918feb8a604a5bf76626bf2ea2bc889a7bbed7c099dd388a0cf530a5044ef0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDZBOjFEODZDNDoxMDAzRjMyOjE0NjNBRTc6NkIwMTExQzQiLCJ2aXNpdG9yX2lkIjoiMjc4NTkxODg2NDYyNDUyMTY2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2a0d3cf8dab97882ea8c004600521b6baef0b151afcc0775600345b26f65f993
hovercard-subject-tagpull_request:4695263718
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1266/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/245253eeccb75f4fc128043d86da6d8b52fd0caff03a897ecbf36f1731bc9179/adcontextprotocol/adcp-client-python/pull/1266
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/245253eeccb75f4fc128043d86da6d8b52fd0caff03a897ecbf36f1731bc9179/adcontextprotocol/adcp-client-python/pull/1266
og:image:altSummary Closes #1260. A seller that declares request_signing can now have the framework verify signatures before dispatch, instead of hand-wiring verification, the keyid → agent mapping, and identi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/1266#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1266
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1266
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-1260-framework-signature-verificationhttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-1260-framework-signature-verification
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
Commits2 (2)https://github.com/adcontextprotocol/adcp-client-python/pull/1266/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/1266/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/1266/files
feat(signing): verify request signatures in the framework before dispatchhttps://github.com/adcontextprotocol/adcp-client-python/pull/1266#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
claude/issue-1260-framework-signature-verificationhttps://github.com/adcontextprotocol/adcp-client-python/tree/claude/issue-1260-framework-signature-verification
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Sep 30, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1266#issue-5652133717
#1260https://github.com/adcontextprotocol/adcp-client-python/issues/1260
Sellers can't identify an unknown signing agent; clarify buyer-agent identity and the operator for buyer-declared accounts adcp#7814https://github.com/adcontextprotocol/adcp/issues/7814
Claude Codehttps://claude.com/claude-code
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
https://github.com/bokelley
https://github.com/claude
feat(signing): verify request signatures in the framework before disp…https://github.com/adcontextprotocol/adcp-client-python/pull/1266/commits/1727638ffafbbd37340c8945228fada50165a387
1727638https://github.com/adcontextprotocol/adcp-client-python/pull/1266/commits/1727638ffafbbd37340c8945228fada50165a387
#1260https://github.com/adcontextprotocol/adcp-client-python/issues/1260
https://github.com/apps/github-code-quality
github-code-qualityhttps://github.com/apps/github-code-quality
Sep 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1266#pullrequestreview-5371259479
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1266/files/1727638ffafbbd37340c8945228fada50165a387
tests/test_signed_request_verification.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1266/files/1727638ffafbbd37340c8945228fada50165a387#diff-77525277efe9b57b70a7e8e2a700192f734eabef9b8ea929fb97afdde91031d4
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
src/adcp/signing/signer_keys.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1266/files/1727638ffafbbd37340c8945228fada50165a387#diff-ad266f7c6e76017eadf157efee1846204be8b3d3ee5c37fc16568e3d155d22b0
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1266#pullrequestreview-5371277872
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1266/files/1727638ffafbbd37340c8945228fada50165a387
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1266#pullrequestreview-5371277872
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
https://github.com/bokelley
https://github.com/claude
test(signing): replace self-comparison with per-config replay store c…https://github.com/adcontextprotocol/adcp-client-python/pull/1266/commits/77121334edde0e11cdac8b941a20fd9acade81a8
7712133https://github.com/adcontextprotocol/adcp-client-python/pull/1266/commits/77121334edde0e11cdac8b941a20fd9acade81a8
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1266#pullrequestreview-5371277872
7712133https://github.com/adcontextprotocol/adcp-client-python/commit/77121334edde0e11cdac8b941a20fd9acade81a8
September 30, 2026 20:45https://github.com/adcontextprotocol/adcp-client-python/pull/1266#event-32199932856
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1266#pullrequestreview-5371817009
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1266/files/77121334edde0e11cdac8b941a20fd9acade81a8
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1266#pullrequestreview-5371817009
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1266https://github.com/adcontextprotocol/adcp-client-python/pull/1266
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Sep 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1266#ref-pullrequest-5652935212
feat(signing): allow bearer fallback for required signatures #1269 https://github.com/adcontextprotocol/adcp-client-python/pull/1269
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
September 30, 2026 21:30https://github.com/adcontextprotocol/adcp-client-python/pull/1266#event-32202622498
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
2b29ee1https://github.com/adcontextprotocol/adcp-client-python/commit/2b29ee1ca06a315bee79db83c01282d9755c0c89
Sep 30, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1266#event-32203809381
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
September 30, 2026 21:51https://github.com/adcontextprotocol/adcp-client-python/pull/1266#event-32203812061
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Sep 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1266#ref-pullrequest-5650381127
chore(main): release 8.0.0 #1262 https://github.com/adcontextprotocol/adcp-client-python/pull/1262
docs(signing): verify against a counterparty's several agents #1871 https://github.com/adcontextprotocol/adcp-client-python/pull/1871
Inbound verification accepts one expected agent_url, but brand.json declares agents[] as a list #1214 https://github.com/adcontextprotocol/adcp-client-python/issues/1214
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1266
https://github.com/apps/aao-secretariat
aao-secretariat[bot] https://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1266/files/77121334edde0e11cdac8b941a20fd9acade81a8
https://github.com/apps/github-code-quality
github-code-quality[bot] https://github.com/apps/github-code-quality
https://github.com/adcontextprotocol/adcp-client-python/pull/1266/files/1727638ffafbbd37340c8945228fada50165a387
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
Verify request signatures in the framework and populate caller identity from the verified signer https://github.com/adcontextprotocol/adcp-client-python/issues/1260
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1266
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.