René's URL Explorer Experiment


Title: fix(signing): reject non-strict-JSON signed bodies at checklist step 14 by bokelley · Pull Request #1265 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(signing): reject non-strict-JSON signed bodies at checklist step 14 by bokelley · Pull Request #1265 · adcontextprotocol/adcp-client-python

X Title: fix(signing): reject non-strict-JSON signed bodies at checklist step 14 by bokelley · Pull Request #1265 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: Fixes #1264 Problem verify_request_signature stopped after the step-13 nonce insert and never ran AdCP checklist step 14 (body well-formedness). json.loads keeps the last duplicate key, so a body s...

X Description: Fixes #1264 Problem verify_request_signature stopped after the step-13 nonce insert and never ran AdCP checklist step 14 (body well-formedness). json.loads keeps the last duplicate key, so a body s...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/1265

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4ccac4f9-6519-289e-6b25-7f9906421680
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC6E:19E4BB:C65676:FE58C0:6B00FFE3
html-safe-nonce19ec1f2c4d2e497cd2568fa50bd6d689a18ba822c7cd5c108c4956cf080c776c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzZFOjE5RTRCQjpDNjU2NzY6RkU1OEMwOjZCMDBGRkUzIiwidmlzaXRvcl9pZCI6IjI3NjgwNjYwMzQxOTQ3NzYwMzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5361f227c96a3f2ae83ee67b7d887cd7398593c7b98d7abe63d2a87d6115cede
hovercard-subject-tagpull_request:4694817884
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1265/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d6747a711ae5d35805e4c8894000739340f899a7e8653d41f70db8b123031a66/adcontextprotocol/adcp-client-python/pull/1265
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d6747a711ae5d35805e4c8894000739340f899a7e8653d41f70db8b123031a66/adcontextprotocol/adcp-client-python/pull/1265
og:image:altFixes #1264 Problem verify_request_signature stopped after the step-13 nonce insert and never ran AdCP checklist step 14 (body well-formedness). json.loads keeps the last duplicate key, so a body s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/1265#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1265
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1265
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
fix/1264-request-body-strict-jsonhttps://github.com/adcontextprotocol/adcp-client-python/tree/fix/1264-request-body-strict-json
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
Commits3 (3)https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/1265/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/1265/files
fix(signing): reject non-strict-JSON signed bodies at checklist step 14https://github.com/adcontextprotocol/adcp-client-python/pull/1265#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
fix/1264-request-body-strict-jsonhttps://github.com/adcontextprotocol/adcp-client-python/tree/fix/1264-request-body-strict-json
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Sep 30, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1265#issue-5651604394
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
#1264https://github.com/adcontextprotocol/adcp-client-python/issues/1264
Claude Codehttps://claude.com/claude-code
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
https://github.com/bokelley
https://github.com/claude
fix(signing): reject non-strict-JSON signed bodies at checklist step 14https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/c25318013644303db04354e8ad18e5bc653c5600
c253180https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/c25318013644303db04354e8ad18e5bc653c5600
#1264https://github.com/adcontextprotocol/adcp-client-python/issues/1264
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370796679
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1265/files/c25318013644303db04354e8ad18e5bc653c5600
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370796679
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
https://github.com/bokelley
https://github.com/claude
fix(signing): harden step-14 body parse per security reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/3d32d81dc1456a2dc017885fea3a25b434f35598
3d32d81https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/3d32d81dc1456a2dc017885fea3a25b434f35598
#1264https://github.com/adcontextprotocol/adcp-client-python/issues/1264
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370796679
3d32d81https://github.com/adcontextprotocol/adcp-client-python/commit/3d32d81dc1456a2dc017885fea3a25b434f35598
September 30, 2026 19:13https://github.com/adcontextprotocol/adcp-client-python/pull/1265#event-32193850822
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370877202
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1265/files/3d32d81dc1456a2dc017885fea3a25b434f35598
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370877202
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
https://github.com/bokelley
https://github.com/claude
fix(signing): keep lone surrogates out of strict-JSON source literalshttps://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/99d2c3c3aa4975e76d02bf1819a79760322c7388
99d2c3chttps://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/99d2c3c3aa4975e76d02bf1819a79760322c7388
#1264https://github.com/adcontextprotocol/adcp-client-python/issues/1264
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370877202
99d2c3chttps://github.com/adcontextprotocol/adcp-client-python/commit/99d2c3c3aa4975e76d02bf1819a79760322c7388
September 30, 2026 19:19https://github.com/adcontextprotocol/adcp-client-python/pull/1265#event-32194277770
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370926101
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1265/files/99d2c3c3aa4975e76d02bf1819a79760322c7388
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370926101
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
https://github.com/bokelley
https://github.com/apps/conductor-build-app
bokelleyhttps://github.com/bokelley
Sep 30, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1265#issuecomment-5918669826
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
72ec2bfhttps://github.com/adcontextprotocol/adcp-client-python/commit/72ec2bf0b3c597dc7842cec8f69252509ad41b02
Sep 30, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1265#event-32197035358
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
September 30, 2026 20:00https://github.com/adcontextprotocol/adcp-client-python/pull/1265#event-32197038330
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Sep 30, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1265#ref-pullrequest-5650381127
chore(main): release 8.0.0 #1262 https://github.com/adcontextprotocol/adcp-client-python/pull/1262
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1265
https://github.com/apps/aao-secretariat
aao-secretariat[bot] https://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1265/files/99d2c3c3aa4975e76d02bf1819a79760322c7388
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
Request-signing verifier skips checklist step 14: duplicate JSON keys are not rejected (request_body_malformed) https://github.com/adcontextprotocol/adcp-client-python/issues/1264
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1265
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.