| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4ccac4f9-6519-289e-6b25-7f9906421680 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC6E:19E4BB:C65676:FE58C0:6B00FFE3 |
| html-safe-nonce | 19ec1f2c4d2e497cd2568fa50bd6d689a18ba822c7cd5c108c4956cf080c776c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzZFOjE5RTRCQjpDNjU2NzY6RkU1OEMwOjZCMDBGRkUzIiwidmlzaXRvcl9pZCI6IjI3NjgwNjYwMzQxOTQ3NzYwMzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5361f227c96a3f2ae83ee67b7d887cd7398593c7b98d7abe63d2a87d6115cede |
| hovercard-subject-tag | pull_request:4694817884 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1265/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d6747a711ae5d35805e4c8894000739340f899a7e8653d41f70db8b123031a66/adcontextprotocol/adcp-client-python/pull/1265 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d6747a711ae5d35805e4c8894000739340f899a7e8653d41f70db8b123031a66/adcontextprotocol/adcp-client-python/pull/1265 |
| og:image:alt | Fixes #1264
Problem
verify_request_signature stopped after the step-13 nonce insert and never ran AdCP checklist step 14 (body well-formedness). json.loads keeps the last duplicate key, so a body s... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/adcontextprotocol/adcp-client-python/pull/1265#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1265 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1265 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
| Reload | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
| adcontextprotocol | https://github.com/adcontextprotocol |
| adcp-client-python | https://github.com/adcontextprotocol/adcp-client-python |
| Code | https://github.com/adcontextprotocol/adcp-client-python |
| Issues44 (44) | https://github.com/adcontextprotocol/adcp-client-python/issues |
| Pull requests13 (13) | https://github.com/adcontextprotocol/adcp-client-python/pulls |
| Actions | https://github.com/adcontextprotocol/adcp-client-python/actions |
| Projects | https://github.com/adcontextprotocol/adcp-client-python/projects |
| Security and quality | https://github.com/adcontextprotocol/adcp-client-python/security |
| Insights | https://github.com/adcontextprotocol/adcp-client-python/insights |
| https://github.com/adcontextprotocol/adcp-client-python |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| fix/1264-request-body-strict-json | https://github.com/adcontextprotocol/adcp-client-python/tree/fix/1264-request-body-strict-json |
| Conversation | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
| Commits3 (3) | https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits |
| Checks | https://github.com/adcontextprotocol/adcp-client-python/pull/1265/checks |
| Files changed | https://github.com/adcontextprotocol/adcp-client-python/pull/1265/files |
| fix(signing): reject non-strict-JSON signed bodies at checklist step 14 | https://github.com/adcontextprotocol/adcp-client-python/pull/1265#top |
| bokelley | https://github.com/bokelley |
| main | https://github.com/adcontextprotocol/adcp-client-python/tree/main |
| fix/1264-request-body-strict-json | https://github.com/adcontextprotocol/adcp-client-python/tree/fix/1264-request-body-strict-json |
|
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| Sep 30, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/1265#issue-5651604394 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
| #1264 | https://github.com/adcontextprotocol/adcp-client-python/issues/1264 |
| Claude Code | https://claude.com/claude-code |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| fix(signing): reject non-strict-JSON signed bodies at checklist step 14 | https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/c25318013644303db04354e8ad18e5bc653c5600 |
| c253180 | https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/c25318013644303db04354e8ad18e5bc653c5600 |
| #1264 | https://github.com/adcontextprotocol/adcp-client-python/issues/1264 |
| https://github.com/apps/aao-secretariat |
| aao-secretariat | https://github.com/apps/aao-secretariat |
|
Sep 30, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370796679 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265/files/c25318013644303db04354e8ad18e5bc653c5600 |
| aao-secretariat | https://github.com/apps/aao-secretariat |
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370796679 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| fix(signing): harden step-14 body parse per security review | https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/3d32d81dc1456a2dc017885fea3a25b434f35598 |
| 3d32d81 | https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/3d32d81dc1456a2dc017885fea3a25b434f35598 |
| #1264 | https://github.com/adcontextprotocol/adcp-client-python/issues/1264 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| aao-secretariat[bot] | https://github.com/apps/aao-secretariat |
| stale review | https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370796679 |
| 3d32d81 | https://github.com/adcontextprotocol/adcp-client-python/commit/3d32d81dc1456a2dc017885fea3a25b434f35598 |
| September 30, 2026 19:13 | https://github.com/adcontextprotocol/adcp-client-python/pull/1265#event-32193850822 |
| https://github.com/apps/aao-secretariat |
| aao-secretariat | https://github.com/apps/aao-secretariat |
|
Sep 30, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370877202 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265/files/3d32d81dc1456a2dc017885fea3a25b434f35598 |
| aao-secretariat | https://github.com/apps/aao-secretariat |
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370877202 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
|
| https://github.com/bokelley |
|
| https://github.com/claude |
| fix(signing): keep lone surrogates out of strict-JSON source literals | https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/99d2c3c3aa4975e76d02bf1819a79760322c7388 |
| 99d2c3c | https://github.com/adcontextprotocol/adcp-client-python/pull/1265/commits/99d2c3c3aa4975e76d02bf1819a79760322c7388 |
| #1264 | https://github.com/adcontextprotocol/adcp-client-python/issues/1264 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| aao-secretariat[bot] | https://github.com/apps/aao-secretariat |
| stale review | https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370877202 |
| 99d2c3c | https://github.com/adcontextprotocol/adcp-client-python/commit/99d2c3c3aa4975e76d02bf1819a79760322c7388 |
| September 30, 2026 19:19 | https://github.com/adcontextprotocol/adcp-client-python/pull/1265#event-32194277770 |
| https://github.com/apps/aao-secretariat |
| aao-secretariat | https://github.com/apps/aao-secretariat |
|
Sep 30, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370926101 |
|
View reviewed changes
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265/files/99d2c3c3aa4975e76d02bf1819a79760322c7388 |
| aao-secretariat | https://github.com/apps/aao-secretariat |
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265#pullrequestreview-5370926101 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
| https://github.com/bokelley |
|
| https://github.com/apps/conductor-build-app |
| bokelley | https://github.com/bokelley |
| Sep 30, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/1265#issuecomment-5918669826 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| 72ec2bf | https://github.com/adcontextprotocol/adcp-client-python/commit/72ec2bf0b3c597dc7842cec8f69252509ad41b02 |
| Sep 30, 2026 | https://github.com/adcontextprotocol/adcp-client-python/pull/1265#event-32197035358 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
| https://github.com/bokelley |
| bokelley | https://github.com/bokelley |
| September 30, 2026 20:00 | https://github.com/adcontextprotocol/adcp-client-python/pull/1265#event-32197038330 |
| https://github.com/apps/aao-ipr-bot |
| aao-ipr-bot | https://github.com/apps/aao-ipr-bot |
|
Sep 30, 2026
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265#ref-pullrequest-5650381127 |
|
chore(main): release 8.0.0
#1262
| https://github.com/adcontextprotocol/adcp-client-python/pull/1262 |
| https://github.co/hiddenchars |
| https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1265 |
|
| https://github.com/apps/aao-secretariat |
|
aao-secretariat[bot]
| https://github.com/apps/aao-secretariat |
|
| https://github.com/adcontextprotocol/adcp-client-python/pull/1265/files/99d2c3c3aa4975e76d02bf1819a79760322c7388 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
|
Request-signing verifier skips checklist step 14: duplicate JSON keys are not rejected (request_body_malformed)
| https://github.com/adcontextprotocol/adcp-client-python/issues/1264 |
| Please reload this page | https://github.com/adcontextprotocol/adcp-client-python/pull/1265 |
|
| https://github.com/bokelley |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |