René's URL Explorer Experiment


Title: fix(reporting)!: allow conditional metrics under full coverage by bokelley · Pull Request #1247 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(reporting)!: allow conditional metrics under full coverage by bokelley · Pull Request #1247 · adcontextprotocol/adcp-client-python

X Title: fix(reporting)!: allow conditional metrics under full coverage by bokelley · Pull Request #1247 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: A full-coverage report currently fails when a display buy has no applicable completed_views metric, and source conformance rejects offering metrics declared partial. Admit both exact and partial me...

X Description: A full-coverage report currently fails when a display buy has no applicable completed_views metric, and source conformance rejects offering metrics declared partial. Admit both exact and partial me...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/1247

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3792a9e0-5706-97ad-7653-2dc2744f5df3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8AD8:363D8E:13C5CFE:19380D8:6B011171
html-safe-nonce2ffd59a36f3df54a00e94d86cfd17d56a55611201212a228535a3d72dc99a72a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUQ4OjM2M0Q4RToxM0M1Q0ZFOjE5MzgwRDg6NkIwMTExNzEiLCJ2aXNpdG9yX2lkIjoiNzc5NDU4ODEzNDY5NTU3MTgyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace0fd1f56813ad34ea67dad709f49183aa2e71178b4d6b95e674a251cbf8bd78e
hovercard-subject-tagpull_request:4678819210
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1247/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ddb068660690b23d57f12f2414fa1a6c1c9ac612b03ea820c1f730385799545d/adcontextprotocol/adcp-client-python/pull/1247
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ddb068660690b23d57f12f2414fa1a6c1c9ac612b03ea820c1f730385799545d/adcontextprotocol/adcp-client-python/pull/1247
og:image:altA full-coverage report currently fails when a display buy has no applicable completed_views metric, and source conformance rejects offering metrics declared partial. Admit both exact and partial me...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/1247#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1247
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1247
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
fix/reporting-conditional-metrics-1239https://github.com/adcontextprotocol/adcp-client-python/tree/fix/reporting-conditional-metrics-1239
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
Commits3 (3)https://github.com/adcontextprotocol/adcp-client-python/pull/1247/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/1247/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/1247/files
fix(reporting)!: allow conditional metrics under full coveragehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
fix/reporting-conditional-metrics-1239https://github.com/adcontextprotocol/adcp-client-python/tree/fix/reporting-conditional-metrics-1239
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Sep 29, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1247#issue-5632532329
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
the source adapter guidehttps://github.com/adcontextprotocol/adcp-client-python/pull/docs/reporting-source-adapters.md
#1239https://github.com/adcontextprotocol/adcp-client-python/issues/1239
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
fix(reporting): allow conditional metrics under full coveragehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247/commits/e5ab6816a0c0fe59d742d48b94fd9638ec75d9b6
e5ab681https://github.com/adcontextprotocol/adcp-client-python/pull/1247/commits/e5ab6816a0c0fe59d742d48b94fd9638ec75d9b6
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Sep 29, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1247#pullrequestreview-5354657048
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1247/files/e5ab6816a0c0fe59d742d48b94fd9638ec75d9b6
bokelleyhttps://github.com/bokelley
https://github.com/adcontextprotocol/adcp-client-python/pull/1247#pullrequestreview-5354657048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
fix(reporting): bind conditional evidence to declared supporthttps://github.com/adcontextprotocol/adcp-client-python/pull/1247/commits/76cfc1f0f3d49bf9e73142f1a593eb9e0528e156
76cfc1fhttps://github.com/adcontextprotocol/adcp-client-python/pull/1247/commits/76cfc1f0f3d49bf9e73142f1a593eb9e0528e156
https://github.com/bokelley
https://github.com/apps/conductor-build-app
bokelleyhttps://github.com/bokelley
Sep 29, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1247#issuecomment-5893542949
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
fix(reporting): enforce full coverage on custom executorshttps://github.com/adcontextprotocol/adcp-client-python/pull/1247/commits/07a53d1fb266ef77f47ad33ca60dd5d0c00d70e5
07a53d1https://github.com/adcontextprotocol/adcp-client-python/pull/1247/commits/07a53d1fb266ef77f47ad33ca60dd5d0c00d70e5
https://github.com/bokelley
https://github.com/apps/conductor-build-app
bokelleyhttps://github.com/bokelley
Sep 29, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1247#issuecomment-5893636454
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Sep 29, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1247#pullrequestreview-5355068139
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1247/files/07a53d1fb266ef77f47ad33ca60dd5d0c00d70e5
bokelleyhttps://github.com/bokelley
https://github.com/adcontextprotocol/adcp-client-python/pull/1247#pullrequestreview-5355068139
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
https://github.com/apps/conductor-build-app
bokelleyhttps://github.com/bokelley
Sep 29, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1247#issuecomment-5894345906
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
September 29, 2026 17:03https://github.com/adcontextprotocol/adcp-client-python/pull/1247#event-32098722576
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 29, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1247#pullrequestreview-5355953189
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1247/files/07a53d1fb266ef77f47ad33ca60dd5d0c00d70e5
src/adcp/reporting/source.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1247/files/07a53d1fb266ef77f47ad33ca60dd5d0c00d70e5#diff-93c29d5f187432faf7febc6f6531c5e60cd78d9a0df84490896817531f55cc5c
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 29, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1247#pullrequestreview-5355963573
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1247/files/07a53d1fb266ef77f47ad33ca60dd5d0c00d70e5
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1247#pullrequestreview-5355963573
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Sep 29, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1247#event-32099580521
https://github.com/bokelley
https://github.com/apps/conductor-build-app
bokelleyhttps://github.com/bokelley
Sep 29, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1247#issuecomment-5895097423
#1247https://github.com/adcontextprotocol/adcp-client-python/pull/1247
#1241https://github.com/adcontextprotocol/adcp-client-python/issues/1241
#1248https://github.com/adcontextprotocol/adcp-client-python/pull/1248
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
September 29, 2026 17:17https://github.com/adcontextprotocol/adcp-client-python/pull/1247#event-32099643513
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
September 29, 2026 17:17https://github.com/adcontextprotocol/adcp-client-python/pull/1247#event-32099647218
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 29, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1247#pullrequestreview-5356070809
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1247/files/07a53d1fb266ef77f47ad33ca60dd5d0c00d70e5
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1247#pullrequestreview-5356070809
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
07a53d1https://github.com/adcontextprotocol/adcp-client-python/commit/07a53d1fb266ef77f47ad33ca60dd5d0c00d70e5
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
3d7f2f5https://github.com/adcontextprotocol/adcp-client-python/commit/3d7f2f50f7dd4f27fd3f65bff16cafffc4509b84
Sep 30, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1247#event-32134141034
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
September 30, 2026 04:14https://github.com/adcontextprotocol/adcp-client-python/pull/1247#event-32134142623
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1247
https://github.com/apps/aao-secretariat
aao-secretariat[bot] https://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1247/files/07a53d1fb266ef77f47ad33ca60dd5d0c00d70e5
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
bug(reporting): a Core seller cannot carry conditional metrics under full coverage https://github.com/adcontextprotocol/adcp-client-python/issues/1239
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1247
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.