René's URL Explorer Experiment


Title: fix(server): settle lifespan cleanup after startup failures by bokelley · Pull Request #1223 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: fix(server): settle lifespan cleanup after startup failures by bokelley · Pull Request #1223 · adcontextprotocol/adcp-client-python

X Title: fix(server): settle lifespan cleanup after startup failures by bokelley · Pull Request #1223 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: A later on_startup failure previously skipped adopter cleanup hooks. A cancelled shutdown callback could also skip later cleanup, and secondary-error logging formatted adopter exception bodies and ...

X Description: A later on_startup failure previously skipped adopter cleanup hooks. A cancelled shutdown callback could also skip later cleanup, and secondary-error logging formatted adopter exception bodies and ...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/pull/1223

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6812c2d0-46ec-0d58-e266-ba3e7cc83554
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD31E:2D40DE:B62775:E6EACA:6B0132C1
html-safe-nonce20004cdf2f19f28bcb8bcb4ceb512da87593f478fc6516f6e6e52ef95b9d1bec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzFFOjJENDBERTpCNjI3NzU6RTZFQUNBOjZCMDEzMkMxIiwidmlzaXRvcl9pZCI6IjY1MjU2OTI1MzE1OTI3Mzc0NzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2e1c636f3baaa7b549f086191456e03ad78e64388a966b9b1922e1dfbed97eb5
hovercard-subject-tagpull_request:4637446418
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/adcontextprotocol/adcp-client-python/1223/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7613a2080f91cf23257883c4eb34550b102968f8972c2c9889c92d3bc5c07bd2/adcontextprotocol/adcp-client-python/pull/1223
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7613a2080f91cf23257883c4eb34550b102968f8972c2c9889c92d3bc5c07bd2/adcontextprotocol/adcp-client-python/pull/1223
og:image:altA later on_startup failure previously skipped adopter cleanup hooks. A cancelled shutdown callback could also skip later cleanup, and secondary-error logging formatted adopter exception bodies and ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/pull/1223#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1223
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1223
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
fix/server-hook-cleanuphttps://github.com/adcontextprotocol/adcp-client-python/tree/fix/server-hook-cleanup
Conversationhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
Commits2 (2)https://github.com/adcontextprotocol/adcp-client-python/pull/1223/commits
Checkshttps://github.com/adcontextprotocol/adcp-client-python/pull/1223/checks
Files changedhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223/files
fix(server): settle lifespan cleanup after startup failureshttps://github.com/adcontextprotocol/adcp-client-python/pull/1223#top
bokelleyhttps://github.com/bokelley
mainhttps://github.com/adcontextprotocol/adcp-client-python/tree/main
fix/server-hook-cleanuphttps://github.com/adcontextprotocol/adcp-client-python/tree/fix/server-hook-cleanup
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Sep 25, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1223#issue-5582178506
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
https://github.com/apps/github-code-quality
github-code-qualityhttps://github.com/apps/github-code-quality
Sep 25, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5317146920
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1223/files
tests/test_serve_lifespan_hooks.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223/files#diff-9ac04a8d522407605e718465f026815948c5d7632d1dfd2674ddfd169116b025
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
tests/test_serve_lifespan_hooks.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223/files#diff-9ac04a8d522407605e718465f026815948c5d7632d1dfd2674ddfd169116b025
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
src/adcp/server/serve.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223/files#diff-6a12d6c162dda4394b0c3d1a6618488a4e6e352e9072faf52dc2c25325523cf9
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
src/adcp/server/serve.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223/files#diff-6a12d6c162dda4394b0c3d1a6618488a4e6e352e9072faf52dc2c25325523cf9
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
tests/test_serve_lifespan_hooks.pyhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223/files#diff-9ac04a8d522407605e718465f026815948c5d7632d1dfd2674ddfd169116b025
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 25, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5317168161
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1223/files
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5317168161
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5317168161
2d76606https://github.com/adcontextprotocol/adcp-client-python/commit/2d76606574664fda55a6363b54712f7b86386a9c
September 26, 2026 14:48https://github.com/adcontextprotocol/adcp-client-python/pull/1223#event-31894986332
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 26, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5326273722
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1223/files
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5326273722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1223https://github.com/adcontextprotocol/adcp-client-python/pull/1223
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5326273722
d336ecdhttps://github.com/adcontextprotocol/adcp-client-python/commit/d336ecd213046581570135508bbd530ba4c62131
September 26, 2026 15:42https://github.com/adcontextprotocol/adcp-client-python/pull/1223#event-31896676206
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
force-pushedhttps://github.com/adcontextprotocol/adcp-client-python/compare/2d76606574664fda55a6363b54712f7b86386a9c..d336ecd213046581570135508bbd530ba4c62131
2d76606https://github.com/adcontextprotocol/adcp-client-python/commit/2d76606574664fda55a6363b54712f7b86386a9c
d336ecdhttps://github.com/adcontextprotocol/adcp-client-python/commit/d336ecd213046581570135508bbd530ba4c62131
Compare https://github.com/adcontextprotocol/adcp-client-python/compare/2d76606574664fda55a6363b54712f7b86386a9c..d336ecd213046581570135508bbd530ba4c62131
September 26, 2026 15:42https://github.com/adcontextprotocol/adcp-client-python/pull/1223#event-31896676257
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 26, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5326444363
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1223/files
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5326444363
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
bokelleyhttps://github.com/bokelley
September 26, 2026 17:06https://github.com/adcontextprotocol/adcp-client-python/pull/1223#commits-pushed-16e71cc
https://github.com/bokelley
fix(server): settle lifespan cleanup after startup failureshttps://github.com/adcontextprotocol/adcp-client-python/pull/1223/commits/16e71cc4c8fcb9874425fbb96e17ad199374dc0a
16e71cchttps://github.com/adcontextprotocol/adcp-client-python/pull/1223/commits/16e71cc4c8fcb9874425fbb96e17ad199374dc0a
https://github.com/bokelley
fix(server): preserve startup errors through cancellationhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223/commits/a1355c5efa59118fd3a9fa91f842b625ad50705c
a1355c5https://github.com/adcontextprotocol/adcp-client-python/pull/1223/commits/a1355c5efa59118fd3a9fa91f842b625ad50705c
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
aao-secretariat[bot]https://github.com/apps/aao-secretariat
stale reviewhttps://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5326444363
a1355c5https://github.com/adcontextprotocol/adcp-client-python/commit/a1355c5efa59118fd3a9fa91f842b625ad50705c
September 26, 2026 17:07https://github.com/adcontextprotocol/adcp-client-python/pull/1223#event-31899261751
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
force-pushedhttps://github.com/adcontextprotocol/adcp-client-python/compare/d336ecd213046581570135508bbd530ba4c62131..a1355c5efa59118fd3a9fa91f842b625ad50705c
d336ecdhttps://github.com/adcontextprotocol/adcp-client-python/commit/d336ecd213046581570135508bbd530ba4c62131
a1355c5https://github.com/adcontextprotocol/adcp-client-python/commit/a1355c5efa59118fd3a9fa91f842b625ad50705c
Compare https://github.com/adcontextprotocol/adcp-client-python/compare/d336ecd213046581570135508bbd530ba4c62131..a1355c5efa59118fd3a9fa91f842b625ad50705c
September 26, 2026 17:07https://github.com/adcontextprotocol/adcp-client-python/pull/1223#event-31899261800
https://github.com/bokelley
https://github.com/apps/conductor-build-app
bokelleyhttps://github.com/bokelley
Sep 26, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1223#issuecomment-5848170897
#1219https://github.com/adcontextprotocol/adcp-client-python/pull/1219
a1355c5https://github.com/adcontextprotocol/adcp-client-python/commit/a1355c5efa59118fd3a9fa91f842b625ad50705c
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
https://github.com/apps/aao-secretariat
aao-secretariathttps://github.com/apps/aao-secretariat
Sep 26, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5326689740
View reviewed changes https://github.com/adcontextprotocol/adcp-client-python/pull/1223/files/a1355c5efa59118fd3a9fa91f842b625ad50705c
aao-secretariathttps://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1223#pullrequestreview-5326689740
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1223https://github.com/adcontextprotocol/adcp-client-python/pull/1223
a1355c5https://github.com/adcontextprotocol/adcp-client-python/commit/a1355c5efa59118fd3a9fa91f842b625ad50705c
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
7c5a123https://github.com/adcontextprotocol/adcp-client-python/commit/7c5a12397a27041bd76fce07e9ffafec4efa2295
Sep 26, 2026https://github.com/adcontextprotocol/adcp-client-python/pull/1223#event-31900802573
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
September 26, 2026 17:57https://github.com/adcontextprotocol/adcp-client-python/pull/1223#event-31900803698
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
Sep 26, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1223#ref-pullrequest-5582153131
fix(reporting): validate buyer frozen histories #1222 https://github.com/adcontextprotocol/adcp-client-python/pull/1222
https://github.com/apps/aao-ipr-bot
aao-ipr-bothttps://github.com/apps/aao-ipr-bot
Sep 27, 2026 https://github.com/adcontextprotocol/adcp-client-python/pull/1223#ref-pullrequest-5602616295
chore(main): release 8.0.0-beta.16 #1228 https://github.com/adcontextprotocol/adcp-client-python/pull/1228
https://github.co/hiddenchars
https://github.com/adcontextprotocol/adcp-client-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fpull%2F1223
https://github.com/apps/aao-secretariat
aao-secretariat[bot] https://github.com/apps/aao-secretariat
https://github.com/adcontextprotocol/adcp-client-python/pull/1223/files/a1355c5efa59118fd3a9fa91f842b625ad50705c
https://github.com/apps/github-code-quality
github-code-quality[bot] https://github.com/apps/github-code-quality
https://github.com/adcontextprotocol/adcp-client-python/pull/1223/files/7cbb06ea21a8bcdc168369498881b30dc65cdfd6
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
Please reload this pagehttps://github.com/adcontextprotocol/adcp-client-python/pull/1223
https://github.com/bokelley
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.