Title: Canonicalization now strips a trailing FQDN-root dot; the spec defines no rule and ships no vector · Issue #986 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: Canonicalization now strips a trailing FQDN-root dot; the spec defines no rule and ships no vector · Issue #986 · adcontextprotocol/adcp-client-python
X Title: Canonicalization now strips a trailing FQDN-root dot; the spec defines no rule and ships no vector · Issue #986 · adcontextprotocol/adcp-client-python
Description: Summary @target-uri / @authority canonicalization now strips a trailing FQDN-root dot from the host. This is a wire-visible change and the AdCP spec does not define the behaviour either way, so it is filed here to make it visible and to ...
Open Graph Description: Summary @target-uri / @authority canonicalization now strips a trailing FQDN-root dot from the host. This is a wire-visible change and the AdCP spec does not define the behaviour either way, so it ...
X Description: Summary @target-uri / @authority canonicalization now strips a trailing FQDN-root dot from the host. This is a wire-visible change and the AdCP spec does not define the behaviour either way, so it ...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/986
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Canonicalization now strips a trailing FQDN-root dot; the spec defines no rule and ships no vector","articleBody":"## Summary\n\n`@target-uri` / `@authority` canonicalization now strips a trailing FQDN-root dot from the host. This is a wire-visible change and the AdCP spec does not define the behaviour either way, so it is filed here to make it visible and to ask that upstream decide it.\n\n**Before:** `https://example.com./p` → authority `example.com.`\n**After:** `https://example.com./p` → authority `example.com`\n\nLanded in #985 (`feat(signing): reject malformed authorities, convert IDN hosts to A-labels`).\n\n## Why the change was forced\n\n#985 makes the signing path call `_idna_canonicalize.canonicalize_host` for non-ASCII hosts, which is the package's designated host normalizer and already has six consumers. That helper strips one trailing root dot as part of its UTS-46 preparation. The pre-existing ASCII path did a bare `host.lower()`, which keeps it.\n\nLeaving both as they were would have produced a **branch-dependent** authority:\n\n| input | ASCII branch | IDNA branch |\n|---|---|---|\n| `https://xn--bcher-kva.example./p` | `xn--bcher-kva.example.` | — |\n| `https://bücher.example./p` | — | `xn--bcher-kva.example` |\n\nSame host, two spellings, two different `@authority` values — so a signer emitting the A-label form and a verifier deriving the host from a `Host` header carrying the U-label would compute different signature bases and every signature between them would fail to verify. That is precisely the silent canonicalization drift the single-algorithm design exists to prevent.\n\nThree options were available, none of them free:\n\n1. **Strip once, before the branch** (chosen). Both branches agree, and they agree with the designated normalizer. Costs a wire-visible change for FQDN-root URLs.\n2. **Detach and re-append around the branch.** Preserves today's bytes exactly, but it is bespoke normalization inside `canonical.py` — which would make it the seventh host-normalizing implementation in the tree, the duplication #985 exists to reduce.\n3. **Reject a trailing root dot as a malformed authority.** Unambiguous, but invents a rejection the spec does not state, and rejecting traffic the spec may require accepting is worse than the ambiguity.\n\n## What this issue is actually asking for\n\n**The spec should define root-dot handling and ship a vector for it.** `example.com.` and `example.com` are the same DNS name; whether they are the same *signature base* is a protocol question, not an SDK question, and every implementation is currently guessing.\n\nNote that the SDK could not simply add a local vector to settle it. `tests/conformance/vectors/request-signing/` is vendored verbatim and pinned by SHA-256 in `vector_manifest.json`; `test_vendored_tree_matches_manifest_exactly` fails on extra files as well as modified ones, and its own message states the policy:\n\n> *\"Vectors are vendored verbatim from the spec; add the file upstream first, then re-vendor and regenerate the manifest.\"*\n\nThat pin is #975/#980's whole point, so working around it locally would have reintroduced the drift those issues exist to stop. The behaviour is therefore pinned by an SDK-local test (`test_trailing_root_dot_is_stripped_on_both_host_branches`) which is explicitly marked as superseded once a real vector exists.\n\n**Suggested upstream ask** (`adcontextprotocol/adcp`): add a `root-dot-*` case to `dist/compliance/\u003cversion>/test-vectors/request-signing/canonicalization.json` fixing whichever behaviour the spec wants, and state the rule in the `@target-uri` canonicalization steps alongside the existing scheme/port/path rules.\n\n## Impact\n\nLow, but real. Affects only callers signing or verifying URLs whose host carries an explicit trailing dot. A new-SDK signer and an old-SDK verifier disagree for those URLs during rollout. Shipping as a **minor** (#985 is titled `feat:`) rather than a patch for this reason.\n\n## Related\n\n- #985 — the PR that makes the change\n- #977 — IDNA A-label conversion (the change that forced the question)\n- #975 / #980 — the vendored-vector pin that prevents settling this locally\n","author":{"url":"https://github.com/KonstantinMirin","@type":"Person","name":"KonstantinMirin"},"datePublished":"2026-07-29T09:28:41Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/986"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:019d2ce6-eaea-9ff1-165e-64277c628994 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 86A8:215B92:D32544:11A1326:6B010087 |
| html-safe-nonce | b55d66d2069ce7cfcf50122ee3342950703217abf36a0ecfc7a2f594561a1c26 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkE4OjIxNUI5MjpEMzI1NDQ6MTFBMTMyNjo2QjAxMDA4NyIsInZpc2l0b3JfaWQiOiIyNzI3MTgxNDA3MjgwNDk2Nzc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 85107925e64f84f643df1baafc0d3117634547907102aa907e28659af57241cf |
| hovercard-subject-tag | issue:5007669425 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/986/issue_layout |
| twitter:image | https://opengraph.githubassets.com/87da5278b0121fb72fd5c25bca9b8c9ea916fef9ac36b1b6dce14d5bc4c04120/adcontextprotocol/adcp-client-python/issues/986 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/87da5278b0121fb72fd5c25bca9b8c9ea916fef9ac36b1b6dce14d5bc4c04120/adcontextprotocol/adcp-client-python/issues/986 |
| og:image:alt | Summary @target-uri / @authority canonicalization now strips a trailing FQDN-root dot from the host. This is a wire-visible change and the AdCP spec does not define the behaviour either way, so it ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | KonstantinMirin |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width