René's URL Explorer Experiment


Title: Canonicalization now strips a trailing FQDN-root dot; the spec defines no rule and ships no vector · Issue #986 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Canonicalization now strips a trailing FQDN-root dot; the spec defines no rule and ships no vector · Issue #986 · adcontextprotocol/adcp-client-python

X Title: Canonicalization now strips a trailing FQDN-root dot; the spec defines no rule and ships no vector · Issue #986 · adcontextprotocol/adcp-client-python

Description: Summary @target-uri / @authority canonicalization now strips a trailing FQDN-root dot from the host. This is a wire-visible change and the AdCP spec does not define the behaviour either way, so it is filed here to make it visible and to ...

Open Graph Description: Summary @target-uri / @authority canonicalization now strips a trailing FQDN-root dot from the host. This is a wire-visible change and the AdCP spec does not define the behaviour either way, so it ...

X Description: Summary @target-uri / @authority canonicalization now strips a trailing FQDN-root dot from the host. This is a wire-visible change and the AdCP spec does not define the behaviour either way, so it ...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/986

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Canonicalization now strips a trailing FQDN-root dot; the spec defines no rule and ships no vector","articleBody":"## Summary\n\n`@target-uri` / `@authority` canonicalization now strips a trailing FQDN-root dot from the host. This is a wire-visible change and the AdCP spec does not define the behaviour either way, so it is filed here to make it visible and to ask that upstream decide it.\n\n**Before:** `https://example.com./p` → authority `example.com.`\n**After:** `https://example.com./p` → authority `example.com`\n\nLanded in #985 (`feat(signing): reject malformed authorities, convert IDN hosts to A-labels`).\n\n## Why the change was forced\n\n#985 makes the signing path call `_idna_canonicalize.canonicalize_host` for non-ASCII hosts, which is the package's designated host normalizer and already has six consumers. That helper strips one trailing root dot as part of its UTS-46 preparation. The pre-existing ASCII path did a bare `host.lower()`, which keeps it.\n\nLeaving both as they were would have produced a **branch-dependent** authority:\n\n| input | ASCII branch | IDNA branch |\n|---|---|---|\n| `https://xn--bcher-kva.example./p` | `xn--bcher-kva.example.` | — |\n| `https://bücher.example./p` | — | `xn--bcher-kva.example` |\n\nSame host, two spellings, two different `@authority` values — so a signer emitting the A-label form and a verifier deriving the host from a `Host` header carrying the U-label would compute different signature bases and every signature between them would fail to verify. That is precisely the silent canonicalization drift the single-algorithm design exists to prevent.\n\nThree options were available, none of them free:\n\n1. **Strip once, before the branch** (chosen). Both branches agree, and they agree with the designated normalizer. Costs a wire-visible change for FQDN-root URLs.\n2. **Detach and re-append around the branch.** Preserves today's bytes exactly, but it is bespoke normalization inside `canonical.py` — which would make it the seventh host-normalizing implementation in the tree, the duplication #985 exists to reduce.\n3. **Reject a trailing root dot as a malformed authority.** Unambiguous, but invents a rejection the spec does not state, and rejecting traffic the spec may require accepting is worse than the ambiguity.\n\n## What this issue is actually asking for\n\n**The spec should define root-dot handling and ship a vector for it.** `example.com.` and `example.com` are the same DNS name; whether they are the same *signature base* is a protocol question, not an SDK question, and every implementation is currently guessing.\n\nNote that the SDK could not simply add a local vector to settle it. `tests/conformance/vectors/request-signing/` is vendored verbatim and pinned by SHA-256 in `vector_manifest.json`; `test_vendored_tree_matches_manifest_exactly` fails on extra files as well as modified ones, and its own message states the policy:\n\n> *\"Vectors are vendored verbatim from the spec; add the file upstream first, then re-vendor and regenerate the manifest.\"*\n\nThat pin is #975/#980's whole point, so working around it locally would have reintroduced the drift those issues exist to stop. The behaviour is therefore pinned by an SDK-local test (`test_trailing_root_dot_is_stripped_on_both_host_branches`) which is explicitly marked as superseded once a real vector exists.\n\n**Suggested upstream ask** (`adcontextprotocol/adcp`): add a `root-dot-*` case to `dist/compliance/\u003cversion>/test-vectors/request-signing/canonicalization.json` fixing whichever behaviour the spec wants, and state the rule in the `@target-uri` canonicalization steps alongside the existing scheme/port/path rules.\n\n## Impact\n\nLow, but real. Affects only callers signing or verifying URLs whose host carries an explicit trailing dot. A new-SDK signer and an old-SDK verifier disagree for those URLs during rollout. Shipping as a **minor** (#985 is titled `feat:`) rather than a patch for this reason.\n\n## Related\n\n- #985 — the PR that makes the change\n- #977 — IDNA A-label conversion (the change that forced the question)\n- #975 / #980 — the vendored-vector pin that prevents settling this locally\n","author":{"url":"https://github.com/KonstantinMirin","@type":"Person","name":"KonstantinMirin"},"datePublished":"2026-07-29T09:28:41Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/986"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:019d2ce6-eaea-9ff1-165e-64277c628994
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id86A8:215B92:D32544:11A1326:6B010087
html-safe-nonceb55d66d2069ce7cfcf50122ee3342950703217abf36a0ecfc7a2f594561a1c26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkE4OjIxNUI5MjpEMzI1NDQ6MTFBMTMyNjo2QjAxMDA4NyIsInZpc2l0b3JfaWQiOiIyNzI3MTgxNDA3MjgwNDk2Nzc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac85107925e64f84f643df1baafc0d3117634547907102aa907e28659af57241cf
hovercard-subject-tagissue:5007669425
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/986/issue_layout
twitter:imagehttps://opengraph.githubassets.com/87da5278b0121fb72fd5c25bca9b8c9ea916fef9ac36b1b6dce14d5bc4c04120/adcontextprotocol/adcp-client-python/issues/986
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/87da5278b0121fb72fd5c25bca9b8c9ea916fef9ac36b1b6dce14d5bc4c04120/adcontextprotocol/adcp-client-python/issues/986
og:image:altSummary @target-uri / @authority canonicalization now strips a trailing FQDN-root dot from the host. This is a wire-visible change and the AdCP spec does not define the behaviour either way, so it ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKonstantinMirin
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/986#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F986
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F986
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/986
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/986
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/986
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/986
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/986
Canonicalization now strips a trailing FQDN-root dot; the spec defines no rule and ships no vectorhttps://github.com/adcontextprotocol/adcp-client-python/issues/986#top
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/986#issue-5007669425
#985https://github.com/adcontextprotocol/adcp-client-python/pull/985
#985https://github.com/adcontextprotocol/adcp-client-python/pull/985
fix(signing): reject malformed authorities, convert IDN hosts to A-labels #985https://github.com/adcontextprotocol/adcp-client-python/pull/985
#975https://github.com/adcontextprotocol/adcp-client-python/issues/975
#980https://github.com/adcontextprotocol/adcp-client-python/pull/980
#985https://github.com/adcontextprotocol/adcp-client-python/pull/985
fix(signing): reject malformed authorities, convert IDN hosts to A-labels #985https://github.com/adcontextprotocol/adcp-client-python/pull/985
@target-uri canonicalization applies no IDNA A-label conversion, and the verifier does not reject raw U-labels #977https://github.com/adcontextprotocol/adcp-client-python/issues/977
Vendored request-signing conformance vectors are incomplete, and the loaders cannot detect it #975https://github.com/adcontextprotocol/adcp-client-python/issues/975
test(signing): vendor the complete AdCP 3.1.8 request-signing vector set and pin it against drift #980https://github.com/adcontextprotocol/adcp-client-python/pull/980
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/986#event-28650351735
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/986#issuecomment-5115845962
fix(signing): reject malformed authorities, convert IDN hosts to A-labels #985https://github.com/adcontextprotocol/adcp-client-python/pull/985
https://claude.ai/code/session_013foFTuh9EmPvu6W397uPEGhttps://claude.ai/code/session_013foFTuh9EmPvu6W397uPEG
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/986#event-28650582234
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Aug 24, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/986#issuecomment-5394985621
adcontextprotocol/adcp#6822https://github.com/adcontextprotocol/adcp/issues/6822
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Aug 25, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/986#issuecomment-5406914582
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 25, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/986#event-29960554630
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/986
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/986
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.