René's URL Explorer Experiment


Title: Canonicalization accepts five malformed authority shapes the spec requires be rejected; request_target_uri_malformed unimplemented · Issue #978 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Canonicalization accepts five malformed authority shapes the spec requires be rejected; request_target_uri_malformed unimplemented · Issue #978 · adcontextprotocol/adcp-client-python

X Title: Canonicalization accepts five malformed authority shapes the spec requires be rejected; request_target_uri_malformed unimplemented · Issue #978 · adcontextprotocol/adcp-client-python

Description: Found while vendoring the complete AdCP 3.1.1 request-signing vector set (#975). Reproductions are canonicalization.json cases, currently strict-xfail in tests/conformance/signing/test_canonicalization.py. Problem The spec requires signe...

Open Graph Description: Found while vendoring the complete AdCP 3.1.1 request-signing vector set (#975). Reproductions are canonicalization.json cases, currently strict-xfail in tests/conformance/signing/test_canonicaliza...

X Description: Found while vendoring the complete AdCP 3.1.1 request-signing vector set (#975). Reproductions are canonicalization.json cases, currently strict-xfail in tests/conformance/signing/test_canonicaliza...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/978

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Canonicalization accepts five malformed authority shapes the spec requires be rejected; request_target_uri_malformed unimplemented","articleBody":"Found while vendoring the complete AdCP 3.1.1 request-signing vector set (#975). Reproductions are `canonicalization.json` cases, currently strict-xfail in `tests/conformance/signing/test_canonicalization.py`.\n\n## Problem\n\nThe spec requires signers to refuse to sign, and verifiers to reject, URLs whose authority is syntactically malformed:\n\n> If the authority has userinfo but no host (`https://user@/p`), no host at all (`https://:443/p` or `https:///p`), a bracketed host missing a closing bracket (`https://[::1/p`), or a bare IPv6 address outside brackets (`https://fe80::1/p`), the URL is malformed; signers MUST NOT sign it and verifiers MUST reject with `request_target_uri_malformed`.\n> — `security.mdx`, `@target-uri` canonicalization step 3\n\n> **IPv6 zone identifiers (RFC 6874) MUST be rejected.** ... verifiers MUST reject `@target-uri` values containing `%25` inside `[...]` with `request_target_uri_malformed`.\n> — ibid., step 2\n\n`canonicalize_target_uri()` rejects only one of the six shapes. The rest are canonicalized into a well-formed-looking result and signed.\n\n## Failing cases\n\n| case | input | expected | actual |\n|---|---|---|---|\n| `malformed-port-without-host` | `https://:443/p` | reject | accepted as `https:///p` |\n| `malformed-userinfo-without-host` | `https://user@/p` | reject | accepted as `https:///p` |\n| `malformed-empty-authority` | `https:///p` | reject | accepted as `https:///p` |\n| `malformed-bare-ipv6` | `https://fe80::1/p` | reject | accepted as `https://fe80::1/p` |\n| `malformed-ipv6-zone-identifier` | `https://[fe80::1%25eth0]/p` | reject | accepted unchanged |\n| `malformed-ipv6-missing-closing-bracket` | `https://[::1/p` | reject | ✅ rejected (`ValueError`) |\n\nThe first three collapse to an **empty authority**, so `@authority` enters the signature base as the empty string and `@target-uri` as `https:///p`. Two different malformed inputs (`https://:443/p` and `https://user@/p`) canonicalize to the identical base — signatures become transferable between them.\n\n`malformed-bare-ipv6` is a distinct hazard: `_canon_authority()` splits `fe80::1` on the last colon, yielding host `fe80:` and port `1`, then reassembles it as `fe80::1`. The round-trip masks the malformation.\n\n## `request_target_uri_malformed` is not implemented\n\nThe spec's error code for all of these does not exist anywhere in the SDK — `src/adcp/signing/errors.py` has no such constant, and `grep -rn request_target_uri_malformed src/` is empty. It has its own row in the transport error taxonomy:\n\n> | Request `@target-uri` is syntactically malformed (e.g., empty authority, bare IPv6, IPv6 zone identifier, raw non-ASCII host), OR canonicalized `@authority` does not byte-match the authority component of the canonical `@target-uri` (cross-vhost replay) | No | `request_target_uri_malformed` |\n\nBecause the code is missing, the vendored test asserts only that canonicalization refuses (`pytest.raises(ValueError)`) rather than grading the code. That assertion should be tightened to the spec code once it exists.\n\n## Note on the taxonomy row\n\nThat same row also covers a second obligation the SDK does not appear to implement: canonicalized `@authority` must byte-match the authority component of the canonical `@target-uri`, and verifiers must derive `@authority` from `:authority`/`Host` rather than proxy state. The spec flags it as a cross-vhost replay defense. No vector in the 3.1.1 set exercises it, so it is not covered by the strict-xfail ledger — flagging it here rather than filing separately, since the fix lands in the same place.\n\n## Suggested direction\n\nReject the five shapes in `_canon_authority()`, add `request_target_uri_malformed` to the error taxonomy, and map the canonicalization refusal onto it at the verifier boundary.\n","author":{"url":"https://github.com/KonstantinMirin","@type":"Person","name":"KonstantinMirin"},"datePublished":"2026-07-28T20:33:40Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/978"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:efbb4030-3940-9ebe-9aca-4a7aef5989bf
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD9F2:4BB79:BC4FF7:F19AD8:6B00FDA4
html-safe-nonceaa0b4dc63602f0fe6bd563cad4d03462aaf944a6a47de895a69d13bd645e36ff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUYyOjRCQjc5OkJDNEZGNzpGMTlBRDg6NkIwMEZEQTQiLCJ2aXNpdG9yX2lkIjoiODg5NjkyOTk4MTY4ODA0NzcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5ab75e95bccae38deffc4a5ac02f70add56aaae383279bf25e83428d148713fd
hovercard-subject-tagissue:5002752584
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/978/issue_layout
twitter:imagehttps://opengraph.githubassets.com/839dc952c72a5e7736384b3960add0ef326f7e6c5203886555953fc08c6a6325/adcontextprotocol/adcp-client-python/issues/978
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/839dc952c72a5e7736384b3960add0ef326f7e6c5203886555953fc08c6a6325/adcontextprotocol/adcp-client-python/issues/978
og:image:altFound while vendoring the complete AdCP 3.1.1 request-signing vector set (#975). Reproductions are canonicalization.json cases, currently strict-xfail in tests/conformance/signing/test_canonicaliza...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKonstantinMirin
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/978#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F978
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F978
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/978
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/978
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/978
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/978
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/978
#985https://github.com/adcontextprotocol/adcp-client-python/pull/985
Canonicalization accepts five malformed authority shapes the spec requires be rejected; request_target_uri_malformed unimplementedhttps://github.com/adcontextprotocol/adcp-client-python/issues/978#top
#985https://github.com/adcontextprotocol/adcp-client-python/pull/985
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/978#issue-5002752584
#975https://github.com/adcontextprotocol/adcp-client-python/issues/975
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/978#event-28622241355
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/978#issuecomment-5109436032
test(signing): vendor the complete AdCP 3.1.8 request-signing vector set and pin it against drift #980https://github.com/adcontextprotocol/adcp-client-python/pull/980
#980https://github.com/adcontextprotocol/adcp-client-python/pull/980
#975https://github.com/adcontextprotocol/adcp-client-python/issues/975
#980https://github.com/adcontextprotocol/adcp-client-python/pull/980
https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}https://claude.ai/code/$%7BCLAUDE_CODE_REMOTE_SESSION_ID%7D
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/978#event-28622464097
KonstantinMirinhttps://github.com/KonstantinMirin
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/978#event-28647061735
test(signing): assert the reject code, not just the refusalhttps://github.com/KonstantinMirin/adcp-client-python/commit/7f72e8700c2ae07fbc16556421a07746efb4caf5
7f72e87https://github.com/KonstantinMirin/adcp-client-python/commit/7f72e8700c2ae07fbc16556421a07746efb4caf5
fix(signing): add the webhook target-uri code and reject authorities …https://github.com/KonstantinMirin/adcp-client-python/commit/3e6d4572a0bc897ee495cbf9fc55f257fa8b5057
3e6d457https://github.com/KonstantinMirin/adcp-client-python/commit/3e6d4572a0bc897ee495cbf9fc55f257fa8b5057
test(signing): assert the reject code, not just the refusalhttps://github.com/KonstantinMirin/adcp-client-python/commit/071238919b46dbccd6db523bcf3d451f0219331b
0712389https://github.com/KonstantinMirin/adcp-client-python/commit/071238919b46dbccd6db523bcf3d451f0219331b
feat(signing): reject malformed authorities, convert IDN hosts to A-l…https://github.com/KonstantinMirin/adcp-client-python/commit/cd99622d7293f15dd6243c0c92206b01290490b8
cd99622https://github.com/KonstantinMirin/adcp-client-python/commit/cd99622d7293f15dd6243c0c92206b01290490b8
fix(signing): add the webhook target-uri code and reject authorities …https://github.com/KonstantinMirin/adcp-client-python/commit/7548cc84b1282ed41d60739f57584208dd347b09
7548cc8https://github.com/KonstantinMirin/adcp-client-python/commit/7548cc84b1282ed41d60739f57584208dd347b09
fix(signing): reject malformed authorities, convert IDN hosts to A-la…https://github.com/KonstantinMirin/adcp-client-python/commit/c9c8ca866c50fbd3650fd62b6f1b2e99f4733a8f
c9c8ca8https://github.com/KonstantinMirin/adcp-client-python/commit/c9c8ca866c50fbd3650fd62b6f1b2e99f4733a8f
fix(signing): add the webhook target-uri code and reject authorities …https://github.com/KonstantinMirin/adcp-client-python/commit/fbab8f44fdd75c699eeaff1330b5648b4810f7b4
fbab8f4https://github.com/KonstantinMirin/adcp-client-python/commit/fbab8f44fdd75c699eeaff1330b5648b4810f7b4
fix(signing): validate the port per RFC 3986 instead of trusting int()https://github.com/KonstantinMirin/adcp-client-python/commit/4331ac84547020331898ac7e6c86d5372c395bda
4331ac8https://github.com/KonstantinMirin/adcp-client-python/commit/4331ac84547020331898ac7e6c86d5372c395bda
bokelleyhttps://github.com/bokelley
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/978#event-28688913981
test(signing): vendor the complete AdCP 3.1.8 request-signing vector …https://github.com/adcontextprotocol/adcp-client-python/commit/cbcd4c3f57ff9a458c6d94c9e610ca1ec8ea9d2a
cbcd4c3https://github.com/adcontextprotocol/adcp-client-python/commit/cbcd4c3f57ff9a458c6d94c9e610ca1ec8ea9d2a
fix(signing): reject malformed authorities, convert IDN hosts to A-la…https://github.com/KonstantinMirin/adcp-client-python/commit/f1bc4613db0e437b8225a29226c7df586417f0dc
f1bc461https://github.com/KonstantinMirin/adcp-client-python/commit/f1bc4613db0e437b8225a29226c7df586417f0dc
fix(signing): add the webhook target-uri code and reject authorities …https://github.com/KonstantinMirin/adcp-client-python/commit/d0c626a138631dae077b2c7685ea8f2925c5b948
d0c626ahttps://github.com/KonstantinMirin/adcp-client-python/commit/d0c626a138631dae077b2c7685ea8f2925c5b948
fix(signing): validate the port per RFC 3986 instead of trusting int()https://github.com/KonstantinMirin/adcp-client-python/commit/cdb0ed485c3dbf3984d63278f5b4e285977e8131
cdb0ed4https://github.com/KonstantinMirin/adcp-client-python/commit/cdb0ed485c3dbf3984d63278f5b4e285977e8131
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#985https://github.com/adcontextprotocol/adcp-client-python/pull/985
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/978#event-28688952707
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/978
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/978
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.