René's URL Explorer Experiment


Title: Verifier does not reject malformed structured-field input at step 1 (wrong error code; covered-component smuggling) · Issue #976 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Verifier does not reject malformed structured-field input at step 1 (wrong error code; covered-component smuggling) · Issue #976 · adcontextprotocol/adcp-client-python

X Title: Verifier does not reject malformed structured-field input at step 1 (wrong error code; covered-component smuggling) · Issue #976 · adcontextprotocol/adcp-client-python

Description: Found while vendoring the complete AdCP 3.1.1 request-signing vector set (#975). Reproductions are the newly vendored vectors, currently strict-xfail in tests/conformance/signing/test_verifier_vectors.py. Problem verify_request_signature...

Open Graph Description: Found while vendoring the complete AdCP 3.1.1 request-signing vector set (#975). Reproductions are the newly vendored vectors, currently strict-xfail in tests/conformance/signing/test_verifier_vect...

X Description: Found while vendoring the complete AdCP 3.1.1 request-signing vector set (#975). Reproductions are the newly vendored vectors, currently strict-xfail in tests/conformance/signing/test_verifier_vect...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/976

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Verifier does not reject malformed structured-field input at step 1 (wrong error code; covered-component smuggling)","articleBody":"Found while vendoring the complete AdCP 3.1.1 request-signing vector set (#975). Reproductions are the newly vendored vectors, currently strict-xfail in `tests/conformance/signing/test_verifier_vectors.py`.\n\n## Problem\n\n`verify_request_signature` has no step-1 strict-parse stage. Structured-field input that is malformed or ambiguous is not rejected at parse time; it flows on to a later checklist step and is rejected under a **different** error code — or, worse, is silently resolved to one interpretation.\n\nConformance requires byte-for-byte match on `expected_outcome.error_code`, so rejecting with the wrong code is a graded failure, not a near-miss. More importantly, each of these is a parser-differential surface: signer and verifier can disagree on what was actually signed.\n\n## Failing vectors\n\n| vector | expected | actual | step reached |\n|---|---|---|---|\n| `negative/021-duplicate-signature-input-label.json` | `request_signature_header_malformed` | `request_signature_components_incomplete` | 6 |\n| `negative/022-multi-valued-content-type.json` | `request_signature_header_malformed` | `request_signature_invalid` | 10 |\n| `negative/023-multi-valued-content-digest.json` | `request_signature_header_malformed` | `request_signature_invalid` | 10 |\n\n### 021 — duplicate `Signature-Input` dictionary key\n\n`Signature-Input` declares label `sig1` twice. RFC 8941 §3.2 permits an implementation to reject *or* retain the last value; the AdCP profile requires rejection at step 1 as downgrade protection.\n\nThis is the one with teeth. The SDK silently resolves the duplicate and then rejects for an unrelated reason — `request_signature_components_incomplete: required covered component missing: @authority` — which means it took the *second* `sig1`, the one covering fewer components. That is precisely the smuggling scenario the spec's rejection rule exists to prevent: a proxy appends a weaker `sig1` and a verifier that reads the last value grades a different component set than the signer committed to. The vector's own `$comment` calls this out.\n\n### 022 — multi-valued `Content-Type`\n\n`Content-Type: application/json, text/plain` on a field covered by the signature. `Content-Type` is not a List-Structured-Field, so concatenation leaves the covered value undefined relative to the signature base. The SDK derives a base from the raw value and fails at crypto verify instead of rejecting at parse.\n\n### 023 — multi-valued `Content-Digest`\n\nTwo `sha-256` members in one `Content-Digest`. Per RFC 9530 §2 this is a Dictionary field and duplicate algorithms are ambiguous for signature coverage. Same failure mode as 022.\n\n## Suggested direction\n\nA strict-parse stage ahead of the checklist that rejects with `request_signature_header_malformed` on: duplicate keys in the `Signature-Input` / `Signature` dictionaries, and multiple field values (or duplicate structured-field members) for any covered non-list field.\n\nNote this changes the error code returned for inputs that are currently rejected as `request_signature_invalid` / `request_signature_components_incomplete`, which is a visible behavior change for consumers keying on the code.\n","author":{"url":"https://github.com/KonstantinMirin","@type":"Person","name":"KonstantinMirin"},"datePublished":"2026-07-28T20:32:59Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/976"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:35586f47-a4fe-9ab9-d458-40518d0c750a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8E54:2564F:E41112:12D9718:6B00FEBC
html-safe-nonce9b3dd888b88a1fa8d9dff709d216c0b0eb82de09de9b023f7313616131a9db8d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTU0OjI1NjRGOkU0MTExMjoxMkQ5NzE4OjZCMDBGRUJDIiwidmlzaXRvcl9pZCI6IjMxODQ0MTc2MTI2NTg0NDE5MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8a282782194d296dd827cabae79d42df37232de8f30037f29fb461f822d26d48
hovercard-subject-tagissue:5002747623
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/976/issue_layout
twitter:imagehttps://opengraph.githubassets.com/00cab0bd67e349fbe23bd57c8ac265dd8c9cb47aa8df67b5609c86fca82c8de0/adcontextprotocol/adcp-client-python/issues/976
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/00cab0bd67e349fbe23bd57c8ac265dd8c9cb47aa8df67b5609c86fca82c8de0/adcontextprotocol/adcp-client-python/issues/976
og:image:altFound while vendoring the complete AdCP 3.1.1 request-signing vector set (#975). Reproductions are the newly vendored vectors, currently strict-xfail in tests/conformance/signing/test_verifier_vect...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKonstantinMirin
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/976#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F976
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F976
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/976
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/976
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/976
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/976
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/976
#993https://github.com/adcontextprotocol/adcp-client-python/pull/993
Verifier does not reject malformed structured-field input at step 1 (wrong error code; covered-component smuggling)https://github.com/adcontextprotocol/adcp-client-python/issues/976#top
#993https://github.com/adcontextprotocol/adcp-client-python/pull/993
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/976#issue-5002747623
#975https://github.com/adcontextprotocol/adcp-client-python/issues/975
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/976#event-28622216381
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/976#issuecomment-5109426397
@bokelleyhttps://github.com/bokelley
#980https://github.com/adcontextprotocol/adcp-client-python/pull/980
#980https://github.com/adcontextprotocol/adcp-client-python/pull/980
@bokelleyhttps://github.com/bokelley
#980https://github.com/adcontextprotocol/adcp-client-python/pull/980
https://claude.ai/code/session_01KpiZzM52qxS4WdFFgfFzqghttps://claude.ai/code/session_01KpiZzM52qxS4WdFFgfFzqg
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/976#event-28622420662
KonstantinMirinhttps://github.com/KonstantinMirin
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/976#event-28662364595
feat(signing): reject malformed structured-field input at step 1https://github.com/KonstantinMirin/adcp-client-python/commit/26a476e1b266372641ecb9bac11c80ae155de9ae
https://docs.github.com/articles/closing-issues-via-commit-messages
26a476ehttps://github.com/KonstantinMirin/adcp-client-python/commit/26a476e1b266372641ecb9bac11c80ae155de9ae
fix(signing): reject malformed structured-field input at step 1https://github.com/KonstantinMirin/adcp-client-python/commit/a02860a9e0caea8dce0fdbfd1d56c405047518cd
https://docs.github.com/articles/closing-issues-via-commit-messages
a02860ahttps://github.com/KonstantinMirin/adcp-client-python/commit/a02860a9e0caea8dce0fdbfd1d56c405047518cd
fix(signing): reject malformed structured-field input at step 1https://github.com/KonstantinMirin/adcp-client-python/commit/5967ab56fc72c431f3d42d70e498e501b6e8b80b
https://docs.github.com/articles/closing-issues-via-commit-messages
5967ab5https://github.com/KonstantinMirin/adcp-client-python/commit/5967ab56fc72c431f3d42d70e498e501b6e8b80b
bokelleyhttps://github.com/bokelley
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/976#event-28688968512
fix(signing): reject malformed structured-field input at step 1https://github.com/KonstantinMirin/adcp-client-python/commit/6139edebe2b4dcc6ad68b01e304ac9208442e5c1
https://docs.github.com/articles/closing-issues-via-commit-messages
6139edehttps://github.com/KonstantinMirin/adcp-client-python/commit/6139edebe2b4dcc6ad68b01e304ac9208442e5c1
fix(signing): reject malformed structured-field input at step 1https://github.com/KonstantinMirin/adcp-client-python/commit/315ec040046d3c1ed9ca01e93c2a0236559770be
https://docs.github.com/articles/closing-issues-via-commit-messages
315ec04https://github.com/KonstantinMirin/adcp-client-python/commit/315ec040046d3c1ed9ca01e93c2a0236559770be
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#993https://github.com/adcontextprotocol/adcp-client-python/pull/993
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/976#event-28688983542
bokelleyhttps://github.com/bokelley
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/976#event-28688984063
fix(signing): reject malformed structured-field input at step 1 (#993)https://github.com/adcontextprotocol/adcp-client-python/commit/6518c2d88d0bd5055caeb39350a24a3b34c45abc
#993https://github.com/adcontextprotocol/adcp-client-python/pull/993
https://docs.github.com/articles/closing-issues-via-commit-messages
6518c2dhttps://github.com/adcontextprotocol/adcp-client-python/commit/6518c2d88d0bd5055caeb39350a24a3b34c45abc
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/976
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/976
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.