Title: Vendored request-signing conformance vectors are incomplete, and the loaders cannot detect it · Issue #975 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: Vendored request-signing conformance vectors are incomplete, and the loaders cannot detect it · Issue #975 · adcontextprotocol/adcp-client-python
X Title: Vendored request-signing conformance vectors are incomplete, and the loaders cannot detect it · Issue #975 · adcontextprotocol/adcp-client-python
Description: Summary The vendored AdCP request-signing conformance vectors under tests/conformance/vectors/request-signing/ are an incomplete copy of the spec set, and the tests that grade against them are structurally incapable of noticing. Both gra...
Open Graph Description: Summary The vendored AdCP request-signing conformance vectors under tests/conformance/vectors/request-signing/ are an incomplete copy of the spec set, and the tests that grade against them are stru...
X Description: Summary The vendored AdCP request-signing conformance vectors under tests/conformance/vectors/request-signing/ are an incomplete copy of the spec set, and the tests that grade against them are stru...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/975
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Vendored request-signing conformance vectors are incomplete, and the loaders cannot detect it","articleBody":"## Summary\n\nThe vendored AdCP request-signing conformance vectors under `tests/conformance/vectors/request-signing/` are an incomplete copy of the spec set, and the tests that grade against them are structurally incapable of noticing.\n\nBoth graders load vectors by globbing and then assert only that the result is non-empty:\n\n- `tests/conformance/signing/test_verifier_vectors.py:77-78` — `_load()` does `glob(\"*.json\")` then `assert result, f\"no vectors under ...\"`\n- `tests/conformance/signing/test_canonicalization.py:24-31` — same shape for vectors carrying `expected_signature_base`\n\nAny non-empty subset satisfies that assertion. A missing vector is indistinguishable from a complete set, so the suite reports green on a partial copy — which is exactly what has been happening.\n\n## The gap\n\nMeasured against AdCP **3.1.1**, the version `src/adcp/ADCP_VERSION` already targets (spec repo `dist/compliance/3.1.1/test-vectors/request-signing/`):\n\n| | spec 3.1.1 | vendored | missing |\n|---|---|---|---|\n| `positive/` | 12 | 8 | `009-percent-encoded-unreserved-decoded`, `010-percent-encoded-slash-preserved`, `011-ipv6-authority`, `012-ipv6-authority-default-port-stripped` |\n| `negative/` | 28 | 20 | `021-duplicate-signature-input-label`, `022-multi-valued-content-type`, `023-multi-valued-content-digest`, `024-unquoted-string-param`, `025-jwk-alg-crv-mismatch`, `026-non-ascii-host`, `027-webhook-registration-authentication-unsigned`, `028-unsigned-protocol-method-required` |\n| `canonicalization.json` | ships | **absent** | the standalone signing-base fixture |\n\n`canonicalization.json` is the conspicuous one: the vendored `README.md` documents it in the file-layout tree *and* devotes a full section to it, describing it as \"the fastest way to surface cross-implementation divergence\" and recommending SDKs \"run `canonicalization.json` on every commit\". The file was never copied in.\n\nThree further vectors had silently drifted from their upstream contents: `016-replayed-nonce`, `017-key-revoked`, `020-rate-abuse`. `017` is the consequential one — it was vendored at a revision that revokes `test-ed25519-2026`, the primary signing key, rather than the dedicated `test-revoked-2026` keypair the spec now uses. `keys.json` had never been refreshed to carry that key either.\n\n## Why it matters\n\nSignature-base construction is the known-hard part of RFC 9421 interop, and the missing vectors sit exactly on its edges: `009`/`010` are percent-encoding, `011`/`012` are IPv6 authority, `026` is a non-ASCII host, `028` is the `protocol_methods_required_for` enforcement path.\n\nA verifier can pass every currently-vendored vector and still reject validly-signed requests from a conformant counterparty. And because the SDK owns canonicalization on behalf of its consumers, these gaps are untested in every downstream implementation too, not just in this suite — this was found while adopting `adcp.signing` in a seller implementation that delegates canonicalization entirely to the SDK.\n\n## Fix\n\nPR #980 vendors the complete 3.1.1 set and, more importantly, replaces the non-empty assertion with a completeness pin so the set cannot silently drift again at the next spec bump. Adding the 12 files without that guard would only reset the clock.\n\nThe pin is over **content hashes**, not filenames — a filename-only manifest would not have caught the `016`/`017`/`020` drift. It is tied to `get_adcp_spec_version()`, so bumping the targeted spec version without re-vendoring fails loudly.\n\n## Grading the new vectors turns up 12 real conformance failures\n\nThey are filed separately and marked strict-xfail in the PR rather than fixed there, since they are production behavior changes in a security-critical verifier:\n\n- The verifier has no step-1 strict-parse stage, so malformed/ambiguous input flows through to a later check and is rejected under the wrong error code (negative `021`, `022`, `023`, `026`). Conformance requires byte-for-byte error codes, so \"rejected anyway\" is not a pass.\n- `@target-uri` canonicalization applies no UTS-46 A-label conversion, drops a trailing empty query, and accepts five malformed authority shapes the spec requires be rejected.\n","author":{"url":"https://github.com/KonstantinMirin","@type":"Person","name":"KonstantinMirin"},"datePublished":"2026-07-28T20:32:36Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/975"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f9756e17-6c6c-ee68-684f-9fbba7234a6f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BE5E:27D3AD:1E044A0:2611B5D:6B015F50 |
| html-safe-nonce | f7762e11ddd6e55df126e1df368112be4a21e04d1b5097b98b14bdfc96fb691a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTVFOjI3RDNBRDoxRTA0NEEwOjI2MTFCNUQ6NkIwMTVGNTAiLCJ2aXNpdG9yX2lkIjoiNjEwMTc4NDM2NjE5MzY2MzgyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bef0257f2083bc3fb679e820bc7536fbb4ea0e64951bb89335e5a101646041d4 |
| hovercard-subject-tag | issue:5002745018 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/975/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5b1f3657e37448726ed94f7df9206cf83daef61924b470fdfcabcd790c894361/adcontextprotocol/adcp-client-python/issues/975 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5b1f3657e37448726ed94f7df9206cf83daef61924b470fdfcabcd790c894361/adcontextprotocol/adcp-client-python/issues/975 |
| og:image:alt | Summary The vendored AdCP request-signing conformance vectors under tests/conformance/vectors/request-signing/ are an incomplete copy of the spec set, and the tests that grade against them are stru... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | KonstantinMirin |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width