René's URL Explorer Experiment


Title: Vendored request-signing conformance vectors are incomplete, and the loaders cannot detect it · Issue #975 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Vendored request-signing conformance vectors are incomplete, and the loaders cannot detect it · Issue #975 · adcontextprotocol/adcp-client-python

X Title: Vendored request-signing conformance vectors are incomplete, and the loaders cannot detect it · Issue #975 · adcontextprotocol/adcp-client-python

Description: Summary The vendored AdCP request-signing conformance vectors under tests/conformance/vectors/request-signing/ are an incomplete copy of the spec set, and the tests that grade against them are structurally incapable of noticing. Both gra...

Open Graph Description: Summary The vendored AdCP request-signing conformance vectors under tests/conformance/vectors/request-signing/ are an incomplete copy of the spec set, and the tests that grade against them are stru...

X Description: Summary The vendored AdCP request-signing conformance vectors under tests/conformance/vectors/request-signing/ are an incomplete copy of the spec set, and the tests that grade against them are stru...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/975

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Vendored request-signing conformance vectors are incomplete, and the loaders cannot detect it","articleBody":"## Summary\n\nThe vendored AdCP request-signing conformance vectors under `tests/conformance/vectors/request-signing/` are an incomplete copy of the spec set, and the tests that grade against them are structurally incapable of noticing.\n\nBoth graders load vectors by globbing and then assert only that the result is non-empty:\n\n- `tests/conformance/signing/test_verifier_vectors.py:77-78` — `_load()` does `glob(\"*.json\")` then `assert result, f\"no vectors under ...\"`\n- `tests/conformance/signing/test_canonicalization.py:24-31` — same shape for vectors carrying `expected_signature_base`\n\nAny non-empty subset satisfies that assertion. A missing vector is indistinguishable from a complete set, so the suite reports green on a partial copy — which is exactly what has been happening.\n\n## The gap\n\nMeasured against AdCP **3.1.1**, the version `src/adcp/ADCP_VERSION` already targets (spec repo `dist/compliance/3.1.1/test-vectors/request-signing/`):\n\n| | spec 3.1.1 | vendored | missing |\n|---|---|---|---|\n| `positive/` | 12 | 8 | `009-percent-encoded-unreserved-decoded`, `010-percent-encoded-slash-preserved`, `011-ipv6-authority`, `012-ipv6-authority-default-port-stripped` |\n| `negative/` | 28 | 20 | `021-duplicate-signature-input-label`, `022-multi-valued-content-type`, `023-multi-valued-content-digest`, `024-unquoted-string-param`, `025-jwk-alg-crv-mismatch`, `026-non-ascii-host`, `027-webhook-registration-authentication-unsigned`, `028-unsigned-protocol-method-required` |\n| `canonicalization.json` | ships | **absent** | the standalone signing-base fixture |\n\n`canonicalization.json` is the conspicuous one: the vendored `README.md` documents it in the file-layout tree *and* devotes a full section to it, describing it as \"the fastest way to surface cross-implementation divergence\" and recommending SDKs \"run `canonicalization.json` on every commit\". The file was never copied in.\n\nThree further vectors had silently drifted from their upstream contents: `016-replayed-nonce`, `017-key-revoked`, `020-rate-abuse`. `017` is the consequential one — it was vendored at a revision that revokes `test-ed25519-2026`, the primary signing key, rather than the dedicated `test-revoked-2026` keypair the spec now uses. `keys.json` had never been refreshed to carry that key either.\n\n## Why it matters\n\nSignature-base construction is the known-hard part of RFC 9421 interop, and the missing vectors sit exactly on its edges: `009`/`010` are percent-encoding, `011`/`012` are IPv6 authority, `026` is a non-ASCII host, `028` is the `protocol_methods_required_for` enforcement path.\n\nA verifier can pass every currently-vendored vector and still reject validly-signed requests from a conformant counterparty. And because the SDK owns canonicalization on behalf of its consumers, these gaps are untested in every downstream implementation too, not just in this suite — this was found while adopting `adcp.signing` in a seller implementation that delegates canonicalization entirely to the SDK.\n\n## Fix\n\nPR #980 vendors the complete 3.1.1 set and, more importantly, replaces the non-empty assertion with a completeness pin so the set cannot silently drift again at the next spec bump. Adding the 12 files without that guard would only reset the clock.\n\nThe pin is over **content hashes**, not filenames — a filename-only manifest would not have caught the `016`/`017`/`020` drift. It is tied to `get_adcp_spec_version()`, so bumping the targeted spec version without re-vendoring fails loudly.\n\n## Grading the new vectors turns up 12 real conformance failures\n\nThey are filed separately and marked strict-xfail in the PR rather than fixed there, since they are production behavior changes in a security-critical verifier:\n\n- The verifier has no step-1 strict-parse stage, so malformed/ambiguous input flows through to a later check and is rejected under the wrong error code (negative `021`, `022`, `023`, `026`). Conformance requires byte-for-byte error codes, so \"rejected anyway\" is not a pass.\n- `@target-uri` canonicalization applies no UTS-46 A-label conversion, drops a trailing empty query, and accepts five malformed authority shapes the spec requires be rejected.\n","author":{"url":"https://github.com/KonstantinMirin","@type":"Person","name":"KonstantinMirin"},"datePublished":"2026-07-28T20:32:36Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/975"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f9756e17-6c6c-ee68-684f-9fbba7234a6f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBE5E:27D3AD:1E044A0:2611B5D:6B015F50
html-safe-noncef7762e11ddd6e55df126e1df368112be4a21e04d1b5097b98b14bdfc96fb691a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTVFOjI3RDNBRDoxRTA0NEEwOjI2MTFCNUQ6NkIwMTVGNTAiLCJ2aXNpdG9yX2lkIjoiNjEwMTc4NDM2NjE5MzY2MzgyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbef0257f2083bc3fb679e820bc7536fbb4ea0e64951bb89335e5a101646041d4
hovercard-subject-tagissue:5002745018
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/975/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5b1f3657e37448726ed94f7df9206cf83daef61924b470fdfcabcd790c894361/adcontextprotocol/adcp-client-python/issues/975
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5b1f3657e37448726ed94f7df9206cf83daef61924b470fdfcabcd790c894361/adcontextprotocol/adcp-client-python/issues/975
og:image:altSummary The vendored AdCP request-signing conformance vectors under tests/conformance/vectors/request-signing/ are an incomplete copy of the spec set, and the tests that grade against them are stru...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKonstantinMirin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/975#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F975
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F975
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/975
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/975
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/975
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/975
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/975
#980https://github.com/adcontextprotocol/adcp-client-python/pull/980
Vendored request-signing conformance vectors are incomplete, and the loaders cannot detect ithttps://github.com/adcontextprotocol/adcp-client-python/issues/975#top
#980https://github.com/adcontextprotocol/adcp-client-python/pull/980
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/975#issue-5002745018
#980https://github.com/adcontextprotocol/adcp-client-python/pull/980
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/975#event-28622195604
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/975#issuecomment-5109409961
Verifier does not reject malformed structured-field input at step 1 (wrong error code; covered-component smuggling) #976https://github.com/adcontextprotocol/adcp-client-python/issues/976
@target-uri canonicalization applies no IDNA A-label conversion, and the verifier does not reject raw U-labels #977https://github.com/adcontextprotocol/adcp-client-python/issues/977
https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}https://claude.ai/code/$%7BCLAUDE_CODE_REMOTE_SESSION_ID%7D
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Jul 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/975#event-28622349133
KonstantinMirinhttps://github.com/KonstantinMirin
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/975#event-28661933753
test(signing): re-pin the vendored vectors at AdCP 3.1.8https://github.com/KonstantinMirin/adcp-client-python/commit/d719b5c69d03d30e45bb0beceb7524c61afbcbb1
d719b5chttps://github.com/KonstantinMirin/adcp-client-python/commit/d719b5c69d03d30e45bb0beceb7524c61afbcbb1
fix(signing): preserve a trailing empty query in @target-urihttps://github.com/KonstantinMirin/adcp-client-python/commit/e8bd78feef63446ffbca466b3e5cf69e4c6b2f68
e8bd78fhttps://github.com/KonstantinMirin/adcp-client-python/commit/e8bd78feef63446ffbca466b3e5cf69e4c6b2f68
fix(signing): preserve a trailing empty query in @target-urihttps://github.com/KonstantinMirin/adcp-client-python/commit/d6f7cb25e019d0fdc84529b930688938b655314e
d6f7cb2https://github.com/KonstantinMirin/adcp-client-python/commit/d6f7cb25e019d0fdc84529b930688938b655314e
fix(signing): preserve a trailing empty query in @target-urihttps://github.com/KonstantinMirin/adcp-client-python/commit/c2808a00ef59ac63e78b008d52fbee557019688b
c2808a0https://github.com/KonstantinMirin/adcp-client-python/commit/c2808a00ef59ac63e78b008d52fbee557019688b
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#980https://github.com/adcontextprotocol/adcp-client-python/pull/980
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/975#event-28688914021
bokelleyhttps://github.com/bokelley
on Jul 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/975#event-28688914109
test(signing): vendor the complete AdCP 3.1.8 request-signing vector …https://github.com/adcontextprotocol/adcp-client-python/commit/cbcd4c3f57ff9a458c6d94c9e610ca1ec8ea9d2a
cbcd4c3https://github.com/adcontextprotocol/adcp-client-python/commit/cbcd4c3f57ff9a458c6d94c9e610ca1ec8ea9d2a
fix(signing): preserve a trailing empty query in @target-urihttps://github.com/KonstantinMirin/adcp-client-python/commit/64bfd6d4a8440d8e2c5792e58b702e3b57f77ada
64bfd6dhttps://github.com/KonstantinMirin/adcp-client-python/commit/64bfd6d4a8440d8e2c5792e58b702e3b57f77ada
fix(signing): preserve a trailing empty query in @target-uri (#987)https://github.com/adcontextprotocol/adcp-client-python/commit/afa0454598320a118f8753b79737f0a320b7afe2
#987https://github.com/adcontextprotocol/adcp-client-python/pull/987
afa0454https://github.com/adcontextprotocol/adcp-client-python/commit/afa0454598320a118f8753b79737f0a320b7afe2
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/975
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/975
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.