René's URL Explorer Experiment


Title: types: 66 silent name collisions in adcp.types / _generated.py — adopters can't safely migrate off generated_poc · Issue #911 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: types: 66 silent name collisions in adcp.types / _generated.py — adopters can't safely migrate off generated_poc · Issue #911 · adcontextprotocol/adcp-client-python

X Title: types: 66 silent name collisions in adcp.types / _generated.py — adopters can't safely migrate off generated_poc · Issue #911 · adcontextprotocol/adcp-client-python

Description: Problem consolidate_exports.py flattens all generated_poc/ types into _generated.py using first-seen-wins (alphabetical sort). When multiple JSON schemas define a type with the same name, one class silently shadows the others. adcp.types...

Open Graph Description: Problem consolidate_exports.py flattens all generated_poc/ types into _generated.py using first-seen-wins (alphabetical sort). When multiple JSON schemas define a type with the same name, one class...

X Description: Problem consolidate_exports.py flattens all generated_poc/ types into _generated.py using first-seen-wins (alphabetical sort). When multiple JSON schemas define a type with the same name, one class...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/911

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"types: 66 silent name collisions in adcp.types / _generated.py — adopters can't safely migrate off generated_poc","articleBody":"## Problem\n\n`consolidate_exports.py` flattens all `generated_poc/` types into `_generated.py` using first-seen-wins (alphabetical sort). When multiple JSON schemas define a type with the same name, one class silently shadows the others. `adcp.types.__init__.py` re-exports from `_generated`, so `from adcp.types import X` may resolve to a different class than the adopter had from their deep `generated_poc` import.\n\nThe migration guide and codemod tell adopters \"import from `adcp.types` (stable public API) instead\", but for **66 type names** this advice silently swaps the underlying class.\n\n## Concrete examples (verified with `is` identity checks)\n\n| Symbol | `adcp.types` resolves to | Adopter likely needs | Fields match? |\n|--------|-------------------------|---------------------|---------------|\n| `Brand` | `protocol.get_adcp_capabilities_response` | `brand` (identity, with `names`, `logos`, etc.) | No — 5 vs 80+ fields |\n| `Creative` | `creative.get_creative_delivery_response` | `creative.list_creatives_response` | No — 6 vs 17+ fields |\n| `Account` | `core.account` | `account.sync_accounts_request` OR `sync_accounts_response` (3 different classes) | No |\n| `Sort` | `core.tasks_list_request` | `creative.list_creatives_request` | No |\n| `Authentication` | `account.sync_governance_request` | `core.push_notification_config` | No |\n| `Unit` | `enums.dimension_unit` | `core.duration` | No |\n| `MediaBuy` | `core.media_buy` | `protocol.get_adcp_capabilities_response` (for capabilities) | No |\n| `GovernanceAgent` | `account.sync_governance_request` | `core.account` | No |\n| `CreditLimit` | `account.sync_accounts_response` | `core.account` | No |\n\nFull list: 66 different-shape collisions across non-bundled modules. Only 5 names are in `known_collisions`; the remaining 61 are unhandled.\n\n## Impact on adopters\n\nsalesagent (first production adopter) has 85 `generated_poc` deep imports across 43 files. Following the migration guide, we attempted to rewrite all of them to `adcp.types`. The result:\n- ~40% were safe (class identity preserved)\n- ~60% silently swapped classes — code compiled, ruff passed, but mypy caught type mismatches for some; others would have been silent runtime bugs\n- The `GENERATED_POC_SYMBOL_MAP` in the codemod only covers 8 symbols; lines 148-157 of `v3_to_v4.py` acknowledge the problem for CreditLimit/Setup/GovernanceAgent but defer resolution\n\nThe current workaround (documented in `extending-types.md` via #644) is to import from the specific submodule. This is correct but means **the migration guide's primary advice is unsafe for most types**.\n\n## Proposed fix\n\n### Step 1: Make collisions loud (safety net)\n\nIn `consolidate_exports.py`, add a `collision_resolution` dict. Any collision not in `known_collisions` or `collision_resolution` **fails the build**. This prevents new silent collisions and forces explicit decisions on existing ones. ~50 lines.\n\n### Step 2: Add semantic aliases to `aliases.py`\n\nFor the 66 colliding names, add disambiguated aliases that adopters can import safely:\n\n```python\n# aliases.py additions\nfrom adcp.types.generated_poc.brand import Brand as BrandIdentity\nfrom adcp.types.generated_poc.creative.list_creatives_response import Creative as ListingCreative\nfrom adcp.types.generated_poc.creative.get_creative_delivery_response import Creative as DeliveryCreative\nfrom adcp.types.generated_poc.creative.sync_creatives_response import Creative as SyncCreativeResult\n# ... etc.\n```\n\nThis can be done incrementally — start with the high-impact names above and expand as adopters report needs.\n\n### Step 3: Expand the codemod's per-symbol map\n\nAdd source-module metadata to `GENERATED_POC_SYMBOL_MAP` so `--auto-apply` can generate precise rewrites instead of the generic \"import from adcp.types\" hint.\n\n## Relation to existing work\n\n- #642 (closed as \"not actionable on SDK side\") — this proposes the actionable SDK-side fix\n- #710 (SchemaVariant) — solves the mypy noise but not the silent-swap problem\n- adcontextprotocol/adcp#4347 (spec-level rename, milestoned to 4.0) — the long-term fix; this issue is the SDK-side mitigation until that lands","author":{"url":"https://github.com/KonstantinMirin","@type":"Person","name":"KonstantinMirin"},"datePublished":"2026-06-04T15:25:19Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/911"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d2e37dd5-9f84-d098-dd78-c784a2a4fd0b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id81CC:229B2E:B37456:EEC8AC:6B00ED44
html-safe-nonce8cda63360c4bffacf3bd181d640c5c280713b2b1736c5b46502c2045d741aa52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUNDOjIyOUIyRTpCMzc0NTY6RUVDOEFDOjZCMDBFRDQ0IiwidmlzaXRvcl9pZCI6IjUyNTQ1OTkyNDQyNDEyNTc2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace8bdb91c259cd8b49d8876f9e95398861dd259c4bf560ae7d7e5e068e803edd3
hovercard-subject-tagissue:4589944245
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/911/issue_layout
twitter:imagehttps://opengraph.githubassets.com/da1f018088f6688aad7cf4511cc150900389b4dbfc0cc73dbe291785fc9b40f4/adcontextprotocol/adcp-client-python/issues/911
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/da1f018088f6688aad7cf4511cc150900389b4dbfc0cc73dbe291785fc9b40f4/adcontextprotocol/adcp-client-python/issues/911
og:image:altProblem consolidate_exports.py flattens all generated_poc/ types into _generated.py using first-seen-wins (alphabetical sort). When multiple JSON schemas define a type with the same name, one class...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKonstantinMirin
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/911#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F911
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F911
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/911
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/911
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/911
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests12 (12)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/911
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/911
types: 66 silent name collisions in adcp.types / _generated.py — adopters can't safely migrate off generated_pochttps://github.com/adcontextprotocol/adcp-client-python/issues/911#top
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/KonstantinMirin
KonstantinMirinhttps://github.com/KonstantinMirin
on Jun 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#issue-4589944245
#644https://github.com/adcontextprotocol/adcp-client-python/pull/644
fix(types): codegen multi-emission of Creative/Package/etc. breaks Sequence covariant override on required response fields #642https://github.com/adcontextprotocol/adcp-client-python/issues/642
feat(types): cross-class entity overrides on response schemas — Protocol bounds or Generic response types #710https://github.com/adcontextprotocol/adcp-client-python/issues/710
spec: rename context-specific schema variants (Creative, Package, MediaBuy, Deployment, Geo*Exclude*) to disambiguate adcp#4347https://github.com/adcontextprotocol/adcp/issues/4347
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Jun 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#event-26344082675
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Jun 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#issuecomment-4623663653
https://claude.ai/code/session_017gMkfzjSe563dgR3Xde2Hhhttps://claude.ai/code/session_017gMkfzjSe563dgR3Xde2Hh
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Jun 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#event-26344337973
bokelleyhttps://github.com/bokelley
on Jun 6, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#event-26427247279
feat(codegen): fail consolidate on unallowlisted name collisionshttps://github.com/adcontextprotocol/adcp-client-python/commit/9722daa6465d2b9b02f6a4149261b13c192d6c48
9722daahttps://github.com/adcontextprotocol/adcp-client-python/commit/9722daa6465d2b9b02f6a4149261b13c192d6c48
feat(codegen): fail consolidate on unallowlisted name collisions (#919)https://github.com/adcontextprotocol/adcp-client-python/commit/d9367a0b20d2884146f207b13b11e3a0820911a8
#919https://github.com/adcontextprotocol/adcp-client-python/pull/919
d9367a0https://github.com/adcontextprotocol/adcp-client-python/commit/d9367a0b20d2884146f207b13b11e3a0820911a8
feat(types): disambiguated aliases for high-traffic colliding type na…https://github.com/adcontextprotocol/adcp-client-python/commit/6c058f03f8bbbd791774d9599d3713883b643a51
6c058f0https://github.com/adcontextprotocol/adcp-client-python/commit/6c058f03f8bbbd791774d9599d3713883b643a51
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Aug 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#issuecomment-5326127800
#911https://github.com/adcontextprotocol/adcp-client-python/issues/911
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Aug 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#event-29609426292
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Aug 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#issuecomment-5326192535
@bokelleyhttps://github.com/bokelley
https://claude.ai/code/session_01Uv22f5QvnqwZNhn26gRcARhttps://claude.ai/code/session_01Uv22f5QvnqwZNhn26gRcAR
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Aug 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#event-29609639570
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Aug 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#issuecomment-5327995645
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Aug 19, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#issuecomment-5340968332
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
on Aug 19, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#event-29676417614
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Aug 19, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#issuecomment-5341003283
https://claude.ai/code/session_013tiz5LYHBctdEB8hSxk9Uxhttps://claude.ai/code/session_013tiz5LYHBctdEB8hSxk9Ux
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Aug 19, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#event-29676433358
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Aug 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#issuecomment-5351609342
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Aug 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#event-29723183042
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Aug 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#issuecomment-5351624839
@bokelleyhttps://github.com/bokelley
https://claude.ai/code/session_014aE1zU8bCmXbtktUAkzLimhttps://claude.ai/code/session_014aE1zU8bCmXbtktUAkzLim
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Aug 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#event-29723198295
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Aug 24, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#issuecomment-5391914046
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 24, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/911#event-29897194140
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/911
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/911
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.