Title: release-please writes SemVer (not PEP 440) to pyproject.toml on prerelease bumps · Issue #830 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: release-please writes SemVer (not PEP 440) to pyproject.toml on prerelease bumps · Issue #830 · adcontextprotocol/adcp-client-python
X Title: release-please writes SemVer (not PEP 440) to pyproject.toml on prerelease bumps · Issue #830 · adcontextprotocol/adcp-client-python
Description: What happened Release-please's Python release-type writes the raw SemVer version string to pyproject.toml's [project] version field, with no PEP 440 normalization for prerelease versions. Observed on #817 (the v6.0.0-beta.1 release PR): ...
Open Graph Description: What happened Release-please's Python release-type writes the raw SemVer version string to pyproject.toml's [project] version field, with no PEP 440 normalization for prerelease versions. Observed ...
X Description: What happened Release-please's Python release-type writes the raw SemVer version string to pyproject.toml's [project] version field, with no PEP 440 normalization for prerelease versions. O...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/830
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"release-please writes SemVer (not PEP 440) to pyproject.toml on prerelease bumps","articleBody":"## What happened\n\nRelease-please's Python release-type writes the raw SemVer version string to `pyproject.toml`'s `[project] version` field, with no PEP 440 normalization for prerelease versions.\n\nObserved on #817 (the v6.0.0-beta.1 release PR):\n\n\\`\\`\\`\n-version = \"5.7.0\"\n+version = \"6.0.0-beta.1\" ← invalid PEP 440; PyPI rejects\n\\`\\`\\`\n\nExpected: `version = \"6.0.0b1\"` (PEP 440 form).\n\nWorked around by hand-editing the release PR in commit `3e0f7e17` before merging, but the next prerelease bump will reproduce the same bug and need the same hand-edit. Need a permanent fix.\n\n## Background\n\nThe aao-ipr-bot flagged this on #804 ([review comment](https://github.com/adcontextprotocol/adcp-client-python/pull/804#pullrequestreview-...)). At the time we believed dropping the generic JSON `extra-files` updater would let the Python release-type's native `pyproject.toml` updater handle the conversion. That turned out to be wrong — the native updater also writes the raw SemVer string.\n\n## Options for a permanent fix\n\n1. **Custom updater via `extra-files`.** Use an `extra-files` entry with `type: \"generic\"` or `type: \"python\"` (if such a type exists in release-please's schema) that knows PEP 440. Worth checking release-please's docs for a Python-aware pyproject.toml updater.\n2. **Post-bump GitHub Action.** Add a step to the release-please workflow that runs after release-please opens/updates the release PR and normalizes the version. Cheap to write but adds a moving part.\n3. **Upstream fix in release-please.** File against `googleapis/release-please` — this looks like a real bug in the Python strategy. Risky from a timeline perspective.\n4. **Switch off the prerelease line.** Cut 6.0.0 GA without intermediate betas (won't work — we explicitly need beta testing on salesagent before GA).\n\nI'd lean toward (2) as the immediate path and file (3) in parallel.\n\n## Acceptance\n\n- [ ] Next prerelease bump (6.0.0-beta.2, etc.) produces `version = \"6.0.0b2\"` in pyproject.toml automatically, no hand-edit required.\n- [ ] Stable version bumps still work (e.g., a future 6.0.0 GA cut produces `version = \"6.0.0\"`).\n\n## Refs\n\n- Surfaced on: #817 (release PR for v6.0.0-beta.1)\n- Config history: #802 (initial 6.0-beta config), #804 (extra-files removal that didn't fix it)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-23T13:13:46Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/830"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6de0ba1d-b819-c2f3-4b57-6d5c4e846966 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C732:2652DC:1335DC6:189C18B:6B01122B |
| html-safe-nonce | 95912ae6a56ea88d64c3fa6f794448f97c5eb91e06783d0502300b8675fc09a4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzMyOjI2NTJEQzoxMzM1REM2OjE4OUMxOEI6NkIwMTEyMkIiLCJ2aXNpdG9yX2lkIjoiNzk1Mzc0MDczMzQxOTE2NDIwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0b947c7def7b003ad53d01d0cdde83715458e37535066e1ce49a11611ccc359d |
| hovercard-subject-tag | issue:4508263311 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/830/issue_layout |
| twitter:image | https://opengraph.githubassets.com/040dce10e1bfe125fc964a0325ed76e139187745f651c6f8227ba405ec20a9ec/adcontextprotocol/adcp-client-python/issues/830 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/040dce10e1bfe125fc964a0325ed76e139187745f651c6f8227ba405ec20a9ec/adcontextprotocol/adcp-client-python/issues/830 |
| og:image:alt | What happened Release-please's Python release-type writes the raw SemVer version string to pyproject.toml's [project] version field, with no PEP 440 normalization for prerelease versions. Observed ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width