Title: chore(ci): freeze reference seller fixture for cross-SDK interop per adcp#4907 Phase 1 · Issue #779 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: chore(ci): freeze reference seller fixture for cross-SDK interop per adcp#4907 Phase 1 · Issue #779 · adcontextprotocol/adcp-client-python
X Title: chore(ci): freeze reference seller fixture for cross-SDK interop per adcp#4907 Phase 1 · Issue #779 · adcontextprotocol/adcp-client-python
Description: Background Tracks the consumer-side of adcontextprotocol/adcp#4907 Phase 1 — the @adcp/sdk repo will start running its storyboard suite against this Python SDK's reference seller before tagging releases. Today's examples/seller_agent.py ...
Open Graph Description: Background Tracks the consumer-side of adcontextprotocol/adcp#4907 Phase 1 — the @adcp/sdk repo will start running its storyboard suite against this Python SDK's reference seller before tagging rel...
X Description: Background Tracks the consumer-side of adcontextprotocol/adcp#4907 Phase 1 — the @adcp/sdk repo will start running its storyboard suite against this Python SDK's reference seller before tagging...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/779
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"chore(ci): freeze reference seller fixture for cross-SDK interop per adcp#4907 Phase 1","articleBody":"## Background\n\nTracks the consumer-side of adcontextprotocol/adcp#4907 Phase 1 — the `@adcp/sdk` repo will start running its storyboard suite against this Python SDK's reference seller before tagging releases.\n\nToday's `examples/seller_agent.py` evolves freely as a demo and is **not stable enough to be a contract test fixture**. For Phase 1 to be useful (rather than a constant friction generator), this SDK needs to commit to a stable reference target.\n\nThis issue owns the consumer-side fixture and CI-hygiene work.\n\n## Scope\n\n### Track A — reference target stability\n\nPick one of:\n\n1. **Freeze `examples/seller_agent.py`.** Treat the example as a semver'd compliance fixture — changes require a PR-level conformance review, and breaking changes ship under a tagged release that `@adcp/sdk` can pin.\n2. **Extract a separate `tests/fixtures/reference_seller.py`.** The demo example stays free-evolving; a parallel fixture serves as the frozen contract target. More files to maintain but cleaner separation.\n\nOption 1 is lower-friction now; Option 2 scales better long-term. Pending adcp#4907 Open Q #1 — wait for that to settle, then implement here.\n\n### Track B — CI cache hygiene (fix forward today, regardless of #4907 outcome)\n\nCurrent npm cache key in `.github/workflows/ci.yml` is `\\${{ runner.os }}-npm-adcp-sdk` — OS-only, no version salt. Once a stale `@adcp/sdk@latest` lands in a runner cache, every subsequent run sees the stale version. Today's red CI is partly caused by this.\n\nFix in this issue:\n\n1. Pin `@adcp/sdk` to an explicit version in the workflow (no more `@latest`).\n2. Salt the cache key with the pinned version: `\\${{ runner.os }}-npm-adcp-sdk-\\${{ env.ADCP_SDK_VERSION }}`.\n3. Add a `dependabot.yml` rule (or equivalent) to surface SDK version bumps as PRs that explicitly re-run interop tests.\n\n## Out of scope\n\n- The actual interop workflow on `@adcp/sdk`'s side — that's adcontextprotocol/adcp-client#XXXX (filed alongside this).\n- Storyboard scenario authoring — those live in `@adcp/sdk`.\n\n## Acceptance\n\n- [ ] adcp#4907 Open Q #1 resolved; Track A implemented per that resolution.\n- [ ] Track B: cache key salted; `@adcp/sdk` version pinned explicitly.\n- [ ] CI run on a deliberate stale-cache simulation confirms it now invalidates correctly.\n- [ ] One concrete cross-stack test run linked here showing `@adcp/sdk`'s pre-release CI catches a deliberate impl-vs-scenario break.\n\n## References\n\n- Primary RFC: adcontextprotocol/adcp#4907\n- TS-side companion: adcontextprotocol/adcp-client#XXXX (to be cross-linked once filed)\n- Trigger: today's storyboard CI red from stale `@adcp/sdk` cache (see adcp#4907 §Concrete trigger)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-21T16:37:18Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/779"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:42bdd9fc-954d-b665-eca9-e617117382fc |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DB2E:38E318:759AC:94502:6B00F526 |
| html-safe-nonce | 37e5d75ce3158b98c622b7663cb86d8a52bc23d35b548cc57ccaf7f79ec9fc15 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjJFOjM4RTMxODo3NTlBQzo5NDUwMjo2QjAwRjUyNiIsInZpc2l0b3JfaWQiOiI3OTUzNTU3NzgwNjk3MjQ5MDYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 616105f7689fc37474164288a487e2a0e620c1eb37cccea37c963dc62934b14f |
| hovercard-subject-tag | issue:4496314023 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/779/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1be0302d3473632fb1c786a31d59c7533d5a58615135a9208139f4bd3cce3713/adcontextprotocol/adcp-client-python/issues/779 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1be0302d3473632fb1c786a31d59c7533d5a58615135a9208139f4bd3cce3713/adcontextprotocol/adcp-client-python/issues/779 |
| og:image:alt | Background Tracks the consumer-side of adcontextprotocol/adcp#4907 Phase 1 — the @adcp/sdk repo will start running its storyboard suite against this Python SDK's reference seller before tagging rel... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width