René's URL Explorer Experiment


Title: Plumb 'source' discriminant through BrandJsonJwksResolver for key_origins publisher-pin carve-out · Issue #776 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Plumb 'source' discriminant through BrandJsonJwksResolver for key_origins publisher-pin carve-out · Issue #776 · adcontextprotocol/adcp-client-python

X Title: Plumb 'source' discriminant through BrandJsonJwksResolver for key_origins publisher-pin carve-out · Issue #776 · adcontextprotocol/adcp-client-python

Description: Context ADCP #3690 security.mdx step 7 specifies the identity.key_origins consistency check is mandatory when the JWKS source was the operator brand.json and skipped for the specific (agent, purpose, role) tuple whose JWKS source was a p...

Open Graph Description: Context ADCP #3690 security.mdx step 7 specifies the identity.key_origins consistency check is mandatory when the JWKS source was the operator brand.json and skipped for the specific (agent, purpos...

X Description: Context ADCP #3690 security.mdx step 7 specifies the identity.key_origins consistency check is mandatory when the JWKS source was the operator brand.json and skipped for the specific (agent, purpos...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/776

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Plumb 'source' discriminant through BrandJsonJwksResolver for key_origins publisher-pin carve-out","articleBody":"## Context\n\nADCP #3690 security.mdx step 7 specifies the ``identity.key_origins`` consistency check is **mandatory when the JWKS source was the operator brand.json** and **skipped for the specific (agent, purpose, role) tuple whose JWKS source was a publisher ``adagents.json signing_keys`` pin**.\n\nThe check primitive landed in #775 as ``adcp.signing.check_key_origin_consistency()``. It takes no ``source`` parameter — the docstring puts the carve-out on the caller. That's correct for the primitive, but Stage 5 needs the actual plumbing so the verifier integration can branch on the source.\n\n## What's missing\n\n``BrandJsonJwksResolver`` (and the upcoming verifier integration) need to expose **which side** of the chain resolved a given ``kid`` → JWK pair:\n\n- **brand_json source** — the JWKS was fetched via brand.json's ``agents[].jwks_uri``. Consistency check applies.\n- **publisher_pin source** — the JWKS was fetched via a publisher's ``adagents.json signing_keys`` pin. Consistency check **must be skipped** for this tuple, otherwise legitimate publisher-pinned keys are wrongly rejected.\n\n## Acceptance\n\n1. ``BrandJsonJwksResolver`` (or an adjacent type) exposes the source per resolved key — proposed shape: a new ``ResolvedKey`` dataclass returned alongside or in place of the bare JWK dict, with a ``source: Literal['brand_json', 'publisher_pin']`` discriminant.\n2. The verifier integration in Stage 5 reads ``source`` and gates the call to ``check_key_origin_consistency``: call it on ``brand_json``, skip on ``publisher_pin``.\n3. Conformance test exercises both sources end-to-end — brand-json-sourced mismatch raises ``request_signature_key_origin_mismatch``, publisher-pin-sourced mismatch does NOT raise (since the check is skipped).\n\n## Why now (Stage 5, not later)\n\nWithout this, Stage 5's wire-up either (a) calls the check unconditionally and rejects legitimate publisher-pinned keys, or (b) silently never calls the check, leaving the operator-brand-json side unenforced. Either way breaks #3690 conformance.\n\n## References\n\n- ADCP #3690 ``docs/building/by-layer/L1/security.mdx`` step 7\n- adcp-client-python #775 (key_origins helper landed here)\n- adcp-client-python #770 (BrandAuthorizationResolver landed here; same chain)\n- Issue #350 (the parent v3-identity roadmap; this is Stage 5 scope)\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-21T16:07:51Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/776"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5bdb428e-a6a7-9350-c2c1-4c13d3a9cefe
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD076:7A60E:D64ED4:1156B70:6B00F695
html-safe-nonce8ce807ad9983c8c98f4b71fa5b2be1afcaf72633455a74615fafb70441bf46b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDc2OjdBNjBFOkQ2NEVENDoxMTU2QjcwOjZCMDBGNjk1IiwidmlzaXRvcl9pZCI6IjEyOTQwNjgzMDk0MzU2NzYzMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5d9113e140f04a492c78f49e814398079ec1a57337fc11305f0ff1add0f84a0
hovercard-subject-tagissue:4496112177
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/776/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ee1e11036ecd67cd525d885b68067afcdf7f74f581030f22ca9df816cb4d37d5/adcontextprotocol/adcp-client-python/issues/776
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ee1e11036ecd67cd525d885b68067afcdf7f74f581030f22ca9df816cb4d37d5/adcontextprotocol/adcp-client-python/issues/776
og:image:altContext ADCP #3690 security.mdx step 7 specifies the identity.key_origins consistency check is mandatory when the JWKS source was the operator brand.json and skipped for the specific (agent, purpos...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/776#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F776
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F776
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/776
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/776
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/776
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/776
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/776
#751https://github.com/adcontextprotocol/adcp-client-python/pull/751
Plumb 'source' discriminant through BrandJsonJwksResolver for key_origins publisher-pin carve-outhttps://github.com/adcontextprotocol/adcp-client-python/issues/776#top
#751https://github.com/adcontextprotocol/adcp-client-python/pull/751
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 21, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/776#issue-4496112177
#775https://github.com/adcontextprotocol/adcp-client-python/pull/775
feat(signing): key_origins check + brand.json chain error codes (#350 stage 4) #775https://github.com/adcontextprotocol/adcp-client-python/pull/775
feat(signing): BrandAuthorizationResolver (Tier 3, #350 stages 1-3) #770https://github.com/adcontextprotocol/adcp-client-python/pull/770
feat(signing): BrandAuthorizationResolver — per-brand agent authorization (Tier 3, gated on ADCP #3690) #350https://github.com/adcontextprotocol/adcp-client-python/issues/350
Claude Codehttps://claude.com/claude-code
bokelleyhttps://github.com/bokelley
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 21, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/776#event-25813478166
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 21, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/776#issuecomment-4510205658
#775https://github.com/adcontextprotocol/adcp-client-python/pull/775
#776https://github.com/adcontextprotocol/adcp-client-python/issues/776
#775https://github.com/adcontextprotocol/adcp-client-python/pull/775
#775https://github.com/adcontextprotocol/adcp-client-python/pull/775
#775https://github.com/adcontextprotocol/adcp-client-python/pull/775
#775https://github.com/adcontextprotocol/adcp-client-python/pull/775
https://claude.ai/code/session_01ES8anyj4MSMcq1n5TAL9RYhttps://claude.ai/code/session_01ES8anyj4MSMcq1n5TAL9RY
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 21, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/776#event-25813609560
bokelleyhttps://github.com/bokelley
on May 21, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/776#event-25825706390
feat(decisioning): Tier 3 brand-authz dispatch gate (#350 stage 5)https://github.com/adcontextprotocol/adcp-client-python/commit/c1cf90b1bef9b1383ab6fd93baf048352bd1afc1
#350https://github.com/adcontextprotocol/adcp-client-python/issues/350
c1cf90bhttps://github.com/adcontextprotocol/adcp-client-python/commit/c1cf90b1bef9b1383ab6fd93baf048352bd1afc1
feat(decisioning): Tier 3 brand-authz dispatch gate (#350 stage 5, cl…https://github.com/adcontextprotocol/adcp-client-python/commit/1ad6df907c5b81c98f079900cb8adf394bc6cbb1
#350https://github.com/adcontextprotocol/adcp-client-python/issues/350
1ad6df9https://github.com/adcontextprotocol/adcp-client-python/commit/1ad6df907c5b81c98f079900cb8adf394bc6cbb1
feat(signing): plumb identity.key_origins check through verifier (closeshttps://github.com/adcontextprotocol/adcp-client-python/commit/b14808274db9046ed259e0d82dc51b00355ffb81
b148082https://github.com/adcontextprotocol/adcp-client-python/commit/b14808274db9046ed259e0d82dc51b00355ffb81
fix(signing): address #789 review — CVE pin + verify_from_agent_url w…https://github.com/adcontextprotocol/adcp-client-python/commit/66b17de337f8b69b5b5a6dbe43de3c38ac0b7328
#789https://github.com/adcontextprotocol/adcp-client-python/pull/789
66b17dehttps://github.com/adcontextprotocol/adcp-client-python/commit/66b17de337f8b69b5b5a6dbe43de3c38ac0b7328
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
31354b4https://github.com/adcontextprotocol/adcp-client-python/commit/31354b4d813116d55e255c2b5f28fa599a09b0e7
on May 22, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/776#event-25849203780
bokelleyhttps://github.com/bokelley
on May 22, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/776#event-25849204216
feat(signing): verifier key_origins check + IDNA-2008 canonicalization (https://github.com/adcontextprotocol/adcp-client-python/commit/31354b4d813116d55e255c2b5f28fa599a09b0e7
https://docs.github.com/articles/closing-issues-via-commit-messages
31354b4https://github.com/adcontextprotocol/adcp-client-python/commit/31354b4d813116d55e255c2b5f28fa599a09b0e7
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/776
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/776
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.