Title: Plumb 'source' discriminant through BrandJsonJwksResolver for key_origins publisher-pin carve-out · Issue #776 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: Plumb 'source' discriminant through BrandJsonJwksResolver for key_origins publisher-pin carve-out · Issue #776 · adcontextprotocol/adcp-client-python
X Title: Plumb 'source' discriminant through BrandJsonJwksResolver for key_origins publisher-pin carve-out · Issue #776 · adcontextprotocol/adcp-client-python
Description: Context ADCP #3690 security.mdx step 7 specifies the identity.key_origins consistency check is mandatory when the JWKS source was the operator brand.json and skipped for the specific (agent, purpose, role) tuple whose JWKS source was a p...
Open Graph Description: Context ADCP #3690 security.mdx step 7 specifies the identity.key_origins consistency check is mandatory when the JWKS source was the operator brand.json and skipped for the specific (agent, purpos...
X Description: Context ADCP #3690 security.mdx step 7 specifies the identity.key_origins consistency check is mandatory when the JWKS source was the operator brand.json and skipped for the specific (agent, purpos...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/776
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Plumb 'source' discriminant through BrandJsonJwksResolver for key_origins publisher-pin carve-out","articleBody":"## Context\n\nADCP #3690 security.mdx step 7 specifies the ``identity.key_origins`` consistency check is **mandatory when the JWKS source was the operator brand.json** and **skipped for the specific (agent, purpose, role) tuple whose JWKS source was a publisher ``adagents.json signing_keys`` pin**.\n\nThe check primitive landed in #775 as ``adcp.signing.check_key_origin_consistency()``. It takes no ``source`` parameter — the docstring puts the carve-out on the caller. That's correct for the primitive, but Stage 5 needs the actual plumbing so the verifier integration can branch on the source.\n\n## What's missing\n\n``BrandJsonJwksResolver`` (and the upcoming verifier integration) need to expose **which side** of the chain resolved a given ``kid`` → JWK pair:\n\n- **brand_json source** — the JWKS was fetched via brand.json's ``agents[].jwks_uri``. Consistency check applies.\n- **publisher_pin source** — the JWKS was fetched via a publisher's ``adagents.json signing_keys`` pin. Consistency check **must be skipped** for this tuple, otherwise legitimate publisher-pinned keys are wrongly rejected.\n\n## Acceptance\n\n1. ``BrandJsonJwksResolver`` (or an adjacent type) exposes the source per resolved key — proposed shape: a new ``ResolvedKey`` dataclass returned alongside or in place of the bare JWK dict, with a ``source: Literal['brand_json', 'publisher_pin']`` discriminant.\n2. The verifier integration in Stage 5 reads ``source`` and gates the call to ``check_key_origin_consistency``: call it on ``brand_json``, skip on ``publisher_pin``.\n3. Conformance test exercises both sources end-to-end — brand-json-sourced mismatch raises ``request_signature_key_origin_mismatch``, publisher-pin-sourced mismatch does NOT raise (since the check is skipped).\n\n## Why now (Stage 5, not later)\n\nWithout this, Stage 5's wire-up either (a) calls the check unconditionally and rejects legitimate publisher-pinned keys, or (b) silently never calls the check, leaving the operator-brand-json side unenforced. Either way breaks #3690 conformance.\n\n## References\n\n- ADCP #3690 ``docs/building/by-layer/L1/security.mdx`` step 7\n- adcp-client-python #775 (key_origins helper landed here)\n- adcp-client-python #770 (BrandAuthorizationResolver landed here; same chain)\n- Issue #350 (the parent v3-identity roadmap; this is Stage 5 scope)\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-21T16:07:51Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/776"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5bdb428e-a6a7-9350-c2c1-4c13d3a9cefe |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D076:7A60E:D64ED4:1156B70:6B00F695 |
| html-safe-nonce | 8ce807ad9983c8c98f4b71fa5b2be1afcaf72633455a74615fafb70441bf46b3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDc2OjdBNjBFOkQ2NEVENDoxMTU2QjcwOjZCMDBGNjk1IiwidmlzaXRvcl9pZCI6IjEyOTQwNjgzMDk0MzU2NzYzMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f5d9113e140f04a492c78f49e814398079ec1a57337fc11305f0ff1add0f84a0 |
| hovercard-subject-tag | issue:4496112177 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/776/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ee1e11036ecd67cd525d885b68067afcdf7f74f581030f22ca9df816cb4d37d5/adcontextprotocol/adcp-client-python/issues/776 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ee1e11036ecd67cd525d885b68067afcdf7f74f581030f22ca9df816cb4d37d5/adcontextprotocol/adcp-client-python/issues/776 |
| og:image:alt | Context ADCP #3690 security.mdx step 7 specifies the identity.key_origins consistency check is mandatory when the JWKS source was the operator brand.json and skipped for the specific (agent, purpos... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width