Title: feat(adagents): apply revoked_publisher_domains to inline_properties branch · Issue #758 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: feat(adagents): apply revoked_publisher_domains to inline_properties branch · Issue #758 · adcontextprotocol/adcp-client-python
X Title: feat(adagents): apply revoked_publisher_domains to inline_properties branch · Issue #758 · adcontextprotocol/adcp-client-python
Description: Context PR #753 added revoked_publisher_domains[] at the top level of adagents.json (per adcp#4504), with the spec language: Validators MUST treat any publisher domain listed here as no-longer-authorized regardless of where else it appea...
Open Graph Description: Context PR #753 added revoked_publisher_domains[] at the top level of adagents.json (per adcp#4504), with the spec language: Validators MUST treat any publisher domain listed here as no-longer-auth...
X Description: Context PR #753 added revoked_publisher_domains[] at the top level of adagents.json (per adcp#4504), with the spec language: Validators MUST treat any publisher domain listed here as no-longer-auth...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/758
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(adagents): apply revoked_publisher_domains to inline_properties branch","articleBody":"## Context\n\nPR #753 added `revoked_publisher_domains[]` at the top level of `adagents.json` (per adcp#4504), with the spec language:\n\n> Validators MUST treat any publisher domain listed here as no-longer-authorized **regardless of where else it appears**.\n\nThe implementation (`src/adcp/adagents.py:filter_revoked_selectors`) applies revocation to:\n\n- `publisher_properties[]` selectors (cross-domain) — both the singular `publisher_domain` and the fanned-out compact form\n- top-level `properties[]` referenced by `property_ids` / `property_tags` authorization types\n\nIt does **not** apply revocation to the `inline_properties` branch — `_resolve_agent_properties` at `src/adcp/adagents.py:1100-1108` returns the agent's inline `properties[]` array unfiltered.\n\nThe round-1 protocol review on PR #753 flagged this:\n\n> revoked_publisher_domains description's \"any publisher domain listed here as no-longer-authorized regardless of where else it appears\" suggests revocation should also strip inline_properties entries whose publisher_domain matches. Confirm intent against the spec PR thread; if intended, add the filter to the inline_properties branch.\n\n## Question for spec discussion\n\n`inline_properties` represents the publisher's own properties directly authorized to a specific agent. Real-world payloads look like:\n\n```json\n{\n \"url\": \"https://agent.example\",\n \"authorization_type\": \"inline_properties\",\n \"properties\": [\n {\"publisher_domain\": \"cnn.com\", \"property_id\": \"...\"},\n {\"publisher_domain\": \"owned-and-operated.example\", \"property_id\": \"...\"}\n ]\n}\n```\n\nIf the **same** adagents.json declares `revoked_publisher_domains: [{publisher_domain: \"owned-and-operated.example\", revoked_at: ...}]`, should the resolver strip that property from the agent's inline list?\n\nThe literal spec text says yes. The practical interpretation is murkier — a publisher revoking its own domain in its own adagents.json is unusual, and inline_properties typically scope to the file's authoring publisher.\n\n## Action\n\n1. Confirm intent against the spec PR thread (adcp#4823 / adcp#4825 / adcp#4827 or the original #4504 thread).\n2. If revocation should also strip inline_properties:\n - Extend `filter_revoked_selectors` (or factor a sibling `filter_revoked_properties`) to filter Property objects by `publisher_domain` against the revoked set.\n - Wire it into the `inline_properties` branch of `_resolve_agent_properties`.\n - Add a test under `TestRevokedPublisherDomains` covering the case.\n3. If not, document the carve-out in the resolver docstring so the asymmetry is intentional and discoverable.\n\n## Out of scope\n\n- Property objects with `identifiers: [{type: \"domain\", ...}]` instead of `publisher_domain`. Whether identifier-typed revocation should chain through is a separate question.\n\n## Related\n\n- PR #753 (added the revoked_publisher_domains filter for two of the three branches)\n- adcp#4504 (the originating spec issue)\n- Round-1 protocol review on #753 — Should-fix #3","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-20T17:28:25Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/758"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:33a97270-0ddb-9285-b1bb-b306f12935ed |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AA76:229B2E:C9EC8A:10BF99C:6B00F508 |
| html-safe-nonce | 2add6b651f712c64fb078c43690e73733b6daca46d199e05bb1b9d25b8156830 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTc2OjIyOUIyRTpDOUVDOEE6MTBCRjk5Qzo2QjAwRjUwOCIsInZpc2l0b3JfaWQiOiI2MDY4NzQwMDczMjI5MTg2MzEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 11ece025fcea66c07127b2c04680a885fb6944e043379fdfe3ce60ed8e57acc3 |
| hovercard-subject-tag | issue:4488571233 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/758/issue_layout |
| twitter:image | https://opengraph.githubassets.com/22045d8da77b31e85b970f4755e8c8484eb11336cd5f7f04c95a9db43b7bde8f/adcontextprotocol/adcp-client-python/issues/758 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/22045d8da77b31e85b970f4755e8c8484eb11336cd5f7f04c95a9db43b7bde8f/adcontextprotocol/adcp-client-python/issues/758 |
| og:image:alt | Context PR #753 added revoked_publisher_domains[] at the top level of adagents.json (per adcp#4504), with the spec language: Validators MUST treat any publisher domain listed here as no-longer-auth... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width