Title: v3 ref seller: residual storyboard response-shape mismatches · Issue #706 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: v3 ref seller: residual storyboard response-shape mismatches · Issue #706 · adcontextprotocol/adcp-client-python
X Title: v3 ref seller: residual storyboard response-shape mismatches · Issue #706 · adcontextprotocol/adcp-client-python
Description: The v3 reference seller's storyboard runner job (added in #693, closes #410) now passes 19/25 active steps but reports overall_status: partial. The "Assert storyboard passed" gate was downgraded to continue-on-error: true in #693 so the ...
Open Graph Description: The v3 reference seller's storyboard runner job (added in #693, closes #410) now passes 19/25 active steps but reports overall_status: partial. The "Assert storyboard passed" gate was downgraded to...
X Description: The v3 reference seller's storyboard runner job (added in #693, closes #410) now passes 19/25 active steps but reports overall_status: partial. The "Assert storyboard passed" gate was...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/706
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"v3 ref seller: residual storyboard response-shape mismatches","articleBody":"The v3 reference seller's storyboard runner job (added in #693, closes #410)\nnow passes 19/25 active steps but reports `overall_status: partial`. The\n\"Assert storyboard passed\" gate was downgraded to `continue-on-error: true`\nin #693 so the anti-façade hard gates (\"Assert storyboard runner produced\noutput\" + \"Assert upstream traffic\") continue to fail the job, while the\nresidual response-shape mismatches don't.\n\nThis issue tracks lifting that flag once the four scenarios below pass.\n\n## Tracked residual failures\n\n1. **`media_buy_seller/refine_products/get_products_refine`** — upstream\n storyboard YAML bug: the runner sends `brief` in a refine request, which\n the seller correctly rejects with `INVALID_REQUEST`. Already covered by\n adcontextprotocol/adcp#702 — wait for that to land.\n\n2. **`media_buy_seller/pending_creatives_to_start/assign_creative_to_package`** —\n `update_media_buy` raises `PACKAGE_NOT_FOUND` because the seller mints\n `pkg_{order_id}_{idx}` package_ids on create, but the mock-server upstream\n stores no line_items, so the validation pass in\n `examples/v3_reference_seller/src/platform.py::update_media_buy`\n rejects them. Needs either: actually call `add_line_item` upstream after\n `create_order`, OR move package_id validation off the upstream line_items\n set (e.g., a local mapping table).\n\n3. **`media_buy_seller/inventory_list_targeting/get_after_create`** —\n `get_media_buys` returns `packages: []` for every buy, so the\n property_list / collection_list targeting echoed at create time is not\n readable back. Needs `get_media_buys` to project per-package state.\n\n4. **`media_buy_seller/invalid_transitions/first_cancel`** and\n **`media_buy_seller/creative_fate_after_cancellation/update_media_buy_canceled`** —\n both probe `update_media_buy` to cancel a buy; the seller returns\n `UNSUPPORTED_FEATURE` because the mock-server has no PATCH endpoint.\n Needs `update_media_buy` to support at least the `cancel`/`pause`\n operations against locally-persisted state.\n\n5. **`__spec_conformance__/account_discovery/list_or_sync_accounts`** —\n the seller advertises neither `list_accounts` nor `sync_accounts`. AdCP\n 3.0.9 §accounts/overview requires every seller agent to expose at least\n one of these. Covered by #377.\n\n## Out-of-scope dependencies\n\n- adcontextprotocol/adcp#702 (refine storyboard YAML)\n- #377 (sync_accounts / list_accounts on the v3 reference seller)\n\n## How to drop the soft gate\n\nOnce all five scenarios pass:\n\n1. Delete the \"Assert storyboard passed (soft)\" step in\n `.github/workflows/ci.yml`.\n2. Move the `overall_status == 'passing'` check back into \"Assert\n storyboard runner produced output\" (the hard gate).\n3. Remove the residual-failures comment.\n\nThe runner result JSON is uploaded as an artifact on every run, so the\nlanded-state of each scenario is auditable from the workflow artifacts\nlist.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-12T19:13:38Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/706"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c9b21a3f-dea4-9730-c19a-c8cb2958722d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AEFA:842EC:D0EE3E:1182543:6B01005F |
| html-safe-nonce | 8f641f6458999489a7c5177bd50fe9ff46ae122c0f1ff40c37b5f9f01bbfa157 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUZBOjg0MkVDOkQwRUUzRToxMTgyNTQzOjZCMDEwMDVGIiwidmlzaXRvcl9pZCI6Ijk0MTE5OTExMzU2NTgzMTI2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 29e6f55aa4f89748094d9b17d879a19343f7571c19fe953b77cb6ab060546724 |
| hovercard-subject-tag | issue:4431934559 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/706/issue_layout |
| twitter:image | https://opengraph.githubassets.com/965e63491e93ae3976a306124c58d8f489a90722f099f54e3e4446bafa00ae2c/adcontextprotocol/adcp-client-python/issues/706 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/965e63491e93ae3976a306124c58d8f489a90722f099f54e3e4446bafa00ae2c/adcontextprotocol/adcp-client-python/issues/706 |
| og:image:alt | The v3 reference seller's storyboard runner job (added in #693, closes #410) now passes 19/25 active steps but reports overall_status: partial. The "Assert storyboard passed" gate was downgraded to... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width