Title: bug(storyboard): media_buy_seller/refine_products/get_products_refine sends buying_mode='refine' with brief · Issue #702 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: bug(storyboard): media_buy_seller/refine_products/get_products_refine sends buying_mode='refine' with brief · Issue #702 · adcontextprotocol/adcp-client-python
X Title: bug(storyboard): media_buy_seller/refine_products/get_products_refine sends buying_mode='refine' with brief · Issue #702 · adcontextprotocol/adcp-client-python
Description: Surfaced by #693. Failure media_buy_seller/refine_products/get_products_refine [media_buy]: INVALID_REQUEST: buying_mode='refine' must not be combined with brief. The refine[] array drives iteration on a previous get_products response. W...
Open Graph Description: Surfaced by #693. Failure media_buy_seller/refine_products/get_products_refine [media_buy]: INVALID_REQUEST: buying_mode='refine' must not be combined with brief. The refine[] array drives iteratio...
X Description: Surfaced by #693. Failure media_buy_seller/refine_products/get_products_refine [media_buy]: INVALID_REQUEST: buying_mode='refine' must not be combined with brief. The refine[] array drives ...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/702
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"bug(storyboard): media_buy_seller/refine_products/get_products_refine sends buying_mode='refine' with brief","articleBody":"Surfaced by #693.\n\n## Failure\n\n```\nmedia_buy_seller/refine_products/get_products_refine [media_buy]:\n INVALID_REQUEST: buying_mode='refine' must not be combined with brief.\n The refine[] array drives iteration on a previous get_products response.\n```\n\n## What this says\n\nThe storyboard step `get_products_refine` is constructing a `get_products` request with **both** `buying_mode='refine'` AND a `brief` field. The seller is correctly rejecting it as `INVALID_REQUEST`. That means either:\n\n1. The storyboard step is wrong — `refine` mode should drop `brief` and pass only the `refine[]` array, OR\n2. The spec on `buying_mode='refine'` shifted and `brief` is now allowed in this combination, but the seller's validation hasn't caught up.\n\nThe seller's rejection text reads like option (1): \"must not be combined with brief\" is a hard rule.\n\n## Run\n\n[ci run 25732467897](https://github.com/adcontextprotocol/adcp-client-python/actions/runs/25732467897/job/75560889145)\n\n## What to investigate\n\nCheck the storyboard scenario file for `refine_products` and confirm the step's request shape. Cross-reference against the [AdCP `get_products` spec](https://github.com/adcontextprotocol/adcp) for which fields are valid alongside `buying_mode='refine'`.\n\nIf the storyboard is the wrong side: fix the scenario, regenerate fixtures.\nIf the seller is the wrong side: relax the validation rule.\n\n## Why it blocks #693\n\nSame as #701 — until this storyboard step passes, the storyboard CI gate cannot go green.\n\n## Acceptance\n\n- `media_buy_seller/refine_products/get_products_refine` passes the storyboard with a correctly-shaped request\n- Root cause documented in the fix PR (storyboard fixture vs seller validation)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-12T15:08:54Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/702"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:64926048-a4a7-ff67-fc91-ab59bc628746 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DA84:96DDF:D39AD7:10D066B:6B00FFF4 |
| html-safe-nonce | e166d5efe45f623ce371f9e394b45daa736d25d6ef52e468d88ebb8b479176ae |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTg0Ojk2RERGOkQzOUFENzoxMEQwNjZCOjZCMDBGRkY0IiwidmlzaXRvcl9pZCI6IjcwMTE5MzYwODI3OTk0Mjc1NzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1600baf798c79346faa3e660c1b4f9bc8632fcdac5407b3b00949937743755f2 |
| hovercard-subject-tag | issue:4430286791 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/702/issue_layout |
| twitter:image | https://opengraph.githubassets.com/550dd5df71769b1129fc9fb19f373782e6582eb13912ccd8a292506c4f45ae86/adcontextprotocol/adcp-client-python/issues/702 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/550dd5df71769b1129fc9fb19f373782e6582eb13912ccd8a292506c4f45ae86/adcontextprotocol/adcp-client-python/issues/702 |
| og:image:alt | Surfaced by #693. Failure media_buy_seller/refine_products/get_products_refine [media_buy]: INVALID_REQUEST: buying_mode='refine' must not be combined with brief. The refine[] array drives iteratio... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width