Title: bug(v3-ref-seller): storyboard terminal-error codes mismatch on three update / create scenarios · Issue #701 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: bug(v3-ref-seller): storyboard terminal-error codes mismatch on three update / create scenarios · Issue #701 · adcontextprotocol/adcp-client-python
X Title: bug(v3-ref-seller): storyboard terminal-error codes mismatch on three update / create scenarios · Issue #701 · adcontextprotocol/adcp-client-python
Description: Surfaced by #693 (which made the storyboard CI gate actually assert on results). Failures The AdCP storyboard runner — v3 reference seller (translator) job fails three scenarios with terminal-code mismatches at /adcp_error/code: media_bu...
Open Graph Description: Surfaced by #693 (which made the storyboard CI gate actually assert on results). Failures The AdCP storyboard runner — v3 reference seller (translator) job fails three scenarios with terminal-code ...
X Description: Surfaced by #693 (which made the storyboard CI gate actually assert on results). Failures The AdCP storyboard runner — v3 reference seller (translator) job fails three scenarios with terminal-code ...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/701
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"bug(v3-ref-seller): storyboard terminal-error codes mismatch on three update / create scenarios","articleBody":"Surfaced by #693 (which made the storyboard CI gate actually assert on results).\n\n## Failures\n\nThe `AdCP storyboard runner — v3 reference seller (translator)` job fails three scenarios with terminal-code mismatches at `/adcp_error/code`:\n\n1. `media_buy_seller/measurement_terms_rejected/create_media_buy_aggressive_terms` — storyboard expects `TERMS_REJECTED`\n2. `media_buy_seller/invalid_transitions/update_unknown_media_buy` — storyboard expects `MEDIA_BUY_NOT_FOUND`\n3. `media_buy_seller/invalid_transitions/update_unknown_package` — storyboard expects `PACKAGE_NOT_FOUND`\n\nEach is a terminal code that cascade rules can't mask — the seller is returning *some other* error code in `adcp_error.code` (or returning success). These are real spec-conformance regressions in the v3 reference seller, not storyboard fixture issues.\n\n## Run\n\n[ci run 25732467897, job 75560889145](https://github.com/adcontextprotocol/adcp-client-python/actions/runs/25732467897/job/75560889145)\n\nFull step output:\n\n```\n- create_media_buy_aggressive_terms [media_buy]: Error code is TERMS_REJECTED at /adcp_error/code\n- update_unknown_media_buy [media_buy]: Error code is MEDIA_BUY_NOT_FOUND at /adcp_error/code\n- update_unknown_package [media_buy]: Error code is PACKAGE_NOT_FOUND at /adcp_error/code\n```\n\n## What to investigate\n\nFor each failure: pull the request/response from the storyboard run artifact (`v3-storyboard-result-1.zip`), confirm what code the seller actually returns, then map that to either:\n- a seller-side bug: handler returns the wrong code → fix handler\n- a translator-side bug: upstream code translation dropping/remapping the wrong code → fix the translation map\n- a spec-vs-code drift: the canonical AdCP error-code enum changed and the seller hasn't caught up → bump\n\n## Why these block #693\n\n#693's whole purpose is to make the storyboard gate assert on results. Until these three are resolved, the v3 storyboard CI job stays red, blocking #693 from landing or making `main` permanently red on merge.\n\n## Acceptance\n\n- All three storyboard steps pass with the spec-correct error code in `adcp_error.code`\n- Root cause documented (seller / translator / spec drift) per step in the fix PR\n- `__spec_conformance__/account_discovery/list_or_sync_accounts` is a separate failure cluster tracked in #377 — not in scope here","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-12T15:08:43Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/701"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c1f5b3d7-a66b-ae33-599b-944963e686fe |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 96F6:62283:E41EC5:12F31C3:6B010059 |
| html-safe-nonce | 56ae996008642ff5b9e07a7db1aa958b9f4cda82bbeebbec09f5491b2c3dff60 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkY2OjYyMjgzOkU0MUVDNToxMkYzMUMzOjZCMDEwMDU5IiwidmlzaXRvcl9pZCI6IjMzNTI5NjY0MTQ0MTQ3MDg4MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3b78c1cdf59ff0ffd03144dfbd4b7fc366db746b8741630075bbf78e8124e3ec |
| hovercard-subject-tag | issue:4430285380 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/701/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3ab03f861aef7e0480a45a3484837be2d8da1ed7589dee2af54d145a33363379/adcontextprotocol/adcp-client-python/issues/701 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3ab03f861aef7e0480a45a3484837be2d8da1ed7589dee2af54d145a33363379/adcontextprotocol/adcp-client-python/issues/701 |
| og:image:alt | Surfaced by #693 (which made the storyboard CI gate actually assert on results). Failures The AdCP storyboard runner — v3 reference seller (translator) job fails three scenarios with terminal-code ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width