René's URL Explorer Experiment


Title: Typed dispatcher rejects valid request when `account` is omitted on auth-resolved tools · Issue #623 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Typed dispatcher rejects valid request when `account` is omitted on auth-resolved tools · Issue #623 · adcontextprotocol/adcp-client-python

X Title: Typed dispatcher rejects valid request when `account` is omitted on auth-resolved tools · Issue #623 · adcontextprotocol/adcp-client-python

Description: Problem The library's typed dispatcher rejects requests on tools where the spec declares `account` optional — specifically when the seller resolves identity from the auth chain and the buyer doesn't send a top-level `account` ref. Affect...

Open Graph Description: Problem The library's typed dispatcher rejects requests on tools where the spec declares `account` optional — specifically when the seller resolves identity from the auth chain and the buyer doesn'...

X Description: Problem The library's typed dispatcher rejects requests on tools where the spec declares `account` optional — specifically when the seller resolves identity from the auth chain and the buyer do...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/623

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Typed dispatcher rejects valid request when `account` is omitted on auth-resolved tools","articleBody":"## Problem\n\nThe library's typed dispatcher rejects requests on tools where the spec declares \\`account\\` optional — specifically when the seller resolves identity from the auth chain and the buyer doesn't send a top-level \\`account\\` ref.\n\nAffected wire tools (3.0.6+):\n- \\`create_media_buy\\`\n- \\`sync_creatives\\`\n- \\`activate_signal\\`\n- (others sharing the AccountReference-bound request shape)\n\nPer spec, when an adopter is in implicit-resolution mode (auth principal IS the account scope) the buyer can omit \\`account\\`. The dispatcher's pre-handler validation insists on the field being present, blocking the request before the adopter's impl can resolve from \\`AuthInfo\\`.\n\n## Workaround on the adopter side\n\nInject a sentinel \\`account: {account_id: \\\"auth-chain\\\"}\\` placeholder at the wire boundary so the validator passes; the impl ignores the placeholder and reads identity from \\`ResolvedIdentity\\`. [bokelley/salesagent's \\`SpecDefaultsMiddleware\\` does this](https://github.com/bokelley/salesagent/blob/main/core/middleware/spec_defaults.py) for the four tools listed above. Workable but every adopter has to ship the equivalent.\n\n## Suggested fix\n\nMake \\`account\\` optional on the typed dispatcher when the surface declares implicit-resolution support. Concretely:\n\n1. \\`AccountStore.resolution\\` is \\`'derived' | 'implicit' | 'explicit'\\` — the dispatcher already has this signal at boot.\n2. For tools that accept \\`account\\` (\\`create_media_buy\\`, \\`sync_creatives\\`, \\`activate_signal\\`, etc.), skip the required-field check on \\`account\\` when the wired \\`AccountStore.resolution != 'explicit'\\`.\n3. Keep the field required for explicit-mode adopters (where \\`account.account_id\\` IS the resolution input).\n\nThis closes the gap without changing the wire schema (which already documents \\`account\\` as optional in implicit/derived mode).\n\n## Related\n\n- bokelley/salesagent's middleware workaround: \\`core/middleware/spec_defaults.py\\` \\`_AUTH_FILLED_TOOLS\\` set.\n- The \\`auth-chain\\` placeholder string is contained (impl reads identity from elsewhere) but is fragile — any adopter forgetting the middleware silently gets \\`INVALID_REQUEST\\` for buyers in implicit mode.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-10T12:43:16Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/623"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2964b25b-0529-4b40-1e7c-18bcec6a50b2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD4CE:291B58:13E0E72:1921901:6B0162B7
html-safe-noncec49359b816462756cd5f546d508006995167442add0cc1d11c41941e69c7aff0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENENFOjI5MUI1ODoxM0UwRTcyOjE5MjE5MDE6NkIwMTYyQjciLCJ2aXNpdG9yX2lkIjoiNjgzNDQxNTE3MTY3MTI1MzY4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac326d15d4166c3278c77a5e852d3c8558dfb1e2c53de0f2e6a87ac16625bcba27
hovercard-subject-tagissue:4415636948
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/623/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c6eb7c2e95d98d576cec7e106767217e9622e5930c38b0a74ef6abc3a52cdb2c/adcontextprotocol/adcp-client-python/issues/623
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c6eb7c2e95d98d576cec7e106767217e9622e5930c38b0a74ef6abc3a52cdb2c/adcontextprotocol/adcp-client-python/issues/623
og:image:altProblem The library's typed dispatcher rejects requests on tools where the spec declares `account` optional — specifically when the seller resolves identity from the auth chain and the buyer doesn'...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/623#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F623
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F623
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/623
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/623
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/623
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/623
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/623
Typed dispatcher rejects valid request when account is omitted on auth-resolved toolshttps://github.com/adcontextprotocol/adcp-client-python/issues/623#top
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#issue-4415636948
bokelley/salesagent's `SpecDefaultsMiddleware` does thishttps://github.com/bokelley/salesagent/blob/main/core/middleware/spec_defaults.py
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#event-25353315385
bokelleyhttps://github.com/bokelley
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#event-25353648420
fix(server): defensive copy before hook call eliminates in-place muta…https://github.com/adcontextprotocol/adcp-client-python/commit/49feaefa5c63edfe56edc7ddd68d80bc33a0b7d4
49feaefhttps://github.com/adcontextprotocol/adcp-client-python/commit/49feaefa5c63edfe56edc7ddd68d80bc33a0b7d4
fix(types): update schema cache and strengthen tests for #623https://github.com/adcontextprotocol/adcp-client-python/commit/20e395472bc464705f94147cf8335d2236df2389
#623https://github.com/adcontextprotocol/adcp-client-python/issues/623
20e3954https://github.com/adcontextprotocol/adcp-client-python/commit/20e395472bc464705f94147cf8335d2236df2389
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#issuecomment-4415395536
#633https://github.com/adcontextprotocol/adcp-client-python/pull/633
https://claude.ai/code/session_01JX6bQ9FK2YxLefGnUSkg6xhttps://claude.ai/code/session_01JX6bQ9FK2YxLefGnUSkg6x
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#event-25353745859
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#issuecomment-4415402405
#614https://github.com/adcontextprotocol/adcp-client-python/issues/614
#629https://github.com/adcontextprotocol/adcp-client-python/pull/629
feat(server): pre-validation request hook / spec-default registry #614https://github.com/adcontextprotocol/adcp-client-python/issues/614
feat(server): pre-validation request hook for spec-default injection (#614) #629https://github.com/adcontextprotocol/adcp-client-python/pull/629
Typed dispatcher rejects valid request when account is omitted on auth-resolved tools #623https://github.com/adcontextprotocol/adcp-client-python/issues/623
Typed dispatcher rejects valid request when account is omitted on auth-resolved tools #623https://github.com/adcontextprotocol/adcp-client-python/issues/623
feat(server): pre-validation request hook for spec-default injection (#614) #629https://github.com/adcontextprotocol/adcp-client-python/pull/629
Typed dispatcher rejects valid request when account is omitted on auth-resolved tools #623https://github.com/adcontextprotocol/adcp-client-python/issues/623
#633https://github.com/adcontextprotocol/adcp-client-python/pull/633
adcontextprotocol/adcphttps://github.com/adcontextprotocol/adcp
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#issuecomment-4415430728
@bokelleyhttps://github.com/bokelley
#633https://github.com/adcontextprotocol/adcp-client-python/pull/633
#629https://github.com/adcontextprotocol/adcp-client-python/pull/629
@bokelleyhttps://github.com/bokelley
#633https://github.com/adcontextprotocol/adcp-client-python/pull/633
https://claude.ai/code/session_01G8chbJ8QNyNsAbN19S75Tdhttps://claude.ai/code/session_01G8chbJ8QNyNsAbN19S75Td
Claude Codehttps://claude.ai/code
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#issuecomment-4415501649
#633https://github.com/adcontextprotocol/adcp-client-python/pull/633
#633https://github.com/adcontextprotocol/adcp-client-python/pull/633
fix(types): make account optional in CreateMediaBuyRequest and SyncCreativesRequest #633https://github.com/adcontextprotocol/adcp-client-python/pull/633
feat(adapters): add list? option to createDerivedAccountStore for spec-compliant list_accounts adcp-client#1630https://github.com/adcontextprotocol/adcp-client/pull/1630
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#event-25354329533
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#issuecomment-4415510629
@bokelleyhttps://github.com/bokelley
#633https://github.com/adcontextprotocol/adcp-client-python/pull/633
#633https://github.com/adcontextprotocol/adcp-client-python/pull/633
https://claude.ai/code/session_019gTFrGnQLUiWXpf3j4FaJ5https://claude.ai/code/session_019gTFrGnQLUiWXpf3j4FaJ5
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#event-25354353784
bokelleyhttps://github.com/bokelley
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#event-25354924678
fix(storyboard): close 4 storyboard failures, wire sync_accounts/list…https://github.com/bokelley/salesagent/commit/cb8557d26da3be729e5c926ca75da99b998d9986
cb8557dhttps://github.com/bokelley/salesagent/commit/cb8557d26da3be729e5c926ca75da99b998d9986
fix(server): defensive copy before hook call eliminates in-place muta…https://github.com/adcontextprotocol/adcp-client-python/commit/83013d1d10b1eed09ed7d17981c4d2b58d85aa43
83013d1https://github.com/adcontextprotocol/adcp-client-python/commit/83013d1d10b1eed09ed7d17981c4d2b58d85aa43
fix(server): defensive copy before hook call eliminates in-place muta…https://github.com/adcontextprotocol/adcp-client-python/commit/bbccd1fbab83919ba870033ef3f2b3d9d50f0333
bbccd1fhttps://github.com/adcontextprotocol/adcp-client-python/commit/bbccd1fbab83919ba870033ef3f2b3d9d50f0333
fix(server): defensive copy before hook call eliminates in-place muta…https://github.com/adcontextprotocol/adcp-client-python/commit/83302834fb0cdf87c011d3a23d44ce9d28d1ca08
8330283https://github.com/adcontextprotocol/adcp-client-python/commit/83302834fb0cdf87c011d3a23d44ce9d28d1ca08
feat(server): pre-validation request hook for spec-default injection (#…https://github.com/adcontextprotocol/adcp-client-python/commit/05d4cd8617440aaa638086ffa5cabc0bf61b403f
#…https://github.com/adcontextprotocol/adcp-client-python/issues/614
05d4cd8https://github.com/adcontextprotocol/adcp-client-python/commit/05d4cd8617440aaa638086ffa5cabc0bf61b403f
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#issuecomment-4415701430
the corrected-spec re-triagehttps://github.com/adcontextprotocol/adcp-client-python/issues/623#issuecomment-4415501649
bokelley/salesagent#314https://github.com/bokelley/salesagent/issues/314
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 10, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/623#event-25355403344
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/623
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/623
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.