Title: release-please: commit-message subjects with parens or quotes silently dropped from CHANGELOG · Issue #578 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: release-please: commit-message subjects with parens or quotes silently dropped from CHANGELOG · Issue #578 · adcontextprotocol/adcp-client-python
X Title: release-please: commit-message subjects with parens or quotes silently dropped from CHANGELOG · Issue #578 · adcontextprotocol/adcp-client-python
Description: What The release-please conventional-commit parser fails on commit subjects containing embedded parens or quotes, and silently drops the affected commits from the auto-generated CHANGELOG. Verified in the workflow logs from run 253261638...
Open Graph Description: What The release-please conventional-commit parser fails on commit subjects containing embedded parens or quotes, and silently drops the affected commits from the auto-generated CHANGELOG. Verified...
X Description: What The release-please conventional-commit parser fails on commit subjects containing embedded parens or quotes, and silently drops the affected commits from the auto-generated CHANGELOG. Verified...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/578
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"release-please: commit-message subjects with parens or quotes silently dropped from CHANGELOG","articleBody":"## What\n\nThe release-please conventional-commit parser fails on commit subjects containing embedded parens or quotes, and silently drops the affected commits from the auto-generated CHANGELOG. Verified in the workflow logs from run 25326163877:\n\n\\`\\`\\`\ncommit could not be parsed: c2ab696c... fix(auth): synthesize AuthInfo(kind=\"bearer\") in _build_request_context for bearer flows (#577)\nerror message: Error: unexpected token '\"' at 10:60, valid tokens [)]\n\ncommit could not be parsed: 4ead6077... feat(auth): serve(auth=BearerTokenAuth(...)) — A2A sibling + cross-transport shortcut (#566)\nerror message: Error: unexpected token '(' at 6:27, valid tokens [)]\n\ncommit could not be parsed: 2affd00f... fix(ci): unblock storyboard runner — poll, MCP outputSchema, ref seller boot (#443)\nerror message: Error: unexpected token '(' at 60:32, valid tokens [)]\n\\`\\`\\`\n\nThe workflow exits \"success\" — no surface signal that commits were dropped. Each affected commit is **in the code** but **absent from the CHANGELOG**, so adopters reading the published release notes see an incomplete picture.\n\n## Impact\n\nThree commits silently missing from the v4.4.0 release-please PR (#328):\n- #577 — \\`fix(auth): synthesize AuthInfo(kind=\"bearer\")...\\` (today's bearer auth_info fix)\n- #566 — \\`feat(auth): serve(auth=BearerTokenAuth(...))...\\`\n- #443 — \\`fix(ci): unblock storyboard runner...\\`\n\nFor 4.4.0 we'll patch by editing the release PR body manually. Going forward we need either a parser fix or a commit-message convention.\n\n## Direction\n\nTwo viable paths:\n\n1. **Convention** — document in \\`CONTRIBUTING.md\\` / pre-commit hook that conventional-commit subjects must not contain embedded parens or quotes. Move the offending content to the body. Brittle (relies on contributor discipline) but zero infra change.\n\n2. **Tooling** — find a release-please config option / parser plugin that tolerates parens/quotes in subjects, OR add a pre-merge GitHub Action that lints squash-merge commit messages before they hit main. Better long-term.\n\n## Surfaced by\n\nInvestigation of release-please PR #328 during 4.4.0 release prep — three of today's merged PRs were missing from the changelog despite successful release-please runs.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-04T15:01:54Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/578"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8a6f3e6b-f98d-d73c-f02d-3d6dfddc867a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C1CC:14F601:10D73FC:1589D6C:6B010297 |
| html-safe-nonce | e3f56f6b9756da52a711365d810842f0530d479e8eb7624dca99b5f9e187cc0f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUNDOjE0RjYwMToxMEQ3M0ZDOjE1ODlENkM6NkIwMTAyOTciLCJ2aXNpdG9yX2lkIjoiODczOTgzMzEzNDcwMDk2MDI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 48e146581bd89d09674608cc71d4b72d5e2e85b710f8541bc6dd394cbe159012 |
| hovercard-subject-tag | issue:4377570359 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/578/issue_layout |
| twitter:image | https://opengraph.githubassets.com/00648a1fd17ffb20305e93b73c0d4eb1823d8957191164c1a886da27c0bdaa24/adcontextprotocol/adcp-client-python/issues/578 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/00648a1fd17ffb20305e93b73c0d4eb1823d8957191164c1a886da27c0bdaa24/adcontextprotocol/adcp-client-python/issues/578 |
| og:image:alt | What The release-please conventional-commit parser fails on commit subjects containing embedded parens or quotes, and silently drops the affected commits from the auto-generated CHANGELOG. Verified... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width