René's URL Explorer Experiment


Title: bug(server): AdcpError raise path bypasses context-echo on MCP and A2A error envelopes · Issue #557 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: bug(server): AdcpError raise path bypasses context-echo on MCP and A2A error envelopes · Issue #557 · adcontextprotocol/adcp-client-python

X Title: bug(server): AdcpError raise path bypasses context-echo on MCP and A2A error envelopes · Issue #557 · adcontextprotocol/adcp-client-python

Description: Bug The MCP and A2A error paths build the structured adcp_error envelope but never echo the request's context extension into the response. The success paths do echo it (inject_context in mcp_tools.py:2030), so any handler that raises Adc...

Open Graph Description: Bug The MCP and A2A error paths build the structured adcp_error envelope but never echo the request's context extension into the response. The success paths do echo it (inject_context in mcp_tools....

X Description: Bug The MCP and A2A error paths build the structured adcp_error envelope but never echo the request's context extension into the response. The success paths do echo it (inject_context in mcp_to...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/557

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"bug(server): AdcpError raise path bypasses context-echo on MCP and A2A error envelopes","articleBody":"## Bug\n\nThe MCP and A2A error paths build the structured `adcp_error` envelope but never echo the request's `context` extension into the response. The success paths do echo it (`inject_context` in `mcp_tools.py:2030`), so any handler that raises `AdcpError` produces a response that violates the AdCP context-echo contract — buyers lose correlation IDs, idempotency hints, and other agent-to-agent state.\n\n## Repro\n\nA handler calls `raise AdcpError('PERMISSION_DENIED', message='nope')`. The wire response carries `structuredContent.adcp_error` but no top-level `context` field, even though the request supplied one.\n\n## Affected paths\n\n- **MCP**: `src/adcp/server/serve.py:1787-1804` — `except ADCPError` and the decisioning-AdcpError branch both call `build_mcp_error_result(exc)` without passing `kwargs` (the raw params).\n- **A2A**: `src/adcp/server/a2a_server.py:237` — `_send_adcp_error` is invoked with `(event_queue, context, exc)` but not the parsed request `params` that carry the wire `context` extension.\n- **Builders**: `src/adcp/server/translate.py:167` (`build_mcp_error_result`) and `src/adcp/server/a2a_server.py:426` (`_send_adcp_error`) take `exc` only, with no surface to receive raw request params.\n\n## Symptom\n\nThree storyboard runners fail on the AdcpError-raise path because the asserted echoed-context fields are missing from error responses.\n\n## Fix\n\n1. Plumb raw params into the error-result builders on both transports.\n2. After building the structured envelope, run `inject_context(raw_params, envelope)` so the `context` field is echoed at the same level the success path uses.\n3. Add tests covering both transports' error path with and without a request `context` field.\n\nPlan to land as a single PR.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-04T09:57:54Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/557"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5b108cc7-2f64-fe63-b435-531420e8f051
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id82A0:1201C:D7F43D:120A8BB:6B00FEB6
html-safe-noncecc062b706a7d0a8ae39f63528ff5fa73a3735c4ea580e829fd9554f12b7e8267
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkEwOjEyMDFDOkQ3RjQzRDoxMjBBOEJCOjZCMDBGRUI2IiwidmlzaXRvcl9pZCI6IjgzMzgyNDczMDI2MzY0MzcxNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac602b66e6215380d1080a5d3419b2e20203e1edbc838f3ceabd86b46a6ec3a0e8
hovercard-subject-tagissue:4375591978
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/557/issue_layout
twitter:imagehttps://opengraph.githubassets.com/58ad962f36fa5b94da90ca61462aa77afbca899749cd44e9e9a661c0394a3b57/adcontextprotocol/adcp-client-python/issues/557
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/58ad962f36fa5b94da90ca61462aa77afbca899749cd44e9e9a661c0394a3b57/adcontextprotocol/adcp-client-python/issues/557
og:image:altBug The MCP and A2A error paths build the structured adcp_error envelope but never echo the request's context extension into the response. The success paths do echo it (inject_context in mcp_tools....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/557#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F557
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F557
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/557
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/557
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/557
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/557
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/557
#560https://github.com/adcontextprotocol/adcp-client-python/pull/560
bug(server): AdcpError raise path bypasses context-echo on MCP and A2A error envelopeshttps://github.com/adcontextprotocol/adcp-client-python/issues/557#top
#560https://github.com/adcontextprotocol/adcp-client-python/pull/560
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
no-triageSkip the Claude triage bot — human or designated agent will handle this issuehttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22no-triage%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/557#issue-4375591978
bokelleyhttps://github.com/bokelley
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
no-triageSkip the Claude triage bot — human or designated agent will handle this issuehttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22no-triage%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/557#event-25126779112
bokelleyhttps://github.com/bokelley
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/557#event-25127747856
fix(server): echo request context on AdcpError error envelopes (#560)https://github.com/adcontextprotocol/adcp-client-python/commit/2e351b0d20c73c8483deeaa4c0efa89d3c453af7
#560https://github.com/adcontextprotocol/adcp-client-python/pull/560
https://docs.github.com/articles/closing-issues-via-commit-messages
2e351b0https://github.com/adcontextprotocol/adcp-client-python/commit/2e351b0d20c73c8483deeaa4c0efa89d3c453af7
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#560https://github.com/adcontextprotocol/adcp-client-python/pull/560
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/557#event-25127747861
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/557
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/557
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
no-triageSkip the Claude triage bot — human or designated agent will handle this issuehttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22no-triage%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.