René's URL Explorer Experiment


Title: testing: ship adcp.testing.make_request_context + build_asgi_app helpers · Issue #516 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: testing: ship adcp.testing.make_request_context + build_asgi_app helpers · Issue #516 · adcontextprotocol/adcp-client-python

X Title: testing: ship adcp.testing.make_request_context + build_asgi_app helpers · Issue #516 · adcontextprotocol/adcp-client-python

Description: From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #10 and #11). Two test-DX gaps in adcp.testing/: 1. make_request_context RequestContext has 11 fields, 4 with defaults. For unit testing through PlatformHandler,...

Open Graph Description: From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #10 and #11). Two test-DX gaps in adcp.testing/: 1. make_request_context RequestContext has 11 fields, 4 with defaults. F...

X Description: From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #10 and #11). Two test-DX gaps in adcp.testing/: 1. make_request_context RequestContext has 11 fields, 4 with <factory> defau...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/516

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"testing: ship adcp.testing.make_request_context + build_asgi_app helpers","articleBody":"From the salesagent v3.12 → 4.x migration (`SDK_FEEDBACK.md`, items #10 and #11).\n\nTwo test-DX gaps in `adcp.testing/`:\n\n## 1. `make_request_context`\n\n`RequestContext` has 11 fields, 4 with `\u003cfactory>` defaults. For unit testing through `PlatformHandler`, the only thing the handler reads is `ctx.account` and sometimes `ctx.request_id`.\n\n> Constructing a `RequestContext` for tests requires guessing which factory defaults are safe. I hit `TypeError: unexpected keyword argument 'adopter_request'` when I read a docstring that mentioned the field but it's not a constructor parameter. The test-friendly path took several tries.\n\n**Ask:** ship `adcp.testing.make_request_context(account=..., **overrides)` with sane defaults and a stable signature documented as the test seam.\n\n## 2. `build_asgi_app`\n\n`create_adcp_server_from_platform` doesn't accept `name=`, but `serve()` does.\n\n> Building the ASGI app in tests requires going through `create_adcp_server_from_platform() → create_mcp_server()` and the kwarg surface differs between the two. The current docstring on `create_mcp_server` is a great implementation reference but it's not framed as the test seam.\n\n**Ask:** first-class `adcp.testing.build_asgi_app(platform, name=...) → ASGIApp` helper that's officially the \"for tests\" way to get a running server.\n\n## Acceptance\n\nAdopters writing platform-handler unit tests can:\n1. Construct a `RequestContext` in one line with no factory-default guessing.\n2. Get an ASGIApp from a platform in one call with the same kwarg surface as `serve()`.\n\nBoth helpers live in `adcp.testing/` (module already exists with `test_helpers.py`).","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-04T01:02:45Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/516"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d253a851-f3f6-34dc-f838-b27df0eb23e1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC2D0:76F02:D3AEBF:1110A83:6B00F669
html-safe-nonce5e7098076ffe373195ff8ee7b717d4c4d7cd269864347f5661b43251c2a773e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkQwOjc2RjAyOkQzQUVCRjoxMTEwQTgzOjZCMDBGNjY5IiwidmlzaXRvcl9pZCI6IjcwMjk1NDcyMzExMjQ0NTI5NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacaf36de727795615d054cd2fa8a30e3779f26a08f22b7b168fd7a051a28103d61
hovercard-subject-tagissue:4373477464
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/516/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8c22819a63bb47962122aac861bac9bb4fc3ba9ac6dcc6f4de93f11687d05941/adcontextprotocol/adcp-client-python/issues/516
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c22819a63bb47962122aac861bac9bb4fc3ba9ac6dcc6f4de93f11687d05941/adcontextprotocol/adcp-client-python/issues/516
og:image:altFrom the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #10 and #11). Two test-DX gaps in adcp.testing/: 1. make_request_context RequestContext has 11 fields, 4 with defaults. F...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/516#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F516
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F516
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/516
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/516
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/516
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/516
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/516
#535https://github.com/adcontextprotocol/adcp-client-python/pull/535
testing: ship adcp.testing.make_request_context + build_asgi_app helpershttps://github.com/adcontextprotocol/adcp-client-python/issues/516#top
#535https://github.com/adcontextprotocol/adcp-client-python/pull/535
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/516#issue-4373477464
#10https://github.com/adcontextprotocol/adcp-client-python/pull/10
#11https://github.com/adcontextprotocol/adcp-client-python/pull/11
bokelleyhttps://github.com/bokelley
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/516#event-25115057422
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/516#issuecomment-4367691353
#532https://github.com/adcontextprotocol/adcp-client-python/pull/532
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/516#event-25115307065
bokelleyhttps://github.com/bokelley
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/516#event-25115521141
feat(testing): make_request_context + build_asgi_app helpers (#535)https://github.com/adcontextprotocol/adcp-client-python/commit/68699763e917980f6d7ad75e4a1364a2dc188715
#535https://github.com/adcontextprotocol/adcp-client-python/pull/535
6869976https://github.com/adcontextprotocol/adcp-client-python/commit/68699763e917980f6d7ad75e4a1364a2dc188715
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#535https://github.com/adcontextprotocol/adcp-client-python/pull/535
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/516#event-25115521153
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/516
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/516
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.