Title: codemod: flag MediaBuyStatus.pending_activation split + required-field omissions · Issue #513 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: codemod: flag MediaBuyStatus.pending_activation split + required-field omissions · Issue #513 · adcontextprotocol/adcp-client-python
X Title: codemod: flag MediaBuyStatus.pending_activation split + required-field omissions · Issue #513 · adcontextprotocol/adcp-client-python
Description: From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #3 and #4). Two semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collection was otherwise clean: 1. MediaBuyStatus.pen...
Open Graph Description: From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #3 and #4). Two semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collection wa...
X Description: From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #3 and #4). Two semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collectio...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/513
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"codemod: flag MediaBuyStatus.pending_activation split + required-field omissions","articleBody":"From the salesagent v3.12 → 4.x migration (`SDK_FEEDBACK.md`, items #3 and #4).\n\nTwo semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collection was otherwise clean:\n\n## 1. `MediaBuyStatus.pending_activation` split\n\nRemoved in 4.x and split into `pending_start | pending_creatives` based on cause. Surfaces as `AttributeError: type object 'MediaBuyStatus' has no attribute 'pending_activation'` at runtime.\n\n> Batch-replaced 9 files mechanically with `pending_start` to unblock collection, then immediately added a `TODO(...)` because the correct mapping is per-call-site (needs_creatives → pending_creatives; schedule-future → pending_start).\n\n**Ask:** flag `MediaBuyStatus.pending_activation` references with a \"use `pending_start | pending_creatives` based on cause\" pointer, OR ship a deprecation alias mapping to `pending_start` with a `DeprecationWarning` for one minor.\n\n## 2. `idempotency_key` becoming required on `CreateMediaBuyRequest`\n\n> The first runtime test failure after a clean collection was a Pydantic `ValidationError: idempotency_key Field required`. The codemod doesn't flag request constructions that omit now-required fields. This is one of ~600 legacy-test failures still pending.\n\n**Ask:** codemod or pytest-level warning hook that flags request constructions missing fields that became required between two schema versions. Even a per-construction warning would beat per-test debugging.\n\n## Notes\n\nThe required-field detection is a bigger lift (needs schema diff between two adcp versions). The `pending_activation` flagger is a one-off enum mapping. Either ships value independently.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-04T01:02:10Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/513"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:81ec9c6f-5578-be6d-6ae2-d8df804d133a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 84B0:2D2F2F:DE3805:11F61F3:6B00F6D1 |
| html-safe-nonce | 6c0866c3053d62ebfa9147ca928c5a2260e73864566aa4b7e0bdaff3a38f9160 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEIwOjJEMkYyRjpERTM4MDU6MTFGNjFGMzo2QjAwRjZEMSIsInZpc2l0b3JfaWQiOiIyMzY4MzM3MzY2NDQxMDY0MTQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 974fc217df06087bc308714ce65005320b83711dc2f78cd877bc3847bd4359ec |
| hovercard-subject-tag | issue:4373476185 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/513/issue_layout |
| twitter:image | https://opengraph.githubassets.com/244636602397e967dd532c64db1961a3970a82f5d6f81b375b0b6c5fca8dce79/adcontextprotocol/adcp-client-python/issues/513 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/244636602397e967dd532c64db1961a3970a82f5d6f81b375b0b6c5fca8dce79/adcontextprotocol/adcp-client-python/issues/513 |
| og:image:alt | From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #3 and #4). Two semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collection wa... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width