René's URL Explorer Experiment


Title: codemod: flag MediaBuyStatus.pending_activation split + required-field omissions · Issue #513 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: codemod: flag MediaBuyStatus.pending_activation split + required-field omissions · Issue #513 · adcontextprotocol/adcp-client-python

X Title: codemod: flag MediaBuyStatus.pending_activation split + required-field omissions · Issue #513 · adcontextprotocol/adcp-client-python

Description: From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #3 and #4). Two semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collection was otherwise clean: 1. MediaBuyStatus.pen...

Open Graph Description: From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #3 and #4). Two semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collection wa...

X Description: From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #3 and #4). Two semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collectio...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/513

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"codemod: flag MediaBuyStatus.pending_activation split + required-field omissions","articleBody":"From the salesagent v3.12 → 4.x migration (`SDK_FEEDBACK.md`, items #3 and #4).\n\nTwo semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collection was otherwise clean:\n\n## 1. `MediaBuyStatus.pending_activation` split\n\nRemoved in 4.x and split into `pending_start | pending_creatives` based on cause. Surfaces as `AttributeError: type object 'MediaBuyStatus' has no attribute 'pending_activation'` at runtime.\n\n> Batch-replaced 9 files mechanically with `pending_start` to unblock collection, then immediately added a `TODO(...)` because the correct mapping is per-call-site (needs_creatives → pending_creatives; schedule-future → pending_start).\n\n**Ask:** flag `MediaBuyStatus.pending_activation` references with a \"use `pending_start | pending_creatives` based on cause\" pointer, OR ship a deprecation alias mapping to `pending_start` with a `DeprecationWarning` for one minor.\n\n## 2. `idempotency_key` becoming required on `CreateMediaBuyRequest`\n\n> The first runtime test failure after a clean collection was a Pydantic `ValidationError: idempotency_key Field required`. The codemod doesn't flag request constructions that omit now-required fields. This is one of ~600 legacy-test failures still pending.\n\n**Ask:** codemod or pytest-level warning hook that flags request constructions missing fields that became required between two schema versions. Even a per-construction warning would beat per-test debugging.\n\n## Notes\n\nThe required-field detection is a bigger lift (needs schema diff between two adcp versions). The `pending_activation` flagger is a one-off enum mapping. Either ships value independently.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-04T01:02:10Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/513"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:81ec9c6f-5578-be6d-6ae2-d8df804d133a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id84B0:2D2F2F:DE3805:11F61F3:6B00F6D1
html-safe-nonce6c0866c3053d62ebfa9147ca928c5a2260e73864566aa4b7e0bdaff3a38f9160
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEIwOjJEMkYyRjpERTM4MDU6MTFGNjFGMzo2QjAwRjZEMSIsInZpc2l0b3JfaWQiOiIyMzY4MzM3MzY2NDQxMDY0MTQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac974fc217df06087bc308714ce65005320b83711dc2f78cd877bc3847bd4359ec
hovercard-subject-tagissue:4373476185
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/513/issue_layout
twitter:imagehttps://opengraph.githubassets.com/244636602397e967dd532c64db1961a3970a82f5d6f81b375b0b6c5fca8dce79/adcontextprotocol/adcp-client-python/issues/513
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/244636602397e967dd532c64db1961a3970a82f5d6f81b375b0b6c5fca8dce79/adcontextprotocol/adcp-client-python/issues/513
og:image:altFrom the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #3 and #4). Two semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collection wa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/513#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F513
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F513
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/513
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/513
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/513
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/513
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/513
codemod: flag MediaBuyStatus.pending_activation split + required-field omissionshttps://github.com/adcontextprotocol/adcp-client-python/issues/513#top
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/513#issue-4373476185
#3https://github.com/adcontextprotocol/adcp-client-python/pull/3
#4https://github.com/adcontextprotocol/adcp-client-python/pull/4
bokelleyhttps://github.com/bokelley
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/513#event-25115050893
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/513#issuecomment-4367665775
#523https://github.com/adcontextprotocol/adcp-client-python/pull/523
#523https://github.com/adcontextprotocol/adcp-client-python/pull/523
https://claude.ai/code/session_01294Agd3ZTguC1drs5Beoushttps://claude.ai/code/session_01294Agd3ZTguC1drs5Beous
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/513#event-25115178906
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 14, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/513#issuecomment-4448756626
#523https://github.com/adcontextprotocol/adcp-client-python/pull/523
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 14, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/513#event-25519140177
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/513
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/513
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.