René's URL Explorer Experiment


Title: feat(server): MCP error responses must populate structuredContent.adcp_error.code (not just text) · Issue #509 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: feat(server): MCP error responses must populate structuredContent.adcp_error.code (not just text) · Issue #509 · adcontextprotocol/adcp-client-python

X Title: feat(server): MCP error responses must populate structuredContent.adcp_error.code (not just text) · Issue #509 · adcontextprotocol/adcp-client-python

Description: Motivation When a platform method raises `AdcpError(code="MEDIA_BUY_NOT_FOUND", ...)`, the framework today projects it onto the MCP wire as a TEXT payload like `MEDIA_BUY_NOT_FOUND[media_buy_id]: ...`. The structured `CallToolResult.stru...

Open Graph Description: Motivation When a platform method raises `AdcpError(code="MEDIA_BUY_NOT_FOUND", ...)`, the framework today projects it onto the MCP wire as a TEXT payload like `MEDIA_BUY_NOT_FOUND[media_buy_id]: ....

X Description: Motivation When a platform method raises `AdcpError(code="MEDIA_BUY_NOT_FOUND", ...)`, the framework today projects it onto the MCP wire as a TEXT payload like `MEDIA_BUY_NOT_FOUND[media_...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/509

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(server): MCP error responses must populate structuredContent.adcp_error.code (not just text)","articleBody":"## Motivation\n\nWhen a platform method raises \\`AdcpError(code=\\\"MEDIA_BUY_NOT_FOUND\\\", ...)\\`, the framework today projects it onto the MCP wire as a TEXT payload like \\`MEDIA_BUY_NOT_FOUND[media_buy_id]: ...\\`. The structured \\`CallToolResult.structuredContent.adcp_error.code\\` field that the AdCP wire spec defines is NOT populated.\n\nDocumented as a known limitation in \\`src/adcp/server/translate.py:246-250\\`:\n\n> Carries \\`isError=True\\` AND a structured \\`adcp_error\\` object on the same envelope — but \\`_make_error_result\\` (\\`mcp/server/lowlevel/server.py:467\\`) drops \\`structuredContent\\` for error results, so we can't reach...\n\n## Why this is biting us now\n\nThe AdCP storyboard runner's compliance checks include JSON-pointer assertions like \\`/adcp_error/code\\` to verify spec-conformant error responses. With the current text-only projection:\n\n- A seller correctly raising \\`MEDIA_BUY_NOT_FOUND\\` for an unknown media_buy_id passes the *behavioral* check (rejected the request)\n- But fails the *wire-shape* check (\\`/adcp_error/code\\` returns \\`actual: mcp_error\\` instead of \\`MEDIA_BUY_NOT_FOUND\\`)\n\nThis was just surfaced by the multi_platform_seller storyboard fix-pack (PR #508): residual storyboard failures aren't mock bugs — they're SDK wire-projection gaps. Every adopter using \\`adcp.server.serve\\` has the same gap.\n\n## Proposed fix\n\nMigrate the error-result construction to use FastMCP's path that preserves \\`structuredContent\\` on \\`isError=True\\` results. The framework should populate:\n\n\\`\\`\\`json\n{\n  \\\"isError\\\": true,\n  \\\"structuredContent\\\": {\n    \\\"adcp_error\\\": {\n      \\\"code\\\": \\\"MEDIA_BUY_NOT_FOUND\\\",\n      \\\"message\\\": \\\"...\\\",\n      \\\"recovery\\\": \\\"correctable\\\",\n      \\\"field\\\": \\\"media_buy_id\\\",\n      \\\"details\\\": { ... }\n    }\n  },\n  \\\"content\\\": [{\\\"type\\\": \\\"text\\\", \\\"text\\\": \\\"\u003chuman-readable fallback>\\\"}]\n}\n\\`\\`\\`\n\nWhere the structured fields are derived from the raised \\`AdcpError\\` instance.\n\n## Acceptance criteria\n\n- [ ] \\`AdcpError\\` raised from any platform method projects to \\`structuredContent.adcp_error\\` with all spec-defined fields (\\`code\\`, \\`message\\`, \\`recovery\\`, optional \\`field\\`/\\`details\\`)\n- [ ] Storyboard runner's \\`/adcp_error/code\\` JSON-pointer assertions pass for correctly-raised errors\n- [ ] Text fallback in \\`content[]\\` preserved for human-readable display\n- [ ] Existing tests stay green\n- [ ] Reference: storyboard runner artifacts from multi_platform_seller showing \\`actual: mcp_error\\` failures\n\n## Refs\n\n- Documented limitation: \\`src/adcp/server/translate.py:246-250\\`\n- Surfacing context: PR #508 (multi_platform_seller storyboard fix-pack) — agent ran into this when verifying wire-conformance of correctly-raised errors\n- Upstream issue: adcp-client#1527 (storyboard runner UX) — once this lands, the storyboard runner's structured error checks become useful as a regression gate","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-04T00:56:13Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/509"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7b8547c5-a066-044e-ca5f-1e3d8801b194
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9AFC:21E3E7:CBF899:10E6A4E:6B00F6CA
html-safe-nonce2b67b629cac738f10ae6b02606f84097921abe3487c6e24e1411394c5ef26763
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUZDOjIxRTNFNzpDQkY4OTk6MTBFNkE0RTo2QjAwRjZDQSIsInZpc2l0b3JfaWQiOiI2ODM3MzQ3NDIzMTUzNjE2NTg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac59af41511b95194d809400b37fdf54c353fcf28b143d6cda95bb78737efc96e3
hovercard-subject-tagissue:4373463108
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/509/issue_layout
twitter:imagehttps://opengraph.githubassets.com/43755aa9b2b5c322e66a2b73bb2477757e2fbe1bcfc58f592a16fb467a92e168/adcontextprotocol/adcp-client-python/issues/509
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/43755aa9b2b5c322e66a2b73bb2477757e2fbe1bcfc58f592a16fb467a92e168/adcontextprotocol/adcp-client-python/issues/509
og:image:altMotivation When a platform method raises `AdcpError(code="MEDIA_BUY_NOT_FOUND", ...)`, the framework today projects it onto the MCP wire as a TEXT payload like `MEDIA_BUY_NOT_FOUND[media_buy_id]: ....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/509#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F509
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F509
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/509
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/509
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/509
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/509
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/509
feat(server): MCP error responses must populate structuredContent.adcp_error.code (not just text)https://github.com/adcontextprotocol/adcp-client-python/issues/509#top
#536https://github.com/adcontextprotocol/adcp-client-python/pull/536
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/509#issue-4373463108
#508https://github.com/adcontextprotocol/adcp-client-python/pull/508
fix(examples): multi_platform_seller passes storyboards (drops continue-on-error) #508https://github.com/adcontextprotocol/adcp-client-python/pull/508
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/509#event-25115002522
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#525https://github.com/adcontextprotocol/adcp-client-python/pull/525
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/509#event-25115293828
bokelleyhttps://github.com/bokelley
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/509#event-25115293833
feat(server): MCP error responses populate structuredContent.adcp_err…https://github.com/adcontextprotocol/adcp-client-python/commit/b50a87ad63a5f00d53e03398d8ee7d9b055879d2
https://docs.github.com/articles/closing-issues-via-commit-messages
b50a87ahttps://github.com/adcontextprotocol/adcp-client-python/commit/b50a87ad63a5f00d53e03398d8ee7d9b055879d2
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/509#issuecomment-4367700108
#510https://github.com/adcontextprotocol/adcp-client-python/issues/510
https://claude.ai/code/session_01V4QPiByXeHu2p18TsxjWDFhttps://claude.ai/code/session_01V4QPiByXeHu2p18TsxjWDF
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 4, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/509#event-25115356100
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/509
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/509
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.