René's URL Explorer Experiment


Title: feat(decisioning): time_budget deadline wrapper + incomplete projection on get_products · Issue #495 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: feat(decisioning): time_budget deadline wrapper + incomplete projection on get_products · Issue #495 · adcontextprotocol/adcp-client-python

X Title: feat(decisioning): time_budget deadline wrapper + incomplete projection on get_products · Issue #495 · adcontextprotocol/adcp-client-python

Description: Motivation GetProductsRequest.time_budget is {interval: int, unit: 'seconds'|'minutes'|'hours'|'days'|'campaign'}. The wire description: "the seller returns the best results achievable within this budget and does not start processes (hum...

Open Graph Description: Motivation GetProductsRequest.time_budget is {interval: int, unit: 'seconds'|'minutes'|'hours'|'days'|'campaign'}. The wire description: "the seller returns the best results achievable within this ...

X Description: Motivation GetProductsRequest.time_budget is {interval: int, unit: 'seconds'|'minutes'|'hours'|'days'|'campaign'}. The wire description: "the seller ret...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/495

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(decisioning): time_budget deadline wrapper + incomplete projection on get_products","articleBody":"## Motivation\n\n`GetProductsRequest.time_budget` is `{interval: int, unit: 'seconds'|'minutes'|'hours'|'days'|'campaign'}`. The wire description: *\\\"the seller returns the best results achievable within this budget and does not start processes (human approvals, expensive external queries) that cannot complete in time.\\\"* The response carries `incomplete[]` with per-scope `estimated_wait` so the buyer can decide whether to retry with a larger budget.\n\nEvery adopter that takes `time_budget` seriously needs to (1) install a deadline, (2) cancel in-flight work when the deadline expires, (3) project the unfinished scopes to the wire `incomplete[]` shape. None of that is business logic — it's protocol plumbing that's identical for every seller.\n\nParent tracker: #491.\n\n## Current state\n\n**Salesagent**: does not honor `time_budget` at all. Grep of `src/core/tools/products.py` shows zero references. The seller can run unbounded.\n\n**SDK**: no deadline wrapper. `MediaBuyHandler.get_products` runs the adopter to completion regardless. Wire shape lives at `src/adcp/types/generated_poc/bundled/media_buy/get_products_request.py:1235-1244` (`TimeBudget`); response `incomplete` at `src/adcp/types/generated_poc/bundled/media_buy/get_products_response.py:2786-2804` (`IncompleteItem`).\n\n## Proposed API\n\nFramework wraps the adapter call in `asyncio.wait_for`, catches `TimeoutError`, projects whatever the adopter has produced so far via a checkpoint protocol:\n\n```python\n# src/adcp/decisioning/time_budget.py (new)\n\nclass IncrementalGetProducts(Protocol):\n    \\\"\\\"\\\"Optional protocol — when the adopter implements it, the framework\n    can project partial results on time-budget exhaustion. When the\n    adopter only implements plain get_products (returns the full\n    response), framework cancels and returns a single\n    incomplete[{scope: 'products', description: 'time_budget exhausted'}]\n    with no products.\\\"\\\"\\\"\n\n    async def get_products_incremental(\n        self, req: GetProductsRequest, ctx: RequestContext, checkpoint: Checkpoint\n    ) -> AsyncIterator[ProductsBatch]:\n        ...\n\n\n# In handler.get_products:\ndeadline = _resolve_time_budget(params.time_budget)  # → seconds float\ntry:\n    response = await asyncio.wait_for(\n        _invoke_platform_method(...), timeout=deadline,\n    )\nexcept asyncio.TimeoutError:\n    response = _project_partial_or_empty(checkpoint, deadline)\nreturn response\n```\n\n## Acceptance criteria\n\n- [ ] `_resolve_time_budget` converts every wire unit (`seconds`/`minutes`/`hours`/`days`/`campaign`) to a deadline; `'campaign'` → no deadline (matches wire description)\n- [ ] When deadline exhausted and adopter is plain (non-incremental), response has `products: []`, `incomplete: [{scope: 'products', description: '...', estimated_wait: ...}]`\n- [ ] When adopter implements `IncrementalGetProducts`, framework returns whatever batches landed before timeout, plus `incomplete[]` for the rest\n- [ ] `estimated_wait` populated from a hint protocol the adopter supplies (or omitted if no hint)\n- [ ] Test: `time_budget={interval: 1, unit: 'seconds'}` against a 10s adapter returns the timeout shape\n- [ ] Test: adopter that returns within budget passes through unchanged (no `incomplete`)\n- [ ] Test: `time_budget` absent → no deadline, no projection\n- [ ] Wire-validates: `incomplete[].scope` uses spec enum (`products`, `pricing`, `forecast`, `proposals`)\n\n## Out of scope\n\n- Per-scope deadlines (wire spec is request-level only)\n- HITL/approval-aware deadline (`refine` with `action='finalize'` explicitly says buyer should NOT set time_budget)\n- Cancellation propagation to upstream adapter calls — adopter responsibility unless framework owns the executor\n- Applying the same wrapper to other tools (open question — see below)\n\n## Cross-references\n\n- Wire request: `src/adcp/types/generated_poc/bundled/media_buy/get_products_request.py:1235-1244`, `1599-1604`\n- Wire response: `src/adcp/types/generated_poc/bundled/media_buy/get_products_response.py:2786-2826`\n- Reference pattern: `src/adcp/decisioning/webhook_emit.py`\n- Parent tracker: #491\n- Migration guide: #489\n\n## Open question (for the implementer, not blocking)\n\n`time_budget` is a request-shape parameter on more than just `get_products` — it also appears on `request_proposal` and likely others. Implement first against `get_products`; generalize when a second tool adopts the same wire shape.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-03T21:07:23Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/495"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f3bd8d61-5695-1ba2-7735-274479976c5c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB158:1CEA6F:EE6CD9:13BEB5C:6B010213
html-safe-nonceb3133b21835c6624d066bf8c78625e0bba22743f9c54534495fe66b9c2faa28f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTU4OjFDRUE2RjpFRTZDRDk6MTNCRUI1Qzo2QjAxMDIxMyIsInZpc2l0b3JfaWQiOiIzMTUzNjIxNDY4Nzg1NDc2MTE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9971d651c68da7de6a67ba35adf49a47a9c8b9c2c5cfc36124d9b996a5da011b
hovercard-subject-tagissue:4372988214
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/495/issue_layout
twitter:imagehttps://opengraph.githubassets.com/88abed02cc127a114d66800f1947c0deea7a292de721dcaa8f96ba9956ca29ff/adcontextprotocol/adcp-client-python/issues/495
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/88abed02cc127a114d66800f1947c0deea7a292de721dcaa8f96ba9956ca29ff/adcontextprotocol/adcp-client-python/issues/495
og:image:altMotivation GetProductsRequest.time_budget is {interval: int, unit: 'seconds'|'minutes'|'hours'|'days'|'campaign'}. The wire description: "the seller returns the best results achievable within this ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/495#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F495
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F495
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/495
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/495
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/495
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/495
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/495
#501https://github.com/adcontextprotocol/adcp-client-python/pull/501
feat(decisioning): time_budget deadline wrapper + incomplete projection on get_productshttps://github.com/adcontextprotocol/adcp-client-python/issues/495#top
#501https://github.com/adcontextprotocol/adcp-client-python/pull/501
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/495#issue-4372988214
#491https://github.com/adcontextprotocol/adcp-client-python/issues/491
feat(decisioning): built-in helpers for buyer-side request-shape parameters on get_products (parent tracker) #491https://github.com/adcontextprotocol/adcp-client-python/issues/491
docs: salesagent → adcp Python SDK migration guide #489https://github.com/adcontextprotocol/adcp-client-python/pull/489
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/495#event-25112652966
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/495#issuecomment-4367241903
https://claude.ai/code/session_01FMKCUEQWdb8my9rXtFVQ9xhttps://claude.ai/code/session_01FMKCUEQWdb8my9rXtFVQ9x
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/495#event-25112989428
bokelleyhttps://github.com/bokelley
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/495#event-25113817616
feat(decisioning): time_budget deadline wrapper + incomplete projecti…https://github.com/adcontextprotocol/adcp-client-python/commit/7cca60b5f7abc3f531f754342e0ad848edb688a3
7cca60bhttps://github.com/adcontextprotocol/adcp-client-python/commit/7cca60b5f7abc3f531f754342e0ad848edb688a3
feat(decisioning): time_budget deadline wrapper + incomplete projecti…https://github.com/adcontextprotocol/adcp-client-python/commit/5a7b64c8a93c6392bc94de7bacbad23588d35a8c
5a7b64chttps://github.com/adcontextprotocol/adcp-client-python/commit/5a7b64c8a93c6392bc94de7bacbad23588d35a8c
feat(decisioning): time_budget deadline wrapper + incomplete projecti…https://github.com/adcontextprotocol/adcp-client-python/commit/80bd2ec21689e6fa39dab64bd3ceb8571575671d
80bd2echttps://github.com/adcontextprotocol/adcp-client-python/commit/80bd2ec21689e6fa39dab64bd3ceb8571575671d
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#501https://github.com/adcontextprotocol/adcp-client-python/pull/501
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/495#event-25114018893
bokelleyhttps://github.com/bokelley
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/495#event-25114018897
feat(decisioning): time_budget deadline wrapper + incomplete projecti…https://github.com/adcontextprotocol/adcp-client-python/commit/bc6ad13ee18454c2091f5d8951574761ca1c0df0
bc6ad13https://github.com/adcontextprotocol/adcp-client-python/commit/bc6ad13ee18454c2091f5d8951574761ca1c0df0
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/495
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/495
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.