René's URL Explorer Experiment


Title: feat(decisioning): property_list resolver + intersection helper for get_products · Issue #494 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: feat(decisioning): property_list resolver + intersection helper for get_products · Issue #494 · adcontextprotocol/adcp-client-python

X Title: feat(decisioning): property_list resolver + intersection helper for get_products · Issue #494 · adcontextprotocol/adcp-client-python

Description: Motivation GetProductsRequest.property_list is {agent_url, list_id, auth_token?} — a reference to an externally-managed list of properties the buyer has been authorized to spend on. The seller is expected to fetch the list from the buyer...

Open Graph Description: Motivation GetProductsRequest.property_list is {agent_url, list_id, auth_token?} — a reference to an externally-managed list of properties the buyer has been authorized to spend on. The seller is e...

X Description: Motivation GetProductsRequest.property_list is {agent_url, list_id, auth_token?} — a reference to an externally-managed list of properties the buyer has been authorized to spend on. The seller is e...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/494

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(decisioning): property_list resolver + intersection helper for get_products","articleBody":"## Motivation\n\n`GetProductsRequest.property_list` is `{agent_url, list_id, auth_token?}` — a reference to an externally-managed list of properties the buyer has been authorized to spend on. The seller is expected to fetch the list from the buyer's agent, intersect against each product's `publisher_properties`, and set `property_list_applied: true` in the response.\n\nThis is **directly capability-gated already**: `RequiredFeatures.property_list_filtering` (`src/adcp/types/generated_poc/core/media_buy_features.py:18`) exists on both buyer-side filter and seller capabilities response. Every adopter that wants to claim this capability writes the same fetch + intersect + flag-echo code. Salesagent already has it inline; the helper should live in the SDK.\n\nParent tracker: #491.\n\n## Current state\n\n**Salesagent** has the canonical implementation inline:\n- `src/core/tools/products.py:65-91` — `extract_product_property_ids` (reads `selection_type` `all`/`by_id`/`by_tag`)\n- `src/core/tools/products.py:94-126` — `should_include_product_for_property_list` (handles `property_targeting_allowed` permissive vs strict mode)\n- `src/core/tools/products.py:129-142` — `filter_products_by_property_list`\n- `src/core/tools/products.py:404-424` — invocation site (calls `resolve_property_list` from `src/core/property_list_resolver.py:42`, then filters, sets the flag *implicitly* via the wire schema's `property_list_applied`)\n\n**SDK**: nothing. `MediaBuyHandler.get_products` (`src/adcp/decisioning/handler.py:1015-1033`) doesn't touch `property_list`. The capability `RequiredFeatures.property_list_filtering` is wire-defined but the framework doesn't gate on it.\n\n## Proposed API\n\nCapability-gated, framework intercepts post-adapter (mirrors auto-emit pattern):\n\n```python\n# src/adcp/decisioning/property_list.py (new)\n\nasync def resolve_property_list(\n    ref: PropertyList,\n    *,\n    fetcher: PropertyListFetcher,\n) -> set[str]:\n    \\\"\\\"\\\"Fetch the list from `ref.agent_url` and return the set of allowed\n    property_ids. Adopter supplies a `PropertyListFetcher` to plug in\n    their HTTP client / auth.\\\"\\\"\\\"\n\ndef filter_products_by_property_list(\n    products: list[Product],\n    allowed_property_ids: set[str],\n) -> list[Product]:\n    \\\"\\\"\\\"Mirrors salesagent's logic: respects publisher_properties.selection_type\n    ('all' = always include, 'by_id' = intersect, 'by_tag' = exclude),\n    and respects product.property_targeting_allowed (False = strict subset\n    required, True = any intersection suffices).\\\"\\\"\\\"\n```\n\nCapability declaration on `DecisioningCapabilities`:\n\n```python\ncaps = DecisioningCapabilities(\n    media_buy=MediaBuy(\n        execution=Execution(\n            features=Features(property_list_filtering=True),\n        ),\n    ),\n)\n# When True, framework runs filter post-adapter and sets\n# response.property_list_applied = True. When False, framework\n# leaves request.property_list untouched and the adopter handles it\n# (or ignores it).\n```\n\n## Acceptance criteria\n\n- [ ] `filter_products_by_property_list` matches salesagent's three-mode logic (all / strict / permissive) — port the salesagent test suite\n- [ ] Framework runs the filter only when capability is declared AND `req.property_list` is present\n- [ ] Sets `response.property_list_applied = True` when filter applied\n- [ ] Adopter-supplied `PropertyListFetcher` protocol (no hidden HTTP client)\n- [ ] Fetch failures surface as `AdcpError` with `recovery='transient'`, mirroring salesagent's behavior\n- [ ] `validate_platform` warns when `property_list_filtering=True` is declared but no fetcher is wired\n- [ ] Test: product with `selection_type='all'` always passes\n- [ ] Test: product with `property_targeting_allowed=False` requires full subset\n- [ ] Test: `auth_token` threaded through to the fetcher\n\n## Out of scope\n\n- The `list_property_lists` / `create_property_list` task family (already wired in handler at lines 1814-1909)\n- Caching the fetched list across requests (out of scope for v1; framework calls fetcher every time)\n- Seller-side property-list publishing (separate from the buyer-supplied filter)\n\n## Cross-references\n\n- Wire capability: `src/adcp/types/generated_poc/core/media_buy_features.py:18` (`property_list_filtering`)\n- Wire request shape: `src/adcp/types/generated_poc/bundled/media_buy/get_products_request.py:1178-1191` (`PropertyList`)\n- Wire response flag: `src/adcp/types/generated_poc/bundled/media_buy/get_products_response.py:4538-4543` (`property_list_applied`)\n- Salesagent helpers (port these): `src/core/tools/products.py:65-142`\n- Salesagent fetcher: `src/core/property_list_resolver.py`\n- Reference pattern: `src/adcp/decisioning/webhook_emit.py`\n- Parent tracker: #491\n- Migration guide: #489","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-03T21:06:58Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/494"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:bb726858-9021-cf57-0923-e4ef1a02a3ac
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id881E:2D2F2F:F6C21C:13E617C:6B00FF02
html-safe-nonce65426a909286d4986fd81d71f80e6874b7a9e3fa8fd2629bb6024aa08441b6ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODFFOjJEMkYyRjpGNkMyMUM6MTNFNjE3Qzo2QjAwRkYwMiIsInZpc2l0b3JfaWQiOiI2NDUwMjg5ODc5NTg1NzE4MDE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbe9a3d5f741000d8f39d676112c78277e852fe7d40e35b6078ba6d28ff762e40
hovercard-subject-tagissue:4372987403
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/494/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f1dc0b01fa34fa880296acdb2281ee66d87a15c0207bff5462b9a2d21d311ac2/adcontextprotocol/adcp-client-python/issues/494
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f1dc0b01fa34fa880296acdb2281ee66d87a15c0207bff5462b9a2d21d311ac2/adcontextprotocol/adcp-client-python/issues/494
og:image:altMotivation GetProductsRequest.property_list is {agent_url, list_id, auth_token?} — a reference to an externally-managed list of properties the buyer has been authorized to spend on. The seller is e...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/494#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F494
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F494
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/494
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/494
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/494
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/494
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/494
#500https://github.com/adcontextprotocol/adcp-client-python/pull/500
feat(decisioning): property_list resolver + intersection helper for get_productshttps://github.com/adcontextprotocol/adcp-client-python/issues/494#top
#500https://github.com/adcontextprotocol/adcp-client-python/pull/500
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/494#issue-4372987403
#491https://github.com/adcontextprotocol/adcp-client-python/issues/491
feat(decisioning): built-in helpers for buyer-side request-shape parameters on get_products (parent tracker) #491https://github.com/adcontextprotocol/adcp-client-python/issues/491
docs: salesagent → adcp Python SDK migration guide #489https://github.com/adcontextprotocol/adcp-client-python/pull/489
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/494#event-25112647267
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/494#issuecomment-4367236844
#500https://github.com/adcontextprotocol/adcp-client-python/pull/500
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/494#event-25113805884
feat(decisioning): property_list resolver + intersection helper for g…https://github.com/adcontextprotocol/adcp-client-python/commit/84d0bbb0a509874128a3b4536edaed45b31eb9bc
https://docs.github.com/articles/closing-issues-via-commit-messages
84d0bbbhttps://github.com/adcontextprotocol/adcp-client-python/commit/84d0bbb0a509874128a3b4536edaed45b31eb9bc
feat(decisioning): property_list resolver + intersection helper for g…https://github.com/adcontextprotocol/adcp-client-python/commit/1affd73ecc55f5ac7a9f7ea125977905339df2a9
https://docs.github.com/articles/closing-issues-via-commit-messages
1affd73https://github.com/adcontextprotocol/adcp-client-python/commit/1affd73ecc55f5ac7a9f7ea125977905339df2a9
feat(decisioning): property_list resolver + intersection helper for g…https://github.com/adcontextprotocol/adcp-client-python/commit/1dfdcd5e00242e3e79faba6f4a255fe822194cb0
https://docs.github.com/articles/closing-issues-via-commit-messages
1dfdcd5https://github.com/adcontextprotocol/adcp-client-python/commit/1dfdcd5e00242e3e79faba6f4a255fe822194cb0
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#500https://github.com/adcontextprotocol/adcp-client-python/pull/500
on May 3, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/494#event-25113875256
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/494
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/494
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.