Title: feat(decisioning): project full get_adcp_capabilities response schema into DecisioningCapabilities · Issue #479 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: feat(decisioning): project full get_adcp_capabilities response schema into DecisioningCapabilities · Issue #479 · adcontextprotocol/adcp-client-python
X Title: feat(decisioning): project full get_adcp_capabilities response schema into DecisioningCapabilities · Issue #479 · adcontextprotocol/adcp-client-python
Description: 🚧 DO NOT TRIAGE — work in progress, owned by @bokelley. This issue tracks an in-flight PR (bokelley/capabilities-projection). Please don't pick it up. Summary DecisioningCapabilities (src/adcp/decisioning/platform.py:21) declares 7 field...
Open Graph Description: 🚧 DO NOT TRIAGE — work in progress, owned by @bokelley. This issue tracks an in-flight PR (bokelley/capabilities-projection). Please don't pick it up. Summary DecisioningCapabilities (src/adcp/deci...
X Description: 🚧 DO NOT TRIAGE — work in progress, owned by @bokelley. This issue tracks an in-flight PR (bokelley/capabilities-projection). Please don't pick it up. Summary DecisioningCapabilities (src/adcp/...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/479
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(decisioning): project full get_adcp_capabilities response schema into DecisioningCapabilities","articleBody":"> 🚧 **DO NOT TRIAGE — work in progress, owned by @bokelley.** This issue tracks an in-flight PR (`bokelley/capabilities-projection`). Please don't pick it up.\n\n## Summary\n\n`DecisioningCapabilities` (`src/adcp/decisioning/platform.py:21`) declares 7 fields. The AdCP capabilities response schema (`schemas/cache/bundled/protocol/get-adcp-capabilities-response.json`) defines ~25 dimensions across 6 protocol blocks. The handler projection (`src/adcp/decisioning/handler.py:841-925`) emits 5 dimensions. Adopters who need to declare anything past the basics override `get_adcp_capabilities` on a `PlatformHandler` subclass and hand-build the response.\n\nThis isn't feature creep — it's correctness work. The SDK is under-shipping the spec.\n\nRelated: #477 (multi-platform proof — declares full capabilities and validates the projection at scale).\n\n## Scope\n\nProject the full schema into `DecisioningCapabilities` by carrying instances of the already-generated Pydantic sub-models (`Account`, `MediaBuy`, `Targeting`, `GeoMetros`, `Idempotency`, `AudienceTargeting`, `ConversionTracking`, `Signals`, etc. — all in `src/adcp/types/generated_poc/bundled/protocol/get_adcp_capabilities_response.py`).\n\n```python\n@dataclass\nclass DecisioningCapabilities:\n # Dispatch / SDK-internal — kept\n specialisms: list[str] = field(default_factory=list)\n governance_aware: bool = False\n creative_agents: list[Any] = field(default_factory=list)\n config: dict[str, Any] = field(default_factory=dict)\n\n # Spec capability blocks — new, structured to mirror the wire\n adcp: Adcp | None = None\n account: Account | None = None\n media_buy: MediaBuy | None = None\n signals: SignalsCapabilities | None = None\n governance: GovernanceCapabilities | None = None\n sponsored_intelligence: SiCapabilities | None = None\n creative: CreativeCapabilities | None = None\n brand: BrandCapabilities | None = None\n\n # Deprecated — flat shortcuts superseded by structured fields above\n pricing_models: list[str] = field(default_factory=list) # → media_buy.supported_pricing_models\n supported_billing: list[str] = field(default_factory=list) # → account.supported_billing\n channels: list[str] = field(default_factory=list) # unused on wire\n```\n\nAdopters import sub-models from `adcp.decisioning` (re-exported):\n\n```python\nfrom adcp.decisioning import (\n DecisioningCapabilities, Account, MediaBuy, Targeting,\n GeoMetros, GeoPostalAreas, Idempotency,\n)\n\ncapabilities = DecisioningCapabilities(\n specialisms=[\"sales-non-guaranteed\"],\n account=Account(supported_billing=[\"operator\"]),\n media_buy=MediaBuy(\n supported_pricing_models=[\"cpm\"],\n execution=Execution(\n targeting=Targeting(\n geo_countries=True,\n geo_metros=GeoMetros(nielsen_dma=True),\n ),\n ),\n ),\n)\n```\n\n`PlatformHandler.get_adcp_capabilities` projects the structured fields directly via `model_dump`. Adopter overrides become rare.\n\n## Deprecations\n\nThe flat legacy fields (`pricing_models`, `supported_billing`, `channels`) are NOT in the AdCP 3.0 spec — they're SDK convenience shortcuts that pre-dated the structured projection. Deprecating them as part of this work.\n\n- v4.x (this PR): legacy fields keep working with `DeprecationWarning` at server boot when set. Projection rule: structured field wins; fall back to legacy when structured absent.\n- v5.0: remove legacy fields.\n\n`governance_aware`, `creative_agents`, `config`, `specialisms` stay — they're SDK-internal dispatch, not wire shape.\n\n## Acceptance criteria\n\n- [ ] `DecisioningCapabilities` carries every spec capability block via generated sub-models\n- [ ] Sub-models re-exported from `adcp.decisioning`\n- [ ] `PlatformHandler.get_adcp_capabilities` projects all dimensions; round-trips through `validate_response` against `protocol/get-adcp-capabilities-response.json` for every parametrized case\n- [ ] Legacy fields fire `DeprecationWarning` when set; projection rule: structured wins\n- [ ] `validate_capabilities_response_shape` rejects malformed declarations with structured `details`\n- [ ] `examples/v3_reference_seller/src/platform.py` updated to use the new shape (motivating example)\n- [ ] `docs/decisioning/capabilities.md` — adopter-facing guide\n- [ ] No regressions in existing reference-seller storyboard\n\n## Files changed (estimated ~1500 LOC including tests + docs)\n\n- `src/adcp/decisioning/platform.py` — extend `DecisioningCapabilities`\n- `src/adcp/decisioning/handler.py:841-925` — rewrite projection\n- `src/adcp/decisioning/validate_capabilities.py` — stricter checks + deprecation warning trigger\n- `src/adcp/decisioning/__init__.py` — re-export sub-models\n- `src/adcp/server/responses.py:capabilities_response` — accept new sub-block kwargs uniformly\n- `examples/v3_reference_seller/src/platform.py` — adopt new shape\n- `tests/decisioning/test_capabilities_projection.py` — round-trip per dimension\n- `tests/decisioning/test_capabilities_legacy_compat.py` — back-compat + deprecation\n- `docs/decisioning/capabilities.md` — new guide\n\n## Out of scope\n\n- Multi-platform routing — see #477\n- Webhook delivery extensions — see #478\n- UI-only capability flags (e.g. `supports_inventory_sync`, `inventory_entity_label`) used by some operators — these are admin-dashboard concerns, not protocol. Stay in adopter `config`. Doc note explains where.\n\n## Why this matters\n\n1. **Spec fidelity**: any adopter wanting to declare `geo_metros.nielsen_dma`, `creative_specs.vast_versions`, `account.account_financials`, `audience_targeting.minimum_audience_size`, `conversion_tracking.attribution_windows`, etc. doesn't need a custom override.\n2. **Migration target for operator-shaped capability dataclasses**: parallel `TargetingCapabilities` / `AdapterCapabilities` patterns in downstreams collapse into `DecisioningCapabilities` once the SDK can declare them.\n3. **Capability-driven validation**: future work — runtime enforcement that platform behavior matches declared capabilities. With full coverage we can validate semantics, not just shape.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-03T14:20:26Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/479"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f24ebbfb-bbcb-0f66-8ca2-109909691f60 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AB20:1201C:C4713C:106CDA9:6B00F764 |
| html-safe-nonce | 6b11202371b480110fff706c7bc4a9d9f1f516406bc81436d360f6af14273e7f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjIwOjEyMDFDOkM0NzEzQzoxMDZDREE5OjZCMDBGNzY0IiwidmlzaXRvcl9pZCI6IjE1MTgxODY3ODUzNDIwMjc2MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3a7190f95bd64d463b8217ed29591c28abc51cb56c5362a579359f256f2f6aed |
| hovercard-subject-tag | issue:4372037053 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/479/issue_layout |
| twitter:image | https://opengraph.githubassets.com/cb46e4770f636b1259924a8d76376b74741ac178c0255707330ecc6e53f77179/adcontextprotocol/adcp-client-python/issues/479 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cb46e4770f636b1259924a8d76376b74741ac178c0255707330ecc6e53f77179/adcontextprotocol/adcp-client-python/issues/479 |
| og:image:alt | 🚧 DO NOT TRIAGE — work in progress, owned by @bokelley. This issue tracks an in-flight PR (bokelley/capabilities-projection). Please don't pick it up. Summary DecisioningCapabilities (src/adcp/deci... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width