Title: feat(client): looksLikeV3Capabilities — drop the v2-downgrade footgun on capabilities-validation failure · Issue #461 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: feat(client): looksLikeV3Capabilities — drop the v2-downgrade footgun on capabilities-validation failure · Issue #461 · adcontextprotocol/adcp-client-python
X Title: feat(client): looksLikeV3Capabilities — drop the v2-downgrade footgun on capabilities-validation failure · Issue #461 · adcontextprotocol/adcp-client-python
Description: Parent: #452 JS source 6.6.0 commit 27bd79d fix(client): don't downgrade obvious v3 agents to v2. Bug class SingleAgentClient.get_capabilities() falls back to v2 synthetic capabilities on any failure. This causes confusing "AdCP schema d...
Open Graph Description: Parent: #452 JS source 6.6.0 commit 27bd79d fix(client): don't downgrade obvious v3 agents to v2. Bug class SingleAgentClient.get_capabilities() falls back to v2 synthetic capabilities on any failu...
X Description: Parent: #452 JS source 6.6.0 commit 27bd79d fix(client): don't downgrade obvious v3 agents to v2. Bug class SingleAgentClient.get_capabilities() falls back to v2 synthetic capabilities on any f...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/461
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(client): looksLikeV3Capabilities — drop the v2-downgrade footgun on capabilities-validation failure","articleBody":"Parent: #452\n\n## JS source\n\n6.6.0 commit `27bd79d fix(client): don't downgrade obvious v3 agents to v2`.\n\n## Bug class\n\n`SingleAgentClient.get_capabilities()` falls back to v2 synthetic capabilities on any failure. This causes confusing \"AdCP schema data for version v2.5 not found\" cascades when a v3 agent has a single shape bug — e.g. one missing field on `Account`. The user sees a v2 error trail with no obvious connection to the actual v3 validation failure.\n\n## Fix\n\nTighten the heuristic — when `result.success is False` but `result.data` is structurally v3-shaped, parse anyway, surface the validation failure loudly, continue with v3 caps. Don't silently downgrade.\n\n`looks_like_v3_capabilities(data)` heuristic: presence of v3-only fields (e.g., `governance_agents`, v3-shaped `pricing_options`, etc.) on the response shape.\n\nPort the same heuristic from JS to Python's client.\n\n## Acceptance criteria\n\n- `looks_like_v3_capabilities` helper in client.\n- `SingleAgentClient.get_capabilities()` no longer silently downgrades to v2 when input is obviously v3.\n- Surfaces the v3 validation error directly.\n- Tests cover: clean v3 (passes), v3 with one shape bug (loud v3 error, no v2 cascade), genuine v2 (downgrades correctly).","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-03T11:29:44Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/461"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d1cdb35d-9020-cfd2-effc-3a8f87ab3e01 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8818:3A347:CCB267:11091E6:6B00F8A9 |
| html-safe-nonce | d2dc5ab6596c1bb767708fd73941055b12bd9d963644ab600728aaf4a173901d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODE4OjNBMzQ3OkNDQjI2NzoxMTA5MUU2OjZCMDBGOEE5IiwidmlzaXRvcl9pZCI6IjQxNDM5MDE4NTE5MDcwNjE5MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cfd97795d48a08a0d55ab52791b10faae496efc97356ce7f6fe0ca4effe59d06 |
| hovercard-subject-tag | issue:4371633579 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/461/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e5501c8b19ab129278f1181f11d7637ae02671bf0edf6a19ad34f93147aa7b52/adcontextprotocol/adcp-client-python/issues/461 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e5501c8b19ab129278f1181f11d7637ae02671bf0edf6a19ad34f93147aa7b52/adcontextprotocol/adcp-client-python/issues/461 |
| og:image:alt | Parent: #452 JS source 6.6.0 commit 27bd79d fix(client): don't downgrade obvious v3 agents to v2. Bug class SingleAgentClient.get_capabilities() falls back to v2 synthetic capabilities on any failu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width