Title: feat(server): Account v3 wire fields + AccountStore.upsert/list/syncGovernance receive ResolveContext · Issue #456 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: feat(server): Account v3 wire fields + AccountStore.upsert/list/syncGovernance receive ResolveContext · Issue #456 · adcontextprotocol/adcp-client-python
X Title: feat(server): Account v3 wire fields + AccountStore.upsert/list/syncGovernance receive ResolveContext · Issue #456 · adcontextprotocol/adcp-client-python
Description: Parent: #452 Two paired changes that together unlock principal-keyed account governance. (a) Account v3 wire fields Extend the SDK's Account shape to carry: setup (pending_approval lifecycle): {url?, message, expires_at?} governance_agen...
Open Graph Description: Parent: #452 Two paired changes that together unlock principal-keyed account governance. (a) Account v3 wire fields Extend the SDK's Account shape to carry: setup (pending_approval lifecycle): {url...
X Description: Parent: #452 Two paired changes that together unlock principal-keyed account governance. (a) Account v3 wire fields Extend the SDK's Account shape to carry: setup (pending_approval lifecycle): ...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/456
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(server): Account v3 wire fields + AccountStore.upsert/list/syncGovernance receive ResolveContext","articleBody":"Parent: #452\n\nTwo paired changes that together unlock principal-keyed account governance.\n\n## (a) Account v3 wire fields\n\nExtend the SDK's `Account` shape to carry:\n\n- `setup` (pending_approval lifecycle): `{url?, message, expires_at?}`\n- `governance_agents`\n- `account_scope`: `operator | brand | operator_brand | agent`\n- `payment_terms`\n- `credit_limit`\n- `rate_card`\n\n`to_wire_account()` projection strips `billing_entity.bank` (write-only on emit).\n\nAlready partially present; finish.\n\n## (b) AccountStore.upsert(ctx) / list(ctx) / sync_governance(ctx)\n\nPass `ResolveContext` (auth_info, tool_name, agent) to `upsert` and `list` per JS `account-store-upsert-list-ctx.md`.\n\nPromote `sync_governance` to typed `AccountStore.sync_governance(entries, ctx)` with framework-side credential write-only-strip on emit (per JS `account-store-sync-governance.md`). Specifically: `governance_agents[i].authentication.credentials` is stripped on the way out.\n\n## Why this matters\n\nSecurity-relevant: enables principal-keyed gates for `BILLING_NOT_PERMITTED_FOR_AGENT` per #449's spec. Pre-this, no way to scope `accounts.list` per-principal — implementations either over-disclose or reject.\n\nIt's also the dependency #5 (`create_tenant_store`) needs to bake a per-entry tenant gate into the framework.\n\n## JS source\n\n`.changeset/account-store-upsert-list-ctx.md` and `.changeset/account-store-sync-governance.md` (6.7).\n\n## Acceptance criteria\n\n- `Account` shape extensions with Pydantic models for `setup`, `governance_agents`, `account_scope`, `payment_terms`, `credit_limit`, `rate_card`.\n- `to_wire_account()` strips `billing_entity.bank`.\n- `AccountStore.upsert`, `AccountStore.list`, `AccountStore.sync_governance` all receive `ResolveContext` as a typed parameter.\n- Credential-strip on `sync_governance` emit covered by tests.\n- Tests for each new wire field round-tripping through validation.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-03T11:28:45Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/456"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f1525712-b51e-97d1-994a-d9e9c23835c6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D050:24A0A:1D1AC3:24827C:6B00F693 |
| html-safe-nonce | 8f6d37f486ffa82230ef1c143221d0d0ece4bb8d42533a2bcecef97314d7e5bd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDUwOjI0QTBBOjFEMUFDMzoyNDgyN0M6NkIwMEY2OTMiLCJ2aXNpdG9yX2lkIjoiNjg0OTE3NjAyOTM3NDc3Mjg4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3a5ebe62073710871dc35f6fcb2169dca951d82693efe258255863ae1773e779 |
| hovercard-subject-tag | issue:4371631292 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/456/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8dd68fa7ee1420da58fa08c1642d1ba52cef70e689337a44f2acd8e768c9ee05/adcontextprotocol/adcp-client-python/issues/456 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8dd68fa7ee1420da58fa08c1642d1ba52cef70e689337a44f2acd8e768c9ee05/adcontextprotocol/adcp-client-python/issues/456 |
| og:image:alt | Parent: #452 Two paired changes that together unlock principal-keyed account governance. (a) Account v3 wire fields Extend the SDK's Account shape to carry: setup (pending_approval lifecycle): {url... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width