Title: feat(testing): docstring-vs-code consistency test · Issue #424 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: feat(testing): docstring-vs-code consistency test · Issue #424 · adcontextprotocol/adcp-client-python
X Title: feat(testing): docstring-vs-code consistency test · Issue #424 · adcontextprotocol/adcp-client-python
Description: Context client.py:381-388 claimed PYTHON_ENV / ENV / ENVIRONMENT env vars were honored; only ADCP_ENV was. Docstring was stale for months. Add a test that AST-parses public method docstrings, looks for env-var references, then greps the ...
Open Graph Description: Context client.py:381-388 claimed PYTHON_ENV / ENV / ENVIRONMENT env vars were honored; only ADCP_ENV was. Docstring was stale for months. Add a test that AST-parses public method docstrings, looks...
X Description: Context client.py:381-388 claimed PYTHON_ENV / ENV / ENVIRONMENT env vars were honored; only ADCP_ENV was. Docstring was stale for months. Add a test that AST-parses public method docstrings, looks...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/424
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(testing): docstring-vs-code consistency test","articleBody":"## Context\n\n`client.py:381-388` claimed `PYTHON_ENV` / `ENV` / `ENVIRONMENT` env vars were honored; only `ADCP_ENV` was. Docstring was stale for months.\n\nAdd a test that AST-parses public method docstrings, looks for env-var references, then greps the code for matching `os.environ.get(...)` calls. Drift = test failure.\n\n## Acceptance Criteria\n\n- [ ] New `tests/test_docstring_consistency.py`\n- [ ] AST-parses public method docstrings in `src/adcp/`\n- [ ] Extracts env-var references and verifies a matching `os.environ.get(...)` call exists\n- [ ] CI fails on drift\n\n## Files\n\n- `src/adcp/client.py:381-388` (the original drift)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-03T02:40:11Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/424"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a79ba2cb-4e9f-761e-7456-d7bc427910f3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C6F0:25598F:D51E10:11AC739:6B00FB87 |
| html-safe-nonce | 134df18f2610ad040aa8cb4dd3a42247668631c59138de3a95e91871c0faf627 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkYwOjI1NTk4RjpENTFFMTA6MTFBQzczOTo2QjAwRkI4NyIsInZpc2l0b3JfaWQiOiIyMzE4NDAyOTUxMzc2MzM3Nzk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f63c11231e185cf5fdf7278f6d96e3401ec5a19d577f64dc04c82002e1129a45 |
| hovercard-subject-tag | issue:4370675333 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/424/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6f3af3f2972bdcdf40e3c3b92363b2ee14ac47dc7061a97ac4a291f3386e8d42/adcontextprotocol/adcp-client-python/issues/424 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6f3af3f2972bdcdf40e3c3b92363b2ee14ac47dc7061a97ac4a291f3386e8d42/adcontextprotocol/adcp-client-python/issues/424 |
| og:image:alt | Context client.py:381-388 claimed PYTHON_ENV / ENV / ENVIRONMENT env vars were honored; only ADCP_ENV was. Docstring was stale for months. Add a test that AST-parses public method docstrings, looks... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width