Title: feat(testing): spec-conformance test for AdcpError code names against error-code.json enum · Issue #416 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: feat(testing): spec-conformance test for AdcpError code names against error-code.json enum · Issue #416 · adcontextprotocol/adcp-client-python
X Title: feat(testing): spec-conformance test for AdcpError code names against error-code.json enum · Issue #416 · adcontextprotocol/adcp-client-python
Description: Context The AGENT_SUSPENDED, AGENT_BLOCKED, REQUEST_AUTH_UNRECOGNIZED_AGENT, and INVALID_BILLING_MODEL codes shipped for months as non-spec (caught in #375 / fixed in PR #393). Drift was only caught by manual review. Add an automated tes...
Open Graph Description: Context The AGENT_SUSPENDED, AGENT_BLOCKED, REQUEST_AUTH_UNRECOGNIZED_AGENT, and INVALID_BILLING_MODEL codes shipped for months as non-spec (caught in #375 / fixed in PR #393). Drift was only caugh...
X Description: Context The AGENT_SUSPENDED, AGENT_BLOCKED, REQUEST_AUTH_UNRECOGNIZED_AGENT, and INVALID_BILLING_MODEL codes shipped for months as non-spec (caught in #375 / fixed in PR #393). Drift was only caugh...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/416
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(testing): spec-conformance test for AdcpError code names against error-code.json enum","articleBody":"## Context\n\nThe `AGENT_SUSPENDED`, `AGENT_BLOCKED`, `REQUEST_AUTH_UNRECOGNIZED_AGENT`, and `INVALID_BILLING_MODEL` codes shipped for months as non-spec (caught in #375 / fixed in PR #393). Drift was only caught by manual review.\n\nAdd an automated test that walks all `AdcpError(\\\"CODE\\\", ...)` raise sites in `src/adcp/` (AST or grep) and asserts the code is in the canonical `static/schemas/source/enums/error-code.json` enum (or has the `X_` vendor prefix). Catches future drift at PR time.\n\n## Acceptance Criteria\n\n- [ ] New `tests/test_error_code_conformance.py`\n- [ ] Walks all `AdcpError(\\\"CODE\\\", ...)` raise sites in `src/adcp/`\n- [ ] Asserts code is in `static/schemas/source/enums/error-code.json` enum or has `X_` vendor prefix\n- [ ] Runs in CI; fails CI on any non-spec code\n\n## Refs\n\n- Issue #375, PR #393","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-03T02:39:24Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/416"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:86c0b5b6-613f-f72f-8f9c-28bcab06450d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B624:2270F4:D90B9E:1219F22:6B01008B |
| html-safe-nonce | cfb92fd6f76318517a38e3caecc825f0aa80dd79b573e60621b9c82a645f7a8f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjI0OjIyNzBGNDpEOTBCOUU6MTIxOUYyMjo2QjAxMDA4QiIsInZpc2l0b3JfaWQiOiI3OTIxMTI4MDYzMTkzMTIwOTA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | de077011b7a7ad06ef63e4362abf8020cd7b6eaee3f7be888d4c3fc878626387 |
| hovercard-subject-tag | issue:4370674237 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/416/issue_layout |
| twitter:image | https://opengraph.githubassets.com/01cc8fbaa98c478c813f3813fd138ff23f150bb18477f742aa6062596a5513c3/adcontextprotocol/adcp-client-python/issues/416 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/01cc8fbaa98c478c813f3813fd138ff23f150bb18477f742aa6062596a5513c3/adcontextprotocol/adcp-client-python/issues/416 |
| og:image:alt | Context The AGENT_SUSPENDED, AGENT_BLOCKED, REQUEST_AUTH_UNRECOGNIZED_AGENT, and INVALID_BILLING_MODEL codes shipped for months as non-spec (caught in #375 / fixed in PR #393). Drift was only caugh... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width