Title: feat(v3-ref-seller): Alembic migration scaffold replacing Base.metadata.create_all · Issue #382 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: feat(v3-ref-seller): Alembic migration scaffold replacing Base.metadata.create_all · Issue #382 · adcontextprotocol/adcp-client-python
X Title: feat(v3-ref-seller): Alembic migration scaffold replacing Base.metadata.create_all · Issue #382 · adcontextprotocol/adcp-client-python
Description: Context The v3 reference seller boots via Base.metadata.create_all. This is idempotent on table existence, but does NOT detect: column renames column type changes new columns on existing tables removed columns index changes Production ad...
Open Graph Description: Context The v3 reference seller boots via Base.metadata.create_all. This is idempotent on table existence, but does NOT detect: column renames column type changes new columns on existing tables rem...
X Description: Context The v3 reference seller boots via Base.metadata.create_all. This is idempotent on table existence, but does NOT detect: column renames column type changes new columns on existing tables rem...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/382
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(v3-ref-seller): Alembic migration scaffold replacing Base.metadata.create_all","articleBody":"## Context\n\nThe v3 reference seller boots via `Base.metadata.create_all`. This is idempotent on table existence, but does NOT detect:\n\n- column renames\n- column type changes\n- new columns on existing tables\n- removed columns\n- index changes\n\nProduction adopters cloning this example need a real migration story. Without one, the example is misleading — adopters will copy `create_all` into prod and get burned the first time the schema evolves.\n\nRefs:\n- `examples/v3_reference_seller/src/app.py` (boot path with `create_all`)\n- `examples/v3_reference_seller/src/models.py`\n\n## Acceptance Criteria\n\n- [ ] Minimal Alembic setup under `examples/v3_reference_seller/alembic/` (env.py, alembic.ini, versions/)\n- [ ] One initial migration that matches the current schema exactly\n- [ ] Boot path runs `alembic upgrade head` (or refuses to start if migrations are out of date) instead of `create_all`\n- [ ] README documents the workflow: how to generate a new migration, how to apply, how to roll back\n- [ ] Integration test runs migrations against a clean database and asserts schema matches `Base.metadata`","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-03T00:29:54Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/382"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ce29d434-9d50-1053-fcf4-3876108ef2f6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A5CC:A99C2:FEF17F:14737E6:6B00FF0E |
| html-safe-nonce | ecd28cbde3354ab090b0ea0f84e6e9208cab3d6306e5de1df0a8db63afd8b00d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUNDOkE5OUMyOkZFRjE3RjoxNDczN0U2OjZCMDBGRjBFIiwidmlzaXRvcl9pZCI6IjQ0Mzc2ODEyODI4NTU1MzQzNTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1e9802e25b572b20570787da6892ab9f80344a57b514db4c4922b84019aab2fe |
| hovercard-subject-tag | issue:4370449142 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/382/issue_layout |
| twitter:image | https://opengraph.githubassets.com/57fe85bbeb30f71a4a43c38845ca23b55529169b59a627aea3b0ce207f88d961/adcontextprotocol/adcp-client-python/issues/382 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/57fe85bbeb30f71a4a43c38845ca23b55529169b59a627aea3b0ce207f88d961/adcontextprotocol/adcp-client-python/issues/382 |
| og:image:alt | Context The v3 reference seller boots via Base.metadata.create_all. This is idempotent on table existence, but does NOT detect: column renames column type changes new columns on existing tables rem... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width