Title: feat(v3-ref-seller): implement 4 spec-required sales-* methods (get_media_buys, provide_performance_feedback, list_creative_formats, list_creatives) · Issue #376 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: feat(v3-ref-seller): implement 4 spec-required sales-* methods (get_media_buys, provide_performance_feedback, list_creative_formats, list_creatives) · Issue #376 · adcontextprotocol/adcp-client-python
X Title: feat(v3-ref-seller): implement 4 spec-required sales-* methods (get_media_buys, provide_performance_feedback, list_creative_formats, list_creatives) · Issue #376 · adcontextprotocol/adcp-client-python
Description: Context The v3 reference seller declares specialisms=("sales-non-guaranteed",) in its DecisioningCapabilities, but is missing four methods that the sales-non-guaranteed specialism contract requires. In v6.0 rc.1 validate_platform() will ...
Open Graph Description: Context The v3 reference seller declares specialisms=("sales-non-guaranteed",) in its DecisioningCapabilities, but is missing four methods that the sales-non-guaranteed specialism contract requires...
X Description: Context The v3 reference seller declares specialisms=("sales-non-guaranteed",) in its DecisioningCapabilities, but is missing four methods that the sales-non-guaranteed specialism contrac...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/376
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(v3-ref-seller): implement 4 spec-required sales-* methods (get_media_buys, provide_performance_feedback, list_creative_formats, list_creatives)","articleBody":"## Context\n\nThe v3 reference seller declares `specialisms=(\"sales-non-guaranteed\",)` in its `DecisioningCapabilities`, but is missing four methods that the `sales-non-guaranteed` specialism contract requires. In v6.0 rc.1 `validate_platform()` will reject these adopters at boot.\n\nRefs:\n- `examples/v3_reference_seller/src/platform.py`\n- `src/adcp/decisioning/specialisms/sales.py:184-227` (specialism contract)\n\n## Missing methods\n\n1. `get_media_buys` — list media buys scoped to the dispatching buyer/principal. Returns the spec `get-media-buys-response` shape.\n2. `provide_performance_feedback` — accept buyer-side performance signals attached to a media buy or package. Persist for downstream optimization. Returns the spec `provide-performance-feedback-response` shape.\n3. `list_creative_formats` — return the formats the seller supports (with channel + dimensions + asset slots). Returns the spec `list-creative-formats-response` shape.\n4. `list_creatives` — list previously-synced creatives for the dispatching principal, with filtering. Returns the spec `list-creatives-response` shape.\n\n## Acceptance Criteria\n\n- [ ] All 4 methods implemented in `examples/v3_reference_seller/src/platform.py`\n- [ ] Persist to existing or new ORM tables (no in-memory only)\n- [ ] Return spec-shaped responses validated against the AdCP JSON schemas\n- [ ] Smoke tests (or storyboard runs) cover each new method\n- [ ] `validate_platform()` passes with `specialisms=(\"sales-non-guaranteed\",)`","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-03T00:29:07Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/376"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:eaaef488-8034-23ab-ffa6-f7a69e5c8dba |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 80FC:DA744:CC14CE:112DB9A:6B010221 |
| html-safe-nonce | 6ff38e9c97dd289d9b5e56f57d0984580176025946cbefae328e3560f7a959a5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEZDOkRBNzQ0OkNDMTRDRToxMTJEQjlBOjZCMDEwMjIxIiwidmlzaXRvcl9pZCI6IjQwMzc1OTg3Nzg1MTYxMTE5MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 34369a6e2b3abfabbe4a9bfddae840c6dbe4f5eada0c7bec2e70184ecbbc0e74 |
| hovercard-subject-tag | issue:4370447948 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/376/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2ccb7d61eba84165097e6addf7255b20be75cbd341696232ee54e6edf3c6f105/adcontextprotocol/adcp-client-python/issues/376 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2ccb7d61eba84165097e6addf7255b20be75cbd341696232ee54e6edf3c6f105/adcontextprotocol/adcp-client-python/issues/376 |
| og:image:alt | Context The v3 reference seller declares specialisms=("sales-non-guaranteed",) in its DecisioningCapabilities, but is missing four methods that the sales-non-guaranteed specialism contract requires... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width