Title: feat(types): Account v3 projection helpers (billing_entity write-only bank-details guard, reporting_bucket) · Issue #356 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: feat(types): Account v3 projection helpers (billing_entity write-only bank-details guard, reporting_bucket) · Issue #356 · adcontextprotocol/adcp-client-python
X Title: feat(types): Account v3 projection helpers (billing_entity write-only bank-details guard, reporting_bucket) · Issue #356 · adcontextprotocol/adcp-client-python
Description: Summary Spec 3.0.x adds billing_entity (B2B invoicing entity, bank details write-only — MUST NOT serialize on response) and reporting_bucket. Need projection helpers so adopters don't accidentally leak bank details on read. Design Bank-d...
Open Graph Description: Summary Spec 3.0.x adds billing_entity (B2B invoicing entity, bank details write-only — MUST NOT serialize on response) and reporting_bucket. Need projection helpers so adopters don't accidentally ...
X Description: Summary Spec 3.0.x adds billing_entity (B2B invoicing entity, bank details write-only — MUST NOT serialize on response) and reporting_bucket. Need projection helpers so adopters don't accidenta...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/356
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(types): Account v3 projection helpers (billing_entity write-only bank-details guard, reporting_bucket)","articleBody":"## Summary\n\nSpec 3.0.x adds `billing_entity` (B2B invoicing entity, **bank details write-only — MUST NOT serialize on response**) and `reporting_bucket`. Need projection helpers so adopters don't accidentally leak bank details on read.\n\n## Design\n\n### Bank-details guard\n\nTwo options — pick one during implementation:\n\n1. Pydantic `model_validator` on the `Account` type that strips `billing_entity.bank_details` on response serialization\n2. Separate `AccountResponse` projection type with bank details omitted from the model entirely\n\nOption 2 is more explicit and harder to misuse — leaning that way pending discussion.\n\n### Migration\n\nAlembic migration template for adopters with existing Account tables to add the new columns:\n\n- `billing_entity` (JSON column or normalized table)\n- `reporting_bucket` (string column)\n\n## Why this matters\n\nPrevents the bank-details-on-read leak that's easy to miss during adopter implementation. The spec is clear that bank details are write-only, but Pydantic's default serialization round-trips everything.\n\n## Cross-references\n\n- RFC: [docs/proposals/v3-identity-bundle-design.md](https://github.com/adcontextprotocol/adcp-client-python/blob/main/docs/proposals/v3-identity-bundle-design.md)\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-05-02T17:52:28Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/356"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e2408658-f642-4961-6be8-5979fa59321a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 97E6:1C94F:2AD925:36B070:6B01023C |
| html-safe-nonce | 896e95ad0a9ae9dbda0b26142bad7b98932aae64a36a01cc6e5b3569e3e14504 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0U2OjFDOTRGOjJBRDkyNTozNkIwNzA6NkIwMTAyM0MiLCJ2aXNpdG9yX2lkIjoiMzY4Mjk2NjI5MjQxMjgyNjE3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 195710d4df4f390d24a1f5a09a0ec2f2371acd7431f3ec7d3c9526c0ea502e4c |
| hovercard-subject-tag | issue:4369623203 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/356/issue_layout |
| twitter:image | https://opengraph.githubassets.com/72ea90e1f898aebe154d12f44a088b779ed5fa29257dba61271bd100c46a08c7/adcontextprotocol/adcp-client-python/issues/356 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/72ea90e1f898aebe154d12f44a088b779ed5fa29257dba61271bd100c46a08c7/adcontextprotocol/adcp-client-python/issues/356 |
| og:image:alt | Summary Spec 3.0.x adds billing_entity (B2B invoicing entity, bank details write-only — MUST NOT serialize on response) and reporting_bucket. Need projection helpers so adopters don't accidentally ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width