Title: storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence) · Issue #319 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence) · Issue #319 · adcontextprotocol/adcp-client-python
X Title: storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence) · Issue #319 · adcontextprotocol/adcp-client-python
Description: Context Now that #317 closed controller_detected: false, end-to-end against examples/seller_agent.py reports 36/47 passing, 5 failed, controller_detected: true. Verified by tracing the runner's calls: the runner only invokes comply_test_...
Open Graph Description: Context Now that #317 closed controller_detected: false, end-to-end against examples/seller_agent.py reports 36/47 passing, 5 failed, controller_detected: true. Verified by tracing the runner's cal...
X Description: Context Now that #317 closed controller_detected: false, end-to-end against examples/seller_agent.py reports 36/47 passing, 5 failed, controller_detected: true. Verified by tracing the runner's...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/319
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence)","articleBody":"## Context\n\nNow that #317 closed `controller_detected: false`, end-to-end against `examples/seller_agent.py` reports **36/47 passing, 5 failed, `controller_detected: true`**. Verified by tracing the runner's calls: the runner only invokes `comply_test_controller` for `simulate_delivery` — it does **not** call `seed_product`/`seed_media_buy`/etc. for the `media_buy_seller` storyboard suite. The 5 failures are real implementation gaps, not seed-wiring issues.\n\n```\noverall_status: partial (36/47, controller_detected: true)\n```\n\n## The 5 failures, grouped\n\n### Category A — runner expects two named test products in the catalog (2 failures)\n\nThe runner uses these product IDs across multiple storyboard scenarios and expects the seller to know them out of the box:\n\n- `outdoor_display_q2` — used by `media_buy_seller/delivery_reporting`\n- `sports_preroll_q2` — used by `media_buy_seller` top-level\n\n`DemoSeller`'s `PRODUCTS` only includes `premium-homepage` and `run-of-site`. **Fix:** add these two as additional entries to `PRODUCTS`. Both need full schema-required shape (`format_ids`, `pricing_options`, `reporting_capabilities`, `delivery_measurement`).\n\n### Category B — seller doesn't validate aggressive measurement_terms (1 failure)\n\n`media_buy_seller/measurement_terms_rejected` proposes a `measurement_terms` block exceeding what the seller would accept (e.g. impossibly high viewability threshold or restrictive required attributes) and expects:\n\n```json\n{ \"errors\": [{ \"code\": \"TERMS_REJECTED\", \"recovery\": \"correctable\", ... }] }\n```\n\n`DemoSeller.create_media_buy` doesn't inspect `measurement_terms` at all. **Fix:** add a small validator that rejects `viewability_threshold > 80` (or similar threshold) with `adcp_error(\"TERMS_REJECTED\", ..., field=\"measurement_terms\")`.\n\n### Category C — `targeting_overlay` not persisted on packages (2 failures)\n\n`media_buy_seller/inventory_list_targeting` exercises:\n1. `create_media_buy` with `packages[*].targeting_overlay.property_list.list_id: \"acme_outdoor_allowlist_v1\"`\n2. `get_media_buys` — runner asserts `/media_buys/0/packages/0/targeting_overlay/property_list/list_id` matches what was sent.\n3. `update_media_buy` swaps in `acme_outdoor_no_match_v1`\n4. `get_media_buys` — runner asserts the new value persisted.\n\nToday `DemoSeller.create_media_buy` strips packages down to `package_id, product_id, pricing_option_id, budget` — `targeting_overlay` is dropped. Same for the update path.\n\n**Fix:** preserve `targeting_overlay` (and any other caller-supplied package fields) on the persisted package state, and surface them on `get_media_buys`. Symmetric pass-through on `update_media_buy`.\n\n## What was verified manually\n\n- `seed_product` works correctly when called directly (probed via `comply_test_controller(scenario=\"seed_product\", ...)`); product appears in subsequent `get_products`. The 2 failures in Category A are NOT seed-wiring bugs — the runner just doesn't call seed_product for these storyboards.\n- `controller_detected: true` after 4.2.0 — confirmed by storyboard JSON output.\n\n## Verification target\n\nAfter all three fixes:\n\n```\noverall_status: pass\ncontroller_detected: true\nsummary.steps_passed: 47\n```\n\n…which lets the storyboard CI job (`continue-on-error: true` today) promote to required.\n\n## References\n\n- Predecessor PRs: #310 (initial 6 fixes), #313 (DemoStore overrides), #317 (controller_detected fix), #315 (seed_creative_format + force_session_status advertisement)\n- Storyboard CI job: #309 (informational), promotes to required once this issue closes\n- Released as part of v4.2.0 bringing storyboard from `unreachable` → 36/47 passing\n","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-30T13:26:27Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/319"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8a73e686-82d9-a347-c8ad-443e6761eef7 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 96BE:363D8E:E9EDC1:12C14B0:6B00F6C8 |
| html-safe-nonce | 1f3fa1aa9c3b50073e6e1ac14c50a460743db6efce6f45d7c098489b1373464b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkJFOjM2M0Q4RTpFOUVEQzE6MTJDMTRCMDo2QjAwRjZDOCIsInZpc2l0b3JfaWQiOiI2NDk4MzQwMjEyNzU2NzcyNTUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | de98ed2d07b62cd2ecfdd279187bb08ddb51a29fea2a464005f470d0ebb86144 |
| hovercard-subject-tag | issue:4358467426 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/319/issue_layout |
| twitter:image | https://opengraph.githubassets.com/99e8a910dea223e113091ca3e9fddc4c21ae5d412d13163df6897b894d68a220/adcontextprotocol/adcp-client-python/issues/319 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/99e8a910dea223e113091ca3e9fddc4c21ae5d412d13163df6897b894d68a220/adcontextprotocol/adcp-client-python/issues/319 |
| og:image:alt | Context Now that #317 closed controller_detected: false, end-to-end against examples/seller_agent.py reports 36/47 passing, 5 failed, controller_detected: true. Verified by tracing the runner's cal... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width