René's URL Explorer Experiment


Title: storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence) · Issue #319 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence) · Issue #319 · adcontextprotocol/adcp-client-python

X Title: storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence) · Issue #319 · adcontextprotocol/adcp-client-python

Description: Context Now that #317 closed controller_detected: false, end-to-end against examples/seller_agent.py reports 36/47 passing, 5 failed, controller_detected: true. Verified by tracing the runner's calls: the runner only invokes comply_test_...

Open Graph Description: Context Now that #317 closed controller_detected: false, end-to-end against examples/seller_agent.py reports 36/47 passing, 5 failed, controller_detected: true. Verified by tracing the runner's cal...

X Description: Context Now that #317 closed controller_detected: false, end-to-end against examples/seller_agent.py reports 36/47 passing, 5 failed, controller_detected: true. Verified by tracing the runner's...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/319

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence)","articleBody":"## Context\n\nNow that #317 closed `controller_detected: false`, end-to-end against `examples/seller_agent.py` reports **36/47 passing, 5 failed, `controller_detected: true`**. Verified by tracing the runner's calls: the runner only invokes `comply_test_controller` for `simulate_delivery` — it does **not** call `seed_product`/`seed_media_buy`/etc. for the `media_buy_seller` storyboard suite. The 5 failures are real implementation gaps, not seed-wiring issues.\n\n```\noverall_status: partial    (36/47, controller_detected: true)\n```\n\n## The 5 failures, grouped\n\n### Category A — runner expects two named test products in the catalog (2 failures)\n\nThe runner uses these product IDs across multiple storyboard scenarios and expects the seller to know them out of the box:\n\n- `outdoor_display_q2` — used by `media_buy_seller/delivery_reporting`\n- `sports_preroll_q2` — used by `media_buy_seller` top-level\n\n`DemoSeller`'s `PRODUCTS` only includes `premium-homepage` and `run-of-site`. **Fix:** add these two as additional entries to `PRODUCTS`. Both need full schema-required shape (`format_ids`, `pricing_options`, `reporting_capabilities`, `delivery_measurement`).\n\n### Category B — seller doesn't validate aggressive measurement_terms (1 failure)\n\n`media_buy_seller/measurement_terms_rejected` proposes a `measurement_terms` block exceeding what the seller would accept (e.g. impossibly high viewability threshold or restrictive required attributes) and expects:\n\n```json\n{ \"errors\": [{ \"code\": \"TERMS_REJECTED\", \"recovery\": \"correctable\", ... }] }\n```\n\n`DemoSeller.create_media_buy` doesn't inspect `measurement_terms` at all. **Fix:** add a small validator that rejects `viewability_threshold > 80` (or similar threshold) with `adcp_error(\"TERMS_REJECTED\", ..., field=\"measurement_terms\")`.\n\n### Category C — `targeting_overlay` not persisted on packages (2 failures)\n\n`media_buy_seller/inventory_list_targeting` exercises:\n1. `create_media_buy` with `packages[*].targeting_overlay.property_list.list_id: \"acme_outdoor_allowlist_v1\"`\n2. `get_media_buys` — runner asserts `/media_buys/0/packages/0/targeting_overlay/property_list/list_id` matches what was sent.\n3. `update_media_buy` swaps in `acme_outdoor_no_match_v1`\n4. `get_media_buys` — runner asserts the new value persisted.\n\nToday `DemoSeller.create_media_buy` strips packages down to `package_id, product_id, pricing_option_id, budget` — `targeting_overlay` is dropped. Same for the update path.\n\n**Fix:** preserve `targeting_overlay` (and any other caller-supplied package fields) on the persisted package state, and surface them on `get_media_buys`. Symmetric pass-through on `update_media_buy`.\n\n## What was verified manually\n\n- `seed_product` works correctly when called directly (probed via `comply_test_controller(scenario=\"seed_product\", ...)`); product appears in subsequent `get_products`. The 2 failures in Category A are NOT seed-wiring bugs — the runner just doesn't call seed_product for these storyboards.\n- `controller_detected: true` after 4.2.0 — confirmed by storyboard JSON output.\n\n## Verification target\n\nAfter all three fixes:\n\n```\noverall_status: pass\ncontroller_detected: true\nsummary.steps_passed: 47\n```\n\n…which lets the storyboard CI job (`continue-on-error: true` today) promote to required.\n\n## References\n\n- Predecessor PRs: #310 (initial 6 fixes), #313 (DemoStore overrides), #317 (controller_detected fix), #315 (seed_creative_format + force_session_status advertisement)\n- Storyboard CI job: #309 (informational), promotes to required once this issue closes\n- Released as part of v4.2.0 bringing storyboard from `unreachable` → 36/47 passing\n","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-30T13:26:27Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/319"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8a73e686-82d9-a347-c8ad-443e6761eef7
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id96BE:363D8E:E9EDC1:12C14B0:6B00F6C8
html-safe-nonce1f3fa1aa9c3b50073e6e1ac14c50a460743db6efce6f45d7c098489b1373464b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkJFOjM2M0Q4RTpFOUVEQzE6MTJDMTRCMDo2QjAwRjZDOCIsInZpc2l0b3JfaWQiOiI2NDk4MzQwMjEyNzU2NzcyNTUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacde98ed2d07b62cd2ecfdd279187bb08ddb51a29fea2a464005f470d0ebb86144
hovercard-subject-tagissue:4358467426
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/319/issue_layout
twitter:imagehttps://opengraph.githubassets.com/99e8a910dea223e113091ca3e9fddc4c21ae5d412d13163df6897b894d68a220/adcontextprotocol/adcp-client-python/issues/319
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/99e8a910dea223e113091ca3e9fddc4c21ae5d412d13163df6897b894d68a220/adcontextprotocol/adcp-client-python/issues/319
og:image:altContext Now that #317 closed controller_detected: false, end-to-end against examples/seller_agent.py reports 36/47 passing, 5 failed, controller_detected: true. Verified by tracing the runner's cal...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/319#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F319
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F319
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/319
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/319
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/319
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/319
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/319
#322https://github.com/adcontextprotocol/adcp-client-python/pull/322
#321https://github.com/adcontextprotocol/adcp-client-python/pull/321
storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence)https://github.com/adcontextprotocol/adcp-client-python/issues/319#top
#322https://github.com/adcontextprotocol/adcp-client-python/pull/322
#321https://github.com/adcontextprotocol/adcp-client-python/pull/321
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/319#issue-4358467426
#317https://github.com/adcontextprotocol/adcp-client-python/pull/317
fix(examples): seller_agent.py AdCP 3.0.1 storyboard compliance (items 1-6 of #304) #310https://github.com/adcontextprotocol/adcp-client-python/pull/310
feat(examples): DemoStore overrides for force_create_media_buy_arm, force_task_completion, and seed_* scenarios #313https://github.com/adcontextprotocol/adcp-client-python/pull/313
fix(server): comply_test_controller returns dict to fix controller_detected: false #317https://github.com/adcontextprotocol/adcp-client-python/pull/317
feat(test-controller): add seed_creative_format scenario; advertise force_session_status in capabilities #315https://github.com/adcontextprotocol/adcp-client-python/pull/315
ci(adcp): add storyboard CI job for seller_agent.py compliance checks #309https://github.com/adcontextprotocol/adcp-client-python/pull/309
bokelleyhttps://github.com/bokelley
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/319#event-25035697880
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/319#event-25036232782
fix(examples): seed_product defaults, TERMS_REJECTED, targeting_overl…https://github.com/adcontextprotocol/adcp-client-python/commit/59cd52330d41a9806a9567576bc5cbb252dfc2e3
59cd523https://github.com/adcontextprotocol/adcp-client-python/commit/59cd52330d41a9806a9567576bc5cbb252dfc2e3
fix(examples): seed_product defaults, TERMS_REJECTED, targeting_overl…https://github.com/adcontextprotocol/adcp-client-python/commit/478167a9d8f3ad186d6a7b418e1c6a40e0d8e12a
478167ahttps://github.com/adcontextprotocol/adcp-client-python/commit/478167a9d8f3ad186d6a7b418e1c6a40e0d8e12a
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/319#event-25036798552
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/319#issuecomment-4353041186
#320https://github.com/adcontextprotocol/adcp-client-python/pull/320
https://claude.ai/code/session_01ENPdJ8Nk7YvUhfRpMXLa8whttps://claude.ai/code/session_01ENPdJ8Nk7YvUhfRpMXLa8w
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/319#event-25037053851
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/319#event-25037878021
fix(examples): close last 5 storyboard fixture-dependent failures (#319…https://github.com/adcontextprotocol/adcp-client-python/commit/d92cfb13839fa26a4ab69ae2db941c752db054a1
#319https://github.com/adcontextprotocol/adcp-client-python/issues/319
d92cfb1https://github.com/adcontextprotocol/adcp-client-python/commit/d92cfb13839fa26a4ab69ae2db941c752db054a1
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#322https://github.com/adcontextprotocol/adcp-client-python/pull/322
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/319#event-25037878123
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/319#event-25046267180
fix(examples): seed_product complete defaults + format_ids agent_url …https://github.com/adcontextprotocol/adcp-client-python/commit/bcfd1a2f66be3f5ef6a9794a6f6c5ff11aa46b93
bcfd1a2https://github.com/adcontextprotocol/adcp-client-python/commit/bcfd1a2f66be3f5ef6a9794a6f6c5ff11aa46b93
fix(examples): seed_product complete defaults + format_ids agent_url …https://github.com/adcontextprotocol/adcp-client-python/commit/dfe7ba1c9a4a4650e52c7fbfdbe7097ad7664533
dfe7ba1https://github.com/adcontextprotocol/adcp-client-python/commit/dfe7ba1c9a4a4650e52c7fbfdbe7097ad7664533
fix(examples): seed_product complete defaults + format_ids agent_url …https://github.com/adcontextprotocol/adcp-client-python/commit/046b15e429b40412a284d50e9d28bf884355c80f
046b15ehttps://github.com/adcontextprotocol/adcp-client-python/commit/046b15e429b40412a284d50e9d28bf884355c80f
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/319
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/319
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.