René's URL Explorer Experiment


Title: ci: run AdCP storyboard suite against examples/seller_agent.py on every PR · Issue #305 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: ci: run AdCP storyboard suite against examples/seller_agent.py on every PR · Issue #305 · adcontextprotocol/adcp-client-python

X Title: ci: run AdCP storyboard suite against examples/seller_agent.py on every PR · Issue #305 · adcontextprotocol/adcp-client-python

Description: Context The SDK's reference seller agent (`examples/seller_agent.py`) is the load-bearing demonstration that `adcp.server.serve()` actually emits compliant AdCP responses end-to-end. Every PR can subtly regress storyboard outcomes (respo...

Open Graph Description: Context The SDK's reference seller agent (`examples/seller_agent.py`) is the load-bearing demonstration that `adcp.server.serve()` actually emits compliant AdCP responses end-to-end. Every PR can s...

X Description: Context The SDK's reference seller agent (`examples/seller_agent.py`) is the load-bearing demonstration that `adcp.server.serve()` actually emits compliant AdCP responses end-to-end. Every PR c...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/305

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ci: run AdCP storyboard suite against examples/seller_agent.py on every PR","articleBody":"## Context\n\nThe SDK's reference seller agent (\\`examples/seller_agent.py\\`) is the load-bearing demonstration that \\`adcp.server.serve()\\` actually emits compliant AdCP responses end-to-end. Every PR can subtly regress storyboard outcomes (response shape, status enums, error codes, capability declarations) without breaking any unit test or import smoke check — and we just hit this in #295/#296 where the SDK transport defaults silently broke the runner for an unknown amount of time before anyone noticed.\n\n\\`.github/workflows/ci.yml\\` today runs:\n- \\`pytest\\` on Python 3.10–3.13\n- \\`ruff\\` + \\`mypy\\`\n- PgReplayStore tests\n- Public-API import smoke\n- Schema regen + drift check\n\n**Nothing exercises the storyboard runner.** Storyboard regressions slip silently until a downstream user notices and files an issue (e.g. #295).\n\n## Proposal\n\nAdd a CI job that:\n\n1. Boots \\`examples/seller_agent.py\\` on a free port (use \\`ADCP_PORT\\`).\n2. Runs \\`npx -y -p @adcp/client@latest adcp storyboard run http://localhost:\\$PORT/mcp media_buy_seller --json --allow-http\\` against it.\n3. Captures the JSON, asserts \\`overall_status: pass\\` and \\`controller_detected: true\\`.\n4. Uploads the JSON as a CI artifact for diagnosis on failure.\n\n## Sketch\n\n\\`\\`\\`yaml\nstoryboard:\n  name: AdCP storyboard runner — examples/seller_agent.py\n  runs-on: ubuntu-latest\n  steps:\n    - uses: actions/checkout@v4\n    - uses: actions/setup-python@v5\n      with: { python-version: \"3.12\" }\n    - uses: actions/setup-node@v4\n      with: { node-version: \"22\" }\n    - run: pip install -e \".[dev]\"\n    - name: Start seller agent\n      run: |\n        ADCP_PORT=3001 python examples/seller_agent.py &\n        until lsof -iTCP:3001 -sTCP:LISTEN >/dev/null 2>&1; do sleep 0.5; done\n    - name: Run storyboard suite\n      run: |\n        npx -y -p @adcp/client@latest adcp storyboard run \\\\\n          http://localhost:3001/mcp media_buy_seller \\\\\n          --json --allow-http \\\\\n          > storyboard-result.json\n    - name: Assert pass\n      run: |\n        python -c \"\n        import json, sys\n        d = json.load(open('storyboard-result.json'))\n        if d.get('overall_status') != 'pass':\n            print(json.dumps({k: d[k] for k in ('overall_status','summary','failures')}, indent=2))\n            sys.exit(1)\n        if not d.get('controller_detected'):\n            print('controller_detected was false; check DemoStore overrides')\n            sys.exit(1)\n        \"\n    - if: always()\n      uses: actions/upload-artifact@v4\n      with:\n        name: storyboard-result\n        path: storyboard-result.json\n\\`\\`\\`\n\n## Sequencing\n\nThis job will fail today against \\`examples/seller_agent.py\\` on \\`main\\` (10 step failures + \\`controller_detected: false\\` — see #304). Two ways to land:\n\n1. **Mark as required only after the seller-agent gaps in #304 are fixed** — green from the start.\n2. **Land it as informational (non-blocking)**, fix the seller agent in parallel via #304, then promote to required once green.\n\nOption 2 surfaces the regressions immediately and creates pressure to close the gaps.\n\n## Out of scope\n\n- Running storyboards against \\`examples/minimal_sales_agent.py\\` (smaller surface; \\`media_buy_seller\\` storyboard doesn't apply)\n- Other compliance suites (creative agent, signals agent) — same pattern, separate jobs once the media_buy one is green.\n- The Python equivalent of the JS storyboard runner (none exists today; \\`@adcp/client\\` npm package is the canonical runner).\n\n## References\n\n- Origin of this regression: #295 / #296 — the streamable-http ASGI bug that made every storyboard fail \\`unreachable\\` until the SDK defaults were changed\n- Seller-agent content gaps surfaced by the first run: #304\n- JS \\`@adcp/client\\` storyboard runner: \\`npm view @adcp/client\\`","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-30T00:04:49Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/305"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f202db4f-94d1-e688-242d-271bb19a8b2c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9320:296654:D379BC:11BEE64:6B010073
html-safe-noncec303cec0dbe3b94819fcca52989bc72dcbf7ec28d26ba7b5c4557255ae0a7b61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzIwOjI5NjY1NDpEMzc5QkM6MTFCRUU2NDo2QjAxMDA3MyIsInZpc2l0b3JfaWQiOiI4NzY3MDkwOTMwOTE5NDczMjY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2fea3524fdb079702dc0073060fd4f07765bd2e7d36ff34c4981bbc9f403268d
hovercard-subject-tagissue:4354398165
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/305/issue_layout
twitter:imagehttps://opengraph.githubassets.com/231b1dacd0ad5344534742e04b997ce8d01c24b8b0bf1e848c90d7b3595e4d6e/adcontextprotocol/adcp-client-python/issues/305
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/231b1dacd0ad5344534742e04b997ce8d01c24b8b0bf1e848c90d7b3595e4d6e/adcontextprotocol/adcp-client-python/issues/305
og:image:altContext The SDK's reference seller agent (`examples/seller_agent.py`) is the load-bearing demonstration that `adcp.server.serve()` actually emits compliant AdCP responses end-to-end. Every PR can s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/305#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F305
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F305
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/305
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/305
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/305
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/305
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/305
#309https://github.com/adcontextprotocol/adcp-client-python/pull/309
ci: run AdCP storyboard suite against examples/seller_agent.py on every PRhttps://github.com/adcontextprotocol/adcp-client-python/issues/305#top
#309https://github.com/adcontextprotocol/adcp-client-python/pull/309
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/305#issue-4354398165
#295https://github.com/adcontextprotocol/adcp-client-python/issues/295
#296https://github.com/adcontextprotocol/adcp-client-python/pull/296
#295https://github.com/adcontextprotocol/adcp-client-python/issues/295
http://localhost:\$PORT/mcphttp://localhost:%5C$PORT/mcp
http://localhost:3001/mcphttp://localhost:3001/mcp
#304https://github.com/adcontextprotocol/adcp-client-python/issues/304
examples/seller_agent.py: storyboard content gaps exposed by #296 transport fix #304https://github.com/adcontextprotocol/adcp-client-python/issues/304
examples/seller_agent.py: storyboard content gaps exposed by #296 transport fix #304https://github.com/adcontextprotocol/adcp-client-python/issues/304
adcp 4.0.0: examples/seller_agent.py fails its own storyboard validation command — streamable-http ASGI incomplete response #295https://github.com/adcontextprotocol/adcp-client-python/issues/295
fix(server): fix streamable-http ASGI error, host binding, and AdCP 3.0.1 scenario gaps #296https://github.com/adcontextprotocol/adcp-client-python/pull/296
examples/seller_agent.py: storyboard content gaps exposed by #296 transport fix #304https://github.com/adcontextprotocol/adcp-client-python/issues/304
bokelleyhttps://github.com/bokelley
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/305#event-25013317381
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/305#issuecomment-4348481463
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/305#issuecomment-4348487664
#304https://github.com/adcontextprotocol/adcp-client-python/issues/304
@bokelleyhttps://github.com/bokelley
https://claude.ai/code/cse_015RdGgN151GgAWTcLvvnqBHhttps://claude.ai/code/cse_015RdGgN151GgAWTcLvvnqBH
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/305#event-25013461895
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/305#issuecomment-4348565845
#304https://github.com/adcontextprotocol/adcp-client-python/issues/304
#309https://github.com/adcontextprotocol/adcp-client-python/pull/309
https://claude.ai/code/session_01SSje6ebBHD85TWdQbEig9mhttps://claude.ai/code/session_01SSje6ebBHD85TWdQbEig9m
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/305#event-25014552610
ci(adcp): add storyboard CI job for seller_agent.py compliance checkshttps://github.com/adcontextprotocol/adcp-client-python/commit/ebad6051a13d4f098d87ab9f52a6bb62f4b7b1e1
https://docs.github.com/articles/closing-issues-via-commit-messages
ebad605https://github.com/adcontextprotocol/adcp-client-python/commit/ebad6051a13d4f098d87ab9f52a6bb62f4b7b1e1
ci(adcp): add storyboard CI job for seller_agent.py compliance checks (…https://github.com/adcontextprotocol/adcp-client-python/commit/f02ea79e2be020197756ef39cc35099c3808c27c
…https://github.com/adcontextprotocol/adcp-client-python/pull/309
https://docs.github.com/articles/closing-issues-via-commit-messages
f02ea79https://github.com/adcontextprotocol/adcp-client-python/commit/f02ea79e2be020197756ef39cc35099c3808c27c
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#309https://github.com/adcontextprotocol/adcp-client-python/pull/309
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/305#event-25014555345
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/305
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/305
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.