Title: ci: run AdCP storyboard suite against examples/seller_agent.py on every PR · Issue #305 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: ci: run AdCP storyboard suite against examples/seller_agent.py on every PR · Issue #305 · adcontextprotocol/adcp-client-python
X Title: ci: run AdCP storyboard suite against examples/seller_agent.py on every PR · Issue #305 · adcontextprotocol/adcp-client-python
Description: Context The SDK's reference seller agent (`examples/seller_agent.py`) is the load-bearing demonstration that `adcp.server.serve()` actually emits compliant AdCP responses end-to-end. Every PR can subtly regress storyboard outcomes (respo...
Open Graph Description: Context The SDK's reference seller agent (`examples/seller_agent.py`) is the load-bearing demonstration that `adcp.server.serve()` actually emits compliant AdCP responses end-to-end. Every PR can s...
X Description: Context The SDK's reference seller agent (`examples/seller_agent.py`) is the load-bearing demonstration that `adcp.server.serve()` actually emits compliant AdCP responses end-to-end. Every PR c...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/305
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ci: run AdCP storyboard suite against examples/seller_agent.py on every PR","articleBody":"## Context\n\nThe SDK's reference seller agent (\\`examples/seller_agent.py\\`) is the load-bearing demonstration that \\`adcp.server.serve()\\` actually emits compliant AdCP responses end-to-end. Every PR can subtly regress storyboard outcomes (response shape, status enums, error codes, capability declarations) without breaking any unit test or import smoke check — and we just hit this in #295/#296 where the SDK transport defaults silently broke the runner for an unknown amount of time before anyone noticed.\n\n\\`.github/workflows/ci.yml\\` today runs:\n- \\`pytest\\` on Python 3.10–3.13\n- \\`ruff\\` + \\`mypy\\`\n- PgReplayStore tests\n- Public-API import smoke\n- Schema regen + drift check\n\n**Nothing exercises the storyboard runner.** Storyboard regressions slip silently until a downstream user notices and files an issue (e.g. #295).\n\n## Proposal\n\nAdd a CI job that:\n\n1. Boots \\`examples/seller_agent.py\\` on a free port (use \\`ADCP_PORT\\`).\n2. Runs \\`npx -y -p @adcp/client@latest adcp storyboard run http://localhost:\\$PORT/mcp media_buy_seller --json --allow-http\\` against it.\n3. Captures the JSON, asserts \\`overall_status: pass\\` and \\`controller_detected: true\\`.\n4. Uploads the JSON as a CI artifact for diagnosis on failure.\n\n## Sketch\n\n\\`\\`\\`yaml\nstoryboard:\n name: AdCP storyboard runner — examples/seller_agent.py\n runs-on: ubuntu-latest\n steps:\n - uses: actions/checkout@v4\n - uses: actions/setup-python@v5\n with: { python-version: \"3.12\" }\n - uses: actions/setup-node@v4\n with: { node-version: \"22\" }\n - run: pip install -e \".[dev]\"\n - name: Start seller agent\n run: |\n ADCP_PORT=3001 python examples/seller_agent.py &\n until lsof -iTCP:3001 -sTCP:LISTEN >/dev/null 2>&1; do sleep 0.5; done\n - name: Run storyboard suite\n run: |\n npx -y -p @adcp/client@latest adcp storyboard run \\\\\n http://localhost:3001/mcp media_buy_seller \\\\\n --json --allow-http \\\\\n > storyboard-result.json\n - name: Assert pass\n run: |\n python -c \"\n import json, sys\n d = json.load(open('storyboard-result.json'))\n if d.get('overall_status') != 'pass':\n print(json.dumps({k: d[k] for k in ('overall_status','summary','failures')}, indent=2))\n sys.exit(1)\n if not d.get('controller_detected'):\n print('controller_detected was false; check DemoStore overrides')\n sys.exit(1)\n \"\n - if: always()\n uses: actions/upload-artifact@v4\n with:\n name: storyboard-result\n path: storyboard-result.json\n\\`\\`\\`\n\n## Sequencing\n\nThis job will fail today against \\`examples/seller_agent.py\\` on \\`main\\` (10 step failures + \\`controller_detected: false\\` — see #304). Two ways to land:\n\n1. **Mark as required only after the seller-agent gaps in #304 are fixed** — green from the start.\n2. **Land it as informational (non-blocking)**, fix the seller agent in parallel via #304, then promote to required once green.\n\nOption 2 surfaces the regressions immediately and creates pressure to close the gaps.\n\n## Out of scope\n\n- Running storyboards against \\`examples/minimal_sales_agent.py\\` (smaller surface; \\`media_buy_seller\\` storyboard doesn't apply)\n- Other compliance suites (creative agent, signals agent) — same pattern, separate jobs once the media_buy one is green.\n- The Python equivalent of the JS storyboard runner (none exists today; \\`@adcp/client\\` npm package is the canonical runner).\n\n## References\n\n- Origin of this regression: #295 / #296 — the streamable-http ASGI bug that made every storyboard fail \\`unreachable\\` until the SDK defaults were changed\n- Seller-agent content gaps surfaced by the first run: #304\n- JS \\`@adcp/client\\` storyboard runner: \\`npm view @adcp/client\\`","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-30T00:04:49Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/305"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f202db4f-94d1-e688-242d-271bb19a8b2c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9320:296654:D379BC:11BEE64:6B010073 |
| html-safe-nonce | c303cec0dbe3b94819fcca52989bc72dcbf7ec28d26ba7b5c4557255ae0a7b61 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzIwOjI5NjY1NDpEMzc5QkM6MTFCRUU2NDo2QjAxMDA3MyIsInZpc2l0b3JfaWQiOiI4NzY3MDkwOTMwOTE5NDczMjY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2fea3524fdb079702dc0073060fd4f07765bd2e7d36ff34c4981bbc9f403268d |
| hovercard-subject-tag | issue:4354398165 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/305/issue_layout |
| twitter:image | https://opengraph.githubassets.com/231b1dacd0ad5344534742e04b997ce8d01c24b8b0bf1e848c90d7b3595e4d6e/adcontextprotocol/adcp-client-python/issues/305 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/231b1dacd0ad5344534742e04b997ce8d01c24b8b0bf1e848c90d7b3595e4d6e/adcontextprotocol/adcp-client-python/issues/305 |
| og:image:alt | Context The SDK's reference seller agent (`examples/seller_agent.py`) is the load-bearing demonstration that `adcp.server.serve()` actually emits compliant AdCP responses end-to-end. Every PR can s... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width