Title: examples/seller_agent.py: storyboard content gaps exposed by #296 transport fix · Issue #304 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: examples/seller_agent.py: storyboard content gaps exposed by #296 transport fix · Issue #304 · adcontextprotocol/adcp-client-python
X Title: examples/seller_agent.py: storyboard content gaps exposed by #296 transport fix · Issue #304 · adcontextprotocol/adcp-client-python
Description: Context Once #296 fixes the ASGI transport so the storyboard runner can connect, running ``` npx -y -p @adcp/client@latest adcp storyboard run http://localhost:3001/mcp media_buy_seller --json --allow-http ``` against `examples/seller_ag...
Open Graph Description: Context Once #296 fixes the ASGI transport so the storyboard runner can connect, running ``` npx -y -p @adcp/client@latest adcp storyboard run http://localhost:3001/mcp media_buy_seller --json --al...
X Description: Context Once #296 fixes the ASGI transport so the storyboard runner can connect, running ``` npx -y -p @adcp/client@latest adcp storyboard run http://localhost:3001/mcp media_buy_seller --json --al...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/304
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"examples/seller_agent.py: storyboard content gaps exposed by #296 transport fix","articleBody":"## Context\n\nOnce #296 fixes the ASGI transport so the storyboard runner can connect, running\n\n\\`\\`\\`\nnpx -y -p @adcp/client@latest adcp storyboard run http://localhost:3001/mcp media_buy_seller --json --allow-http\n\\`\\`\\`\n\nagainst \\`examples/seller_agent.py\\` produces \\`overall_status: partial\\` — **29/47 steps pass, 10 fail, 8 skipped**, and \\`controller_detected: false\\`. Every failure is content-side in the example seller (or its \\`DemoStore\\`); none are SDK regressions from this round of releases.\n\nThis issue tracks the punch list. Each item is a separate seller-agent fix and can land independently.\n\n## Failures\n\n1. **\\`adcp.idempotency\\` not declared in capabilities** — \\`get_adcp_capabilities\\` returns \\`compliance_testing\\` without an \\`idempotency\\` block. PR #296 added a runtime WARNING log for exactly this case; the example just doesn't follow its own advice. Fix: pass \\`idempotency=store.capability()\\` (or \\`idempotency={\"supported\": False}\\`) to \\`capabilities_response()\\`.\n\n2. **\\`get_media_buys\\` response missing \\`total_budget\\`** — schema validation: \\`/media_buys/0/total_budget: must have required property 'total_budget'\\`. The reference \\`media_buys_response()\\` either doesn't populate it or the example's seed data drops it.\n\n3. **Status returned as \\`active\\` instead of \\`pending_creatives\\` when no creatives supplied** — runner sends \\`create_media_buy\\` with no creatives and expects \\`status=pending_creatives\\`. The example seller jumps straight to \\`active\\`. Fix: branch on \\`creatives_present\\` and return \\`pending_creatives\\` per the AdCP v3 lifecycle.\n\n4. **\\`list_creative_formats\\` renders missing required fields** — schema validation: each render must have \\`role\\`, \\`dimensions\\`, and \\`parameters_from_format_id\\`, OR match the alternate variant of the discriminated union. Likely a 3.0.1-related schema tightening on the format-render type. Fix: populate render objects with the AdCP 3.0.1-required fields.\n\n5. **\\`list_creative_formats\\` filter ignored** — runner filters for \\`format_id.id = display_970x250\\` but the seller returns \\`display_300x250\\`. Either the filter parameter isn't honored or the format catalog's primary format is just the wrong one for this storyboard.\n\n6. **\\`update_media_buy\\` with bogus package_id doesn't return \\`PACKAGE_NOT_FOUND\\`** — the example doesn't validate package existence; runner expects a structured \\`PACKAGE_NOT_FOUND\\` adcp_error.\n\n7. **\\`create_media_buy\\` for storyboard fixture product fails with \"Product 'sports_preroll_q2' not found\"** — the storyboard pre-populates a product fixture via a \\`seed_product\\` controller call. \\`DemoStore\\` doesn't override \\`seed_product\\` (it's a \\`NotImplementedError\\` stub from PR #296). Without a working \\`seed_*\\` controller on the example, every storyboard that needs fixtures skips. Related: the \\`controller_detected: false\\` outcome.\n\n## Why \\`controller_detected: false\\`?\n\nThe runner discovers the \\`comply_test_controller\\` tool but doesn't grade the controller as detected. \\`DemoStore\\` overrides 5 \\`force_*\\`/\\`simulate_*\\` scenarios but none of the AdCP 3.0.1 \\`seed_*\\` or \\`force_create_media_buy_arm\\`/\\`force_task_completion\\` ones (the latter come from PR #282, in flight). When PR #282 lands and \\`DemoStore\\` overrides at least \\`force_task_completion\\` and \\`seed_creative_format\\`, controller detection should flip.\n\n## Out of scope\n\n- The transport-level fixes — those are #296.\n- Adding the controller scenarios to the SDK base class — those are #282 and partially in #296.\n- Adding a CI job that runs the storyboard suite — separate issue.\n\n## Verification\n\n\\`\\`\\`\nADCP_PORT=3001 python examples/seller_agent.py &\nsleep 2\nnpx -y -p @adcp/client@latest adcp storyboard run \\\\\n http://localhost:3001/mcp media_buy_seller --json --allow-http \\\\\n | jq '{overall_status, controller_detected, summary, failures}'\n\\`\\`\\`\n\nTarget on completion of this punch list: \\`overall_status: pass\\`, \\`controller_detected: true\\`.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-30T00:04:28Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/304"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0f88d377-8686-4c4d-ada0-fb6fda7f69c5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9ADC:2564F:E4ED2A:12EB596:6B00FF0C |
| html-safe-nonce | 400332c1ecbc571b87bb1865b1bdbd324d1df62b6368529476d8ca48a1a1d7b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QURDOjI1NjRGOkU0RUQyQToxMkVCNTk2OjZCMDBGRjBDIiwidmlzaXRvcl9pZCI6IjgxMjk4MDc4NTM5NTIyMzczMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a81ff107a6ee53bab78afa0bad17b2e24540b1b25768356b6532e4248dd37692 |
| hovercard-subject-tag | issue:4354396793 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/304/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f5ce2b296ce8c1198159673f9844e6567d6abde44625ebb860a3cfa140712740/adcontextprotocol/adcp-client-python/issues/304 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f5ce2b296ce8c1198159673f9844e6567d6abde44625ebb860a3cfa140712740/adcontextprotocol/adcp-client-python/issues/304 |
| og:image:alt | Context Once #296 fixes the ASGI transport so the storyboard runner can connect, running ``` npx -y -p @adcp/client@latest adcp storyboard run http://localhost:3001/mcp media_buy_seller --json --al... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width