René's URL Explorer Experiment


Title: Wire SSRF guard into legacy webhooks.deliver() · Issue #299 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Wire SSRF guard into legacy webhooks.deliver() · Issue #299 · adcontextprotocol/adcp-client-python

X Title: Wire SSRF guard into legacy webhooks.deliver() · Issue #299 · adcontextprotocol/adcp-client-python

Description: Summary adcp.webhooks.deliver() (the deprecated AdCP 3.x HMAC-SHA256 path) constructs an unpinned httpx.AsyncClient(timeout=...) and POSTs to a buyer-controlled URL when no operator client is supplied. No SSRF guard. Source: src/adcp/web...

Open Graph Description: Summary adcp.webhooks.deliver() (the deprecated AdCP 3.x HMAC-SHA256 path) constructs an unpinned httpx.AsyncClient(timeout=...) and POSTs to a buyer-controlled URL when no operator client is suppl...

X Description: Summary adcp.webhooks.deliver() (the deprecated AdCP 3.x HMAC-SHA256 path) constructs an unpinned httpx.AsyncClient(timeout=...) and POSTs to a buyer-controlled URL when no operator client is suppl...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/299

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Wire SSRF guard into legacy webhooks.deliver()","articleBody":"## Summary\n\n`adcp.webhooks.deliver()` (the deprecated AdCP 3.x HMAC-SHA256 path) constructs an unpinned `httpx.AsyncClient(timeout=...)` and POSTs to a buyer-controlled URL when no operator client is supplied. **No SSRF guard.**\n\nSource: `src/adcp/webhooks.py:867-872`. Surfaced by security-reviewer on PR #297 as L4 — explicitly deferred from the prep PR scope.\n\n## Why deferred\n\n`deliver()` is the AdCP 3.x deprecated path; emits `DeprecationWarning` already; new traffic goes through `WebhookSender`. PR #297 was scoped to RFC 9421 sender hardening.\n\n## Proposed fix\n\nMirror the `WebhookSender._send_bytes` pattern:\n- When the operator supplies a client, trust them.\n- When the sender owns the client, build a per-request `AsyncIpPinnedTransport` via `build_async_ip_pinned_transport(url, ...)` and construct `httpx.AsyncClient(transport=transport, follow_redirects=False, trust_env=False)`.\n- Same `allow_private_destinations` and `allowed_destination_ports` kwargs on the public surface.\n\n## Risk\n\nAdopters on the legacy `deliver()` path posting to private/internal endpoints (dev/test fixtures) will start getting `SSRFValidationError`. One-kwarg opt-out via `allow_private=True` (or whatever name fits the existing `deliver()` surface).\n\n## References\n\n- Code: `src/adcp/webhooks.py:867-872`\n- Pattern to mirror: `src/adcp/webhook_sender.py:_send_bytes` (post PR #297)\n- Sec audit reference: `.context/foundations-audit/FINDINGS.md`","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-29T17:23:57Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/299"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9916a943-3987-ca1c-6582-6e9e74335abb
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8398:240CD1:CEDA50:1089991:6B0101EE
html-safe-nonce27db9b746fc604a0bbed86a906961f071935ca2822995bf99a38bd81149c84cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Mzk4OjI0MENEMTpDRURBNTA6MTA4OTk5MTo2QjAxMDFFRSIsInZpc2l0b3JfaWQiOiIyNjk3MzQzNzc1NTUzOTQ2MDk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3982f8c030d3987bc2c4d7327ae1df91acba149f9c1e7a604dd499b1afa27c62
hovercard-subject-tagissue:4352419341
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/299/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b8f6c3f92d9ce3ddbb46ea0b6dd9bb11ddab9cb2a9722d29f7ea4417b095e92c/adcontextprotocol/adcp-client-python/issues/299
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b8f6c3f92d9ce3ddbb46ea0b6dd9bb11ddab9cb2a9722d29f7ea4417b095e92c/adcontextprotocol/adcp-client-python/issues/299
og:image:altSummary adcp.webhooks.deliver() (the deprecated AdCP 3.x HMAC-SHA256 path) constructs an unpinned httpx.AsyncClient(timeout=...) and POSTs to a buyer-controlled URL when no operator client is suppl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/299#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F299
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F299
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/299
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/299
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/299
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/299
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/299
#303https://github.com/adcontextprotocol/adcp-client-python/pull/303
Wire SSRF guard into legacy webhooks.deliver()https://github.com/adcontextprotocol/adcp-client-python/issues/299#top
#303https://github.com/adcontextprotocol/adcp-client-python/pull/303
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/299#issue-4352419341
#297https://github.com/adcontextprotocol/adcp-client-python/pull/297
#297https://github.com/adcontextprotocol/adcp-client-python/pull/297
feat(signing): close 4 SSRF gaps and add opt-in port hardening (foundation audit) #297https://github.com/adcontextprotocol/adcp-client-python/pull/297
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/299#event-25001475648
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/299#issuecomment-4346019808
#297https://github.com/adcontextprotocol/adcp-client-python/pull/297
feat(signing): close 4 SSRF gaps and add opt-in port hardening (foundation audit) #297https://github.com/adcontextprotocol/adcp-client-python/pull/297
feat(signing): close 4 SSRF gaps and add opt-in port hardening (foundation audit) #297https://github.com/adcontextprotocol/adcp-client-python/pull/297
feat(signing): close 4 SSRF gaps and add opt-in port hardening (foundation audit) #297https://github.com/adcontextprotocol/adcp-client-python/pull/297
#297https://github.com/adcontextprotocol/adcp-client-python/pull/297
#297https://github.com/adcontextprotocol/adcp-client-python/pull/297
https://claude.ai/code/session_01SaZb7fWVnax15UzFjAWCUshttps://claude.ai/code/session_01SaZb7fWVnax15UzFjAWCUs
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/299#event-25001529988
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/299#issuecomment-4346037466
@bokelleyhttps://github.com/bokelley
https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}https://claude.ai/code/$%7BCLAUDE_CODE_REMOTE_SESSION_ID%7D
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/299#event-25001723675
bokelleyhttps://github.com/bokelley
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/299#event-25012942569
feat(signing): wire SSRF guard into legacy webhooks.deliver()https://github.com/adcontextprotocol/adcp-client-python/commit/189ad6f16abdfcf71b769992fa3545978682ac35
https://docs.github.com/articles/closing-issues-via-commit-messages
189ad6fhttps://github.com/adcontextprotocol/adcp-client-python/commit/189ad6f16abdfcf71b769992fa3545978682ac35
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#303https://github.com/adcontextprotocol/adcp-client-python/pull/303
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/299#event-25013019884
KonstantinMirinhttps://github.com/KonstantinMirin
on May 13, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/299#event-25486658948
feat(signing): drain three foundation-audit deferreds (adcontextproto…https://github.com/KonstantinMirin/adcp-client-python/commit/072998a8fd7b33097b7e6ab0496c2ecadf33a691
adcontextproto…https://github.com/adcontextprotocol/adcp-client-python/issues/298
072998ahttps://github.com/KonstantinMirin/adcp-client-python/commit/072998a8fd7b33097b7e6ab0496c2ecadf33a691
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/299
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/299
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.