Title: Revert covers_content_digest default to spec-mandated 'either' · Issue #298 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: Revert covers_content_digest default to spec-mandated 'either' · Issue #298 · adcontextprotocol/adcp-client-python
X Title: Revert covers_content_digest default to spec-mandated 'either' · Issue #298 · adcontextprotocol/adcp-client-python
Description: Summary Pre-existing spec divergence in src/adcp/signing/verifier.py:95: VerifierCapability.covers_content_digest defaults to \"required\" but the AdCP 3.0 schema explicitly sets \"default\": \"either\" (schemas/cache/protocol/get-adcp-c...
Open Graph Description: Summary Pre-existing spec divergence in src/adcp/signing/verifier.py:95: VerifierCapability.covers_content_digest defaults to \"required\" but the AdCP 3.0 schema explicitly sets \"default\": \"eit...
X Description: Summary Pre-existing spec divergence in src/adcp/signing/verifier.py:95: VerifierCapability.covers_content_digest defaults to \"required\" but the AdCP 3.0 schema explicitly sets \"d...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/298
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Revert covers_content_digest default to spec-mandated 'either'","articleBody":"## Summary\n\nPre-existing spec divergence in `src/adcp/signing/verifier.py:95`: `VerifierCapability.covers_content_digest` defaults to `\\\"required\\\"` but the AdCP 3.0 schema explicitly sets `\\\"default\\\": \\\"either\\\"` (`schemas/cache/protocol/get-adcp-capabilities-response.json:912-921`) with the rationale: *\\\"'required' is recommended for spend-committing operations in production; 4.0 recommends 'required' for those operations.\\\"*\n\nThe 3.0 spec position: default is `\\\"either\\\"`, `\\\"required\\\"` is opt-in for spend-committing ops, and 4.0 will recommend it broadly.\n\n## Background\n\nSurfaced during the v6.0 DecisioningPlatform foundation audit (PR #297 expert review). PR #297's first commit included a regression test pinning the divergent default — that test was dropped in the scope-down per protocol-expert finding.\n\n## Proposed change\n\n- Flip `VerifierCapability.covers_content_digest` default from `\\\"required\\\"` to `\\\"either\\\"`.\n- Promote spend-committing operations (`create_media_buy`, `update_media_buy`) to `\\\"required\\\"` via `required_for=frozenset({...})`.\n- Webhook profile (`adcp.signing.webhook_verifier`) keeps its hard-coded `\\\"required\\\"` (correct, distinct from the request-signing default).\n\n## Risk\n\nAny existing adopter relying on `\\\"required\\\"` by default will need to set it explicitly when constructing `VerifierCapability(covers_content_digest=\\\"required\\\")`. Document in CHANGELOG.\n\n## References\n\n- Surfaced by ad-tech-protocol-expert review on PR #297\n- Schema: `schemas/cache/protocol/get-adcp-capabilities-response.json:912-921`\n- Code: `src/adcp/signing/verifier.py:84-95`","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-29T17:23:41Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/298"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6ee0dfa0-58ee-d6dc-4391-adbe2f6215e8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AA8E:2AAD2E:B95F34:F8D8EA:6B00F75B |
| html-safe-nonce | b8912e9c2fba980a43dd1e874a304c18fb0a68b5de7bb4b133addc27f74a7c10 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQThFOjJBQUQyRTpCOTVGMzQ6RjhEOEVBOjZCMDBGNzVCIiwidmlzaXRvcl9pZCI6IjM3MzI2OTM3NDE1OTM0OTEyOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c78ce245826670b5c3ce09ceb5e9c0f6c7ffe2fb8a3f7d4bf92d11c2827a31a6 |
| hovercard-subject-tag | issue:4352417769 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/298/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b8f6c3f92d9ce3ddbb46ea0b6dd9bb11ddab9cb2a9722d29f7ea4417b095e92c/adcontextprotocol/adcp-client-python/issues/298 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b8f6c3f92d9ce3ddbb46ea0b6dd9bb11ddab9cb2a9722d29f7ea4417b095e92c/adcontextprotocol/adcp-client-python/issues/298 |
| og:image:alt | Summary Pre-existing spec divergence in src/adcp/signing/verifier.py:95: VerifierCapability.covers_content_digest defaults to \"required\" but the AdCP 3.0 schema explicitly sets \"default\": \"eit... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width