René's URL Explorer Experiment


Title: Revert covers_content_digest default to spec-mandated 'either' · Issue #298 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Revert covers_content_digest default to spec-mandated 'either' · Issue #298 · adcontextprotocol/adcp-client-python

X Title: Revert covers_content_digest default to spec-mandated 'either' · Issue #298 · adcontextprotocol/adcp-client-python

Description: Summary Pre-existing spec divergence in src/adcp/signing/verifier.py:95: VerifierCapability.covers_content_digest defaults to \"required\" but the AdCP 3.0 schema explicitly sets \"default\": \"either\" (schemas/cache/protocol/get-adcp-c...

Open Graph Description: Summary Pre-existing spec divergence in src/adcp/signing/verifier.py:95: VerifierCapability.covers_content_digest defaults to \"required\" but the AdCP 3.0 schema explicitly sets \"default\": \"eit...

X Description: Summary Pre-existing spec divergence in src/adcp/signing/verifier.py:95: VerifierCapability.covers_content_digest defaults to \"required\" but the AdCP 3.0 schema explicitly sets \"d...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/298

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Revert covers_content_digest default to spec-mandated 'either'","articleBody":"## Summary\n\nPre-existing spec divergence in `src/adcp/signing/verifier.py:95`: `VerifierCapability.covers_content_digest` defaults to `\\\"required\\\"` but the AdCP 3.0 schema explicitly sets `\\\"default\\\": \\\"either\\\"` (`schemas/cache/protocol/get-adcp-capabilities-response.json:912-921`) with the rationale: *\\\"'required' is recommended for spend-committing operations in production; 4.0 recommends 'required' for those operations.\\\"*\n\nThe 3.0 spec position: default is `\\\"either\\\"`, `\\\"required\\\"` is opt-in for spend-committing ops, and 4.0 will recommend it broadly.\n\n## Background\n\nSurfaced during the v6.0 DecisioningPlatform foundation audit (PR #297 expert review). PR #297's first commit included a regression test pinning the divergent default — that test was dropped in the scope-down per protocol-expert finding.\n\n## Proposed change\n\n- Flip `VerifierCapability.covers_content_digest` default from `\\\"required\\\"` to `\\\"either\\\"`.\n- Promote spend-committing operations (`create_media_buy`, `update_media_buy`) to `\\\"required\\\"` via `required_for=frozenset({...})`.\n- Webhook profile (`adcp.signing.webhook_verifier`) keeps its hard-coded `\\\"required\\\"` (correct, distinct from the request-signing default).\n\n## Risk\n\nAny existing adopter relying on `\\\"required\\\"` by default will need to set it explicitly when constructing `VerifierCapability(covers_content_digest=\\\"required\\\")`. Document in CHANGELOG.\n\n## References\n\n- Surfaced by ad-tech-protocol-expert review on PR #297\n- Schema: `schemas/cache/protocol/get-adcp-capabilities-response.json:912-921`\n- Code: `src/adcp/signing/verifier.py:84-95`","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-29T17:23:41Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/298"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6ee0dfa0-58ee-d6dc-4391-adbe2f6215e8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAA8E:2AAD2E:B95F34:F8D8EA:6B00F75B
html-safe-nonceb8912e9c2fba980a43dd1e874a304c18fb0a68b5de7bb4b133addc27f74a7c10
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQThFOjJBQUQyRTpCOTVGMzQ6RjhEOEVBOjZCMDBGNzVCIiwidmlzaXRvcl9pZCI6IjM3MzI2OTM3NDE1OTM0OTEyOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc78ce245826670b5c3ce09ceb5e9c0f6c7ffe2fb8a3f7d4bf92d11c2827a31a6
hovercard-subject-tagissue:4352417769
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/298/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b8f6c3f92d9ce3ddbb46ea0b6dd9bb11ddab9cb2a9722d29f7ea4417b095e92c/adcontextprotocol/adcp-client-python/issues/298
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b8f6c3f92d9ce3ddbb46ea0b6dd9bb11ddab9cb2a9722d29f7ea4417b095e92c/adcontextprotocol/adcp-client-python/issues/298
og:image:altSummary Pre-existing spec divergence in src/adcp/signing/verifier.py:95: VerifierCapability.covers_content_digest defaults to \"required\" but the AdCP 3.0 schema explicitly sets \"default\": \"eit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/298#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F298
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F298
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/298
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/298
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/298
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/298
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/298
#303https://github.com/adcontextprotocol/adcp-client-python/pull/303
Revert covers_content_digest default to spec-mandated 'either'https://github.com/adcontextprotocol/adcp-client-python/issues/298#top
#303https://github.com/adcontextprotocol/adcp-client-python/pull/303
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/298#issue-4352417769
#297https://github.com/adcontextprotocol/adcp-client-python/pull/297
#297https://github.com/adcontextprotocol/adcp-client-python/pull/297
feat(signing): close 4 SSRF gaps and add opt-in port hardening (foundation audit) #297https://github.com/adcontextprotocol/adcp-client-python/pull/297
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/298#event-25001450324
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/298#issuecomment-4346036763
@bokelleyhttps://github.com/bokelley
https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}https://claude.ai/code/$%7BCLAUDE_CODE_REMOTE_SESSION_ID%7D
Claude Codehttps://claude.ai/code
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/298#issuecomment-4346048260
https://claude.ai/code/session_01FLWko81Re1Soq5M5itTAuqhttps://claude.ai/code/session_01FLWko81Re1Soq5M5itTAuq
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/298#event-25001667544
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/298#issuecomment-4346062563
@bokelleyhttps://github.com/bokelley
https://claude.ai/code/session_01UhwW7XUJ36mTFFiXEUVQghhttps://claude.ai/code/session_01UhwW7XUJ36mTFFiXEUVQgh
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/298#event-25012942501
fix(signing): default covers_content_digest to spec-mandated 'either'https://github.com/adcontextprotocol/adcp-client-python/commit/2fdc3d61ad27103afb6227fe5fb8418283d28085
https://docs.github.com/articles/closing-issues-via-commit-messages
2fdc3d6https://github.com/adcontextprotocol/adcp-client-python/commit/2fdc3d61ad27103afb6227fe5fb8418283d28085
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#303https://github.com/adcontextprotocol/adcp-client-python/pull/303
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/298#event-25013019766
KonstantinMirinhttps://github.com/KonstantinMirin
on May 13, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/298#event-25486658894
feat(signing): drain three foundation-audit deferreds (adcontextproto…https://github.com/KonstantinMirin/adcp-client-python/commit/072998a8fd7b33097b7e6ab0496c2ecadf33a691
adcontextproto…https://github.com/adcontextprotocol/adcp-client-python/issues/298
072998ahttps://github.com/KonstantinMirin/adcp-client-python/commit/072998a8fd7b33097b7e6ab0496c2ecadf33a691
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/298
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/298
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.