Title: adcp 4.0.0: examples/seller_agent.py fails its own storyboard validation command — streamable-http ASGI incomplete response · Issue #295 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: adcp 4.0.0: examples/seller_agent.py fails its own storyboard validation command — streamable-http ASGI incomplete response · Issue #295 · adcontextprotocol/adcp-client-python
X Title: adcp 4.0.0: examples/seller_agent.py fails its own storyboard validation command — streamable-http ASGI incomplete response · Issue #295 · adcontextprotocol/adcp-client-python
Description: Summary The official examples/seller_agent.py shipped with adcp 4.0.0 does not pass the AdCP storyboard compliance runner out of the box. The MCP streamable-http transport accepts the runner's initialize POST, returns 200 OK, then closes...
Open Graph Description: Summary The official examples/seller_agent.py shipped with adcp 4.0.0 does not pass the AdCP storyboard compliance runner out of the box. The MCP streamable-http transport accepts the runner's init...
X Description: Summary The official examples/seller_agent.py shipped with adcp 4.0.0 does not pass the AdCP storyboard compliance runner out of the box. The MCP streamable-http transport accepts the runner's ...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/295
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"adcp 4.0.0: examples/seller_agent.py fails its own storyboard validation command — streamable-http ASGI incomplete response","articleBody":"## Summary\n\nThe official `examples/seller_agent.py` shipped with `adcp 4.0.0` does not\npass the AdCP storyboard compliance runner out of the box. The MCP\nstreamable-http transport accepts the runner's `initialize` POST, returns\n`200 OK`, then closes the response without completing — surfaced in uvicorn\nas `ASGI callable returned without completing response`. The runner times out\nafter 120s and reports `overall_status: \"unreachable\"`.\n\nReproduces on macOS 15 (arm64) and clean Ubuntu Linux (Fly.io x86_64).\nNot environmental — contract mismatch between the SDK's `serve()` defaults\nand what the runner expects.\n\n## Environment\n\nServer (Python):\n adcp 4.0.0 | mcp 1.27.0 | fastmcp 3.2.4 | uvicorn 0.46.0\n anyio 4.13.0 | Python 3.13.1 (local), 3.11.9 (Fly Docker)\n\nRunner (JS/TS):\n @adcp/client 5.23.0 (also 5.13.0) | Node.js v24.9.0 (also v20)\n\nSpec target: AdCP 3.0.1\nOS: macOS 15 Darwin 25.2.0 arm64, Linux Fly.io Firecracker x86_64\n\n## Headline Finding\n\n`examples/seller_agent.py` documents this validation command in its\nmodule docstring (line 12):\n\n # Validate:\n # npx -y -p @adcp/client adcp storyboard run \\\n # http://localhost:3001/mcp media_buy_seller --json\n\nThis command does NOT pass — the agent reports `unreachable`.\n\n## Reproduction (5 minutes, no fork required)\n\n git clone --depth 1 --branch v4.0.0 \\\n https://github.com/adcontextprotocol/adcp-client-python.git /tmp/adcp-sdk\n python3 -m venv /tmp/adcp-sdk/.venv\n /tmp/adcp-sdk/.venv/bin/pip install \"adcp==4.0.0\" mcp fastmcp\n\n # Terminal A — start the SDK's own reference agent, unmodified\n ADCP_PORT=3001 /tmp/adcp-sdk/.venv/bin/python /tmp/adcp-sdk/examples/seller_agent.py\n\n # Terminal B — run the validation command from the example's docstring\n npx -y -p @adcp/client adcp storyboard run \\\n http://localhost:3001/mcp media_buy_seller --json --allow-http\n\n## Actual Runner Output\n\n {\n \"agent_url\": \"http://localhost:3001/mcp\",\n \"agent_profile\": { \"name\": \"Unknown\", \"tools\": [] },\n \"overall_status\": \"unreachable\",\n \"summary\": {\n \"tracks_passed\": 0,\n \"tracks_failed\": 0,\n \"tracks_skipped\": 0,\n \"headline\": \"Agent unreachable — Failed to discover MCP endpoint. Tried:\\n 1. http://localhost:3001/mcp\\n 2. http://localhost:3001/mcp/\\nNone responded to MCP protocol.\"\n },\n \"total_duration_ms\": 120044\n }\n\n## Server Logs During Run\n\n INFO: 127.0.0.1:50452 - \"POST /mcp HTTP/1.1\" 200 OK\n ERROR: ASGI callable returned without completing response.\n INFO: 127.0.0.1:50475 - \"GET /mcp HTTP/1.1\" 400 Bad Request\n INFO: 127.0.0.1:50477 - \"POST /mcp/ HTTP/1.1\" 307 Temporary Redirect\n INFO: 127.0.0.1:50475 - \"POST /mcp HTTP/1.1\" 200 OK\n ERROR: ASGI callable returned without completing response.\n\n## Workaround\n\nPatching FastMCP to use stateless_http=True and json_response=True\nmakes the response complete synchronously and the runner connects:\n\n from mcp.server.fastmcp import FastMCP\n _orig = FastMCP.__init__\n def _patched(self, *args, **kwargs):\n kwargs.setdefault(\"stateless_http\", True)\n kwargs.setdefault(\"json_response\", True)\n _orig(self, *args, **kwargs)\n FastMCP.__init__ = _patched\n\nAfter this patch the runner connects and starts running storyboards\n(27/40 steps passing before hitting the secondary issues below).\n\n## Likely Root Cause\n\nmcp 1.27.0's streaming-SSE response handler for streamable-http doesn't\nflush/close on the runner's specific request shape. Fix surface is\nadcp.server.serve() — defaulting stateless_http=True for\ntransport=\"streamable-http\" is likely a one-line fix.\n\n## Secondary Findings\n\n1. serve() doesn't pass host to FastMCP (src/adcp/server/serve.py:747)\n FastMCP defaults to 127.0.0.1. Behind any reverse proxy (Fly, k8s,\n Cloud Run) the container's external interface never receives traffic.\n Recommend: expose host as a serve() kwarg with ADCP_HOST env fallback.\n\n2. DNS-rebinding allowlist rejects production hostnames.\n TransportSecuritySettings defaults allow only 127.0.0.1/localhost/[::1].\n Any production hostname (e.g. myagent.fly.dev) gets 400.\n Recommend: serve() accept transport_security kwarg or env-var defaults.\n\n3. SCENARIOS whitelist out of sync with AdCP 3.0.1\n (src/adcp/server/test_controller.py:48)\n SDK declares 6 scenarios; runner schema (@adcp/client@5.23.0) declares 14,\n including 6 seed_* scenarios used to pre-populate storyboard fixtures.\n Without them, every storyboard with prerequisites.controller_seeding: true\n fails preflight and cascades-skips.\n Missing: force_create_media_buy_arm, force_task_completion, seed_product,\n seed_pricing_option, seed_creative, seed_plan, seed_media_buy,\n seed_creative_format.\n\n4. Hardcoded if/elif dispatcher in _handle_test_controller returns\n UNKNOWN_SCENARIO for anything beyond the 6 known branches.\n Recommend: replace with getattr(store, scenario) dynamic dispatch.\n\n5. capabilities_response() missing required adcp.idempotency field.\n AdCP 3.0.1 schema marks this required. Without it the runner logs\n validation failure and downgrades to v2 mode, cascading failures across\n most tracks. Recommend: default to {\"supported\": False} when not provided.\n\n6. comply_test_controller tool param schema strips runner's account field.\n Runner sends { account, scenario, params }; SDK schema only declares\n { scenario, params, context }. Runner strips account, controller_detected\n reports false even though the tool exists and list_scenarios succeeds.\n Recommend: add account: {type: object} to the tool's inputSchema.\n\n## Impact\n\nA new implementer following the SDK quickstart cannot pass storyboards\nwith the SDK's own example. Every issue above was discovered by reading\nthe runner's compiled JS source because the runner's error messages\nprovided no actionable detail. The fix surface for the headline is a\nsingle line in adcp.server.serve().","author":{"url":"https://github.com/tescoboy","@type":"Person","name":"tescoboy"},"datePublished":"2026-04-29T13:32:54Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/295"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a5772760-442c-be50-a13d-b0a770820d1e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ADAE:26ECEB:10066E9:148E568:6B010059 |
| html-safe-nonce | c0a1e0ee92dd44b17bfd1b9f06eb35aebd56a1ce1438f8f742d19c9fef7d3d9d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREFFOjI2RUNFQjoxMDA2NkU5OjE0OEU1Njg6NkIwMTAwNTkiLCJ2aXNpdG9yX2lkIjoiMzUzNDYxNzY5NjgwNzIyMzM4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8f7ebf42c60b16a3176db3acc955ab4aea5127c7e8988497969888d7c048e7ca |
| hovercard-subject-tag | issue:4350938699 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/295/issue_layout |
| twitter:image | https://opengraph.githubassets.com/696b7d9ec720a7c822769510f71026bd3e73d919c0da8ca8eb29c5819f9f3cff/adcontextprotocol/adcp-client-python/issues/295 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/696b7d9ec720a7c822769510f71026bd3e73d919c0da8ca8eb29c5819f9f3cff/adcontextprotocol/adcp-client-python/issues/295 |
| og:image:alt | Summary The official examples/seller_agent.py shipped with adcp 4.0.0 does not pass the AdCP storyboard compliance runner out of the box. The MCP streamable-http transport accepts the runner's init... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tescoboy |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width