René's URL Explorer Experiment


Title: adcp 4.0.0: examples/seller_agent.py fails its own storyboard validation command — streamable-http ASGI incomplete response · Issue #295 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: adcp 4.0.0: examples/seller_agent.py fails its own storyboard validation command — streamable-http ASGI incomplete response · Issue #295 · adcontextprotocol/adcp-client-python

X Title: adcp 4.0.0: examples/seller_agent.py fails its own storyboard validation command — streamable-http ASGI incomplete response · Issue #295 · adcontextprotocol/adcp-client-python

Description: Summary The official examples/seller_agent.py shipped with adcp 4.0.0 does not pass the AdCP storyboard compliance runner out of the box. The MCP streamable-http transport accepts the runner's initialize POST, returns 200 OK, then closes...

Open Graph Description: Summary The official examples/seller_agent.py shipped with adcp 4.0.0 does not pass the AdCP storyboard compliance runner out of the box. The MCP streamable-http transport accepts the runner's init...

X Description: Summary The official examples/seller_agent.py shipped with adcp 4.0.0 does not pass the AdCP storyboard compliance runner out of the box. The MCP streamable-http transport accepts the runner's ...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/295

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"adcp 4.0.0: examples/seller_agent.py fails its own storyboard validation command — streamable-http ASGI incomplete response","articleBody":"## Summary\n\nThe official `examples/seller_agent.py` shipped with `adcp 4.0.0` does not\npass the AdCP storyboard compliance runner out of the box. The MCP\nstreamable-http transport accepts the runner's `initialize` POST, returns\n`200 OK`, then closes the response without completing — surfaced in uvicorn\nas `ASGI callable returned without completing response`. The runner times out\nafter 120s and reports `overall_status: \"unreachable\"`.\n\nReproduces on macOS 15 (arm64) and clean Ubuntu Linux (Fly.io x86_64).\nNot environmental — contract mismatch between the SDK's `serve()` defaults\nand what the runner expects.\n\n## Environment\n\nServer (Python):\n  adcp 4.0.0 | mcp 1.27.0 | fastmcp 3.2.4 | uvicorn 0.46.0\n  anyio 4.13.0 | Python 3.13.1 (local), 3.11.9 (Fly Docker)\n\nRunner (JS/TS):\n  @adcp/client 5.23.0 (also 5.13.0) | Node.js v24.9.0 (also v20)\n\nSpec target: AdCP 3.0.1\nOS: macOS 15 Darwin 25.2.0 arm64, Linux Fly.io Firecracker x86_64\n\n## Headline Finding\n\n`examples/seller_agent.py` documents this validation command in its\nmodule docstring (line 12):\n\n    # Validate:\n    #     npx -y -p @adcp/client adcp storyboard run \\\n    #         http://localhost:3001/mcp media_buy_seller --json\n\nThis command does NOT pass — the agent reports `unreachable`.\n\n## Reproduction (5 minutes, no fork required)\n\n    git clone --depth 1 --branch v4.0.0 \\\n      https://github.com/adcontextprotocol/adcp-client-python.git /tmp/adcp-sdk\n    python3 -m venv /tmp/adcp-sdk/.venv\n    /tmp/adcp-sdk/.venv/bin/pip install \"adcp==4.0.0\" mcp fastmcp\n\n    # Terminal A — start the SDK's own reference agent, unmodified\n    ADCP_PORT=3001 /tmp/adcp-sdk/.venv/bin/python /tmp/adcp-sdk/examples/seller_agent.py\n\n    # Terminal B — run the validation command from the example's docstring\n    npx -y -p @adcp/client adcp storyboard run \\\n      http://localhost:3001/mcp media_buy_seller --json --allow-http\n\n## Actual Runner Output\n\n    {\n      \"agent_url\": \"http://localhost:3001/mcp\",\n      \"agent_profile\": { \"name\": \"Unknown\", \"tools\": [] },\n      \"overall_status\": \"unreachable\",\n      \"summary\": {\n        \"tracks_passed\": 0,\n        \"tracks_failed\": 0,\n        \"tracks_skipped\": 0,\n        \"headline\": \"Agent unreachable — Failed to discover MCP endpoint. Tried:\\n  1. http://localhost:3001/mcp\\n  2. http://localhost:3001/mcp/\\nNone responded to MCP protocol.\"\n      },\n      \"total_duration_ms\": 120044\n    }\n\n## Server Logs During Run\n\n    INFO:     127.0.0.1:50452 - \"POST /mcp HTTP/1.1\" 200 OK\n    ERROR:    ASGI callable returned without completing response.\n    INFO:     127.0.0.1:50475 - \"GET /mcp HTTP/1.1\" 400 Bad Request\n    INFO:     127.0.0.1:50477 - \"POST /mcp/ HTTP/1.1\" 307 Temporary Redirect\n    INFO:     127.0.0.1:50475 - \"POST /mcp HTTP/1.1\" 200 OK\n    ERROR:    ASGI callable returned without completing response.\n\n## Workaround\n\nPatching FastMCP to use stateless_http=True and json_response=True\nmakes the response complete synchronously and the runner connects:\n\n    from mcp.server.fastmcp import FastMCP\n    _orig = FastMCP.__init__\n    def _patched(self, *args, **kwargs):\n        kwargs.setdefault(\"stateless_http\", True)\n        kwargs.setdefault(\"json_response\", True)\n        _orig(self, *args, **kwargs)\n    FastMCP.__init__ = _patched\n\nAfter this patch the runner connects and starts running storyboards\n(27/40 steps passing before hitting the secondary issues below).\n\n## Likely Root Cause\n\nmcp 1.27.0's streaming-SSE response handler for streamable-http doesn't\nflush/close on the runner's specific request shape. Fix surface is\nadcp.server.serve() — defaulting stateless_http=True for\ntransport=\"streamable-http\" is likely a one-line fix.\n\n## Secondary Findings\n\n1. serve() doesn't pass host to FastMCP (src/adcp/server/serve.py:747)\n   FastMCP defaults to 127.0.0.1. Behind any reverse proxy (Fly, k8s,\n   Cloud Run) the container's external interface never receives traffic.\n   Recommend: expose host as a serve() kwarg with ADCP_HOST env fallback.\n\n2. DNS-rebinding allowlist rejects production hostnames.\n   TransportSecuritySettings defaults allow only 127.0.0.1/localhost/[::1].\n   Any production hostname (e.g. myagent.fly.dev) gets 400.\n   Recommend: serve() accept transport_security kwarg or env-var defaults.\n\n3. SCENARIOS whitelist out of sync with AdCP 3.0.1\n   (src/adcp/server/test_controller.py:48)\n   SDK declares 6 scenarios; runner schema (@adcp/client@5.23.0) declares 14,\n   including 6 seed_* scenarios used to pre-populate storyboard fixtures.\n   Without them, every storyboard with prerequisites.controller_seeding: true\n   fails preflight and cascades-skips.\n   Missing: force_create_media_buy_arm, force_task_completion, seed_product,\n   seed_pricing_option, seed_creative, seed_plan, seed_media_buy,\n   seed_creative_format.\n\n4. Hardcoded if/elif dispatcher in _handle_test_controller returns\n   UNKNOWN_SCENARIO for anything beyond the 6 known branches.\n   Recommend: replace with getattr(store, scenario) dynamic dispatch.\n\n5. capabilities_response() missing required adcp.idempotency field.\n   AdCP 3.0.1 schema marks this required. Without it the runner logs\n   validation failure and downgrades to v2 mode, cascading failures across\n   most tracks. Recommend: default to {\"supported\": False} when not provided.\n\n6. comply_test_controller tool param schema strips runner's account field.\n   Runner sends { account, scenario, params }; SDK schema only declares\n   { scenario, params, context }. Runner strips account, controller_detected\n   reports false even though the tool exists and list_scenarios succeeds.\n   Recommend: add account: {type: object} to the tool's inputSchema.\n\n## Impact\n\nA new implementer following the SDK quickstart cannot pass storyboards\nwith the SDK's own example. Every issue above was discovered by reading\nthe runner's compiled JS source because the runner's error messages\nprovided no actionable detail. The fix surface for the headline is a\nsingle line in adcp.server.serve().","author":{"url":"https://github.com/tescoboy","@type":"Person","name":"tescoboy"},"datePublished":"2026-04-29T13:32:54Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/295"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a5772760-442c-be50-a13d-b0a770820d1e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idADAE:26ECEB:10066E9:148E568:6B010059
html-safe-noncec0a1e0ee92dd44b17bfd1b9f06eb35aebd56a1ce1438f8f742d19c9fef7d3d9d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREFFOjI2RUNFQjoxMDA2NkU5OjE0OEU1Njg6NkIwMTAwNTkiLCJ2aXNpdG9yX2lkIjoiMzUzNDYxNzY5NjgwNzIyMzM4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8f7ebf42c60b16a3176db3acc955ab4aea5127c7e8988497969888d7c048e7ca
hovercard-subject-tagissue:4350938699
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/295/issue_layout
twitter:imagehttps://opengraph.githubassets.com/696b7d9ec720a7c822769510f71026bd3e73d919c0da8ca8eb29c5819f9f3cff/adcontextprotocol/adcp-client-python/issues/295
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/696b7d9ec720a7c822769510f71026bd3e73d919c0da8ca8eb29c5819f9f3cff/adcontextprotocol/adcp-client-python/issues/295
og:image:altSummary The official examples/seller_agent.py shipped with adcp 4.0.0 does not pass the AdCP storyboard compliance runner out of the box. The MCP streamable-http transport accepts the runner's init...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametescoboy
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/295#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F295
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F295
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/295
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/295
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/295
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/295
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/295
adcp 4.0.0: examples/seller_agent.py fails its own storyboard validation command — streamable-http ASGI incomplete responsehttps://github.com/adcontextprotocol/adcp-client-python/issues/295#top
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/tescoboy
tescoboyhttps://github.com/tescoboy
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/295#issue-4350938699
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/295#event-24992336916
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/295#issuecomment-4344407352
#296https://github.com/adcontextprotocol/adcp-client-python/pull/296
https://claude.ai/code/session_01RJtJkQ8rooA7monEAB6ZVdhttps://claude.ai/code/session_01RJtJkQ8rooA7monEAB6ZVd
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
6be0232https://github.com/adcontextprotocol/adcp-client-python/commit/6be02328be979ccd32ac2914d8b5e04c0923dd02
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/295#event-25014420076
KonstantinMirinhttps://github.com/KonstantinMirin
on May 13, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/295#event-25486659316
fix(server): fix streamable-http ASGI error, host binding, and AdCP 3…https://github.com/KonstantinMirin/adcp-client-python/commit/6be02328be979ccd32ac2914d8b5e04c0923dd02
https://docs.github.com/articles/closing-issues-via-commit-messages
6be0232https://github.com/KonstantinMirin/adcp-client-python/commit/6be02328be979ccd32ac2914d8b5e04c0923dd02
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/295
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/295
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.