René's URL Explorer Experiment


Title: Python SDK (adcp 3.10.0) schema drift: MediaBuyStatus, AggregatedTotals, UpdateMediaBuySuccess out of sync with v3 schemas · Issue #288 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Python SDK (adcp 3.10.0) schema drift: MediaBuyStatus, AggregatedTotals, UpdateMediaBuySuccess out of sync with v3 schemas · Issue #288 · adcontextprotocol/adcp-client-python

X Title: Python SDK (adcp 3.10.0) schema drift: MediaBuyStatus, AggregatedTotals, UpdateMediaBuySuccess out of sync with v3 schemas · Issue #288 · adcontextprotocol/adcp-client-python

Description: Summary The adcp Python library (3.10.0) is auto-generated from a stale snapshot and is out of sync with the AdCP v3 JSON schemas at /schemas/3.0.1/. Extending SDK types via inheritance (per CLAUDE.md Pattern #1) does not guarantee spec ...

Open Graph Description: Summary The adcp Python library (3.10.0) is auto-generated from a stale snapshot and is out of sync with the AdCP v3 JSON schemas at /schemas/3.0.1/. Extending SDK types via inheritance (per CLAUDE...

X Description: Summary The adcp Python library (3.10.0) is auto-generated from a stale snapshot and is out of sync with the AdCP v3 JSON schemas at /schemas/3.0.1/. Extending SDK types via inheritance (per CLAUDE...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/288

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Python SDK (adcp 3.10.0) schema drift: MediaBuyStatus, AggregatedTotals, UpdateMediaBuySuccess out of sync with v3 schemas","articleBody":"## Summary\n\nThe `adcp` Python library (3.10.0) is auto-generated from a stale snapshot and is out of sync with the AdCP v3 JSON schemas at `/schemas/3.0.1/`. Extending SDK types via inheritance (per CLAUDE.md Pattern #1) does not guarantee spec compliance — implementations have to audit the live schemas separately and apply field-level overrides where the SDK lags.\n\nThis issue documents concrete drift discovered during a compliance pass, verified against the live schemas. Cross-posting from a downstream implementation repo.\n\n---\n\n## Evidence\n\n**SDK version:** `adcp 3.10.0`\n**Schema source:** `https://adcontextprotocol.org/schemas/v3/` (`$id` declares `3.0.1`)\n\n### 1. `MediaBuyStatus`: `pending_activation` → `pending_start` + missing `pending_creatives`\n\nSDK emits `pending_activation`. Live schema (`enums/media-buy-status.json`):\n\n```\n\"enum\": [\"pending_creatives\", \"pending_start\", \"active\", \"paused\", \"completed\", \"rejected\", \"canceled\"]\n```\n\n`pending_activation` does not appear. `pending_creatives` (required when creatives are unapproved) is absent from the SDK entirely.\n\n**Workaround:** Override `MediaBuyDeliveryData.status` as a `Literal` of spec values; translate internal `pending_activation → pending_start` at emission time. Add `pending_creatives` as an override.\n\nNote: the delivery-item response also allows `pending`, `failed`, and `reporting_delayed` — these are delivery-level statuses distinct from the top-level `media-buy-status.json` enum and may need separate handling.\n\n---\n\n### 2. `AggregatedTotals.video_completions` → `completed_views`\n\nSDK field: `video_completions`\nLive schema (`get-media-buy-delivery-response.json → aggregated_totals`):\n\n```json\n\"completed_views\": { \"description\": \"Total audio/video completions across all media buys\" }\n```\n\nNo `video_completions` key exists in the schema. The rename happened upstream; SDK still has the old name.\n\n**Workaround:** Subclass overrides `model_dump` to rename `video_completions → completed_views` on serialization.\n\n---\n\n### 3. `AggregatedTotals` missing spec fields\n\nLive schema lists these on `aggregated_totals`:\n\n| Field | In SDK? |\n|---|---|\n| `impressions` | ✓ |\n| `spend` | ✓ |\n| `clicks` | ✓ |\n| `completed_views` | ✗ (SDK has `video_completions`) |\n| `views` | ✗ |\n| `conversions` | ✓ |\n| `conversion_value` | ✓ |\n| `roas` | ✓ |\n| `new_to_brand_rate` | ✓ |\n\n","author":{"url":"https://github.com/tescoboy","@type":"Person","name":"tescoboy"},"datePublished":"2026-04-28T14:33:56Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/288"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a8d7f756-25a5-46a8-871c-82c5bff73477
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE5FC:291B58:2E3C42:3A917D:6B010242
html-safe-nonceb5683191ec78a58fcb17529ad416f5b89752720ac485db3c3af191a61600c4e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUZDOjI5MUI1ODoyRTNDNDI6M0E5MTdEOjZCMDEwMjQyIiwidmlzaXRvcl9pZCI6IjY3NDI5MjM5Mjg2NTU2OTIzNTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf37f5625cdd936408049b8b32787d8ba56823b25529a2e8cbfcd23d5db4459cc
hovercard-subject-tagissue:4343976721
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/288/issue_layout
twitter:imagehttps://opengraph.githubassets.com/252442fa88dfe34ce61ce930ab28c067cf390461feaef1e04bd53e1e30ad9bd3/adcontextprotocol/adcp-client-python/issues/288
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/252442fa88dfe34ce61ce930ab28c067cf390461feaef1e04bd53e1e30ad9bd3/adcontextprotocol/adcp-client-python/issues/288
og:image:altSummary The adcp Python library (3.10.0) is auto-generated from a stale snapshot and is out of sync with the AdCP v3 JSON schemas at /schemas/3.0.1/. Extending SDK types via inheritance (per CLAUDE...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametescoboy
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/288#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F288
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F288
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/288
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/288
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/288
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/288
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/288
#289https://github.com/adcontextprotocol/adcp-client-python/pull/289
Python SDK (adcp 3.10.0) schema drift: MediaBuyStatus, AggregatedTotals, UpdateMediaBuySuccess out of sync with v3 schemashttps://github.com/adcontextprotocol/adcp-client-python/issues/288#top
#289https://github.com/adcontextprotocol/adcp-client-python/pull/289
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com/tescoboy
tescoboyhttps://github.com/tescoboy
on Apr 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/288#issue-4343976721
#1https://github.com/adcontextprotocol/adcp-client-python/pull/1
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/288#event-24952346312
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 28, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/288#issuecomment-4336376832
#289https://github.com/adcontextprotocol/adcp-client-python/pull/289
#289https://github.com/adcontextprotocol/adcp-client-python/pull/289
https://claude.ai/code/session_01Q4gEoNmiYsfqnfFSR71JLghttps://claude.ai/code/session_01Q4gEoNmiYsfqnfFSR71JLg
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#289https://github.com/adcontextprotocol/adcp-client-python/pull/289
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/288#event-25012879360
KonstantinMirinhttps://github.com/KonstantinMirin
on May 13, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/288#event-25486658692
fix(handlers): sync MEDIA_BUY_STATE_MACHINE with spec v3 enum (adcont…https://github.com/KonstantinMirin/adcp-client-python/commit/54fd18b45cbef587db0d6ce48531c5b35e3c302b
adcont…https://github.com/adcontextprotocol/adcp-client-python/pull/289
https://docs.github.com/articles/closing-issues-via-commit-messages
54fd18bhttps://github.com/KonstantinMirin/adcp-client-python/commit/54fd18b45cbef587db0d6ce48531c5b35e3c302b
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/288
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/288
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.