Title: Python SDK (adcp 3.10.0) schema drift: MediaBuyStatus, AggregatedTotals, UpdateMediaBuySuccess out of sync with v3 schemas · Issue #288 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: Python SDK (adcp 3.10.0) schema drift: MediaBuyStatus, AggregatedTotals, UpdateMediaBuySuccess out of sync with v3 schemas · Issue #288 · adcontextprotocol/adcp-client-python
X Title: Python SDK (adcp 3.10.0) schema drift: MediaBuyStatus, AggregatedTotals, UpdateMediaBuySuccess out of sync with v3 schemas · Issue #288 · adcontextprotocol/adcp-client-python
Description: Summary The adcp Python library (3.10.0) is auto-generated from a stale snapshot and is out of sync with the AdCP v3 JSON schemas at /schemas/3.0.1/. Extending SDK types via inheritance (per CLAUDE.md Pattern #1) does not guarantee spec ...
Open Graph Description: Summary The adcp Python library (3.10.0) is auto-generated from a stale snapshot and is out of sync with the AdCP v3 JSON schemas at /schemas/3.0.1/. Extending SDK types via inheritance (per CLAUDE...
X Description: Summary The adcp Python library (3.10.0) is auto-generated from a stale snapshot and is out of sync with the AdCP v3 JSON schemas at /schemas/3.0.1/. Extending SDK types via inheritance (per CLAUDE...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/288
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Python SDK (adcp 3.10.0) schema drift: MediaBuyStatus, AggregatedTotals, UpdateMediaBuySuccess out of sync with v3 schemas","articleBody":"## Summary\n\nThe `adcp` Python library (3.10.0) is auto-generated from a stale snapshot and is out of sync with the AdCP v3 JSON schemas at `/schemas/3.0.1/`. Extending SDK types via inheritance (per CLAUDE.md Pattern #1) does not guarantee spec compliance — implementations have to audit the live schemas separately and apply field-level overrides where the SDK lags.\n\nThis issue documents concrete drift discovered during a compliance pass, verified against the live schemas. Cross-posting from a downstream implementation repo.\n\n---\n\n## Evidence\n\n**SDK version:** `adcp 3.10.0`\n**Schema source:** `https://adcontextprotocol.org/schemas/v3/` (`$id` declares `3.0.1`)\n\n### 1. `MediaBuyStatus`: `pending_activation` → `pending_start` + missing `pending_creatives`\n\nSDK emits `pending_activation`. Live schema (`enums/media-buy-status.json`):\n\n```\n\"enum\": [\"pending_creatives\", \"pending_start\", \"active\", \"paused\", \"completed\", \"rejected\", \"canceled\"]\n```\n\n`pending_activation` does not appear. `pending_creatives` (required when creatives are unapproved) is absent from the SDK entirely.\n\n**Workaround:** Override `MediaBuyDeliveryData.status` as a `Literal` of spec values; translate internal `pending_activation → pending_start` at emission time. Add `pending_creatives` as an override.\n\nNote: the delivery-item response also allows `pending`, `failed`, and `reporting_delayed` — these are delivery-level statuses distinct from the top-level `media-buy-status.json` enum and may need separate handling.\n\n---\n\n### 2. `AggregatedTotals.video_completions` → `completed_views`\n\nSDK field: `video_completions`\nLive schema (`get-media-buy-delivery-response.json → aggregated_totals`):\n\n```json\n\"completed_views\": { \"description\": \"Total audio/video completions across all media buys\" }\n```\n\nNo `video_completions` key exists in the schema. The rename happened upstream; SDK still has the old name.\n\n**Workaround:** Subclass overrides `model_dump` to rename `video_completions → completed_views` on serialization.\n\n---\n\n### 3. `AggregatedTotals` missing spec fields\n\nLive schema lists these on `aggregated_totals`:\n\n| Field | In SDK? |\n|---|---|\n| `impressions` | ✓ |\n| `spend` | ✓ |\n| `clicks` | ✓ |\n| `completed_views` | ✗ (SDK has `video_completions`) |\n| `views` | ✗ |\n| `conversions` | ✓ |\n| `conversion_value` | ✓ |\n| `roas` | ✓ |\n| `new_to_brand_rate` | ✓ |\n\n","author":{"url":"https://github.com/tescoboy","@type":"Person","name":"tescoboy"},"datePublished":"2026-04-28T14:33:56Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/288"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a8d7f756-25a5-46a8-871c-82c5bff73477 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E5FC:291B58:2E3C42:3A917D:6B010242 |
| html-safe-nonce | b5683191ec78a58fcb17529ad416f5b89752720ac485db3c3af191a61600c4e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUZDOjI5MUI1ODoyRTNDNDI6M0E5MTdEOjZCMDEwMjQyIiwidmlzaXRvcl9pZCI6IjY3NDI5MjM5Mjg2NTU2OTIzNTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f37f5625cdd936408049b8b32787d8ba56823b25529a2e8cbfcd23d5db4459cc |
| hovercard-subject-tag | issue:4343976721 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/288/issue_layout |
| twitter:image | https://opengraph.githubassets.com/252442fa88dfe34ce61ce930ab28c067cf390461feaef1e04bd53e1e30ad9bd3/adcontextprotocol/adcp-client-python/issues/288 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/252442fa88dfe34ce61ce930ab28c067cf390461feaef1e04bd53e1e30ad9bd3/adcontextprotocol/adcp-client-python/issues/288 |
| og:image:alt | Summary The adcp Python library (3.10.0) is auto-generated from a stale snapshot and is out of sync with the AdCP v3 JSON schemas at /schemas/3.0.1/. Extending SDK types via inheritance (per CLAUDE... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tescoboy |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width