Title: A2A 1.0 follow-ups: wrapper policy, webhook envelope, test coverage · Issue #263 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: A2A 1.0 follow-ups: wrapper policy, webhook envelope, test coverage · Issue #263 · adcontextprotocol/adcp-client-python
X Title: A2A 1.0 follow-ups: wrapper policy, webhook envelope, test coverage · Issue #263 · adcontextprotocol/adcp-client-python
Description: Follow-up issue after PR #261 landed the a2a-sdk 1.0 migration. Reviewing against the A2A 1.0 extraction/placement rules that just landed in the adcp spec+docs repo (see bokelley/a2a-1.0-update — docs PR pending), we found two policy con...
Open Graph Description: Follow-up issue after PR #261 landed the a2a-sdk 1.0 migration. Reviewing against the A2A 1.0 extraction/placement rules that just landed in the adcp spec+docs repo (see bokelley/a2a-1.0-update — d...
X Description: Follow-up issue after PR #261 landed the a2a-sdk 1.0 migration. Reviewing against the A2A 1.0 extraction/placement rules that just landed in the adcp spec+docs repo (see bokelley/a2a-1.0-update — d...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/263
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"A2A 1.0 follow-ups: wrapper policy, webhook envelope, test coverage","articleBody":"Follow-up issue after PR #261 landed the a2a-sdk 1.0 migration. Reviewing against the A2A 1.0 extraction/placement rules that just landed in the adcp spec+docs repo (see [`bokelley/a2a-1.0-update`](https://github.com/adcontextprotocol/adcp/tree/bokelley/a2a-1.0-update) — docs PR pending), we found two policy conflicts and three test-coverage gaps worth addressing.\n\nSome of these may resolve cleanly when **a2a-sdk 1.0.1** ships upstream — the shim layer in `tests/a2a_compat_shim.py` and the `MessageToDict` post-processing dance are the kind of thing that gets smaller as the Python SDK matures. Suggest revisiting this list after the next upstream drop before committing to any of the fixes.\n\n## Policy conflicts (need alignment across repos)\n\n### 1. Wrapper policy — docs say reject, Python unwraps silently\n\nadcp docs (`a2a-response-extraction.mdx`) state the [normative rule](https://github.com/adcontextprotocol/adcp/blob/bokelley/a2a-1.0-update/docs/building/implementation/a2a-response-extraction.mdx) clients MUST throw or log when a DataPart's `.data` is a single-key `{ response: {...} }` wrapper — it's a server-side bug.\n\nThis PR continues to silently unwrap in `_extract_result_from_task` and `_process_task_response` (`src/adcp/protocols/a2a.py`), and `test_extract_from_a2a_with_response_wrapper` / `test_extract_from_a2a_with_nested_response_wrapper` actively assert unwrap behavior.\n\n**Options:**\n- **Soften the docs** to \\\"MAY unwrap with warning; MUST NOT silently consume in strict mode.\\\" Matches deployed Python behavior and preserves pressure on buggy servers without breaking consumers that already rely on forgiving extraction.\n- **Flip Python** to reject. Aligns with current docs but risks breaking any production buyer relying on the forgiving behavior.\n\nLeaning toward softening the docs — but wanted to surface the divergence.\n\n### 2. Webhook envelope wrapping — docs say `StreamResponse`-wrapped, Python emits bare\n\nadcp docs state push-notification payloads use the A2A 1.0 `StreamResponse` wrapper (`{ task }` / `{ statusUpdate }` / `{ artifactUpdate }` / `{ message }`), citing A2A 1.0 §4.3.3.\n\nThis PR emits bare `Task` and `TaskStatusUpdateEvent` in `create_a2a_webhook_payload` (`src/adcp/webhooks.py`) — looks like an intentional choice for v0.3 consumer compat.\n\n**Action:** direct re-read of A2A 1.0 §4.3.3. If wrapping is normative, Python needs a future fix (potentially controlled by the same `enable_v0_3_compat` flag so 0.3 consumers keep the bare shape). If peer-choice, adcp docs should note Python emits bare for compat and new servers SHOULD wrap.\n\n## Test coverage gaps\n\n### 3. No extraction tests for `rejected` / `auth-required`\n\nThe tolerant enum maps (`src/adcp/protocols/a2a.py`, `src/adcp/webhooks.py`) include both new 1.0 states, but no test asserts `adcp_error` extraction from a `TASK_STATE_REJECTED` artifact DataPart, or auth-challenge extraction from a `TASK_STATE_AUTH_REQUIRED` status message.\n\nadcp repo has vectors for both — worth mirroring in the Python test suite.\n\n### 4. No integration test for 1.0 client → 0.3 server\n\n`tests/integration/test_a2a_wire_compat.py` covers 0.3 client → 1.0 server (the deployment direction most likely to break). The reverse — 1.0 Python client talking to a 0.3-only peer via `force_a2a_version=\\\"0.3\\\"` — has unit coverage of the version-filter logic but no end-to-end regression guard.\n\n### 5. CHANGELOG 4.1.0 should flag subclasser breakage\n\nThe 4.1.0 release is pragmatically a minor bump given near-zero A2A adopter population, but subclassers face breaking changes:\n- `a2a.utils.errors.ServerError` → `A2AError`\n- `get_agent_info()` no longer returns `adcp_version` / `protocols_supported`\n- `a2a-sdk` type import paths shifted\n\nWorth a top-level entry in CHANGELOG 4.1.0 so downstream integrators see it.\n\n## Related\n\n- adcp spec+docs: `bokelley/a2a-1.0-update` branch (PR pending)\n- Original PR: #261\n- A2A 1.0 milestone context: https://medium.com/google-cloud/the-a2a-1-0-milestone-ensuring-and-testing-backward-compatibility-4aadb007c49b\n\n🤖 Filed with [Claude Code](https://claude.com/claude-code) after expert review of the 1.0 migration.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-23T22:28:10Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/263"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3a017091-d8dc-3c37-44f5-afff43e82dbc |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 92DA:34CAB:C0DA87:F72F69:6B01001C |
| html-safe-nonce | f57ba8290af236d81fc8a2b1a877f779d2b3c08ca868e81be794ef7597662752 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkRBOjM0Q0FCOkMwREE4NzpGNzJGNjk6NkIwMTAwMUMiLCJ2aXNpdG9yX2lkIjoiOTEwNDE3MjIwMDY3MTM3OTQ4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6f8223d4eb5b4cb0e297df10a58df324d50a61d1c2940e65fd2b8ecf4e40e246 |
| hovercard-subject-tag | issue:4319249086 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/263/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2920a32aabfc9e2b3e73f9fed4180524ac4ddf30ba365e87d9cad53682409d8f/adcontextprotocol/adcp-client-python/issues/263 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2920a32aabfc9e2b3e73f9fed4180524ac4ddf30ba365e87d9cad53682409d8f/adcontextprotocol/adcp-client-python/issues/263 |
| og:image:alt | Follow-up issue after PR #261 landed the a2a-sdk 1.0 migration. Reviewing against the A2A 1.0 extraction/placement rules that just landed in the adcp spec+docs repo (see bokelley/a2a-1.0-update — d... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width