René's URL Explorer Experiment


Title: A2A 1.0 follow-ups: wrapper policy, webhook envelope, test coverage · Issue #263 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: A2A 1.0 follow-ups: wrapper policy, webhook envelope, test coverage · Issue #263 · adcontextprotocol/adcp-client-python

X Title: A2A 1.0 follow-ups: wrapper policy, webhook envelope, test coverage · Issue #263 · adcontextprotocol/adcp-client-python

Description: Follow-up issue after PR #261 landed the a2a-sdk 1.0 migration. Reviewing against the A2A 1.0 extraction/placement rules that just landed in the adcp spec+docs repo (see bokelley/a2a-1.0-update — docs PR pending), we found two policy con...

Open Graph Description: Follow-up issue after PR #261 landed the a2a-sdk 1.0 migration. Reviewing against the A2A 1.0 extraction/placement rules that just landed in the adcp spec+docs repo (see bokelley/a2a-1.0-update — d...

X Description: Follow-up issue after PR #261 landed the a2a-sdk 1.0 migration. Reviewing against the A2A 1.0 extraction/placement rules that just landed in the adcp spec+docs repo (see bokelley/a2a-1.0-update — d...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/263

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"A2A 1.0 follow-ups: wrapper policy, webhook envelope, test coverage","articleBody":"Follow-up issue after PR #261 landed the a2a-sdk 1.0 migration. Reviewing against the A2A 1.0 extraction/placement rules that just landed in the adcp spec+docs repo (see [`bokelley/a2a-1.0-update`](https://github.com/adcontextprotocol/adcp/tree/bokelley/a2a-1.0-update) — docs PR pending), we found two policy conflicts and three test-coverage gaps worth addressing.\n\nSome of these may resolve cleanly when **a2a-sdk 1.0.1** ships upstream — the shim layer in `tests/a2a_compat_shim.py` and the `MessageToDict` post-processing dance are the kind of thing that gets smaller as the Python SDK matures. Suggest revisiting this list after the next upstream drop before committing to any of the fixes.\n\n## Policy conflicts (need alignment across repos)\n\n### 1. Wrapper policy — docs say reject, Python unwraps silently\n\nadcp docs (`a2a-response-extraction.mdx`) state the [normative rule](https://github.com/adcontextprotocol/adcp/blob/bokelley/a2a-1.0-update/docs/building/implementation/a2a-response-extraction.mdx) clients MUST throw or log when a DataPart's `.data` is a single-key `{ response: {...} }` wrapper — it's a server-side bug.\n\nThis PR continues to silently unwrap in `_extract_result_from_task` and `_process_task_response` (`src/adcp/protocols/a2a.py`), and `test_extract_from_a2a_with_response_wrapper` / `test_extract_from_a2a_with_nested_response_wrapper` actively assert unwrap behavior.\n\n**Options:**\n- **Soften the docs** to \\\"MAY unwrap with warning; MUST NOT silently consume in strict mode.\\\" Matches deployed Python behavior and preserves pressure on buggy servers without breaking consumers that already rely on forgiving extraction.\n- **Flip Python** to reject. Aligns with current docs but risks breaking any production buyer relying on the forgiving behavior.\n\nLeaning toward softening the docs — but wanted to surface the divergence.\n\n### 2. Webhook envelope wrapping — docs say `StreamResponse`-wrapped, Python emits bare\n\nadcp docs state push-notification payloads use the A2A 1.0 `StreamResponse` wrapper (`{ task }` / `{ statusUpdate }` / `{ artifactUpdate }` / `{ message }`), citing A2A 1.0 §4.3.3.\n\nThis PR emits bare `Task` and `TaskStatusUpdateEvent` in `create_a2a_webhook_payload` (`src/adcp/webhooks.py`) — looks like an intentional choice for v0.3 consumer compat.\n\n**Action:** direct re-read of A2A 1.0 §4.3.3. If wrapping is normative, Python needs a future fix (potentially controlled by the same `enable_v0_3_compat` flag so 0.3 consumers keep the bare shape). If peer-choice, adcp docs should note Python emits bare for compat and new servers SHOULD wrap.\n\n## Test coverage gaps\n\n### 3. No extraction tests for `rejected` / `auth-required`\n\nThe tolerant enum maps (`src/adcp/protocols/a2a.py`, `src/adcp/webhooks.py`) include both new 1.0 states, but no test asserts `adcp_error` extraction from a `TASK_STATE_REJECTED` artifact DataPart, or auth-challenge extraction from a `TASK_STATE_AUTH_REQUIRED` status message.\n\nadcp repo has vectors for both — worth mirroring in the Python test suite.\n\n### 4. No integration test for 1.0 client → 0.3 server\n\n`tests/integration/test_a2a_wire_compat.py` covers 0.3 client → 1.0 server (the deployment direction most likely to break). The reverse — 1.0 Python client talking to a 0.3-only peer via `force_a2a_version=\\\"0.3\\\"` — has unit coverage of the version-filter logic but no end-to-end regression guard.\n\n### 5. CHANGELOG 4.1.0 should flag subclasser breakage\n\nThe 4.1.0 release is pragmatically a minor bump given near-zero A2A adopter population, but subclassers face breaking changes:\n- `a2a.utils.errors.ServerError` → `A2AError`\n- `get_agent_info()` no longer returns `adcp_version` / `protocols_supported`\n- `a2a-sdk` type import paths shifted\n\nWorth a top-level entry in CHANGELOG 4.1.0 so downstream integrators see it.\n\n## Related\n\n- adcp spec+docs: `bokelley/a2a-1.0-update` branch (PR pending)\n- Original PR: #261\n- A2A 1.0 milestone context: https://medium.com/google-cloud/the-a2a-1-0-milestone-ensuring-and-testing-backward-compatibility-4aadb007c49b\n\n🤖 Filed with [Claude Code](https://claude.com/claude-code) after expert review of the 1.0 migration.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-23T22:28:10Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/263"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3a017091-d8dc-3c37-44f5-afff43e82dbc
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id92DA:34CAB:C0DA87:F72F69:6B01001C
html-safe-noncef57ba8290af236d81fc8a2b1a877f779d2b3c08ca868e81be794ef7597662752
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkRBOjM0Q0FCOkMwREE4NzpGNzJGNjk6NkIwMTAwMUMiLCJ2aXNpdG9yX2lkIjoiOTEwNDE3MjIwMDY3MTM3OTQ4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6f8223d4eb5b4cb0e297df10a58df324d50a61d1c2940e65fd2b8ecf4e40e246
hovercard-subject-tagissue:4319249086
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/263/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2920a32aabfc9e2b3e73f9fed4180524ac4ddf30ba365e87d9cad53682409d8f/adcontextprotocol/adcp-client-python/issues/263
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2920a32aabfc9e2b3e73f9fed4180524ac4ddf30ba365e87d9cad53682409d8f/adcontextprotocol/adcp-client-python/issues/263
og:image:altFollow-up issue after PR #261 landed the a2a-sdk 1.0 migration. Reviewing against the A2A 1.0 extraction/placement rules that just landed in the adcp spec+docs repo (see bokelley/a2a-1.0-update — d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/263#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F263
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F263
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/263
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/263
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/263
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/263
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/263
#270https://github.com/adcontextprotocol/adcp-client-python/pull/270
A2A 1.0 follow-ups: wrapper policy, webhook envelope, test coveragehttps://github.com/adcontextprotocol/adcp-client-python/issues/263#top
#270https://github.com/adcontextprotocol/adcp-client-python/pull/270
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
documentationImprovements or additions to documentationhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22documentation%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 23, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/263#issue-4319249086
#261https://github.com/adcontextprotocol/adcp-client-python/pull/261
bokelley/a2a-1.0-updatehttps://github.com/adcontextprotocol/adcp/tree/bokelley/a2a-1.0-update
normative rulehttps://github.com/adcontextprotocol/adcp/blob/bokelley/a2a-1.0-update/docs/building/implementation/a2a-response-extraction.mdx
feat(a2a): migrate to a2a-sdk 1.0 with 0.3 wire-compat shim (Release-As: 4.1.0) #261https://github.com/adcontextprotocol/adcp-client-python/pull/261
https://medium.com/google-cloud/the-a2a-1-0-milestone-ensuring-and-testing-backward-compatibility-4aadb007c49bhttps://medium.com/google-cloud/the-a2a-1-0-milestone-ensuring-and-testing-backward-compatibility-4aadb007c49b
Claude Codehttps://claude.com/claude-code
bokelleyhttps://github.com/bokelley
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
on Apr 24, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/263#event-24820686219
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 24, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/263#issuecomment-4310299062
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 24, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/263#issuecomment-4310335710
#268https://github.com/adcontextprotocol/adcp-client-python/pull/268
https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}https://claude.ai/code/$%7BCLAUDE_CODE_REMOTE_SESSION_ID%7D
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
documentationImprovements or additions to documentationhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22documentation%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
on Apr 24, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/263#event-24821541900
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 24, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/263#issuecomment-4312566858
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 24, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/263#issuecomment-4312650073
#270https://github.com/adcontextprotocol/adcp-client-python/pull/270
@bokelleyhttps://github.com/bokelley
#270https://github.com/adcontextprotocol/adcp-client-python/pull/270
@bokelleyhttps://github.com/bokelley
https://claude.ai/code/session_01MxALGppjocjuZzDVp48tpshttps://claude.ai/code/session_01MxALGppjocjuZzDVp48tps
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#270https://github.com/adcontextprotocol/adcp-client-python/pull/270
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/263#event-25012235661
KonstantinMirinhttps://github.com/KonstantinMirin
on May 13, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/263#event-25486658471
test(a2a): assert TaskResult content for rejected and auth-required s…https://github.com/KonstantinMirin/adcp-client-python/commit/7be949c6fd83388c1492ed883e18d2be6c3f9395
https://docs.github.com/articles/closing-issues-via-commit-messages
7be949chttps://github.com/KonstantinMirin/adcp-client-python/commit/7be949c6fd83388c1492ed883e18d2be6c3f9395
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/263
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/263
bugSomething isn't workinghttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22bug%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
documentationImprovements or additions to documentationhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22documentation%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.