René's URL Explorer Experiment


Title: sdk(server): bound request input size before Pydantic model_validate · Issue #239 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: sdk(server): bound request input size before Pydantic model_validate · Issue #239 · adcontextprotocol/adcp-client-python

X Title: sdk(server): bound request input size before Pydantic model_validate · Issue #239 · adcontextprotocol/adcp-client-python

Description: Context Security review of PR #238 (typed handler params) flagged that create_tool_caller now runs Model.model_validate on every tool call with no input-size or depth cap at the SDK layer. Upstream transports (FastMCP streamable-HTTP, a2...

Open Graph Description: Context Security review of PR #238 (typed handler params) flagged that create_tool_caller now runs Model.model_validate on every tool call with no input-size or depth cap at the SDK layer. Upstream...

X Description: Context Security review of PR #238 (typed handler params) flagged that create_tool_caller now runs Model.model_validate on every tool call with no input-size or depth cap at the SDK layer. Upstream...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/239

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"sdk(server): bound request input size before Pydantic model_validate","articleBody":"## Context\n\nSecurity review of PR #238 (typed handler params) flagged that `create_tool_caller` now runs `Model.model_validate` on every tool call with no input-size or depth cap at the SDK layer. Upstream transports (FastMCP streamable-HTTP, a2a-python) don't impose a uniform request-body cap, so a hostile caller can submit arbitrarily large JSON and force the server to parse it.\n\nPydantic 2's pydantic-core is Rust-native and resilient to stack depth, but:\n- Deeply-nested JSON with ``extra=\"allow\"`` still allocates per-level Python objects.\n- Large string fields without a `max_length` constraint (e.g. `promoted_offering` on `GetProductsRequest`) become validator-free bulk.\n- CPU per-request rises non-trivially under adversarial input.\n\nPre-existing transport-level concern that PR #238 meaningfully increases because typed dispatch runs validation unconditionally when a model is declared.\n\n## Proposal\n\nOne of:\n\n1. **Starlette middleware at bind time.** `_run_mcp_http` / A2A bind sites install a `max_body_size` guard (Starlette has no built-in; needs a small custom ASGI middleware that reads Content-Length or buffers + caps). Default to a generous 10 MB, expose as a `serve(..., max_request_size=)` kwarg. Same knob for both transports.\n\n2. **SDK-level `len(json.dumps(params)) > N` shortcut** inside `create_tool_caller` before calling `model_validate`. Simpler, but re-serialises what the transport already parsed.\n\nPrefer (1). It kicks in before parsing (cheaper) and covers non-typed handlers too.\n\n## Acceptance\n\n- Size cap on request bodies, enforced at the transport bind point.\n- Default documented in `docs/handler-authoring.md`.\n- Test: request exceeding the cap returns an appropriate transport error before dispatch runs.\n\n## Severity\n\nMedium. Not a merge-blocker for anything shipped. Adversarial-load resilience for adopters running public-facing endpoints.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-20T15:22:38Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/239"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:be80aeb1-5468-fe13-b53b-7ac932d5e2cd
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8354:1C6C3E:E27D47:12B8432:6B00FE44
html-safe-nonce4a8eb831c80fb4f796fe9d5f77f26b7ed5acde4f7c8111fa209fb1ff12274cba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzU0OjFDNkMzRTpFMjdENDc6MTJCODQzMjo2QjAwRkU0NCIsInZpc2l0b3JfaWQiOiI3MjA1ODcyMDg4MzQ5OTk4NjYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd7226903636c829d0082be7d9cb5284c805838598ba69f77992edd613ef641d0
hovercard-subject-tagissue:4296766058
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/239/issue_layout
twitter:imagehttps://opengraph.githubassets.com/78554d8b14fc97ceb77683f4c195aa2615301290448353553ffc43542ee64975/adcontextprotocol/adcp-client-python/issues/239
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/78554d8b14fc97ceb77683f4c195aa2615301290448353553ffc43542ee64975/adcontextprotocol/adcp-client-python/issues/239
og:image:altContext Security review of PR #238 (typed handler params) flagged that create_tool_caller now runs Model.model_validate on every tool call with no input-size or depth cap at the SDK layer. Upstream...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/239#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F239
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F239
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/239
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/239
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/239
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/239
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/239
#177https://github.com/adcontextprotocol/adcp-client-python/pull/177
#241https://github.com/adcontextprotocol/adcp-client-python/pull/241
sdk(server): bound request input size before Pydantic model_validatehttps://github.com/adcontextprotocol/adcp-client-python/issues/239#top
#177https://github.com/adcontextprotocol/adcp-client-python/pull/177
#241https://github.com/adcontextprotocol/adcp-client-python/pull/241
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/239#issue-4296766058
#238https://github.com/adcontextprotocol/adcp-client-python/pull/238
#238https://github.com/adcontextprotocol/adcp-client-python/pull/238
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/239#event-24683360134
fix(server): PR #238 expert-review followupshttps://github.com/adcontextprotocol/adcp-client-python/commit/a1986562eb0e36bf1ec3a4e2136082c93b994698
#238https://github.com/adcontextprotocol/adcp-client-python/pull/238
a198656https://github.com/adcontextprotocol/adcp-client-python/commit/a1986562eb0e36bf1ec3a4e2136082c93b994698
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#241https://github.com/adcontextprotocol/adcp-client-python/pull/241
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/239#event-24685558410
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/239#event-24685558427
Merge pull request #241 from adcontextprotocol/bokelley/request-size-caphttps://github.com/adcontextprotocol/adcp-client-python/commit/21249a5032c8afa4f59033dec0b896e6cc4b637d
#241https://github.com/adcontextprotocol/adcp-client-python/pull/241
https://docs.github.com/articles/closing-issues-via-commit-messages
21249a5https://github.com/adcontextprotocol/adcp-client-python/commit/21249a5032c8afa4f59033dec0b896e6cc4b637d
KonstantinMirinhttps://github.com/KonstantinMirin
on May 13, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/239#event-25486654069
feat(server): request-body size cap middleware (closes adcontextproto…https://github.com/KonstantinMirin/adcp-client-python/commit/9ccf9601182e248861bf0683fbfe55408f76e93f
adcontextproto…https://github.com/adcontextprotocol/adcp-client-python/issues/239
https://docs.github.com/articles/closing-issues-via-commit-messages
9ccf960https://github.com/KonstantinMirin/adcp-client-python/commit/9ccf9601182e248861bf0683fbfe55408f76e93f
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/239
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/239
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.