René's URL Explorer Experiment


Title: Phase 2: Expand docs/handler-authoring.md with salesagent-migration lessons (PR-T) · Issue #229 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Phase 2: Expand docs/handler-authoring.md with salesagent-migration lessons (PR-T) · Issue #229 · adcontextprotocol/adcp-client-python

X Title: Phase 2: Expand docs/handler-authoring.md with salesagent-migration lessons (PR-T) · Issue #229 · adcontextprotocol/adcp-client-python

Description: Summary docs/handler-authoring.md covers the first 80% of the authoring journey. Once salesagent completes their MCP migration using the SDK's new hooks, a bunch of concrete patterns surface that this guide should document for the next a...

Open Graph Description: Summary docs/handler-authoring.md covers the first 80% of the authoring journey. Once salesagent completes their MCP migration using the SDK's new hooks, a bunch of concrete patterns surface that t...

X Description: Summary docs/handler-authoring.md covers the first 80% of the authoring journey. Once salesagent completes their MCP migration using the SDK's new hooks, a bunch of concrete patterns surface th...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/229

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Phase 2: Expand docs/handler-authoring.md with salesagent-migration lessons (PR-T)","articleBody":"## Summary\n\n`docs/handler-authoring.md` covers the first 80% of the authoring journey. Once salesagent completes their MCP migration using the SDK's new hooks, a bunch of concrete patterns surface that this guide should document for the next adopter.\n\n## Intended additions\n\nPost-migration feedback should drive the specifics, but a rough list:\n\n- **ResolvedIdentity pattern**, end-to-end. The guide mentions it; expand into a real example showing the `_impl` layer taking a typed identity, the `ADCPHandler` delegating, and the `context_factory` populating from token → DB lookup.\n- **Tenant routing from token.** Nginx-only subdomain → tenant + bearer-token → principal, both resolved inside `BearerAuthMiddleware`. salesagent's actual prod pattern. Include the Postgres lookup sketch.\n- **Discovery-skill exemption in practice.** `DISCOVERY_TOOLS | {\"list_public_formats\", ...}` + `validate_discovery_set()` + the composed `method in DISCOVERY_METHODS or (method == \"tools/call\" and name in DISCOVERY_TOOLS)` gate from #222.\n- **Keeping `SalesAgentHandler(ADCPHandler)` class thin.** Every method is a one-line delegation to `_impl.*`; the class exists to translate between SDK `ToolContext` and internal `ResolvedIdentity`. Structural test that enforces this (a grep-based check that handler methods don't do business logic).\n- **Idempotency wiring.** `@store.wrap` on create/update methods; `ToolContext.caller_identity` + `tenant_id` populated by the factory; the warning on missing-principal calls.\n- **Error classification in practice.** When to raise `adcp_error(\"BUDGET_TOO_LOW\")` vs a plain `ADCPTaskError`; the AdCP error-code taxonomy.\n- **Troubleshooting section.** \"My handler runs but idempotency dedup isn't firing\" → check `caller_identity`. \"My context_factory returned a dict and now the handler explodes\" → the `isinstance` guard error message.\n\n## Acceptance\n\n- Appended to `docs/handler-authoring.md` (or split into `docs/handler-authoring-advanced.md` if it gets big).\n- Cross-links from `examples/mcp_with_auth_middleware.py` and `MIGRATION_v3_to_v4.md`.\n- Skim-pass from salesagent (or another adopter) confirming the recipes reflect actual production setups, not just theory.\n\n## Context\n\nRoadmap item PR-T (Phase 2). Explicitly scheduled for after at least one downstream has completed MCP adoption — don't guess at the lessons; ship what the migration actually surfaced.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-20T06:07:55Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/229"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:cd7e4467-172d-bc0c-26ff-78e37cb9f523
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB796:CC1A4:D4A93E:10F824A:6B01027E
html-safe-nonce79651eeb19cf14c8c3212f90d8415a0c5aa5152ded5ec177732739b0d3c4b0f0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzk2OkNDMUE0OkQ0QTkzRToxMEY4MjRBOjZCMDEwMjdFIiwidmlzaXRvcl9pZCI6IjIxMzM5NTgxOTIxODk3MzU1NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9f229e038af777c7966dc53b063e7be95280f5d1890f64ff06438fc027c4f9e8
hovercard-subject-tagissue:4293476227
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/229/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bba11d66023342d115a92f1ed8805ac96617e557d0fa77be6ecb1ee2ff912310/adcontextprotocol/adcp-client-python/issues/229
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bba11d66023342d115a92f1ed8805ac96617e557d0fa77be6ecb1ee2ff912310/adcontextprotocol/adcp-client-python/issues/229
og:image:altSummary docs/handler-authoring.md covers the first 80% of the authoring journey. Once salesagent completes their MCP migration using the SDK's new hooks, a bunch of concrete patterns surface that t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/229#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F229
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F229
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/229
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/229
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/229
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/229
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/229
#326https://github.com/adcontextprotocol/adcp-client-python/pull/326
Phase 2: Expand docs/handler-authoring.md with salesagent-migration lessons (PR-T)https://github.com/adcontextprotocol/adcp-client-python/issues/229#top
#326https://github.com/adcontextprotocol/adcp-client-python/pull/326
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
documentationImprovements or additions to documentationhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22documentation%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/229#issue-4293476227
Document and lock the tools/list pre-auth posture; consider DISCOVERY_METHODS for JSON-RPC method gating #222https://github.com/adcontextprotocol/adcp-client-python/issues/222
bokelleyhttps://github.com/bokelley
documentationImprovements or additions to documentationhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22documentation%22
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/229#event-24663787469
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 29, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/229#event-24999112211
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/229#issuecomment-4353395429
bokelleyhttps://github.com/bokelley
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
claude-triagingTriage routine is actively working on this issue (1-3 min)https://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaging%22
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/229#event-25038665928
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/229#issuecomment-4353535697
#326https://github.com/adcontextprotocol/adcp-client-python/pull/326
https://claude.ai/code/session_01FxyYMBreWYeJxcJQCqsBbnhttps://claude.ai/code/session_01FxyYMBreWYeJxcJQCqsBbn
Claude Codehttps://claude.ai/code
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#326https://github.com/adcontextprotocol/adcp-client-python/pull/326
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/229#event-25039511475
bokelleyhttps://github.com/bokelley
on Apr 30, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/229#event-25039511486
docs(handler-authoring): expand with salesagent migration production …https://github.com/adcontextprotocol/adcp-client-python/commit/ce4c5df50fa156f3ff318c6a4c6376019adff540
https://docs.github.com/articles/closing-issues-via-commit-messages
ce4c5dfhttps://github.com/adcontextprotocol/adcp-client-python/commit/ce4c5df50fa156f3ff318c6a4c6376019adff540
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/229
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/229
claude-triagedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22claude-triaged%22
documentationImprovements or additions to documentationhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22documentation%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.