René's URL Explorer Experiment


Title: Phase 2: TestControllerStore + AdCPTestContext header-driven compatibility (PR-R) · Issue #227 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Phase 2: TestControllerStore + AdCPTestContext header-driven compatibility (PR-R) · Issue #227 · adcontextprotocol/adcp-client-python

X Title: Phase 2: TestControllerStore + AdCPTestContext header-driven compatibility (PR-R) · Issue #227 · adcontextprotocol/adcp-client-python

Description: Summary Downstream (salesagent) drives mock-ad-server behaviors via request headers (AdCPTestContext.from_headers(...)). The SDK's TestControllerStore is storyboard-shaped — transitions are triggered via the comply_test_controller skill,...

Open Graph Description: Summary Downstream (salesagent) drives mock-ad-server behaviors via request headers (AdCPTestContext.from_headers(...)). The SDK's TestControllerStore is storyboard-shaped — transitions are trigger...

X Description: Summary Downstream (salesagent) drives mock-ad-server behaviors via request headers (AdCPTestContext.from_headers(...)). The SDK's TestControllerStore is storyboard-shaped — transitions are tri...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/227

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Phase 2: TestControllerStore + AdCPTestContext header-driven compatibility (PR-R)","articleBody":"## Summary\n\nDownstream (salesagent) drives mock-ad-server behaviors via request headers (`AdCPTestContext.from_headers(...)`). The SDK's `TestControllerStore` is storyboard-shaped — transitions are triggered via the `comply_test_controller` skill, not via headers. The two models don't compose; downstreams that adopt `TestControllerStore` lose their header-driven test scaffolding.\n\n## Proposed fix\n\nAdd a `test_context_factory` hook to `register_test_controller()` / `create_mcp_server(test_controller=...)` that lets downstream derive the test-runtime context from request headers before the skill dispatches. Minimum signature:\n\n```python\nTestContextFactory = Callable[[RequestMetadata, Mapping[str, str]], Any]\n\ndef register_test_controller(\n    mcp: Any,\n    store: TestControllerStore,\n    *,\n    test_context_factory: TestContextFactory | None = None,\n) -> None: ...\n```\n\nWhen set, the factory is invoked per tool call with request headers — it returns whatever test-runtime context the seller's mock-ad-server code expects, which the handler can read off `ToolContext.metadata[\"test_context\"]`.\n\nAlternative (lower ambition): document the integration pattern without adding a hook. Downstream reads headers from their own middleware (via ContextVars) and sets `ToolContext.metadata[\"test_context\"]` inside their `context_factory`.\n\n## Acceptance\n\n- One of the two shapes above — prefer the hook since it formalizes the pattern.\n- Section in `docs/handler-authoring.md` under a new \"Testing hooks\" heading showing header-driven + storyboard-driven testing side-by-side.\n- Integration test exercising the factory against a mock seller.\n\n## Context\n\nRoadmap item PR-R (Phase 2) from `.context/sdk-adoption-roadmap.md`. Not a blocker for MCP migration; becomes relevant when salesagent's header-driven test framework needs to coexist with storyboard compliance testing.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-20T06:07:18Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/227"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ecfc419a-2277-716b-c8ff-8b8c9aee7651
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id832A:2F9718:AEEF0C:EBB820:6B00F690
html-safe-nonce899056c31fb45cf3173c6f1d13e2e62b1ab8a202214c4dfb7b064677f617df9a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzJBOjJGOTcxODpBRUVGMEM6RUJCODIwOjZCMDBGNjkwIiwidmlzaXRvcl9pZCI6Ijg0NzI3MzM3NjI0NDUxNzg1MTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8def0cebf0de4394eaa952ea395cf3a5e8c8ee2112f3c3c47a6d6d94a207c005
hovercard-subject-tagissue:4293473992
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/227/issue_layout
twitter:imagehttps://opengraph.githubassets.com/690bdd350c703e4c4ed78130defadf5857cc0a0ca3740f3c83392df6455a7811/adcontextprotocol/adcp-client-python/issues/227
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/690bdd350c703e4c4ed78130defadf5857cc0a0ca3740f3c83392df6455a7811/adcontextprotocol/adcp-client-python/issues/227
og:image:altSummary Downstream (salesagent) drives mock-ad-server behaviors via request headers (AdCPTestContext.from_headers(...)). The SDK's TestControllerStore is storyboard-shaped — transitions are trigger...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/227#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F227
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F227
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/227
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/227
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/227
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/227
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/227
#177https://github.com/adcontextprotocol/adcp-client-python/pull/177
#237https://github.com/adcontextprotocol/adcp-client-python/pull/237
Phase 2: TestControllerStore + AdCPTestContext header-driven compatibility (PR-R)https://github.com/adcontextprotocol/adcp-client-python/issues/227#top
#177https://github.com/adcontextprotocol/adcp-client-python/pull/177
#237https://github.com/adcontextprotocol/adcp-client-python/pull/237
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/227#issue-4293473992
bokelleyhttps://github.com/bokelley
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/227#event-24663773871
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/227#event-24681193742
feat(server): thread ToolContext through TestControllerStore (closes #…https://github.com/adcontextprotocol/adcp-client-python/commit/a0d89e3be1a60fa29aa7b1dfd81d4f8b79f9132d
#…https://github.com/adcontextprotocol/adcp-client-python/issues/227
https://docs.github.com/articles/closing-issues-via-commit-messages
a0d89e3https://github.com/adcontextprotocol/adcp-client-python/commit/a0d89e3be1a60fa29aa7b1dfd81d4f8b79f9132d
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#237https://github.com/adcontextprotocol/adcp-client-python/pull/237
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/227#event-24681758667
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/227#event-24681758712
Merge pull request #237 from adcontextprotocol/bokelley/test-controll…https://github.com/adcontextprotocol/adcp-client-python/commit/a4c6489285ba76b1e57caf09bf561c3aa1461ecf
#237https://github.com/adcontextprotocol/adcp-client-python/pull/237
https://docs.github.com/articles/closing-issues-via-commit-messages
a4c6489https://github.com/adcontextprotocol/adcp-client-python/commit/a4c6489285ba76b1e57caf09bf561c3aa1461ecf
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/227
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/227
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.