René's URL Explorer Experiment


Title: Gate tools/list on 'handler overrode this method' — stop not_supported defaults from polluting the advertised surface · Issue #220 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Gate tools/list on 'handler overrode this method' — stop not_supported defaults from polluting the advertised surface · Issue #220 · adcontextprotocol/adcp-client-python

X Title: Gate tools/list on 'handler overrode this method' — stop not_supported defaults from polluting the advertised surface · Issue #220 · adcontextprotocol/adcp-client-python

Description: Summary ADCPHandler auto-registers all ~57 AdCP tools on every server started via create_mcp_server() / create_a2a_server(), including ones where the subclass inherits the base class's not_supported default. The result: an agent that imp...

Open Graph Description: Summary ADCPHandler auto-registers all ~57 AdCP tools on every server started via create_mcp_server() / create_a2a_server(), including ones where the subclass inherits the base class's not_supporte...

X Description: Summary ADCPHandler auto-registers all ~57 AdCP tools on every server started via create_mcp_server() / create_a2a_server(), including ones where the subclass inherits the base class's not_supp...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/220

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Gate tools/list on 'handler overrode this method' — stop not_supported defaults from polluting the advertised surface","articleBody":"## Summary\n\n`ADCPHandler` auto-registers all ~57 AdCP tools on every server started via `create_mcp_server()` / `create_a2a_server()`, including ones where the subclass inherits the base class's `not_supported` default. The result: an agent that implements `get_products` and 2-3 other tools still advertises all 57 in `tools/list`. With Pydantic-generated schemas averaging 300-600 tokens each after `$defs` resolution, that's 20-30K tokens of tool metadata shipped to every client on connect.\n\nNoted by @agentic-product-architect in the PR #219 review:\n> Today this is tolerable because AdCP agents are called by other agents with 200K+ windows. In 12 months, when AdCP agents get consumed by lighter-weight orchestrators (ChatGPT app, Claude skill, mobile agent), advertising the full surface will look profligate.\n\n## Proposed fix\n\nAdd a registration-time filter: only advertise tools whose handler method was actually overridden by the subclass. The information is knowable:\n\n```python\n# In adcp.server.mcp_tools.get_tools_for_handler():\nhandler_cls = type(handler)\nfor tool_def in ADCP_TOOL_DEFINITIONS:\n    method_name = tool_def[\"name\"]\n    own_method = getattr(handler_cls, method_name, None)\n    base_method = getattr(ADCPHandler, method_name, None)\n    if own_method is base_method:\n        continue  # subclass inherited the not-supported stub; skip advertising\n    tools.append(tool_def)\n```\n\nKnobs to consider:\n- Escape hatch for agents that want to advertise a spec-mandated tool even though they haven't implemented it (e.g. `get_adcp_capabilities` is the handshake and must always be present — it's a special case already).\n- Per-protocol handler classes (`GovernanceHandler`, `ContentStandardsHandler`, etc.) — the override check should walk the MRO stopping at the SDK-provided base.\n- `advertised: bool` class attribute on base methods as an opt-in override.\n\n## Tradeoffs\n\n- Subclasses that intentionally want to expose a not_supported tool (to declare \"this agent knows about X but can't do it\") lose that ability unless we add the opt-in escape hatch.\n- Spec-compliance tests that call every tool and expect either a real response or `not_supported` need to adapt — the tool simply won't be listed.\n- Docs need to say \"override the method = advertise the tool.\"\n\n## Context\n\nTracked from PR #219 expert review. Not breaking for existing downstreams at registration-time (the same handler still works), but observably changes `tools/list` output, so ship with a CHANGELOG entry.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-20T06:03:28Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/220"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:da42c981-2b5e-bd4d-b4c1-d50c1aade606
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE880:3A4875:BC9D91:FC44ED:6B00F6AA
html-safe-nonce5d2273f7d0f311aea3e05a4d4e4933ee7559fb0957da56363ff0115c499c8562
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODgwOjNBNDg3NTpCQzlEOTE6RkM0NEVEOjZCMDBGNkFBIiwidmlzaXRvcl9pZCI6IjgyOTcyNjc3ODI3MTQ3MTc4NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc111dfba086d3b8640885fea9909b225a7cba269dc5b8f1a893b54720a5fbf89
hovercard-subject-tagissue:4293459335
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/220/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a80f35fd32206bdc4f913a586bba3224e949b808030019d21469d52a3fa311b7/adcontextprotocol/adcp-client-python/issues/220
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a80f35fd32206bdc4f913a586bba3224e949b808030019d21469d52a3fa311b7/adcontextprotocol/adcp-client-python/issues/220
og:image:altSummary ADCPHandler auto-registers all ~57 AdCP tools on every server started via create_mcp_server() / create_a2a_server(), including ones where the subclass inherits the base class's not_supporte...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/220#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F220
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F220
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/220
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/220
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/220
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/220
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/220
#177https://github.com/adcontextprotocol/adcp-client-python/pull/177
#235https://github.com/adcontextprotocol/adcp-client-python/pull/235
Gate tools/list on 'handler overrode this method' — stop not_supported defaults from polluting the advertised surfacehttps://github.com/adcontextprotocol/adcp-client-python/issues/220#top
#177https://github.com/adcontextprotocol/adcp-client-python/pull/177
#235https://github.com/adcontextprotocol/adcp-client-python/pull/235
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/220#issue-4293459335
#219https://github.com/adcontextprotocol/adcp-client-python/pull/219
#219https://github.com/adcontextprotocol/adcp-client-python/pull/219
bokelleyhttps://github.com/bokelley
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/220#event-24663683270
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/220#event-24679007492
feat(server): gate tools/list on method overrides (closes #220)https://github.com/adcontextprotocol/adcp-client-python/commit/a61e3893065b9a28f4818dcd03d154d8f268267f
#220https://github.com/adcontextprotocol/adcp-client-python/issues/220
https://docs.github.com/articles/closing-issues-via-commit-messages
a61e389https://github.com/adcontextprotocol/adcp-client-python/commit/a61e3893065b9a28f4818dcd03d154d8f268267f
feat(server): gate tools/list on method overrides (closes #220)https://github.com/adcontextprotocol/adcp-client-python/commit/fc1a7885325d3587a1066140c4838f4e46f8b9c8
#220https://github.com/adcontextprotocol/adcp-client-python/issues/220
https://docs.github.com/articles/closing-issues-via-commit-messages
fc1a788https://github.com/adcontextprotocol/adcp-client-python/commit/fc1a7885325d3587a1066140c4838f4e46f8b9c8
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#235https://github.com/adcontextprotocol/adcp-client-python/pull/235
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/220#event-24680793149
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/220#event-24680793287
Merge pull request #235 from adcontextprotocol/bokelley/advertised-to…https://github.com/adcontextprotocol/adcp-client-python/commit/816d22ccd809a0e9cf45c05789eea7e0c8178464
#235https://github.com/adcontextprotocol/adcp-client-python/pull/235
816d22chttps://github.com/adcontextprotocol/adcp-client-python/commit/816d22ccd809a0e9cf45c05789eea7e0c8178464
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/220
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/220
enhancementNew feature or requesthttps://github.com/adcontextprotocol/adcp-client-python/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.